222184 2021-02-19 11:07:56 -0800 Need to rebase builtins generator tests results. 2021-02-19 11:17:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist jenner keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1731440 0 mark.lam 2021-02-19 11:07:56 -0800 Notes: to run the test, Tools/Scripts/run-builtins-generator-tests. rdar://74528501 1731444 1 420995 mark.lam 2021-02-19 11:09:36 -0800 Created attachment 420995 proposed patch. 1731446 2 420995 ysuzuki 2021-02-19 11:11:25 -0800 Comment on attachment 420995 proposed patch. r=me 1731450 3 mark.lam 2021-02-19 11:13:36 -0800 *** Bug 222182 has been marked as a duplicate of this bug. *** 1731456 4 mark.lam 2021-02-19 11:17:51 -0800 Thanks for the review. Landed in r273152: <http://trac.webkit.org/r273152>. 420995 2021-02-19 11:09:36 -0800 2021-02-19 11:11:25 -0800 proposed patch. bug-222184.patch text/plain 6257 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjczMTQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDIxLTAyLTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBO ZWVkIHRvIHJlYmFzZSBidWlsdGlucyBnZW5lcmF0b3IgdGVzdHMgcmVzdWx0cy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjE4NAorICAgICAgICBy ZGFyOi8vNzQ1Mjg1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvdGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2ViQ29yZS1Bbm90aGVy R3VhcmRlZEludGVybmFsQnVpbHRpbi1TZXBhcmF0ZS5qcy1yZXN1bHQ6CisgICAgICAgICogU2Ny aXB0cy90ZXN0cy9idWlsdGlucy9leHBlY3RlZC9XZWJDb3JlLUd1YXJkZWRJbnRlcm5hbEJ1aWx0 aW4tU2VwYXJhdGUuanMtcmVzdWx0OgorICAgICAgICAqIFNjcmlwdHMvdGVzdHMvYnVpbHRpbnMv ZXhwZWN0ZWQvV2ViQ29yZS14bWxDYXNpbmdUZXN0LVNlcGFyYXRlLmpzLXJlc3VsdDoKKyAgICAg ICAgKiBTY3JpcHRzL3Rlc3RzL2J1aWx0aW5zL2V4cGVjdGVkL1dlYkNvcmVKU0J1aWx0aW5zLmgt cmVzdWx0OgorCiAyMDIxLTAyLTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBJbXBsZW1lbnQgYSBHQyB2ZXJpZmllci4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9TY3JpcHRzL3Rlc3RzL2J1aWx0aW5zL2V4cGVjdGVkL1dlYkNvcmUtQW5vdGhlckd1YXJk ZWRJbnRlcm5hbEJ1aWx0aW4tU2VwYXJhdGUuanMtcmVzdWx0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL3Rlc3RzL2J1aWx0aW5zL2V4cGVjdGVkL1dlYkNvcmUt QW5vdGhlckd1YXJkZWRJbnRlcm5hbEJ1aWx0aW4tU2VwYXJhdGUuanMtcmVzdWx0CShyZXZpc2lv biAyNzMxNDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvU2NyaXB0cy90ZXN0cy9idWlsdGlu cy9leHBlY3RlZC9XZWJDb3JlLUFub3RoZXJHdWFyZGVkSW50ZXJuYWxCdWlsdGluLVNlcGFyYXRl LmpzLXJlc3VsdAkod29ya2luZyBjb3B5KQpAQCAtMTI2LDcgKzEyNiw3IEBAIHB1YmxpYzoKICAg ICBleHBsaWNpdCBBbm90aGVyR3VhcmRlZEludGVybmFsQnVpbHRpbkJ1aWx0aW5GdW5jdGlvbnMo SlNDOjpWTSYgdm0pIDogbV92bSh2bSkgeyB9CiAKICAgICB2b2lkIGluaXQoSlNDOjpKU0dsb2Jh bE9iamVjdCYpOwotICAgIHZvaWQgdmlzaXQoSlNDOjpTbG90VmlzaXRvciYpOworICAgIHRlbXBs YXRlPHR5cGVuYW1lIFZpc2l0b3I+IHZvaWQgdmlzaXQoVmlzaXRvciYpOwogCiBwdWJsaWM6CiAg ICAgSlNDOjpWTSYgbV92bTsKQEAgLTE0NSwxMyArMTQ1LDE4IEBAIGlubGluZSB2b2lkIEFub3Ro ZXJHdWFyZGVkSW50ZXJuYWxCdWlsdGkKICN1bmRlZiBFWFBPUlRfRlVOQ1RJT04KIH0KIAotaW5s aW5lIHZvaWQgQW5vdGhlckd1YXJkZWRJbnRlcm5hbEJ1aWx0aW5CdWlsdGluRnVuY3Rpb25zOjp2 aXNpdChKU0M6OlNsb3RWaXNpdG9yJiB2aXNpdG9yKQordGVtcGxhdGU8dHlwZW5hbWUgVmlzaXRv cj4KK2lubGluZSB2b2lkIEFub3RoZXJHdWFyZGVkSW50ZXJuYWxCdWlsdGluQnVpbHRpbkZ1bmN0 aW9uczo6dmlzaXQoVmlzaXRvciYgdmlzaXRvcikKIHsKICNkZWZpbmUgVklTSVRfRlVOQ1RJT04o bmFtZSkgdmlzaXRvci5hcHBlbmQobV8jI25hbWUjI0Z1bmN0aW9uKTsKICAgICBXRUJDT1JFX0ZP UkVBQ0hfQU5PVEhFUkdVQVJERURJTlRFUk5BTEJVSUxUSU5fQlVJTFRJTl9GVU5DVElPTl9OQU1F KFZJU0lUX0ZVTkNUSU9OKQogI3VuZGVmIFZJU0lUX0ZVTkNUSU9OCiB9CiAKK3RlbXBsYXRlIHZv aWQgQW5vdGhlckd1YXJkZWRJbnRlcm5hbEJ1aWx0aW5CdWlsdGluRnVuY3Rpb25zOjp2aXNpdChK U0M6OkFic3RyYWN0U2xvdFZpc2l0b3ImKTsKK3RlbXBsYXRlIHZvaWQgQW5vdGhlckd1YXJkZWRJ bnRlcm5hbEJ1aWx0aW5CdWlsdGluRnVuY3Rpb25zOjp2aXNpdChKU0M6OlNsb3RWaXNpdG9yJik7 CisKKwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9TY3JpcHRzL3Rlc3RzL2J1aWx0aW5zL2V4cGVjdGVkL1dlYkNvcmUtR3VhcmRlZEludGVy bmFsQnVpbHRpbi1TZXBhcmF0ZS5qcy1yZXN1bHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL1NjcmlwdHMvdGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2ViQ29yZS1HdWFyZGVk SW50ZXJuYWxCdWlsdGluLVNlcGFyYXRlLmpzLXJlc3VsdAkocmV2aXNpb24gMjczMTQ4KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvdGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2Vi Q29yZS1HdWFyZGVkSW50ZXJuYWxCdWlsdGluLVNlcGFyYXRlLmpzLXJlc3VsdAkod29ya2luZyBj b3B5KQpAQCAtMTI3LDcgKzEyNyw3IEBAIHB1YmxpYzoKICAgICBleHBsaWNpdCBHdWFyZGVkSW50 ZXJuYWxCdWlsdGluQnVpbHRpbkZ1bmN0aW9ucyhKU0M6OlZNJiB2bSkgOiBtX3ZtKHZtKSB7IH0K IAogICAgIHZvaWQgaW5pdChKU0M6OkpTR2xvYmFsT2JqZWN0Jik7Ci0gICAgdm9pZCB2aXNpdChK U0M6OlNsb3RWaXNpdG9yJik7CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVmlzaXRvcj4gdm9pZCB2 aXNpdChWaXNpdG9yJik7CiAKIHB1YmxpYzoKICAgICBKU0M6OlZNJiBtX3ZtOwpAQCAtMTQ2LDEz ICsxNDYsMTggQEAgaW5saW5lIHZvaWQgR3VhcmRlZEludGVybmFsQnVpbHRpbkJ1aWx0aQogI3Vu ZGVmIEVYUE9SVF9GVU5DVElPTgogfQogCi1pbmxpbmUgdm9pZCBHdWFyZGVkSW50ZXJuYWxCdWls dGluQnVpbHRpbkZ1bmN0aW9uczo6dmlzaXQoSlNDOjpTbG90VmlzaXRvciYgdmlzaXRvcikKK3Rl bXBsYXRlPHR5cGVuYW1lIFZpc2l0b3I+CitpbmxpbmUgdm9pZCBHdWFyZGVkSW50ZXJuYWxCdWls dGluQnVpbHRpbkZ1bmN0aW9uczo6dmlzaXQoVmlzaXRvciYgdmlzaXRvcikKIHsKICNkZWZpbmUg VklTSVRfRlVOQ1RJT04obmFtZSkgdmlzaXRvci5hcHBlbmQobV8jI25hbWUjI0Z1bmN0aW9uKTsK ICAgICBXRUJDT1JFX0ZPUkVBQ0hfR1VBUkRFRElOVEVSTkFMQlVJTFRJTl9CVUlMVElOX0ZVTkNU SU9OX05BTUUoVklTSVRfRlVOQ1RJT04pCiAjdW5kZWYgVklTSVRfRlVOQ1RJT04KIH0KIAordGVt cGxhdGUgdm9pZCBHdWFyZGVkSW50ZXJuYWxCdWlsdGluQnVpbHRpbkZ1bmN0aW9uczo6dmlzaXQo SlNDOjpBYnN0cmFjdFNsb3RWaXNpdG9yJik7Cit0ZW1wbGF0ZSB2b2lkIEd1YXJkZWRJbnRlcm5h bEJ1aWx0aW5CdWlsdGluRnVuY3Rpb25zOjp2aXNpdChKU0M6OlNsb3RWaXNpdG9yJik7CisKKwog CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9T Y3JpcHRzL3Rlc3RzL2J1aWx0aW5zL2V4cGVjdGVkL1dlYkNvcmUteG1sQ2FzaW5nVGVzdC1TZXBh cmF0ZS5qcy1yZXN1bHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL1Njcmlw dHMvdGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2ViQ29yZS14bWxDYXNpbmdUZXN0LVNlcGFyYXRl LmpzLXJlc3VsdAkocmV2aXNpb24gMjczMTQ4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL1Nj cmlwdHMvdGVzdHMvYnVpbHRpbnMvZXhwZWN0ZWQvV2ViQ29yZS14bWxDYXNpbmdUZXN0LVNlcGFy YXRlLmpzLXJlc3VsdAkod29ya2luZyBjb3B5KQpAQCAtMTQzLDcgKzE0Myw3IEBAIHB1YmxpYzoK ICAgICBleHBsaWNpdCB4bWxDYXNpbmdUZXN0QnVpbHRpbkZ1bmN0aW9ucyhKU0M6OlZNJiB2bSkg OiBtX3ZtKHZtKSB7IH0KIAogICAgIHZvaWQgaW5pdChKU0M6OkpTR2xvYmFsT2JqZWN0Jik7Ci0g ICAgdm9pZCB2aXNpdChKU0M6OlNsb3RWaXNpdG9yJik7CisgICAgdGVtcGxhdGU8dHlwZW5hbWUg VmlzaXRvcj4gdm9pZCB2aXNpdChWaXNpdG9yJik7CiAKIHB1YmxpYzoKICAgICBKU0M6OlZNJiBt X3ZtOwpAQCAtMTYyLDEzICsxNjIsMTggQEAgaW5saW5lIHZvaWQgeG1sQ2FzaW5nVGVzdEJ1aWx0 aW5GdW5jdGlvbgogI3VuZGVmIEVYUE9SVF9GVU5DVElPTgogfQogCi1pbmxpbmUgdm9pZCB4bWxD YXNpbmdUZXN0QnVpbHRpbkZ1bmN0aW9uczo6dmlzaXQoSlNDOjpTbG90VmlzaXRvciYgdmlzaXRv cikKK3RlbXBsYXRlPHR5cGVuYW1lIFZpc2l0b3I+CitpbmxpbmUgdm9pZCB4bWxDYXNpbmdUZXN0 QnVpbHRpbkZ1bmN0aW9uczo6dmlzaXQoVmlzaXRvciYgdmlzaXRvcikKIHsKICNkZWZpbmUgVklT SVRfRlVOQ1RJT04obmFtZSkgdmlzaXRvci5hcHBlbmQobV8jI25hbWUjI0Z1bmN0aW9uKTsKICAg ICBXRUJDT1JFX0ZPUkVBQ0hfWE1MQ0FTSU5HVEVTVF9CVUlMVElOX0ZVTkNUSU9OX05BTUUoVklT SVRfRlVOQ1RJT04pCiAjdW5kZWYgVklTSVRfRlVOQ1RJT04KIH0KIAordGVtcGxhdGUgdm9pZCB4 bWxDYXNpbmdUZXN0QnVpbHRpbkZ1bmN0aW9uczo6dmlzaXQoSlNDOjpBYnN0cmFjdFNsb3RWaXNp dG9yJik7Cit0ZW1wbGF0ZSB2b2lkIHhtbENhc2luZ1Rlc3RCdWlsdGluRnVuY3Rpb25zOjp2aXNp dChKU0M6OlNsb3RWaXNpdG9yJik7CisKKwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL3Rlc3RzL2J1aWx0aW5zL2V4cGVjdGVk L1dlYkNvcmVKU0J1aWx0aW5zLmgtcmVzdWx0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9TY3JpcHRzL3Rlc3RzL2J1aWx0aW5zL2V4cGVjdGVkL1dlYkNvcmVKU0J1aWx0aW5z LmgtcmVzdWx0CShyZXZpc2lvbiAyNzMxNDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvU2Ny aXB0cy90ZXN0cy9idWlsdGlucy9leHBlY3RlZC9XZWJDb3JlSlNCdWlsdGlucy5oLXJlc3VsdAko d29ya2luZyBjb3B5KQpAQCAtMTk5LDcgKzE5OSw3IEBAIGNsYXNzIEpTQnVpbHRpbkludGVybmFs RnVuY3Rpb25zIHsKIHB1YmxpYzoKICAgICBleHBsaWNpdCBKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0 aW9ucyhKU0M6OlZNJik7CiAKLSAgICB2b2lkIHZpc2l0KEpTQzo6U2xvdFZpc2l0b3ImKTsKKyAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBWaXNpdG9yPiB2b2lkIHZpc2l0KFZpc2l0b3ImKTsKICAgICB2 b2lkIGluaXRpYWxpemUoSlNET01HbG9iYWxPYmplY3QmKTsKIAogI2lmIEVOQUJMRShGRVRDSF9B UEkpCkBAIC0yODYsNyArMjg2LDggQEAgSlNCdWlsdGluSW50ZXJuYWxGdW5jdGlvbnM6OkpTQnVp bHRpbkludAogICAgIFVOVVNFRF9QQVJBTSh2bSk7CiB9CiAKLXZvaWQgSlNCdWlsdGluSW50ZXJu YWxGdW5jdGlvbnM6OnZpc2l0KEpTQzo6U2xvdFZpc2l0b3ImIHZpc2l0b3IpCit0ZW1wbGF0ZTx0 eXBlbmFtZSBWaXNpdG9yPgordm9pZCBKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0aW9uczo6dmlzaXQo VmlzaXRvciYgdmlzaXRvcikKIHsKICNpZiBFTkFCTEUoRkVUQ0hfQVBJKQogICAgIG1fYW5vdGhl ckd1YXJkZWRJbnRlcm5hbEJ1aWx0aW4udmlzaXQodmlzaXRvcik7CkBAIC0zMDAsNiArMzAxLDkg QEAgdm9pZCBKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0aW9uczo6dmlzaXQoSgogICAgIFVOVVNFRF9Q QVJBTSh2aXNpdG9yKTsKIH0KIAordGVtcGxhdGUgdm9pZCBKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0 aW9uczo6dmlzaXQoQWJzdHJhY3RTbG90VmlzaXRvciYpOwordGVtcGxhdGUgdm9pZCBKU0J1aWx0 aW5JbnRlcm5hbEZ1bmN0aW9uczo6dmlzaXQoU2xvdFZpc2l0b3ImKTsKKwogdm9pZCBKU0J1aWx0 aW5JbnRlcm5hbEZ1bmN0aW9uczo6aW5pdGlhbGl6ZShKU0RPTUdsb2JhbE9iamVjdCYgZ2xvYmFs T2JqZWN0KQogewogICAgIFVOVVNFRF9QQVJBTShnbG9iYWxPYmplY3QpOwo=