222169 2021-02-19 07:46:24 -0800 Add better error handling to ResourceLoadStatisticsDatabaseStore::needsUpdatedPrivateClickMeasurementSchema() 2021-02-19 09:55:43 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney darin webkit-bug-importer oldest_to_newest 1731328 0 katherine_cheney 2021-02-19 07:46:24 -0800 We should add better SQLite error handling here 1731329 1 webkit-bug-importer 2021-02-19 07:46:45 -0800 <rdar://problem/74522283> 1731331 2 420966 katherine_cheney 2021-02-19 07:48:11 -0800 Created attachment 420966 Patch 1731399 3 ews-feeder 2021-02-19 09:55:41 -0800 Committed r273144: <https://commits.webkit.org/r273144> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420966. 420966 2021-02-19 07:48:11 -0800 2021-02-19 09:55:42 -0800 Patch bug-222169-20210219074810.patch text/plain 3051 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjMDJiMWVhMmViNDRlNzE5 ZDgyNGY0ODU0Y2YwZDhiNjBiMzNmYWEuLmFmMjRhZTNlZDY3NzA1OTA5YmYzMzQyZDhlNzM5ZDgw N2MyOGQ3ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDItMTkgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGJldHRlciBl cnJvciBoYW5kbGluZyB0byBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6bmVl ZHNVcGRhdGVkUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRTY2hlbWEoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMTY5CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83NDUyMjI4Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgYmV0dGVyIGVycm9yIGhhbmRsaW5nIGZvciB0aGUgY2FzZSB3aGVyZSB0 aGUgcXVlcnkgdG8gZmluZCB0aGUKKyAgICAgICAgVW5hdHRyaWJ1dGVkUHJpdmF0ZUNsaWNrTWVh c3VyZW1lbnQgdGFibGUgZmFpbHMuIFRoaXMgaXMgdW5saWtlbHkgdG8KKyAgICAgICAgaGFwcGVu IGluIHByYWN0aWNlLCBob3dldmVyLCBpZiBpdCBkb2VzLCB3ZSBzaG91bGQgYWRkIGxvZ2dpbmcg YW5kCisgICAgICAgIGEgZGVidWcgQVNTRVJULgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv Q2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlOjpuZWVkc1Vw ZGF0ZWRQcml2YXRlQ2xpY2tNZWFzdXJlbWVudFNjaGVtYSk6CisKIDIwMjEtMDItMTkgIEthdGUg Q2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3JlYXRlIFNR TGl0ZSBza2VsZXRvbiBpbXBsZW1lbnRhdGlvbiBmb3IgUENNIGZyYXVkIHByZXZlbnRpb24KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJj ZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQ cm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3Bw CmluZGV4IDJlMTVjN2JjMjdiOTk3NzYxODg2YzVlNTRkZDUxYjU2ZDc1ZmRhZTIuLjllZDk5MmNm YWEzZDUyYjc1OGI4MGNiNzBkNzJhMzNiY2ZlOWE3OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJh c2VTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVy L1Jlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlLmNwcApAQCAtNDM1LDEzICs0MzUs MTggQEAgYm9vbCBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6bmVlZHNVcGRh dGVkUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRTY2gKICAgICAvLyBGZXRjaCB0aGUgc2NoZW1hIGZv ciB0aGUgZXhpc3RpbmcgVW5hdHRyaWJ1dGVkUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQgdGFibGUu CiAgICAgU1FMaXRlU3RhdGVtZW50IHN0YXRlbWVudChtX2RhdGFiYXNlLCAiU0VMRUNUIHR5cGUs IHNxbCBGUk9NIHNxbGl0ZV9tYXN0ZXIgV0hFUkUgdGJsX25hbWU9J1VuYXR0cmlidXRlZFByaXZh dGVDbGlja01lYXN1cmVtZW50JyBBTkQgdHlwZSA9ICd0YWJsZSciKTsKICAgICBpZiAoc3RhdGVt ZW50LnByZXBhcmUoKSAhPSBTUUxJVEVfT0spIHsKLSAgICAgICAgTE9HX0VSUk9SKCJVbmFibGUg dG8gcHJlcGFyZSBzdGF0ZW1lbnQgdG8gZmV0Y2ggc2NoZW1hIGZvciB0aGUgVW5hdHRyaWJ1dGVk UHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQgdGFibGUuIik7CisgICAgICAgIFJFTEVBU0VfTE9HX0VS Uk9SKE5ldHdvcmssICIlcCAtIFJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlOjpu ZWVkc1VwZGF0ZWRQcml2YXRlQ2xpY2tNZWFzdXJlbWVudFNjaGVtYSBVbmFibGUgdG8gcHJlcGFy ZSBzdGF0ZW1lbnQgdG8gZmV0Y2ggc2NoZW1hIGZvciB0aGUgVW5hdHRyaWJ1dGVkUHJpdmF0ZUNs aWNrTWVhc3VyZW1lbnQgdGFibGUsIGVycm9yIG1lc3NhZ2U6ICV7cHJpdmF0ZX1zIiwgdGhpcywg bV9kYXRhYmFzZS5sYXN0RXJyb3JNc2coKSk7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgaWYgKHN0YXRlbWVudC5zdGVw KCkgPT0gU1FMSVRFX1JPVykKLSAgICAgICAgY3VycmVudFNjaGVtYSA9IHN0YXRlbWVudC5nZXRD b2x1bW5UZXh0KDEpOworICAgIGlmIChzdGF0ZW1lbnQuc3RlcCgpICE9IFNRTElURV9ST1cpIHsK KyAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoTmV0d29yaywgIiVwIC0gUmVzb3VyY2VMb2FkU3Rh dGlzdGljc0RhdGFiYXNlU3RvcmU6Om5lZWRzVXBkYXRlZFByaXZhdGVDbGlja01lYXN1cmVtZW50 U2NoZW1hIGVycm9yIGV4ZWN1dGluZyBzdGF0ZW1lbnQgdG8gZmV0Y2ggVW5hdHRyaWJ1dGVkUHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnQgc2NoZW1hLCBlcnJvciBtZXNzYWdlOiAle3ByaXZhdGV9cyIs IHRoaXMsIG1fZGF0YWJhc2UubGFzdEVycm9yTXNnKCkpOworICAgICAgICBBU1NFUlRfTk9UX1JF QUNIRUQoKTsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAgIGN1cnJlbnRTY2hl bWEgPSBzdGF0ZW1lbnQuZ2V0Q29sdW1uVGV4dCgxKTsKIAogICAgIGlmICghY3VycmVudFNjaGVt YS5pc0VtcHR5KCkKICAgICAgICAgJiYgY3VycmVudFNjaGVtYSAhPSB1bmF0dHJpYnV0ZWRQcml2 YXRlQ2xpY2tNZWFzdXJlbWVudFNjaGVtYVYxKCkK