222162 2021-02-19 00:31:57 -0800 [JSC] Remove vm.topCallFrame storing in Baseline JIT 2021-02-21 04:38:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1731249 0 ysuzuki 2021-02-19 00:31:57 -0800 [JSC] Remove vm.topCallFrame storing in Baseline JIT 1731253 1 420935 ysuzuki 2021-02-19 00:40:16 -0800 Created attachment 420935 Patch 1731260 2 420935 mark.lam 2021-02-19 01:06:23 -0800 Comment on attachment 420935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420935&action=review > Source/JavaScriptCore/ChangeLog:9 > + This patch removes vm.topCallFrame storing in Baseline JIT since operation / slow-path-call can retrieve CallFrame* via > + __builtin_frame_address or callFrame argument. After discussing the intent of this patch with Yusuke offline, I suggest rephrasing this as "This patch removes vm.topCallFrame storing in the Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS). Also refactored some CommonSlowPath functions so that they can start using __builtin_frame_address later instead of the requiring that CallFrame be passed in." 1731261 3 mark.lam 2021-02-19 01:06:32 -0800 r=me 1731267 4 mark.lam 2021-02-19 01:29:48 -0800 (In reply to Mark Lam from comment #2) > After discussing the intent of this patch with Yusuke offline, I suggest > rephrasing this as "This patch removes vm.topCallFrame storing in the > Baseline JIT for ports that can USE(BUILTIN_FRAME_ADDRESS). Also refactored > some CommonSlowPath functions so that they can start using > __builtin_frame_address later instead of the requiring that CallFrame be > passed in." Looks like I had a typo: /instead of the requiring/instead of requiring/ 1731937 5 ysuzuki 2021-02-21 04:37:47 -0800 Committed r273217 (234403@main): <https://commits.webkit.org/234403@main> 1731938 6 webkit-bug-importer 2021-02-21 04:38:16 -0800 <rdar://problem/74566597> 420935 2021-02-19 00:40:16 -0800 2021-02-19 01:06:23 -0800 Patch bug-222162-20210219004016.patch text/plain 5271 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 OGZhYTdiOWFiMjE0MTJjMTIzMjIwNzU3ZjU0YmQyZmExN2QwNGZiLi45ZDExZGUzZGQ1MTE5ZjU3 MDA1MWY5NTZiZmZlYzFmY2MwYTczNGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0wMi0xOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFJlbW92ZSB2bS50b3BDYWxsRnJhbWUgc3RvcmluZyBpbiBCYXNl bGluZSBKSVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyMjE2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgcGF0Y2ggcmVtb3ZlcyB2bS50b3BDYWxsRnJhbWUgc3RvcmluZyBpbiBCYXNlbGluZSBK SVQgc2luY2Ugb3BlcmF0aW9uIC8gc2xvdy1wYXRoLWNhbGwgY2FuIHJldHJpZXZlIENhbGxGcmFt ZSogdmlhCisgICAgICAgIF9fYnVpbHRpbl9mcmFtZV9hZGRyZXNzIG9yIGNhbGxGcmFtZSBhcmd1 bWVudC4KKworICAgICAgICAqIGppdC9KSVRJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkpJVDo6 dXBkYXRlVG9wQ2FsbEZyYW1lKToKKyAgICAgICAgKiBydW50aW1lL0NvbW1vblNsb3dQYXRocy5j cHA6CisgICAgICAgIChKU0M6Oml0ZXJhdG9yT3BlblRyeUZhc3RJbXBsKToKKyAgICAgICAgKEpT Qzo6SlNDX0RFRklORV9DT01NT05fU0xPV19QQVRIKToKKyAgICAgICAgKEpTQzo6aXRlcmF0b3JO ZXh0VHJ5RmFzdEltcGwpOgorCiAyMDIxLTAyLTE4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVkdWNlIGV4cGxpY2l0IHVzYWdlIG9mIFtvYmpDIGF1dG9yZWxl YXNlXSBpbiBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU SW5saW5lcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgKaW5kZXgg Yzg0MTE2ZTM3MDQxZmUzNzAyZTVmYzc3NzdkNmIyYmM4MjViN2JhNS4uOWJmOWNmZGQxOTgyNDVh NDY2MWU5YmM1YjllODAwNTU5MWM5Y2M2MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRJbmxpbmVzLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJ bmxpbmVzLmgKQEAgLTEwOSwxMSArMTA5LDcgQEAgQUxXQVlTX0lOTElORSB2b2lkIEpJVDo6dXBk YXRlVG9wQ2FsbEZyYW1lKCkKIHsKICAgICB1aW50MzJfdCBsb2NhdGlvbkJpdHMgPSBDYWxsU2l0 ZUluZGV4KG1fYnl0ZWNvZGVJbmRleC5vZmZzZXQoKSkuYml0cygpOwogICAgIHN0b3JlMzIoVHJ1 c3RlZEltbTMyKGxvY2F0aW9uQml0cyksIHRhZ0ZvcihDYWxsRnJhbWVTbG90Ojphcmd1bWVudENv dW50SW5jbHVkaW5nVGhpcykpOwotICAgIAotICAgIC8vIEZJWE1FOiBJdCdzIG5vdCBjbGVhciB0 aGF0IHRoaXMgaXMgbmVlZGVkLiBKSVRPcGVyYXRpb25zIHRlbmQgdG8gdXBkYXRlIHRoZSB0b3Ag Y2FsbCBmcmFtZSBvbgotICAgIC8vIHRoZSBDKysgc2lkZS4KLSAgICAvLyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1NjkzCi0gICAgc3RvcmVQdHIoY2FsbEZyYW1l UmVnaXN0ZXIsICZtX3ZtLT50b3BDYWxsRnJhbWUpOworICAgIHByZXBhcmVDYWxsT3BlcmF0aW9u KCptX3ZtKTsKIH0KIAogQUxXQVlTX0lOTElORSBNYWNyb0Fzc2VtYmxlcjo6Q2FsbCBKSVQ6OmFw cGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2soY29uc3QgRnVuY3Rpb25QdHI8Q0Z1bmN0aW9uUHRy VGFnPiBmdW5jdGlvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NvbW1vblNsb3dQYXRocy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db21t b25TbG93UGF0aHMuY3BwCmluZGV4IDAwY2FhNzUyNmNjNjYwZWY1NTk3YTVmYTYyNDdjOTI0NGZj ZWU5MjAuLmQyNTEyMmYzNTZhNzI0NTIzYmY1ZTViODI3NTljOWM3OWU5YjA2NjEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcApAQCAt ODUyLDExICs4NTIsOCBAQCBKU0NfREVGSU5FX0NPTU1PTl9TTE9XX1BBVEgoc2xvd19wYXRoX2lu X2J5X2lkKQogfQogCiB0ZW1wbGF0ZTxPcGNvZGVTaXplIHdpZHRoPgotQUxXQVlTX0lOTElORSBT bG93UGF0aFJldHVyblR5cGUgaXRlcmF0b3JPcGVuVHJ5RmFzdEltcGwoQ2FsbEZyYW1lKiBjYWxs RnJhbWUsIGNvbnN0IEluc3RydWN0aW9uKiBwYykKK0FMV0FZU19JTkxJTkUgU2xvd1BhdGhSZXR1 cm5UeXBlIGl0ZXJhdG9yT3BlblRyeUZhc3RJbXBsKFZNJiB2bSwgSlNHbG9iYWxPYmplY3QqIGds b2JhbE9iamVjdCwgQ29kZUJsb2NrKiBjb2RlQmxvY2ssIENhbGxGcmFtZSogY2FsbEZyYW1lLCBj b25zdCBJbnN0cnVjdGlvbiogcGMpCiB7Ci0gICAgLy8gRG9uJ3Qgc2V0IFBDOyB3ZSBjYW4ndCB0 aHJvdyBhbmQgaXQncyByZWxhdGl2ZWx5IHNsb3cuCi0gICAgQkVHSU5fTk9fU0VUX1BDKCk7Ci0K ICAgICBhdXRvIGJ5dGVjb2RlID0gcGMtPmFzS25vd25XaWR0aDxPcEl0ZXJhdG9yT3Blbiwgd2lk dGg+KCk7CiAgICAgYXV0byYgbWV0YWRhdGEgPSBieXRlY29kZS5tZXRhZGF0YShjb2RlQmxvY2sp OwogICAgIEpTVmFsdWUgaXRlcmFibGUgPSBHRVRfQyhieXRlY29kZS5tX2l0ZXJhYmxlKS5qc1Zh bHVlKCk7CkBAIC04ODEsMjQgKzg3OCwyOCBAQCBBTFdBWVNfSU5MSU5FIFNsb3dQYXRoUmV0dXJu VHlwZSBpdGVyYXRvck9wZW5UcnlGYXN0SW1wbChDYWxsRnJhbWUqIGNhbGxGcmFtZSwgYwogCiBK U0NfREVGSU5FX0NPTU1PTl9TTE9XX1BBVEgoaXRlcmF0b3Jfb3Blbl90cnlfZmFzdF9uYXJyb3cp CiB7Ci0gICAgcmV0dXJuIGl0ZXJhdG9yT3BlblRyeUZhc3RJbXBsPE5hcnJvdz4oY2FsbEZyYW1l LCBwYyk7CisgICAgLy8gRG9uJ3Qgc2V0IFBDOyB3ZSBjYW4ndCB0aHJvdyBhbmQgaXQncyByZWxh dGl2ZWx5IHNsb3cuCisgICAgQkVHSU5fTk9fU0VUX1BDKCk7CisgICAgcmV0dXJuIGl0ZXJhdG9y T3BlblRyeUZhc3RJbXBsPE5hcnJvdz4odm0sIGdsb2JhbE9iamVjdCwgY29kZUJsb2NrLCBjYWxs RnJhbWUsIHBjKTsKIH0KIAogSlNDX0RFRklORV9DT01NT05fU0xPV19QQVRIKGl0ZXJhdG9yX29w ZW5fdHJ5X2Zhc3Rfd2lkZTE2KQogewotICAgIHJldHVybiBpdGVyYXRvck9wZW5UcnlGYXN0SW1w bDxXaWRlMTY+KGNhbGxGcmFtZSwgcGMpOworICAgIC8vIERvbid0IHNldCBQQzsgd2UgY2FuJ3Qg dGhyb3cgYW5kIGl0J3MgcmVsYXRpdmVseSBzbG93LgorICAgIEJFR0lOX05PX1NFVF9QQygpOwor ICAgIHJldHVybiBpdGVyYXRvck9wZW5UcnlGYXN0SW1wbDxXaWRlMTY+KHZtLCBnbG9iYWxPYmpl Y3QsIGNvZGVCbG9jaywgY2FsbEZyYW1lLCBwYyk7CiB9CiAKIEpTQ19ERUZJTkVfQ09NTU9OX1NM T1dfUEFUSChpdGVyYXRvcl9vcGVuX3RyeV9mYXN0X3dpZGUzMikKIHsKLSAgICByZXR1cm4gaXRl cmF0b3JPcGVuVHJ5RmFzdEltcGw8V2lkZTMyPihjYWxsRnJhbWUsIHBjKTsKKyAgICAvLyBEb24n dCBzZXQgUEM7IHdlIGNhbid0IHRocm93IGFuZCBpdCdzIHJlbGF0aXZlbHkgc2xvdy4KKyAgICBC RUdJTl9OT19TRVRfUEMoKTsKKyAgICByZXR1cm4gaXRlcmF0b3JPcGVuVHJ5RmFzdEltcGw8V2lk ZTMyPih2bSwgZ2xvYmFsT2JqZWN0LCBjb2RlQmxvY2ssIGNhbGxGcmFtZSwgcGMpOwogfQogCiB0 ZW1wbGF0ZTxPcGNvZGVTaXplIHdpZHRoPgotQUxXQVlTX0lOTElORSBTbG93UGF0aFJldHVyblR5 cGUgaXRlcmF0b3JOZXh0VHJ5RmFzdEltcGwoQ2FsbEZyYW1lKiBjYWxsRnJhbWUsIGNvbnN0IElu c3RydWN0aW9uKiBwYykKK0FMV0FZU19JTkxJTkUgU2xvd1BhdGhSZXR1cm5UeXBlIGl0ZXJhdG9y TmV4dFRyeUZhc3RJbXBsKFZNJiB2bSwgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgQ29k ZUJsb2NrKiBjb2RlQmxvY2ssIENhbGxGcmFtZSogY2FsbEZyYW1lLCBUaHJvd1Njb3BlJiB0aHJv d1Njb3BlLCBjb25zdCBJbnN0cnVjdGlvbiogcGMpCiB7Ci0gICAgQkVHSU4oKTsKLQogICAgIGF1 dG8gYnl0ZWNvZGUgPSBwYy0+YXNLbm93bldpZHRoPE9wSXRlcmF0b3JOZXh0LCB3aWR0aD4oKTsK ICAgICBhdXRvJiBtZXRhZGF0YSA9IGJ5dGVjb2RlLm1ldGFkYXRhKGNvZGVCbG9jayk7CiAKQEAg LTkzOCwxNyArOTM5LDIwIEBAIEFMV0FZU19JTkxJTkUgU2xvd1BhdGhSZXR1cm5UeXBlIGl0ZXJh dG9yTmV4dFRyeUZhc3RJbXBsKENhbGxGcmFtZSogY2FsbEZyYW1lLCBjCiAKIEpTQ19ERUZJTkVf Q09NTU9OX1NMT1dfUEFUSChpdGVyYXRvcl9uZXh0X3RyeV9mYXN0X25hcnJvdykKIHsKLSAgICBy ZXR1cm4gaXRlcmF0b3JOZXh0VHJ5RmFzdEltcGw8TmFycm93PihjYWxsRnJhbWUsIHBjKTsKKyAg ICBCRUdJTigpOworICAgIHJldHVybiBpdGVyYXRvck5leHRUcnlGYXN0SW1wbDxOYXJyb3c+KHZt LCBnbG9iYWxPYmplY3QsIGNvZGVCbG9jaywgY2FsbEZyYW1lLCB0aHJvd1Njb3BlLCBwYyk7CiB9 CiAKIEpTQ19ERUZJTkVfQ09NTU9OX1NMT1dfUEFUSChpdGVyYXRvcl9uZXh0X3RyeV9mYXN0X3dp ZGUxNikKIHsKLSAgICByZXR1cm4gaXRlcmF0b3JOZXh0VHJ5RmFzdEltcGw8V2lkZTE2PihjYWxs RnJhbWUsIHBjKTsKKyAgICBCRUdJTigpOworICAgIHJldHVybiBpdGVyYXRvck5leHRUcnlGYXN0 SW1wbDxXaWRlMTY+KHZtLCBnbG9iYWxPYmplY3QsIGNvZGVCbG9jaywgY2FsbEZyYW1lLCB0aHJv d1Njb3BlLCBwYyk7CiB9CiAKIEpTQ19ERUZJTkVfQ09NTU9OX1NMT1dfUEFUSChpdGVyYXRvcl9u ZXh0X3RyeV9mYXN0X3dpZGUzMikKIHsKLSAgICByZXR1cm4gaXRlcmF0b3JOZXh0VHJ5RmFzdElt cGw8V2lkZTMyPihjYWxsRnJhbWUsIHBjKTsKKyAgICBCRUdJTigpOworICAgIHJldHVybiBpdGVy YXRvck5leHRUcnlGYXN0SW1wbDxXaWRlMzI+KHZtLCBnbG9iYWxPYmplY3QsIGNvZGVCbG9jaywg Y2FsbEZyYW1lLCB0aHJvd1Njb3BlLCBwYyk7CiB9CiAKIEpTQ19ERUZJTkVfQ09NTU9OX1NMT1df UEFUSChzbG93X3BhdGhfZGVsX2J5X3ZhbCkK