222156 2021-02-18 20:18:33 -0800 A number of offscreencanvas tests are asserting isMainThread trying to access strictCSSParserContext 2021-02-19 12:10:16 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221881 InRadar P2 Normal --- 1 lmoura fujii bugs-noreply cgarcia chris.lord dino esprehn+autocc ews-watchlist fujii glenn gyuyoung.kim macpherson menard sam webkit-bug-importer oldest_to_newest 1731187 0 lmoura 2021-02-18 20:18:33 -0800 imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.invalidstring.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.invalidtype.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.worker.html imported/w3c/web-platform-tests/html/canvas/offscreen/shadows/2d.shadow.attributes.shadowColor.invalid.worker.html Looks like some JS code is trying to access strictCSSParserContext() from outside the main thread. Last good revision: r272858. First bad revision: r272891. Sample trace: Thread 1 (Thread 0x7fa495ffb700 (LWP 45157)): #0 WTFCrash() () at ../../Source/WTF/wtf/Assertions.cpp:295 #1 0x00007fa64628210d in CRASH_WITH_INFO(...) () at DerivedSources/ForwardingHeaders/wtf/Assertions.h:713 #2 0x00007fa647c45d98 in WTF::MainThreadAccessTraits::assertAccess() () at DerivedSources/ForwardingHeaders/wtf/NeverDestroyed.h:55 #3 0x00007fa6493fb635 in WTF::NeverDestroyed<WebCore::CSSParserContext, WTF::MainThreadAccessTraits>::storagePointer() const (this=0x7fa652f60c80 <WebCore::strictCSSParserContext()::strictContext>) at DerivedSources/ForwardingHeaders/wtf/NeverDestroyed.h:91 #4 0x00007fa6493f88de in WTF::NeverDestroyed<WebCore::CSSParserContext, WTF::MainThreadAccessTraits>::operator WebCore::CSSParserContext&() (this=0x7fa652f60c80 <WebCore::strictCSSParserContext()::strictContext>) at DerivedSources/ForwardingHeaders/wtf/NeverDestroyed.h:76 #5 0x00007fa6493e5ea7 in WebCore::strictCSSParserContext() () at ../../Source/WebCore/css/parser/CSSParserContext.cpp:41 #6 0x00007fa6493e4ade in WebCore::CSSParser::parseColorWorkerSafe(WTF::String const&) (string=...) at ../../Source/WebCore/css/parser/CSSParser.cpp:120 #7 0x00007fa649a2ec6e in WebCore::parseColor(WTF::String const&, WebCore::CanvasBase&) (colorString=..., canvasBase=...) at ../../Source/WebCore/html/canvas/CanvasStyle.cpp:60 #8 0x00007fa649a2f099 in WebCore::CanvasStyle::createFromString(WTF::String const&, WebCore::CanvasBase&) (colorString=..., canvasBase=...) at ../../Source/WebCore/html/canvas/CanvasStyle.cpp:122 #9 0x00007fa649a25c6d in WebCore::CanvasRenderingContext2DBase::setFillColor(WTF::String const&, WTF::Optional<float>) (this=0x7fa5c3a8c110, color=..., alpha=...) at ../../Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:957 #10 0x00007fa649a2afb0 in operator()(WTF::String const&) const (__closure=0x7fa495ff93d0, string=...) at ../../Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:1882 #11 0x00007fa649a31781 in WTF::__visitor_table<WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::String&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> >&)> >, WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> > >::__trampoline_func<WTF::String>(WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::String&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> >&)> > &, WTF::__visitor_table<WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::String&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> >&)> >, WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> > >::__variant_type &) (__visitor=..., __v=...) at DerivedSources/ForwardingHeaders/wtf/Variant.h:1870 #12 0x00007fa649a30a30 in WTF::visit<WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::String&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> >&)> >, WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> > >(WTF::Visitor<WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::String&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> >&)> > &&, WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> > > &) (__visitor=..., __v=...) at DerivedSources/ForwardingHeaders/wtf/Variant.h:1886 #13 0x00007fa649a30204 in WTF::switchOn<WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> > >&, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::String&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >&)>, WebCore::CanvasRenderingContext2DBase::setFillStyle(WebCore::CanvasRenderingContext2DBase::StyleVariant&&)::<lambda(const WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> >&)> >(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> > > &) (v=...) at DerivedSources/ForwardingHeaders/wtf/Variant.h:2051 #14 0x00007fa649a2b113 in WebCore::CanvasRenderingContext2DBase::setFillStyle(WTF::Variant<WTF::String, WTF::RefPtr<WebCore::CanvasGradient, WTF::RawPtrTraits<WebCore::CanvasGradient>, WTF::DefaultRefDerefTraits<WebCore::CanvasGradient> >, WTF::RefPtr<WebCore::CanvasPattern, WTF::RawPtrTraits<WebCore::CanvasPattern>, WTF::DefaultRefDerefTraits<WebCore::CanvasPattern> > >&&) (this=0x7fa5c3a8c110, style=...) at ../../Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:1881 #15 0x00007fa6482ea714 in operator()() const (__closure=0x7fa495ff94f0) at DerivedSources/WebCore/JSOffscreenCanvasRenderingContext2D.cpp:499 #16 0x00007fa6482ff45a in WebCore::AttributeSetter::call<WebCore::setJSOffscreenCanvasRenderingContext2D_fillStyleSetter(JSC::JSGlobalObject&, WebCore::JSOffscreenCanvasRenderingContext2D&, JSC::JSValue)::<lambda()> >(JSC::JSGlobalObject &, JSC::ThrowScope &, struct {...} &&) (functor=...) at ../../Source/WebCore/bindings/js/JSDOMAttribute.h:93 #17 0x00007fa6482ea844 in WebCore::setJSOffscreenCanvasRenderingContext2D_fillStyleSetter(JSC::JSGlobalObject&, WebCore::JSOffscreenCanvasRenderingContext2D&, JSC::JSValue) (lexicalGlobalObject=..., thisObject=..., value=...) at DerivedSources/WebCore/JSOffscreenCanvasRenderingContext2D.cpp:498 #18 0x00007fa6482ff577 in WebCore::IDLAttribute<WebCore::JSOffscreenCanvasRenderingContext2D>::set<WebCore::setJSOffscreenCanvasRenderingContext2D_fillStyleSetter>(JSC::JSGlobalObject&, JSC::EncodedJSValue, JSC::EncodedJSValue, char const*) (lexicalGlobalObject=..., thisValue=140348953544632, encodedValue=140349627230768, attributeName=0x7fa64d433a4a "fillStyle") at ../../Source/WebCore/bindings/js/JSDOMAttribute.h:50 #19 0x00007fa6482ea8ac in WebCore::setJSOffscreenCanvasRenderingContext2D_fillStyle(JSC::JSGlobalObject*, JSC::EncodedJSValue, JSC::EncodedJSValue) (lexicalGlobalObject=0x7fa588843068, thisValue=140348953544632, encodedValue=140349627230768) at DerivedSources/WebCore/JSOffscreenCanvasRenderingContext2D.cpp:506 #20 0x00007fa63682d594 in JSC::callCustomSetter(JSC::JSGlobalObject*, bool (*)(JSC::JSGlobalObject*, long, long), bool, JSC::JSObject*, JSC::JSValue, JSC::JSValue) (globalObject=0x7fa588843068, setter=0x7fa6482ea87d <WebCore::setJSOffscreenCanvasRenderingContext2D_fillStyle(JSC::JSGlobalObject*, JSC::EncodedJSValue, JSC::EncodedJSValue)>, isAccessor=true, slotBase=0x7fa5ba2301a0, thisValue=..., value=...) at ../../Source/JavaScriptCore/runtime/CustomGetterSetter.cpp:43 #21 0x00007fa6369b3549 in JSC::JSObject::putInlineSlow(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) (this=0x7fa5898547b8, globalObject=0x7fa588843068, propertyName=..., value=..., slot=...) at ../../Source/JavaScriptCore/runtime/JSObject.cpp:847 #22 0x00007fa648df5ee3 in JSC::JSObject::putInlineForJSObject(JSC::JSCell*, JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) (cell=0x7fa5898547b8, globalObject=0x7fa588843068, propertyName=..., value=..., slot=...) at DerivedSources/ForwardingHeaders/JavaScriptCore/JSObjectInlines.h:277 #23 0x00007fa648df55c4 in JSC::JSCell::putInline(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) (this=0x7fa5898547b8, globalObject=0x7fa588843068, propertyName=..., value=..., slot=...) at DerivedSources/ForwardingHeaders/JavaScriptCore/JSCellInlines.h:441 #24 0x00007fa635e87df3 in JSC::JSValue::putInline(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) (this=0x7fa495ff9928, globalObject=0x7fa588843068, propertyName=..., value=..., slot=...) at ../../Source/JavaScriptCore/runtime/JSCJSValueInlines.h:1060 #25 0x00007fa63660176e in JSC::LLInt::llint_slow_path_put_by_id(JSC::CallFrame*, JSC::Instruction const*) (callFrame=0x7fa495ff9b30, pc=0x7fa58981fefc) at ../../Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:907 #26 0x00007fa6354a75de in llint_op_put_by_id () at /app/webkit/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:97 1731190 1 lmoura 2021-02-18 20:33:24 -0800 Gardened in r273124. About the mentioned revisions, they are the last good and first bad on the bots. A candidate in the range seems to be r272870/bug221881 "Prepare for adding relative color support". Cc'ing Sam. 1731240 2 420929 fujii 2021-02-18 23:44:48 -0800 Created attachment 420929 Patch 1731256 3 420929 cgarcia 2021-02-19 00:50:36 -0800 Comment on attachment 420929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420929&action=review > Source/WebCore/css/parser/CSSParser.cpp:120 > - return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, strictCSSParserContext()); > + return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, CSSParserContext(HTMLStandardMode)); Why is this GLib specific? 1731286 4 420929 chris.lord 2021-02-19 02:47:32 -0800 Comment on attachment 420929 Patch FWIW, this looks good to me. 1731287 5 chris.lord 2021-02-19 02:48:06 -0800 (In reply to Carlos Garcia Campos from comment #3) > Comment on attachment 420929 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420929&action=review > > > Source/WebCore/css/parser/CSSParser.cpp:120 > > - return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, strictCSSParserContext()); > > + return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, CSSParserContext(HTMLStandardMode)); > > Why is this GLib specific? OffscreenCanvas is only enabled on GLib, this function is only used there. 1731496 6 fujii 2021-02-19 12:10:00 -0800 Committed r273156 (234351@main): <https://commits.webkit.org/234351@main> 1731497 7 webkit-bug-importer 2021-02-19 12:10:16 -0800 <rdar://problem/74532293> 420929 2021-02-18 23:44:48 -0800 2021-02-19 06:26:10 -0800 Patch bug-222156-20210219164446.patch text/plain 7929 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdlNzM5NTkyOTg0ODgx Y2ZhM2NjMzE4ODBiYWFkZDJiOWVhYmM3OS4uMDM0N2Y5YjlmNDYxNmY2NTgyNTM3NzBkMzE4YTQz ZDMzYzRjN2ExOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAyLTE4ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtHTElCXSBB IG51bWJlciBvZiBvZmZzY3JlZW5jYW52YXMgdGVzdHMgYXJlIGFzc2VydGluZyBpc01haW5UaHJl YWQgdHJ5aW5nIHRvIGFjY2VzcyBzdHJpY3RDU1NQYXJzZXJDb250ZXh0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIxNTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzdHJpY3RDU1NQYXJzZXJDb250ZXh0 KCkgY2FuIGJlIHVzZWQgb25seSBpbiB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgIEl0IGNhbid0 IGJlIHVzZWQgaW4gcGFyc2VDb2xvcldvcmtlclNhZmUoKS4KKworICAgICAgICAqIGNzcy9wYXJz ZXIvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VDb2xv cldvcmtlclNhZmUpOiBVc2UKKyAgICAgICAgQ1NTUGFyc2VyQ29udGV4dChIVE1MU3RhbmRhcmRN b2RlKSBpbnN0ZWFkIG9mCisgICAgICAgIHN0cmljdENTU1BhcnNlckNvbnRleHQoKS4KKwogMjAy MS0wMi0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBTY3JvbGxpbmcgb24gaHR0cHM6Ly93d3cuYXBwbGUuY29tL2lwYWQtYWlyLyBjYW4gaml0dGVy IG9uIGNlcnRhaW4gc2VjdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJz ZXIvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUGFyc2VyLmNw cAppbmRleCBhNzkyMDI5ZGVhNjQxN2FhNGUwZGYxNjYzMDZmYTc4Zjk0Y2FlNTVkLi43NjQ4ZjUw NGE1ZDdhMzA4MDM5NTU2NmRhYjM4ZTQzZmIwODgxYjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL3Bh cnNlci9DU1NQYXJzZXIuY3BwCkBAIC0xMTcsNyArMTE3LDcgQEAgQ29sb3IgQ1NTUGFyc2VyOjpw YXJzZUNvbG9yV29ya2VyU2FmZShjb25zdCBTdHJpbmcmIHN0cmluZykKICAgICBDU1NQYXJzZXJU b2tlblJhbmdlIHJhbmdlKHRva2VuaXplci50b2tlblJhbmdlKCkpOwogICAgIHJhbmdlLmNvbnN1 bWVXaGl0ZXNwYWNlKCk7CiAKLSAgICByZXR1cm4gQ1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzOjpj b25zdW1lQ29sb3JXb3JrZXJTYWZlKHJhbmdlLCBzdHJpY3RDU1NQYXJzZXJDb250ZXh0KCkpOwor ICAgIHJldHVybiBDU1NQcm9wZXJ0eVBhcnNlckhlbHBlcnM6OmNvbnN1bWVDb2xvcldvcmtlclNh ZmUocmFuZ2UsIENTU1BhcnNlckNvbnRleHQoSFRNTFN0YW5kYXJkTW9kZSkpOwogfQogCiBDb2xv ciBDU1NQYXJzZXI6OnBhcnNlU3lzdGVtQ29sb3IoU3RyaW5nVmlldyBzdHJpbmcpCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg Y2I3N2JiODE0NzBhNTNhMTUyMjBhNTFkYzdjOWZkZTNiZjQ0YTAzYi4uNjk3NmQ3YmU0ZmY2MjE1 N2JjYjg1NjkxZjEzY2FkNjc1NTg5NWYzOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAy LTE4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAg IFtHTElCXSBBIG51bWJlciBvZiBvZmZzY3JlZW5jYW52YXMgdGVzdHMgYXJlIGFzc2VydGluZyBp c01haW5UaHJlYWQgdHJ5aW5nIHRvIGFjY2VzcyBzdHJpY3RDU1NQYXJzZXJDb250ZXh0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIxNTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2ds aWIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMS0wMi0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBTY3JvbGxpbmcgb24gaHR0cHM6Ly93d3cuYXBw bGUuY29tL2lwYWQtYWlyLyBjYW4gaml0dGVyIG9uIGNlcnRhaW4gc2VjdGlvbnMKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBmYTcwZDA2ZjQ4Y2U5MzYx NmYwYzE5ZTdiNDU2YzUzMzVlYmFiOTRjLi4yYzk5ZjU5ZjkwNjViYjFkMWVkNjFlYWJlYzU3ZGE5 MTU1NTRkZjkxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBl Y3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25z CkBAIC02NjQsMzUgKzY2NCw2IEBAIHdlYmtpdC5vcmcvYi8yMTU0NjIgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vbWFudWFsCiB3ZWJraXQub3Jn L2IvMjIxMzExIFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv Y2FudmFzL29mZnNjcmVlbi9maWx0ZXIvb2Zmc2NyZWVuY2FudmFzLmZpbHRlci53Lmh0bWwgWyBT bG93IF0KIHdlYmtpdC5vcmcvYi8yMjEzMTEgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvb2Zmc2NyZWVuL21hbnVhbC9maWx0ZXIvb2Zmc2NyZWVu Y2FudmFzLmZpbHRlci53Lmh0bWwgWyBTbG93IF0KIAotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERl YnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3Jl ZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5bGUuaW52YWxpZHN0cmluZy53b3Jr ZXIuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMjIxNTYgWyBEZWJ1ZyBdIGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvb2Zmc2NyZWVuL2ZpbGwtYW5kLXN0 cm9rZS1zdHlsZXMvMmQuZmlsbFN0eWxlLmludmFsaWR0eXBlLndvcmtlci5odG1sIFsgQ3Jhc2gg XQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5m aWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsLTEud29ya2VyLmh0bWwgWyBDcmFzaCBdCi13 ZWJraXQub3JnL2IvMjIyMTU2IFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2h0bWwvY2FudmFzL29mZnNjcmVlbi9maWxsLWFuZC1zdHJva2Utc3R5bGVzLzJkLmZpbGxT dHlsZS5wYXJzZS5jc3MtY29sb3ItNC1oc2wtMi53b3JrZXIuaHRtbCBbIENyYXNoIF0KLXdlYmtp dC5vcmcvYi8yMjIxNTYgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv aHRtbC9jYW52YXMvb2Zmc2NyZWVuL2ZpbGwtYW5kLXN0cm9rZS1zdHlsZXMvMmQuZmlsbFN0eWxl LnBhcnNlLmNzcy1jb2xvci00LWhzbC0zLndvcmtlci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9y Zy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5bGUucGFy c2UuY3NzLWNvbG9yLTQtaHNsLTQud29ya2VyLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2Iv MjIyMTU2IFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2Fu dmFzL29mZnNjcmVlbi9maWxsLWFuZC1zdHJva2Utc3R5bGVzLzJkLmZpbGxTdHlsZS5wYXJzZS5j c3MtY29sb3ItNC1oc2wtNS53b3JrZXIuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMjIx NTYgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMv b2Zmc2NyZWVuL2ZpbGwtYW5kLXN0cm9rZS1zdHlsZXMvMmQuZmlsbFN0eWxlLnBhcnNlLmNzcy1j b2xvci00LWhzbC02Lndvcmtlci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBb IERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZz Y3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9y LTQtaHNsLTcud29ya2VyLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMjIyMTU2IFsgRGVi dWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29mZnNjcmVl bi9maWxsLWFuZC1zdHJva2Utc3R5bGVzLzJkLmZpbGxTdHlsZS5wYXJzZS5jc3MtY29sb3ItNC1o c2wtOC53b3JrZXIuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMjIxNTYgWyBEZWJ1ZyBd IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvb2Zmc2NyZWVuL2Zp bGwtYW5kLXN0cm9rZS1zdHlsZXMvMmQuZmlsbFN0eWxlLnBhcnNlLmNzcy1jb2xvci00LWhzbC05 Lndvcmtlci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1h bmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS0xLndv cmtlci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQt c3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS0yLndvcmtl ci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ry b2tlLXN0eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS0zLndvcmtlci5o dG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tl LXN0eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS00Lndvcmtlci5odG1s IFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0 eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS01Lndvcmtlci5odG1sIFsg Q3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxl cy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS02Lndvcmtlci5odG1sIFsgQ3Jh c2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8y ZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS03Lndvcmtlci5odG1sIFsgQ3Jhc2gg XQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5m aWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS04Lndvcmtlci5odG1sIFsgQ3Jhc2ggXQot d2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxs U3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtaHNsYS05Lndvcmtlci5odG1sIFsgQ3Jhc2ggXQotd2Vi a2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5 bGUucGFyc2UuY3NzLWNvbG9yLTQtcmdiLTEud29ya2VyLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQu b3JnL2IvMjIyMTU2IFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0 bWwvY2FudmFzL29mZnNjcmVlbi9maWxsLWFuZC1zdHJva2Utc3R5bGVzLzJkLmZpbGxTdHlsZS5w YXJzZS5jc3MtY29sb3ItNC1yZ2ItMi53b3JrZXIuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcv Yi8yMjIxNTYgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9j YW52YXMvb2Zmc2NyZWVuL2ZpbGwtYW5kLXN0cm9rZS1zdHlsZXMvMmQuZmlsbFN0eWxlLnBhcnNl LmNzcy1jb2xvci00LXJnYi0zLndvcmtlci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIy MjE1NiBbIERlYnVnIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZh cy9vZmZzY3JlZW4vZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3Nz LWNvbG9yLTQtcmdiLTQud29ya2VyLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMjIyMTU2 IFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29m ZnNjcmVlbi9maWxsLWFuZC1zdHJva2Utc3R5bGVzLzJkLmZpbGxTdHlsZS5wYXJzZS5jc3MtY29s b3ItNC1yZ2ItNS53b3JrZXIuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMjIxNTYgWyBE ZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9jYW52YXMvb2Zmc2Ny ZWVuL2ZpbGwtYW5kLXN0cm9rZS1zdHlsZXMvMmQuZmlsbFN0eWxlLnBhcnNlLmNzcy1jb2xvci00 LXJnYi02Lndvcmtlci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVn IF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4v ZmlsbC1hbmQtc3Ryb2tlLXN0eWxlcy8yZC5maWxsU3R5bGUucGFyc2UuY3NzLWNvbG9yLTQtcmdi YS0xLndvcmtlci5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyMjE1NiBbIERlYnVnIF0g aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vc2hh ZG93cy8yZC5zaGFkb3cuYXR0cmlidXRlcy5zaGFkb3dDb2xvci5pbnZhbGlkLndvcmtlci5odG1s IFsgQ3Jhc2ggXQotCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2Yg T2Zmc2NyZWVuQ2FudmFzLXJlbGF0ZWQgYnVncwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8K