222151 2021-02-18 17:58:43 -0800 Correctly retain properties in _WKAppHighlight 2021-02-18 18:19:12 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1731135 0 megan_gardner 2021-02-18 17:58:43 -0800 Correctly retain properties in _WKAppHighlight 1731136 1 420891 megan_gardner 2021-02-18 17:59:45 -0800 Created attachment 420891 Patch 1731139 2 420891 wenson_hsieh 2021-02-18 18:05:29 -0800 Comment on attachment 420891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420891&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKAppHighlight.mm:45 > + _highlight = adoptNS(highlight); > + _text = adoptNS(text); > + _image = adoptNS(image); This will overrelease the arguments, since they're not +1 objects. 1731140 3 420893 megan_gardner 2021-02-18 18:07:22 -0800 Created attachment 420893 Patch 1731144 4 megan_gardner 2021-02-18 18:18:22 -0800 Committed r273119 (234316@main): <https://commits.webkit.org/234316@main> 1731145 5 webkit-bug-importer 2021-02-18 18:19:12 -0800 <rdar://problem/74503732> 420891 2021-02-18 17:59:45 -0800 2021-02-18 18:07:21 -0800 Patch bug-222151-20210218175944.patch text/plain 2969 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVjYzQwODE2ZjRjODY0NGUy MDdlZGQyMzQ1MjlhMDI2ZjZhODAwNWYuLjdmNGU3ZDQzY2VkNDE0Y2NhZDBmNWFmYTFmYTYzYzRm YTY1MDM3MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDItMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDb3JyZWN0bHkgcmV0 YWluIHByb3BlcnRpZXMgaW4gX1dLQXBwSGlnaGxpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIxNTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXBwSGln aGxpZ2h0Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBcHBIaWdobGlnaHQu bW06CisgICAgICAgICgtW19XS0FwcEhpZ2hsaWdodCBpbml0V2l0aEhpZ2hsaWdodDp0ZXh0Omlt YWdlOl0pOgorICAgICAgICAoLVtfV0tBcHBIaWdobGlnaHQgaGlnaGxpZ2h0XSk6CisgICAgICAg ICgtW19XS0FwcEhpZ2hsaWdodCB0ZXh0XSk6CisgICAgICAgICgtW19XS0FwcEhpZ2hsaWdodCBp bWFnZV0pOgorCiAyMDIxLTAyLTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIG51bGwgY2hlY2sgaW4gX2dldE1haW5SZXNvdXJjZURh dGFXaXRoQ29tcGxldGlvbkhhbmRsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9fV0tBcHBIaWdobGlnaHQuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tBcHBIaWdobGlnaHQuaAppbmRleCA3NmMzNzc4MTY1NWM0OWE5ZTE4ZmIw Y2M2ZGRiN2YyMzlkMDQ0YmY3Li5kM2RiNDVkN2EwYTA5NzI2ZTk4YzM2NzBkYjdlZWEzOGJlNDA1 ZjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXBw SGlnaGxpZ2h0LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0Fw cEhpZ2hsaWdodC5oCkBAIC0zNiwxNCArMzYsMTQgQEAgV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29z KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpCiAKIC0gKGluc3RhbmNldHlwZSlpbml0IE5T X1VOQVZBSUxBQkxFOwogCi1AcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNvcHkpIE5T RGF0YSAqaGlnaGxpZ2h0OworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5LCBzdHJvbmcp IE5TRGF0YSAqaGlnaGxpZ2h0OwogCi1AcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNv cHkpIE5TU3RyaW5nICp0ZXh0OworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5LCBzdHJv bmcpIE5TU3RyaW5nICp0ZXh0OwogCiAjaWYgVEFSR0VUX09TX0lQSE9ORQotQHByb3BlcnR5IChu b25hdG9taWMsIHJlYWRvbmx5LCBjb3B5KSBVSUltYWdlICppbWFnZTsKK0Bwcm9wZXJ0eSAobm9u YXRvbWljLCByZWFkb25seSwgc3Ryb25nKSBVSUltYWdlICppbWFnZTsKICNlbHNlCi1AcHJvcGVy dHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNvcHkpIE5TSW1hZ2UgKmltYWdlOworQHByb3BlcnR5 IChub25hdG9taWMsIHJlYWRvbmx5LCBzdHJvbmcpIE5TSW1hZ2UgKmltYWdlOwogI2VuZGlmCiAK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0FwcEhp Z2hsaWdodC5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBcHBIaWdo bGlnaHQubW0KaW5kZXggZTY3NGRmMTE2ODQ1ZGY3YTAwNmM1NTE3MjNlMzIxNzY3YmYzMGVmZS4u MzJlMDQ5MmVmNzAxOWM4ZWEwODJiMzdlNjI2NDNjOWQ4ZmVmN2U1NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0FwcEhpZ2hsaWdodC5tbQorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXBwSGlnaGxpZ2h0Lm1tCkBAIC0y NywxOSArMjcsMzkgQEAKICNpbXBvcnQgIl9XS0FwcEhpZ2hsaWdodC5oIgogCiAjaW1wb3J0ICJD b2NvYUltYWdlLmgiCisjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CiAKLUBpbXBsZW1lbnRhdGlv biBfV0tBcHBIaWdobGlnaHQKK0BpbXBsZW1lbnRhdGlvbiBfV0tBcHBIaWdobGlnaHQgeworICAg IFJldGFpblB0cjxOU0RhdGE+IF9oaWdobGlnaHQ7CisgICAgUmV0YWluUHRyPE5TU3RyaW5nPiBf dGV4dDsKKyAgICBSZXRhaW5QdHI8Q29jb2FJbWFnZT4gX2ltYWdlOworfQogCiAtIChpbnN0YW5j ZXR5cGUpaW5pdFdpdGhIaWdobGlnaHQ6KE5TRGF0YSAqKWhpZ2hsaWdodCB0ZXh0OihOU1N0cmlu ZyAqKXRleHQgaW1hZ2U6KENvY29hSW1hZ2UgKilpbWFnZQogewogICAgIGlmICghKHNlbGYgPSBb c3VwZXIgaW5pdF0pKQogICAgICAgICByZXR1cm4gbmlsOwogCi0gICAgX2hpZ2hsaWdodCA9IGhp Z2hsaWdodDsKLSAgICBfdGV4dCA9IHRleHQ7Ci0gICAgX2ltYWdlID0gaW1hZ2U7CisgICAgX2hp Z2hsaWdodCA9IGFkb3B0TlMoaGlnaGxpZ2h0KTsKKyAgICBfdGV4dCA9IGFkb3B0TlModGV4dCk7 CisgICAgX2ltYWdlID0gYWRvcHROUyhpbWFnZSk7CiAKICAgICByZXR1cm4gc2VsZjsKIH0KIAor LSAoTlNEYXRhICopaGlnaGxpZ2h0Cit7CisgICAgcmV0dXJuIF9oaWdobGlnaHQuZ2V0KCk7Cit9 CisKKy0gKE5TU3RyaW5nICopdGV4dAoreworICAgIHJldHVybiBfdGV4dC5nZXQoKTsKK30KKwor LSAoQ29jb2FJbWFnZSAqKWltYWdlCit7CisgICAgcmV0dXJuIF9pbWFnZS5nZXQoKTsKK30KKwog QGVuZAo= 420893 2021-02-18 18:07:22 -0800 2021-02-18 18:08:58 -0800 Patch bug-222151-20210218180722.patch text/plain 2845 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVjYzQwODE2ZjRjODY0NGUy MDdlZGQyMzQ1MjlhMDI2ZjZhODAwNWYuLjdmNGU3ZDQzY2VkNDE0Y2NhZDBmNWFmYTFmYTYzYzRm YTY1MDM3MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDItMTggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBDb3JyZWN0bHkgcmV0 YWluIHByb3BlcnRpZXMgaW4gX1dLQXBwSGlnaGxpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIxNTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXBwSGln aGxpZ2h0Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBcHBIaWdobGlnaHQu bW06CisgICAgICAgICgtW19XS0FwcEhpZ2hsaWdodCBpbml0V2l0aEhpZ2hsaWdodDp0ZXh0Omlt YWdlOl0pOgorICAgICAgICAoLVtfV0tBcHBIaWdobGlnaHQgaGlnaGxpZ2h0XSk6CisgICAgICAg ICgtW19XS0FwcEhpZ2hsaWdodCB0ZXh0XSk6CisgICAgICAgICgtW19XS0FwcEhpZ2hsaWdodCBp bWFnZV0pOgorCiAyMDIxLTAyLTE4ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIG51bGwgY2hlY2sgaW4gX2dldE1haW5SZXNvdXJjZURh dGFXaXRoQ29tcGxldGlvbkhhbmRsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9fV0tBcHBIaWdobGlnaHQuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tBcHBIaWdobGlnaHQuaAppbmRleCA3NmMzNzc4MTY1NWM0OWE5ZTE4ZmIw Y2M2ZGRiN2YyMzlkMDQ0YmY3Li5kM2RiNDVkN2EwYTA5NzI2ZTk4YzM2NzBkYjdlZWEzOGJlNDA1 ZjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXBw SGlnaGxpZ2h0LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0Fw cEhpZ2hsaWdodC5oCkBAIC0zNiwxNCArMzYsMTQgQEAgV0tfQ0xBU1NfQVZBSUxBQkxFKG1hY29z KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpCiAKIC0gKGluc3RhbmNldHlwZSlpbml0IE5T X1VOQVZBSUxBQkxFOwogCi1AcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNvcHkpIE5T RGF0YSAqaGlnaGxpZ2h0OworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5LCBzdHJvbmcp IE5TRGF0YSAqaGlnaGxpZ2h0OwogCi1AcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNv cHkpIE5TU3RyaW5nICp0ZXh0OworQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5LCBzdHJv bmcpIE5TU3RyaW5nICp0ZXh0OwogCiAjaWYgVEFSR0VUX09TX0lQSE9ORQotQHByb3BlcnR5IChu b25hdG9taWMsIHJlYWRvbmx5LCBjb3B5KSBVSUltYWdlICppbWFnZTsKK0Bwcm9wZXJ0eSAobm9u YXRvbWljLCByZWFkb25seSwgc3Ryb25nKSBVSUltYWdlICppbWFnZTsKICNlbHNlCi1AcHJvcGVy dHkgKG5vbmF0b21pYywgcmVhZG9ubHksIGNvcHkpIE5TSW1hZ2UgKmltYWdlOworQHByb3BlcnR5 IChub25hdG9taWMsIHJlYWRvbmx5LCBzdHJvbmcpIE5TSW1hZ2UgKmltYWdlOwogI2VuZGlmCiAK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0FwcEhp Z2hsaWdodC5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBcHBIaWdo bGlnaHQubW0KaW5kZXggZTY3NGRmMTE2ODQ1ZGY3YTAwNmM1NTE3MjNlMzIxNzY3YmYzMGVmZS4u NWZmYzdjYWI4ODgwYjljMTAzNmUzMzkxMzA2MzQzOGU2N2U2NTU5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0FwcEhpZ2hsaWdodC5tbQorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXBwSGlnaGxpZ2h0Lm1tCkBAIC0y Nyw4ICsyNywxMyBAQAogI2ltcG9ydCAiX1dLQXBwSGlnaGxpZ2h0LmgiCiAKICNpbXBvcnQgIkNv Y29hSW1hZ2UuaCIKKyNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KIAotQGltcGxlbWVudGF0aW9u IF9XS0FwcEhpZ2hsaWdodAorQGltcGxlbWVudGF0aW9uIF9XS0FwcEhpZ2hsaWdodCB7CisgICAg UmV0YWluUHRyPE5TRGF0YT4gX2hpZ2hsaWdodDsKKyAgICBSZXRhaW5QdHI8TlNTdHJpbmc+IF90 ZXh0OworICAgIFJldGFpblB0cjxDb2NvYUltYWdlPiBfaW1hZ2U7Cit9CiAKIC0gKGluc3RhbmNl dHlwZSlpbml0V2l0aEhpZ2hsaWdodDooTlNEYXRhICopaGlnaGxpZ2h0IHRleHQ6KE5TU3RyaW5n ICopdGV4dCBpbWFnZTooQ29jb2FJbWFnZSAqKWltYWdlCiB7CkBAIC00Miw0ICs0NywxOSBAQCAt IChpbnN0YW5jZXR5cGUpaW5pdFdpdGhIaWdobGlnaHQ6KE5TRGF0YSAqKWhpZ2hsaWdodCB0ZXh0 OihOU1N0cmluZyAqKXRleHQgaW1hZwogICAgIHJldHVybiBzZWxmOwogfQogCistIChOU0RhdGEg KiloaWdobGlnaHQKK3sKKyAgICByZXR1cm4gX2hpZ2hsaWdodC5nZXQoKTsKK30KKworLSAoTlNT dHJpbmcgKil0ZXh0Cit7CisgICAgcmV0dXJuIF90ZXh0LmdldCgpOworfQorCistIChDb2NvYUlt YWdlICopaW1hZ2UKK3sKKyAgICByZXR1cm4gX2ltYWdlLmdldCgpOworfQorCiBAZW5kCg==