222126 2021-02-18 12:58:15 -0800 Fix null dereferencing in RangeResponseGenerator::giveResponseToTasksWithFinishedRanges 2021-02-18 15:14:55 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221072 P2 Normal --- 1 achristensen achristensen darin oldest_to_newest 1730991 0 achristensen 2021-02-18 12:58:15 -0800 Fix null dereferencing in RangeResponseGenerator::giveResponseToTasksWithFinishedRanges 1730994 1 420864 achristensen 2021-02-18 12:59:27 -0800 Created attachment 420864 Patch 1730999 2 420864 darin 2021-02-18 13:08:18 -0800 Comment on attachment 420864 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420864&action=review > Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:274 > m_generator->giveResponseToTasksWithFinishedRanges(*data); I think it’s clearer to write: protectedThis->m_generator->giveResponseToTasksWithFinishedRanges(*data); But I’m not sure anyone else in this project agrees with me! Also, I think that Ryosuke said our overall strategy is to protect differently than this; it would be the caller who should be doing ref/deref, not this function protecting itself. So the fix would be in RemoteMediaResourceManager::loadFinished, which should be using a RefPtr for its local variable. 1731001 3 420866 achristensen 2021-02-18 13:15:35 -0800 Created attachment 420866 Patch 1731041 4 achristensen 2021-02-18 15:14:49 -0800 r273103 420864 2021-02-18 12:59:27 -0800 2021-02-18 13:15:33 -0800 Patch bug-222126-20210218125927.patch text/plain 3400 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIyNWJiM2MwZDcxOTFj ZGZiOWI5MTM0ZDQ0MWJkNGM0YWM1ODZlOS4uN2MxYTE4MWU0OTYyNDc4MjllY2Y2ZWFmZGJmYTU2 YzZiYjhhZDI4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTE4ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG51 bGwgZGVyZWZlcmVuY2luZyBpbiBSYW5nZVJlc3BvbnNlR2VuZXJhdG9yOjpnaXZlUmVzcG9uc2VU b1Rhc2tzV2l0aEZpbmlzaGVkUmFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjIxMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTZXR0aW5nIHRoZSByZXNvdXJjZSB0byBudWxscHRyIGNhbiBkZWxl dGUgdGhlIHJlc291cmNlLCB3aGljaCBkZWxldGVzIHRoZSBjbGllbnQsIHdoaWNoIGlzIHRoaXMu CisgICAgICAgIFdoZW4gd2UgZ28gdG8gcmVhZCBtX2dlbmVyYXRvciBmcm9tIHRoaXMsIHdlIGdl dCBhIG51bGxwdHIgY3Jhc2guICBMZXQncyBub3QgY3Jhc2guCisKKyAgICAgICAgKiBwbGF0Zm9y bS9uZXR3b3JrL2NvY29hL1JhbmdlUmVzcG9uc2VHZW5lcmF0b3IubW06CisgICAgICAgIChXZWJD b3JlOjpSYW5nZVJlc3BvbnNlR2VuZXJhdG9yOjp3aWxsU3ludGhlc2l6ZVJhbmdlUmVzcG9uc2Vz KToKKwogMjAyMS0wMi0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIERpc2FibGUgUmFuZ2VSZXNwb25zZUdlbmVyYXRvciBhZ2Fpbi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmFuZ2VSZXNw b25zZUdlbmVyYXRvci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2Ev UmFuZ2VSZXNwb25zZUdlbmVyYXRvci5tbQppbmRleCBhMzU2NTRjZTFhOGU5OWJhZTYwYzE5YWMx OWYzOGYxYWJiYWRhZjI5Li45MDIzZGIwODIxNTM5MzdjNWIxNmE4NTdhZmIwYzRlOTcyMDRlNTZj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1Jhbmdl UmVzcG9uc2VHZW5lcmF0b3IubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jb2NvYS9SYW5nZVJlc3BvbnNlR2VuZXJhdG9yLm1tCkBAIC0yNjksNiArMjY5LDcgQEAgcHJp dmF0ZToKICAgICAgICAgaWYgKCFkYXRhKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBk YXRhLT5zdWNjZXNzZnVsbHlGaW5pc2hlZExvYWRpbmcgPSBEYXRhOjpTdWNjZXNzZnVsbHlGaW5p c2hlZExvYWRpbmc6OlllczsKKyAgICAgICAgYXV0byBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigq dGhpcyk7CiAgICAgICAgIGRhdGEtPnJlc291cmNlID0gbnVsbHB0cjsKICAgICAgICAgbV9nZW5l cmF0b3ItPmdpdmVSZXNwb25zZVRvVGFza3NXaXRoRmluaXNoZWRSYW5nZXMoKmRhdGEpOwogICAg IH0KQEAgLTI3OSwxMCArMjgwLDYgQEAgcHJpdmF0ZToKIAogYm9vbCBSYW5nZVJlc3BvbnNlR2Vu ZXJhdG9yOjp3aWxsU3ludGhlc2l6ZVJhbmdlUmVzcG9uc2VzKFdlYkNvcmVOU1VSTFNlc3Npb25E YXRhVGFzayAqdGFzaywgUGxhdGZvcm1NZWRpYVJlc291cmNlJiByZXNvdXJjZSwgY29uc3QgUmVz b3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7Ci0gICAgYm9vbCByYW5nZVJlc3BvbnNlR2VuZXJh dG9yRGlzYWJsZWQgPSB0cnVlOwotICAgICBpZiAocmFuZ2VSZXNwb25zZUdlbmVyYXRvckRpc2Fi bGVkKQotICAgICAgICAgcmV0dXJuIGZhbHNlOwotCiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgp KTsKICAgICBOU1VSTFJlcXVlc3QgKm9yaWdpbmFsUmVxdWVzdCA9IHRhc2sub3JpZ2luYWxSZXF1 ZXN0OwogICAgIGlmICghb3JpZ2luYWxSZXF1ZXN0LlVSTCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMTBjODM5NjQ0NWYzZDdmZGMyNGJlZjA1 MWMwNzk3MTc4MTk4MzQ5Li5mNzk5ZjkwNDZjYzY5YWY4ODliNmQ0NmYyODRiNGQ1NGE2ZjhkZGUw IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMjEtMDItMTggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KKworICAgICAgICBGaXggbnVsbCBkZXJlZmVyZW5jaW5nIGluIFJhbmdlUmVz cG9uc2VHZW5lcmF0b3I6OmdpdmVSZXNwb25zZVRvVGFza3NXaXRoRmluaXNoZWRSYW5nZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjEyNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9NZWRpYUxvYWRpbmcubW06CisgICAgICAgIChUZXN0V2Vi S2l0QVBJOjpURVNUKToKKwogMjAyMS0wMi0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIERpc2FibGUgUmFuZ2VSZXNwb25zZUdlbmVyYXRv ciBhZ2Fpbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29j b2EvTWVkaWFMb2FkaW5nLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9NZWRpYUxvYWRpbmcubW0KaW5kZXggM2NlMDUxOGRkMTA4ZmI1NjA3MjhhYmEyNTliMTU0YWZi NzYyNWU0Ni4uOGY4YWIyMGEzYjk4OTEyNWRiODAxMDFkMWMzMDdkNGY2OGQzZDEzOCAxMDA2NDQK LS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9NZWRpYUxvYWRpbmcu bW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9NZWRpYUxvYWRp bmcubW0KQEAgLTE1Miw3ICsxNTIsNyBAQCBURVNUKE1lZGlhTG9hZGluZywgUmFuZ2VSZXF1ZXN0 U3ludGhlc2lzV2l0aENvbnRlbnRMZW5ndGgpCiAgICAgICAgIHsiLyIsIHsgdmlkZW9QbGF5VGVz dEhUTUwgfX0sCiAgICAgICAgIHsiL3ZpZGVvLm1wNCIsIHsgdGVzdFZpZGVvQnl0ZXMoKSB9fQog ICAgIH0pOwotICAgIHJ1blZpZGVvVGVzdChzZXJ2ZXIucmVxdWVzdCgpLCAiZXJyb3IiKTsKKyAg ICBydW5WaWRlb1Rlc3Qoc2VydmVyLnJlcXVlc3QoKSwgInBsYXlpbmciKTsKICAgICBFWFBFQ1Rf RVEoc2VydmVyLnRvdGFsUmVxdWVzdHMoKSwgMnUpOwogfQogCg== 420866 2021-02-18 13:15:35 -0800 2021-02-18 15:14:55 -0800 Patch bug-222126-20210218131534.patch text/plain 3919 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIyNWJiM2MwZDcxOTFj ZGZiOWI5MTM0ZDQ0MWJkNGM0YWM1ODZlOS4uN2VhNGRhNmFhODU3MDdiNDYyYWRhM2I2MWQwNWE4 MjAzYTAwZmI5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTE4ICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IG51 bGwgZGVyZWZlcmVuY2luZyBpbiBSYW5nZVJlc3BvbnNlR2VuZXJhdG9yOjpnaXZlUmVzcG9uc2VU b1Rhc2tzV2l0aEZpbmlzaGVkUmFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjIxMjYKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KKworICAgICAgICBTZXR0aW5nIHRoZSByZXNvdXJjZSB0byBudWxscHRyIGNhbiBkZWxldGUg dGhlIHJlc291cmNlLCB3aGljaCBkZWxldGVzIHRoZSBjbGllbnQsIHdoaWNoIGlzIHRoaXMuCisg ICAgICAgIFdoZW4gd2UgZ28gdG8gcmVhZCBtX2dlbmVyYXRvciBmcm9tIHRoaXMsIHdlIGdldCBh IG51bGxwdHIgY3Jhc2guICBMZXQncyBub3QgY3Jhc2guCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2NvY29hL1JhbmdlUmVzcG9uc2VHZW5lcmF0b3IubW06CisgICAgICAgIChXZWJDb3Jl OjpSYW5nZVJlc3BvbnNlR2VuZXJhdG9yOjp3aWxsU3ludGhlc2l6ZVJhbmdlUmVzcG9uc2VzKToK KwogMjAyMS0wMi0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIERpc2FibGUgUmFuZ2VSZXNwb25zZUdlbmVyYXRvciBhZ2Fpbi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmFuZ2VSZXNwb25z ZUdlbmVyYXRvci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmFu Z2VSZXNwb25zZUdlbmVyYXRvci5tbQppbmRleCBhMzU2NTRjZTFhOGU5OWJhZTYwYzE5YWMxOWYz OGYxYWJiYWRhZjI5Li4xNzUyMjZiZGZhOGQwODJkNjNkOWE3ZTU5NTkwYjBjZGE1MmY0ZmI1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL1JhbmdlUmVz cG9uc2VHZW5lcmF0b3IubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j b2NvYS9SYW5nZVJlc3BvbnNlR2VuZXJhdG9yLm1tCkBAIC0yNjMsMTQgKzI2MywxNSBAQCBwcml2 YXRlOgogICAgIHZvaWQgbG9hZEZpbmlzaGVkKFBsYXRmb3JtTWVkaWFSZXNvdXJjZSYsIGNvbnN0 IE5ldHdvcmtMb2FkTWV0cmljcyYpIGZpbmFsCiAgICAgewogICAgICAgICBBU1NFUlQoaXNNYWlu VGhyZWFkKCkpOwotICAgICAgICBpZiAoIW1fZ2VuZXJhdG9yKQorICAgICAgICBhdXRvIGdlbmVy YXRvciA9IG1ha2VSZWZQdHIobV9nZW5lcmF0b3IuZ2V0KCkpOworICAgICAgICBpZiAoIWdlbmVy YXRvcikKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgYXV0byogZGF0YSA9IG1fZ2VuZXJh dG9yLT5tX21hcC5nZXQobV91cmxTdHJpbmcpOworICAgICAgICBhdXRvKiBkYXRhID0gZ2VuZXJh dG9yLT5tX21hcC5nZXQobV91cmxTdHJpbmcpOwogICAgICAgICBpZiAoIWRhdGEpCiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIGRhdGEtPnN1Y2Nlc3NmdWxseUZpbmlzaGVkTG9hZGluZyA9 IERhdGE6OlN1Y2Nlc3NmdWxseUZpbmlzaGVkTG9hZGluZzo6WWVzOwotICAgICAgICBkYXRhLT5y ZXNvdXJjZSA9IG51bGxwdHI7Ci0gICAgICAgIG1fZ2VuZXJhdG9yLT5naXZlUmVzcG9uc2VUb1Rh c2tzV2l0aEZpbmlzaGVkUmFuZ2VzKCpkYXRhKTsKKyAgICAgICAgZGF0YS0+cmVzb3VyY2UgPSBu dWxscHRyOyAvLyBUaGlzIGxpbmUgY2FuIGRlbGV0ZSB0aGlzIE1lZGlhUmVzb3VyY2VDbGllbnQu CisgICAgICAgIGdlbmVyYXRvci0+Z2l2ZVJlc3BvbnNlVG9UYXNrc1dpdGhGaW5pc2hlZFJhbmdl cygqZGF0YSk7CiAgICAgfQogCiAgICAgV2Vha1B0cjxSYW5nZVJlc3BvbnNlR2VuZXJhdG9yPiBt X2dlbmVyYXRvcjsKQEAgLTI3OSwxMCArMjgwLDYgQEAgcHJpdmF0ZToKIAogYm9vbCBSYW5nZVJl c3BvbnNlR2VuZXJhdG9yOjp3aWxsU3ludGhlc2l6ZVJhbmdlUmVzcG9uc2VzKFdlYkNvcmVOU1VS TFNlc3Npb25EYXRhVGFzayAqdGFzaywgUGxhdGZvcm1NZWRpYVJlc291cmNlJiByZXNvdXJjZSwg Y29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7Ci0gICAgYm9vbCByYW5nZVJlc3Bv bnNlR2VuZXJhdG9yRGlzYWJsZWQgPSB0cnVlOwotICAgICBpZiAocmFuZ2VSZXNwb25zZUdlbmVy YXRvckRpc2FibGVkKQotICAgICAgICAgcmV0dXJuIGZhbHNlOwotCiAgICAgQVNTRVJUKGlzTWFp blRocmVhZCgpKTsKICAgICBOU1VSTFJlcXVlc3QgKm9yaWdpbmFsUmVxdWVzdCA9IHRhc2sub3Jp Z2luYWxSZXF1ZXN0OwogICAgIGlmICghb3JpZ2luYWxSZXF1ZXN0LlVSTCkKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMTBjODM5NjQ0NWYzZDdm ZGMyNGJlZjA1MWMwNzk3MTc4MTk4MzQ5Li44YjliMGZjZjEwMjA3OTc5ZTQ3Zjk0NjJmMjRhMmJm YTdmMWYwZGE0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDItMTggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggbnVsbCBkZXJlZmVyZW5jaW5nIGlu IFJhbmdlUmVzcG9uc2VHZW5lcmF0b3I6OmdpdmVSZXNwb25zZVRvVGFza3NXaXRoRmluaXNoZWRS YW5nZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy MjEyNgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgICogVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9NZWRpYUxvYWRpbmcubW06CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMS0wMi0xOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIERpc2FibGUgUmFuZ2VSZXNwb25zZUdl bmVyYXRvciBhZ2Fpbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2Vi S2l0Q29jb2EvTWVkaWFMb2FkaW5nLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXRDb2NvYS9NZWRpYUxvYWRpbmcubW0KaW5kZXggM2NlMDUxOGRkMTA4ZmI1NjA3MjhhYmEyNTli MTU0YWZiNzYyNWU0Ni4uOGY4YWIyMGEzYjk4OTEyNWRiODAxMDFkMWMzMDdkNGY2OGQzZDEzOCAx MDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9NZWRpYUxv YWRpbmcubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9NZWRp YUxvYWRpbmcubW0KQEAgLTE1Miw3ICsxNTIsNyBAQCBURVNUKE1lZGlhTG9hZGluZywgUmFuZ2VS ZXF1ZXN0U3ludGhlc2lzV2l0aENvbnRlbnRMZW5ndGgpCiAgICAgICAgIHsiLyIsIHsgdmlkZW9Q bGF5VGVzdEhUTUwgfX0sCiAgICAgICAgIHsiL3ZpZGVvLm1wNCIsIHsgdGVzdFZpZGVvQnl0ZXMo KSB9fQogICAgIH0pOwotICAgIHJ1blZpZGVvVGVzdChzZXJ2ZXIucmVxdWVzdCgpLCAiZXJyb3Ii KTsKKyAgICBydW5WaWRlb1Rlc3Qoc2VydmVyLnJlcXVlc3QoKSwgInBsYXlpbmciKTsKICAgICBF WFBFQ1RfRVEoc2VydmVyLnRvdGFsUmVxdWVzdHMoKSwgMnUpOwogfQogCg==