222108 2021-02-18 08:38:10 -0800 [GStreamer] Error instead of asserting on the player in the source 2021-03-23 10:13:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=213857 InRadar P2 Normal --- 1 calvaris calvaris aboya cgarcia ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1730862 0 calvaris 2021-02-18 08:38:10 -0800 [GStreamer] Error instead of asserting on the player in the source 1730864 1 420833 calvaris 2021-02-18 08:40:01 -0800 Created attachment 420833 Patch 1730871 2 420833 pnormand 2021-02-18 08:55:03 -0800 Comment on attachment 420833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420833&action=review > Source/WebCore/ChangeLog:10 > + The release assert can be hit in some cases in smoothstreaming > + with already invalid pipelines so better to just error out instead > + of assert on release. I don't disagree about this patch, but I would like to know more about these invalid pipelines :) 1730885 3 aboya 2021-02-18 09:06:16 -0800 Do you have a test vector that reproduces the failed assertion? 1731232 4 calvaris 2021-02-18 22:53:36 -0800 It's a DRM test that plays, ends, loops, the DRM systems fails and then sometimes you get the error. 1731313 5 420833 aboya 2021-02-19 06:02:18 -0800 Comment on attachment 420833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420833&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:484 > + GST_ERROR_OBJECT(src, "player should not be null"); I would word it better: "Couldn't obtain WebKitWebSrcPlayerContext, which is necessary to make network requests." > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:485 > + ASSERT_NOT_REACHED(); I would not assert here. While reaching this case is undesirable, we're already handling the error by returning GST_FLOW_ERROR. The cause of not being able to get a player is most likely a preceding error, so crashing here doesn't help gather valuable information. Also I don't think Release and Debug should get different treatment in this case. 1731314 6 aboya 2021-02-19 06:03:03 -0800 Informal r+ with these changes 1734839 7 421933 calvaris 2021-03-02 07:33:48 -0800 Created attachment 421933 Patch 1734864 8 ews-feeder 2021-03-02 08:31:58 -0800 Committed r273731: <https://commits.webkit.org/r273731> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421933. 1734866 9 webkit-bug-importer 2021-03-02 08:32:15 -0800 <rdar://problem/74930203> 420833 2021-02-18 08:40:01 -0800 2021-03-02 07:33:41 -0800 Patch bug-222108-20210218173959.patch text/plain 1868 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRmZDJjZjM3ZjgzZDU5 ZjYyNzk4MzVhYjBkMmYyZWZjMWYxMDQ3NS4uMmVjZDNiYTJkNTI3MzlhYjQ1YzRlNmIxOGZiNjJk OTE1MDQ3MDM0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTE4ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gRXJyb3IgaW5zdGVhZCBvZiBhc3NlcnRpbmcgb24gdGhlIHBsYXllciBpbiB0aGUg c291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjIxMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgcmVsZWFzZSBhc3NlcnQgY2FuIGJlIGhpdCBpbiBzb21lIGNhc2VzIGluIHNtb290aHN0cmVh bWluZworICAgICAgICB3aXRoIGFscmVhZHkgaW52YWxpZCBwaXBlbGluZXMgc28gYmV0dGVyIHRv IGp1c3QgZXJyb3Igb3V0IGluc3RlYWQKKyAgICAgICAgb2YgYXNzZXJ0IG9uIHJlbGVhc2UuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0 cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYktpdFdlYlNyY0NyZWF0ZSk6CisKIDIwMjEtMDItMTIg IEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gU291bmQg ZG9lcyBub3QgcGxheSBvbiBZb3VUdWJlIGFmdGVyIHN3aXRjaGluZyBiYWNrIHRvIGZvcmVncm91 bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXggNThi YTYyZDc0MTZjNDYzOTg0M2Q1NWYyODhmYjgzNGVjYzE5YmQ5OC4uNzA4OGZiOTU3ZTM4YmM5ZDVm NDFhMWVhN2JjMGJjZDhlOTU1ZTU3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJj ZUdTdHJlYW1lci5jcHAKQEAgLTQ4MCw3ICs0ODAsMTEgQEAgc3RhdGljIEdzdEZsb3dSZXR1cm4g d2ViS2l0V2ViU3JjQ3JlYXRlKEdzdFB1c2hTcmMqIHB1c2hTcmMsIEdzdEJ1ZmZlcioqIGJ1ZmZl cikKICAgICAgICAgaWYgKG1lbWJlcnMtPmlzRmx1c2hpbmcpCiAgICAgICAgICAgICByZXR1cm4g R1NUX0ZMT1dfRkxVU0hJTkc7CiAgICAgfQotICAgIFJFTEVBU0VfQVNTRVJUKG1lbWJlcnMtPnBs YXllcik7CisgICAgaWYgKCFtZW1iZXJzLT5wbGF5ZXIpIHsKKyAgICAgICAgR1NUX0VSUk9SX09C SkVDVChzcmMsICJwbGF5ZXIgc2hvdWxkIG5vdCBiZSBudWxsIik7CisgICAgICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm4gR1NUX0ZMT1dfRVJST1I7CisgICAgfQogCiAg ICAgR1NUX1RSQUNFX09CSkVDVChzcmMsICJyZWFkUG9zaXRpb24gPSAlIiBHX0dVSU5UNjRfRk9S TUFUICIgcmVxdWVzdGVkUG9zaXRpb24gPSAlIiBHX0dVSU5UNjRfRk9STUFULCBtZW1iZXJzLT5y ZWFkUG9zaXRpb24sIG1lbWJlcnMtPnJlcXVlc3RlZFBvc2l0aW9uKTsKIAo= 421933 2021-03-02 07:33:48 -0800 2021-03-02 08:31:59 -0800 Patch bug-222108-20210302163347.patch text/plain 1957 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWE3YmUwYzRhZDQzMTQ3 MmRiZTg3MTk0M2YxYjZjYmU2YjdiZTNlYS4uOTQxNmU4ZGZmNTg4MTlhMTUyZjQ3YjhmZGYyNDEw NmQ0MzIzMTU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTAyICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gRXJyb3IgaW5zdGVhZCBvZiBhc3NlcnRpbmcgb24gdGhlIHBsYXllciBpbiB0aGUg c291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjIxMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgcmVsZWFzZSBhc3NlcnQgY2FuIGJlIGhpdCBpbiBzb21lIGNhc2VzIGluIHNtb290aHN0cmVh bWluZworICAgICAgICB3aXRoIGFscmVhZHkgaW52YWxpZCBwaXBlbGluZXMgc28gYmV0dGVyIHRv IGp1c3QgZXJyb3Igb3V0IGluc3RlYWQKKyAgICAgICAgb2YgYXNzZXJ0IG9uIHJlbGVhc2UuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0 cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYktpdFdlYlNyY0NyZWF0ZSk6CisKIDIwMjEtMDItMjYg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFtQYXltZW50IFJl cXVlc3RdIGxvZyB3aGVuIHRoZSByZXF1ZXN0IGlzIGNhbmNlbGxlZCB3aGlsZSB3YWl0aW5nIGZv ciB0aGUgYFByb21pc2VgIHByb3ZpZGVkIHRvIGBzaG93KClgL2B1cGRhdGVXaXRoKClgIHRvIHNl dHRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCAw Y2I3ZTcyYjUwMDM1MjZhZmRiOTExODdlOGNkMWQ3NTFiMjM1ZmRkLi40MDNmYjBhYzRkMmVmYTk4 YTZiZmFjODY4MmJmOTQ5MjQ0M2FiOTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291 cmNlR1N0cmVhbWVyLmNwcApAQCAtNDgwLDcgKzQ4MCwxMCBAQCBzdGF0aWMgR3N0Rmxvd1JldHVy biB3ZWJLaXRXZWJTcmNDcmVhdGUoR3N0UHVzaFNyYyogcHVzaFNyYywgR3N0QnVmZmVyKiogYnVm ZmVyKQogICAgICAgICBpZiAobWVtYmVycy0+aXNGbHVzaGluZykKICAgICAgICAgICAgIHJldHVy biBHU1RfRkxPV19GTFVTSElORzsKICAgICB9Ci0gICAgUkVMRUFTRV9BU1NFUlQobWVtYmVycy0+ cGxheWVyKTsKKyAgICBpZiAoIW1lbWJlcnMtPnBsYXllcikgeworICAgICAgICBHU1RfRVJST1Jf T0JKRUNUKHNyYywgIkNvdWxkbid0IG9idGFpbiBXZWJLaXRXZWJTcmNQbGF5ZXJDb250ZXh0LCB3 aGljaCBpcyBuZWNlc3NhcnkgdG8gbWFrZSBuZXR3b3JrIHJlcXVlc3RzIik7CisgICAgICAgIHJl dHVybiBHU1RfRkxPV19FUlJPUjsKKyAgICB9CiAKICAgICBHU1RfVFJBQ0VfT0JKRUNUKHNyYywg InJlYWRQb3NpdGlvbiA9ICUiIEdfR1VJTlQ2NF9GT1JNQVQgIiByZXF1ZXN0ZWRQb3NpdGlvbiA9 ICUiIEdfR1VJTlQ2NF9GT1JNQVQsIG1lbWJlcnMtPnJlYWRQb3NpdGlvbiwgbWVtYmVycy0+cmVx dWVzdGVkUG9zaXRpb24pOwogCg==