222089 2021-02-17 19:25:34 -0800 Return correct target for App Highlight menus. 2021-02-18 00:00:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer oldest_to_newest 1730712 0 megan_gardner 2021-02-17 19:25:34 -0800 Return correct target for App Highlight menus. 1730713 1 420784 megan_gardner 2021-02-17 19:26:20 -0800 Created attachment 420784 Patch 1730714 2 420784 thorton 2021-02-17 19:35:06 -0800 Comment on attachment 420784 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420784&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3699 > + if (sel_isEqual(action, @selector(createHighlightInCurrentGroupWithRange:)) || sel_isEqual(action, @selector(createHighlightInNewGroupWithRange:))) You can just use == (see above, or see the sel_isEqual docs) 1730715 3 420785 megan_gardner 2021-02-17 19:43:52 -0800 Created attachment 420785 Patch 1730729 4 420793 megan_gardner 2021-02-17 20:42:50 -0800 Created attachment 420793 Patch for landing 1730757 5 ews-feeder 2021-02-17 23:59:29 -0800 Committed r273066: <https://commits.webkit.org/r273066> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420793. 1730758 6 webkit-bug-importer 2021-02-18 00:00:25 -0800 <rdar://problem/74467567> 420784 2021-02-17 19:26:20 -0800 2021-02-17 20:42:47 -0800 Patch bug-222089-20210217192619.patch text/plain 1428 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1NzMxNWFmOTkxNDM0YmUz MTE4YTYwMmIxNjdhNWE2M2EzNjE1NDkuLjJhODIwNGE1NjM2ZjI1NmFkY2YwZmYzODM5ZDUwNjY1 NjExZjhkYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDItMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXR1cm4gY29ycmVj dCB0YXJnZXQgZm9yIEFwcCBIaWdobGlnaHQgbWVudXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIwODkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHRhcmdldEZvckFjdGlvbjp3 aXRoU2VuZGVyOl0pOgorCiAyMDIxLTAyLTE3ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBs ZS5jb20+CiAKICAgICAgICAgW0pTQ10gUmVuYW1lIGVudGl0bGVtZW50cyBmb3IgSklUQ2FnZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0KaW5kZXggNmRlNjBjZjVmNjllZTgxMmNmOTkyZDA5ZjJhOWZjZjBhMGRlM2Q4 Yi4uZWVhYWIxM2ZhZTE2NTdjZTY0YTdhZGViN2Q4ZDUwYzU0MTQyMTk3NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCkBAIC0zNjk2LDYgKzM2OTYsOCBAQCAtIChCT09MKWNhblBlcmZvcm1BY3Rpb25Gb3JXZWJW aWV3OihTRUwpYWN0aW9uIHdpdGhTZW5kZXI6KGlkKXNlbmRlcgogCiAtIChpZCl0YXJnZXRGb3JB Y3Rpb246KFNFTClhY3Rpb24gd2l0aFNlbmRlcjooaWQpc2VuZGVyCiB7CisgICAgaWYgKHNlbF9p c0VxdWFsKGFjdGlvbiwgQHNlbGVjdG9yKGNyZWF0ZUhpZ2hsaWdodEluQ3VycmVudEdyb3VwV2l0 aFJhbmdlOikpIHx8IHNlbF9pc0VxdWFsKGFjdGlvbiwgQHNlbGVjdG9yKGNyZWF0ZUhpZ2hsaWdo dEluTmV3R3JvdXBXaXRoUmFuZ2U6KSkpCisgICAgICAgIHJldHVybiBzZWxmOwogICAgIHJldHVy biBbX3dlYlZpZXcgdGFyZ2V0Rm9yQWN0aW9uOmFjdGlvbiB3aXRoU2VuZGVyOnNlbmRlcl07CiB9 CiAK 420785 2021-02-17 19:43:52 -0800 2021-02-17 20:42:48 -0800 Patch bug-222089-20210217194351.patch text/plain 1443 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1NzMxNWFmOTkxNDM0YmUz MTE4YTYwMmIxNjdhNWE2M2EzNjE1NDkuLjJhODIwNGE1NjM2ZjI1NmFkY2YwZmYzODM5ZDUwNjY1 NjExZjhkYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDItMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXR1cm4gY29ycmVj dCB0YXJnZXQgZm9yIEFwcCBIaWdobGlnaHQgbWVudXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIwODkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHRhcmdldEZvckFjdGlvbjp3 aXRoU2VuZGVyOl0pOgorCiAyMDIxLTAyLTE3ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBs ZS5jb20+CiAKICAgICAgICAgW0pTQ10gUmVuYW1lIGVudGl0bGVtZW50cyBmb3IgSklUQ2FnZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb24ubW0KaW5kZXggNmRlNjBjZjVmNjllZTgxMmNmOTkyZDA5ZjJhOWZjZjBhMGRlM2Q4 Yi4uMmIzYmQyM2NiMGFkYzI1MzQyMTk1ZjdlOGZkNmExZWU2MTg3MzRjMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCkBAIC0zNjk2LDYgKzM2OTYsMTAgQEAgLSAoQk9PTCljYW5QZXJmb3JtQWN0aW9uRm9yV2Vi VmlldzooU0VMKWFjdGlvbiB3aXRoU2VuZGVyOihpZClzZW5kZXIKIAogLSAoaWQpdGFyZ2V0Rm9y QWN0aW9uOihTRUwpYWN0aW9uIHdpdGhTZW5kZXI6KGlkKXNlbmRlcgogeworI2lmIEVOQUJMRShB UFBfSElHSExJR0hUUykKKyAgICBpZiAoYWN0aW9uID09IEBzZWxlY3RvcihjcmVhdGVIaWdobGln aHRJbkN1cnJlbnRHcm91cFdpdGhSYW5nZTopIHx8IGFjdGlvbiA9PSBAc2VsZWN0b3IoY3JlYXRl SGlnaGxpZ2h0SW5OZXdHcm91cFdpdGhSYW5nZTopKQorICAgICAgICByZXR1cm4gc2VsZjsKKyNl bmRpZgogICAgIHJldHVybiBbX3dlYlZpZXcgdGFyZ2V0Rm9yQWN0aW9uOmFjdGlvbiB3aXRoU2Vu ZGVyOnNlbmRlcl07CiB9CiAK 420793 2021-02-17 20:42:50 -0800 2021-02-17 23:59:30 -0800 Patch for landing bug-222089-20210217204249.patch text/plain 1439 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc1NzMxNWFmOTkxNDM0YmUz MTE4YTYwMmIxNjdhNWE2M2EzNjE1NDkuLjQxZDRkMDk3MjQ5Zjg1MWEyODZmMTQ4NzQ4YzE3Mjg0 MDgyN2Q4ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDItMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXR1cm4gY29ycmVj dCB0YXJnZXQgZm9yIEFwcCBIaWdobGlnaHQgbWVudXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIwODkKKworICAgICAgICBSZXZpZXdlZCBieSBU aW0gSG9ydG9uLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgdGFyZ2V0Rm9yQWN0aW9uOndpdGhT ZW5kZXI6XSk6CisKIDIwMjEtMDItMTcgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBSZW5hbWUgZW50aXRsZW1lbnRzIGZvciBKSVRDYWdlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQppbmRleCA2ZGU2MGNmNWY2OWVlODEyY2Y5OTJkMDlmMmE5ZmNmMGEwZGUzZDhiLi4y YjNiZDIzY2IwYWRjMjUzNDIxOTVmN2U4ZmQ2YTFlZTYxODczNGMxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0K QEAgLTM2OTYsNiArMzY5NiwxMCBAQCAtIChCT09MKWNhblBlcmZvcm1BY3Rpb25Gb3JXZWJWaWV3 OihTRUwpYWN0aW9uIHdpdGhTZW5kZXI6KGlkKXNlbmRlcgogCiAtIChpZCl0YXJnZXRGb3JBY3Rp b246KFNFTClhY3Rpb24gd2l0aFNlbmRlcjooaWQpc2VuZGVyCiB7CisjaWYgRU5BQkxFKEFQUF9I SUdITElHSFRTKQorICAgIGlmIChhY3Rpb24gPT0gQHNlbGVjdG9yKGNyZWF0ZUhpZ2hsaWdodElu Q3VycmVudEdyb3VwV2l0aFJhbmdlOikgfHwgYWN0aW9uID09IEBzZWxlY3RvcihjcmVhdGVIaWdo bGlnaHRJbk5ld0dyb3VwV2l0aFJhbmdlOikpCisgICAgICAgIHJldHVybiBzZWxmOworI2VuZGlm CiAgICAgcmV0dXJuIFtfd2ViVmlldyB0YXJnZXRGb3JBY3Rpb246YWN0aW9uIHdpdGhTZW5kZXI6 c2VuZGVyXTsKIH0KIAo=