222070 2021-02-17 14:15:57 -0800 Use a smart pointer for s_exception in objc_instance.mm 2021-02-17 16:20:18 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren sam webkit-bug-importer oldest_to_newest 1730524 0 cdumez 2021-02-17 14:15:57 -0800 Use a smart pointer for s_exception in objc_instance.mm. 1730531 1 420715 cdumez 2021-02-17 14:23:01 -0800 Created attachment 420715 Patch 1730572 2 420715 ggaren 2021-02-17 15:05:16 -0800 Comment on attachment 420715 Patch r=me 1730625 3 ews-feeder 2021-02-17 16:19:17 -0800 Committed r273044: <https://commits.webkit.org/r273044> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420715. 1730626 4 webkit-bug-importer 2021-02-17 16:20:18 -0800 <rdar://problem/74454795> 420715 2021-02-17 14:23:01 -0800 2021-02-17 16:19:18 -0800 Patch bug-222070-20210217142300.patch text/plain 2627 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTdjNTQ4MmI0ZjIzNjIw NWU4ODM3NTdhMWQyNjM2ZDI2YmIyY2RmNi4uNWU4MmQyZjhiMmZhNGNjYjQwOWIwYWM0OTFiMWQ5 NjFiOGMxZTZhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAyLTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGEgc21hcnQgcG9pbnRl ciBmb3Igc19leGNlcHRpb24gaW4gb2JqY19pbnN0YW5jZS5tbQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMDcwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBicmlkZ2Uvb2JqYy9vYmpjX2luc3RhbmNl Lm1tOgorICAgICAgICAoZ2xvYmFsRXhjZXB0aW9uKToKKyAgICAgICAgKE9iamNJbnN0YW5jZTo6 c2V0R2xvYmFsRXhjZXB0aW9uKToKKyAgICAgICAgKE9iamNJbnN0YW5jZTo6bW92ZUdsb2JhbEV4 Y2VwdGlvblRvRXhlY1N0YXRlKToKKwogMjAyMS0wMi0xNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNz b0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gdXBkYXRlIG1lZGlhIGNvbnRyb2xzIHRvIHVz ZSBuZXcgU0YgU3ltYm9scwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL29iamMv b2JqY19pbnN0YW5jZS5tbSBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9vYmpjL29iamNfaW5zdGFu Y2UubW0KaW5kZXggNmY1YmQxYTZjYTg2ZWZkYzFmYTMzZjEzNDlmNmE3MWU0MjY4ZmU2Mi4uYjU5 NWQ1YTEzODViYWU2ZjdmYjAxZGViYzNhNjc4NWJjZTEzYTY1YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvYnJpZGdlL29iamMvb2JqY19pbnN0YW5jZS5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9icmlkZ2Uvb2JqYy9vYmpjX2luc3RhbmNlLm1tCkBAIC01NSw3ICs1NSwxMSBAQAogdXNpbmcg bmFtZXNwYWNlIEpTQzo6QmluZGluZ3M7CiB1c2luZyBuYW1lc3BhY2UgSlNDOwogCi1zdGF0aWMg TlNTdHJpbmcgKnNfZXhjZXB0aW9uOworc3RhdGljIFJldGFpblB0cjxOU1N0cmluZz4mIGdsb2Jh bEV4Y2VwdGlvbigpCit7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFJldGFpblB0cjxOU1N0 cmluZz4+IGV4Y2VwdGlvbjsKKyAgICByZXR1cm4gZXhjZXB0aW9uOworfQogc3RhdGljIEpTR2xv YmFsT2JqZWN0KiBzX2V4Y2VwdGlvbkVudmlyb25tZW50OyAvLyBObyBuZWVkIHRvIHByb3RlY3Qg dGhpcyB2YWx1ZSwgc2luY2Ugd2UganVzdCB1c2UgaXQgZm9yIGEgcG9pbnRlciBjb21wYXJpc29u LgogCiBzdGF0aWMgSGFzaE1hcDxDRlR5cGVSZWYsIE9iamNJbnN0YW5jZSo+JiB3cmFwcGVyQ2Fj aGUoKQpAQCAtNzIsOCArNzYsNyBAQCBSdW50aW1lT2JqZWN0KiBPYmpjSW5zdGFuY2U6Om5ld1J1 bnRpbWVPYmplY3QoSlNHbG9iYWxPYmplY3QqIGxleGljYWxHbG9iYWxPYmplYwogCiB2b2lkIE9i amNJbnN0YW5jZTo6c2V0R2xvYmFsRXhjZXB0aW9uKE5TU3RyaW5nKiBleGNlcHRpb24sIEpTR2xv YmFsT2JqZWN0KiBleGNlcHRpb25FbnZpcm9ubWVudCkKIHsKLSAgICBhdXRvIG9sZEV4Y2VwdGlv biA9IGFkb3B0TlMoc19leGNlcHRpb24pOwotICAgIHNfZXhjZXB0aW9uID0gW2V4Y2VwdGlvbiBj b3B5XTsKKyAgICBnbG9iYWxFeGNlcHRpb24oKSA9IGFkb3B0TlMoW2V4Y2VwdGlvbiBjb3B5XSk7 CiAKICAgICBzX2V4Y2VwdGlvbkVudmlyb25tZW50ID0gZXhjZXB0aW9uRW52aXJvbm1lbnQ7CiB9 CkBAIC04MywxNyArODYsMTcgQEAgdm9pZCBPYmpjSW5zdGFuY2U6Om1vdmVHbG9iYWxFeGNlcHRp b25Ub0V4ZWNTdGF0ZShKU0dsb2JhbE9iamVjdCogbGV4aWNhbEdsb2JhbE8KICAgICBWTSYgdm0g PSBsZXhpY2FsR2xvYmFsT2JqZWN0LT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RI Uk9XX1NDT1BFKHZtKTsKIAotICAgIGlmICghc19leGNlcHRpb24pIHsKKyAgICBpZiAoIWdsb2Jh bEV4Y2VwdGlvbigpKSB7CiAgICAgICAgIEFTU0VSVCghc19leGNlcHRpb25FbnZpcm9ubWVudCk7 CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAgICBpZiAoIXNfZXhjZXB0aW9uRW52aXJvbm1l bnQgfHwgc19leGNlcHRpb25FbnZpcm9ubWVudCA9PSB2bS5kZXByZWNhdGVkVk1FbnRyeUdsb2Jh bE9iamVjdChsZXhpY2FsR2xvYmFsT2JqZWN0KSkgewogICAgICAgICBKU0xvY2tIb2xkZXIgbG9j ayh2bSk7Ci0gICAgICAgIHRocm93RXJyb3IobGV4aWNhbEdsb2JhbE9iamVjdCwgc2NvcGUsIHNf ZXhjZXB0aW9uKTsKKyAgICAgICAgdGhyb3dFcnJvcihsZXhpY2FsR2xvYmFsT2JqZWN0LCBzY29w ZSwgZ2xvYmFsRXhjZXB0aW9uKCkuZ2V0KCkpOwogICAgIH0KIAotICAgIGF1dG8gZXhjZXB0aW9u ID0gYWRvcHROUyhzdGQ6OmV4Y2hhbmdlKHNfZXhjZXB0aW9uLCBuaWwpKTsKKyAgICBnbG9iYWxF eGNlcHRpb24oKSA9IG5pbDsKICAgICBzX2V4Y2VwdGlvbkVudmlyb25tZW50ID0gbnVsbHB0cjsK IH0KIAo=