222063 2021-02-17 12:43:51 -0800 Add SPI to allow apps to initiate highlight creation. 2021-02-17 15:43:28 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer oldest_to_newest 1730459 0 megan_gardner 2021-02-17 12:43:51 -0800 Add SPI to allow apps to initiate highlight creation. 1730481 1 420701 megan_gardner 2021-02-17 13:15:35 -0800 Created attachment 420701 Patch 1730488 2 420701 thorton 2021-02-17 13:22:22 -0800 Comment on attachment 420701 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420701&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:372 > +- (void)_addAppHighlight WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); Maybe `ForSelection`? 1730575 3 420729 megan_gardner 2021-02-17 15:06:55 -0800 Created attachment 420729 Patch for landing 1730595 4 ews-feeder 2021-02-17 15:42:45 -0800 Committed r273040: <https://commits.webkit.org/r273040> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420729. 1730597 5 webkit-bug-importer 2021-02-17 15:43:28 -0800 <rdar://problem/74453348> 420701 2021-02-17 13:15:35 -0800 2021-02-17 15:06:53 -0800 Patch bug-222063-20210217131534.patch text/plain 2304 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ4N2QzNjdhNzczMDRhZmJj YzhkMjE4MTQ2NjFmZmU3OWM4NjNjMDEuLmQ4ODBiNTUyZjI0Nzc0ZGI5MzdmYTViMGQwNzllNjA1 NDkxMmI1ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDItMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgU1BJIHRvIGFs bG93IGFwcHMgdG8gaW5pdGlhdGUgaGlnaGxpZ2h0IGNyZWF0aW9uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMDYzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dL V2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9hZGRBcHBIaWdobGlnaHRdKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDoKKwogMjAyMS0w Mi0xNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g QWRkIHN1cHBvcnQgZm9yIGFkZGl0aW9uYWwgYWNjZXNzaWJpbGl0eSBpbWFnZSBleHRyYWN0aW9u IGNvbnRleHRtZW51IGFjdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tCmluZGV4IGFhNjMxNjM0YmMzOGJiMDk2NzgxZmJhMzA1MDY1ODVlNmM2 OGFkNDQuLjk5MmE0YjNmNGU1MTUzNTkyNWUyMmJkMjk3ZmEzNGQ2NjQ3OTUwYmEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtMjA0Nyw2 ICsyMDQ3LDEzIEBAIC0gKHZvaWQpX3Jlc3RvcmVBcHBIaWdobGlnaHRzOihOU0FycmF5PE5TRGF0 YSAqPiAqKWhpZ2hsaWdodHMKICNlbmRpZgogfQogCistICh2b2lkKV9hZGRBcHBIaWdobGlnaHQK K3sKKyNpZiBFTkFCTEUoQVBQX0hJR0hMSUdIVFMpCisgICAgX3BhZ2UtPmNyZWF0ZUFwcEhpZ2hs aWdodEluU2VsZWN0ZWRSYW5nZShXZWJDb3JlOjpDcmVhdGVOZXdHcm91cEZvckhpZ2hsaWdodDo6 Tm8pOworI2VuZGlmCit9CisKIC0gKE5TVVJMICopX3VucmVhY2hhYmxlVVJMCiB7CiAgICAgcmV0 dXJuIFtOU1VSTCBfd2ViX1VSTFdpdGhXVEZTdHJpbmc6X3BhZ2UtPnBhZ2VMb2FkU3RhdGUoKS51 bnJlYWNoYWJsZVVSTCgpXTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oCmluZGV4IGU0NWNiMWJiYmJlYmEwYjFhNzk1NTZiOGQ0 MzEwYzc3ODI1NTViZmQuLjA3NmYxMzAwMTgwZGI5NjI3NGMwZGRkZmMxYzBkNmRjZDA0NTUzOWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQ cml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d1ByaXZhdGUuaApAQCAtMzY5LDYgKzM2OSw3IEBAIGZvciB0aGlzIHByb3BlcnR5LgogCiBAcHJv cGVydHkgKG5vbmF0b21pYywgd2Vhaywgc2V0dGVyPV9zZXRBcHBIaWdobGlnaHREZWxlZ2F0ZTop IGlkIDxfV0tBcHBIaWdobGlnaHREZWxlZ2F0ZT4gX2FwcEhpZ2hsaWdodERlbGVnYXRlIFdLX0FQ SV9BVkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CiAtICh2b2lk KV9yZXN0b3JlQXBwSGlnaGxpZ2h0czooTlNBcnJheTxOU0RhdGEgKj4gKilkYXRhIFdLX0FQSV9B VkFJTEFCTEUobWFjb3MoV0tfTUFDX1RCQSksIGlvcyhXS19JT1NfVEJBKSk7CistICh2b2lkKV9h ZGRBcHBIaWdobGlnaHQgV0tfQVBJX0FWQUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9zKFdL X0lPU19UQkEpKTsKIAogLyohIEBhYnN0cmFjdCBUaGUgdGhlbWUgY29sb3Igb2YgdGhlIGFjdGl2 ZSBwYWdlLgogIEBkaXNjdXNzaW9uIFRoaXMgaXMgdGhlIHZhbHVlIG9mIHRoZSBtb3N0IHJlY2Vu dGx5IGNyZWF0ZWQgb3IgbW9kaWZpZWQK 420729 2021-02-17 15:06:55 -0800 2021-02-17 15:42:45 -0800 Patch for landing bug-222063-20210217150654.patch text/plain 2300 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ4N2QzNjdhNzczMDRhZmJj YzhkMjE4MTQ2NjFmZmU3OWM4NjNjMDEuLjgzMzc1ZDhkMTBiNmQyZDM4MmEwMjc2OGNkMTk1M2Fm YzhlMzI1MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDItMTcgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgU1BJIHRvIGFs bG93IGFwcHMgdG8gaW5pdGlhdGUgaGlnaGxpZ2h0IGNyZWF0aW9uLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMDYzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJW aWV3Lm1tOgorICAgICAgICAoLVtXS1dlYlZpZXcgX2FkZEFwcEhpZ2hsaWdodF0pOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJpdmF0ZS5oOgorCiAyMDIxLTAyLTE3 ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBZGQg c3VwcG9ydCBmb3IgYWRkaXRpb25hbCBhY2Nlc3NpYmlsaXR5IGltYWdlIGV4dHJhY3Rpb24gY29u dGV4dG1lbnUgYWN0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW0KaW5kZXggYWE2MzE2MzRiYzM4YmIwOTY3ODFmYmEzMDUwNjU4NWU2YzY4YWQ0 NC4uOTkyYTRiM2Y0ZTUxNTM1OTI1ZTIyYmQyOTdmYTM0ZDY2NDc5NTBiYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC0yMDQ3LDYgKzIw NDcsMTMgQEAgLSAodm9pZClfcmVzdG9yZUFwcEhpZ2hsaWdodHM6KE5TQXJyYXk8TlNEYXRhICo+ ICopaGlnaGxpZ2h0cwogI2VuZGlmCiB9CiAKKy0gKHZvaWQpX2FkZEFwcEhpZ2hsaWdodAorewor I2lmIEVOQUJMRShBUFBfSElHSExJR0hUUykKKyAgICBfcGFnZS0+Y3JlYXRlQXBwSGlnaGxpZ2h0 SW5TZWxlY3RlZFJhbmdlKFdlYkNvcmU6OkNyZWF0ZU5ld0dyb3VwRm9ySGlnaGxpZ2h0OjpObyk7 CisjZW5kaWYKK30KKwogLSAoTlNVUkwgKilfdW5yZWFjaGFibGVVUkwKIHsKICAgICByZXR1cm4g W05TVVJMIF93ZWJfVVJMV2l0aFdURlN0cmluZzpfcGFnZS0+cGFnZUxvYWRTdGF0ZSgpLnVucmVh Y2hhYmxlVVJMKCldOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlld1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXdQcml2YXRlLmgKaW5kZXggZTQ1Y2IxYmJiYmViYTBiMWE3OTU1NmI4ZDQzMTBj Nzc4MjU1NWJmZC4uMDc2ZjEzMDAxODBkYjk2Mjc0YzBkZGRmYzFjMGQ2ZGNkMDQ1NTM5YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZh dGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3UHJp dmF0ZS5oCkBAIC0zNjksNiArMzY5LDcgQEAgZm9yIHRoaXMgcHJvcGVydHkuCiAKIEBwcm9wZXJ0 eSAobm9uYXRvbWljLCB3ZWFrLCBzZXR0ZXI9X3NldEFwcEhpZ2hsaWdodERlbGVnYXRlOikgaWQg PF9XS0FwcEhpZ2hsaWdodERlbGVnYXRlPiBfYXBwSGlnaGxpZ2h0RGVsZWdhdGUgV0tfQVBJX0FW QUlMQUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKIC0gKHZvaWQpX3Jl c3RvcmVBcHBIaWdobGlnaHRzOihOU0FycmF5PE5TRGF0YSAqPiAqKWRhdGEgV0tfQVBJX0FWQUlM QUJMRShtYWNvcyhXS19NQUNfVEJBKSwgaW9zKFdLX0lPU19UQkEpKTsKKy0gKHZvaWQpX2FkZEFw cEhpZ2hsaWdodCBXS19BUElfQVZBSUxBQkxFKG1hY29zKFdLX01BQ19UQkEpLCBpb3MoV0tfSU9T X1RCQSkpOwogCiAvKiEgQGFic3RyYWN0IFRoZSB0aGVtZSBjb2xvciBvZiB0aGUgYWN0aXZlIHBh Z2UuCiAgQGRpc2N1c3Npb24gVGhpcyBpcyB0aGUgdmFsdWUgb2YgdGhlIG1vc3QgcmVjZW50bHkg Y3JlYXRlZCBvciBtb2RpZmllZAo=