222049 2021-02-17 10:27:58 -0800 [WPE][GTK] Avoid another child setup function in process launcher code 2021-02-18 11:40:58 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugzilla.redhat.com/show_bug.cgi?id=1910092 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia mcatanzaro pgriffis oldest_to_newest 1730362 0 mcatanzaro 2021-02-17 10:27:58 -0800 This is a follow-up to bug #220090. Avoiding child setup functions is desirable because it could allow GSubprocess to use posix_spawn() instead of fork() in the future. That's not possible to do if we have code that needs to run between fork() and exec(). In this case, the child setup is used only to unset CLOEXEC. We could simply not set it in the first place. This only fails if a secondary thread decides to launch a subprocess before XDGDBusProxyLauncher::launch returns. That window already exists in many other places (e.g. anywhere else setCloseOnExec is called, such as for IPC::Connection objects). Threads should not do that. This also fixes a bug where unsetting CLOEXEC would fail if we get unlucky and receive EINTR. A loop is required here. WTF::setCloseOnExec handles that for us. 1730364 1 420666 mcatanzaro 2021-02-17 10:30:32 -0800 Created attachment 420666 Patch 1730365 2 420667 mcatanzaro 2021-02-17 10:32:11 -0800 Created attachment 420667 Patch 1730955 3 ews-feeder 2021-02-18 11:40:55 -0800 Committed r273087: <https://commits.webkit.org/r273087> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420667. 420666 2021-02-17 10:30:32 -0800 2021-02-17 10:32:08 -0800 Patch bug-222049-20210217123031.patch text/plain 3480 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmYmJkMjg1Y2M3NTZmOWZk NmMxNjM5MmUxNDgxMmRkNTY4MWRlZmYuLjA5Mzk5ZGE1MDk2ZTE5MjY2MjhkY2VjMmY3MjQ0ZjQ2 NDVkNGUyODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjEtMDItMTcgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBB dm9pZCBhbm90aGVyIGNoaWxkIHNldHVwIGZ1bmN0aW9uIGluIHByb2Nlc3MgbGF1bmNoZXIgY29k ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMDQ5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWRp bmcgY2hpbGQgc2V0dXAgZnVuY3Rpb25zIGlzIGRlc2lyYWJsZSBiZWNhdXNlIGl0IGNvdWxkIGFs bG93IEdTdWJwcm9jZXNzIHRvIHVzZQorICAgICAgICBwb3NpeF9zcGF3bigpIGluc3RlYWQgb2Yg Zm9yaygpIGluIHRoZSBmdXR1cmUuIFRoYXQncyBub3QgcG9zc2libGUgdG8gZG8gaWYgd2UgaGF2 ZSBjb2RlCisgICAgICAgIHRoYXQgbmVlZHMgdG8gcnVuIGJldHdlZW4gZm9yaygpIGFuZCBleGVj KCkuCisKKyAgICAgICAgSW4gdGhpcyBjYXNlLCB0aGUgY2hpbGQgc2V0dXAgaXMgdXNlZCBvbmx5 IHRvIHVuc2V0IENMT0VYRUMuIFdlIGNvdWxkIHNpbXBseSBub3Qgc2V0IGl0IGluCisgICAgICAg IHRoZSBmaXJzdCBwbGFjZS4gVGhpcyBvbmx5IGZhaWxzIGlmIGEgc2Vjb25kYXJ5IHRocmVhZCBk ZWNpZGVzIHRvIGxhdW5jaCBhIHN1YnByb2Nlc3MgYmVmb3JlCisgICAgICAgIFhER0RCdXNQcm94 eUxhdW5jaGVyOjpsYXVuY2ggcmV0dXJucy4gVGhhdCB3aW5kb3cgYWxyZWFkeSBleGlzdHMgaW4g bWFueSBvdGhlciBwbGFjZXMgKGUuZy4KKyAgICAgICAgYW55d2hlcmUgZWxzZSBzZXRDbG9zZU9u RXhlYyBpcyBjYWxsZWQsIHN1Y2ggYXMgZm9yIElQQzo6Q29ubmVjdGlvbiBvYmplY3RzKS4gVGhy ZWFkcyBzaG91bGQKKyAgICAgICAgbm90IGRvIHRoYXQuCisKKyAgICAgICAgVGhpcyBhbHNvIGZp eGVzIGEgYnVnIHdoZXJlIHVuc2V0dGluZyBDTE9FWEVDIHdvdWxkIGZhaWwgaWYgd2UgZ2V0IHVu bHVja3kgYW5kIHJlY2VpdmUKKyAgICAgICAgRUlOVFIuIEEgbG9vcCBpcyByZXF1aXJlZCBoZXJl LiBXVEY6OnNldENsb3NlT25FeGVjIGhhbmRsZXMgdGhhdCBmb3IgdXMuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOgorICAgICAgICAo V2ViS2l0OjpYREdEQnVzUHJveHlMYXVuY2hlcjo6bGF1bmNoKToKKyAgICAgICAgKFdlYktpdDo6 WERHREJ1c1Byb3h5TGF1bmNoZXI6OmNoaWxkU2V0dXBGdW5jKTogRGVsZXRlZC4KKwogMjAyMS0w Mi0xNyAgUGVyIEFybmUgIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIERl bnkgbWFjaC1sb29rdXAgdG8gdGhlIGZvbnRzIHNlcnZpY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNw cAppbmRleCA4ZWVjOThkZGRkZmRjOWRmYjczZDg1MGNlYjA5NjY1MGM3MTcyN2Y4Li45ZTAyMjA4 ODRiYTkwZmZjYTQ5MGFjOWJlN2U1ZGQ3MWYwYTBkMzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIu Y3BwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSA8c3lzL2lvY3RsLmg+CiAjaW5jbHVkZSA8 dW5pc3RkLmg+CiAjaW5jbHVkZSA8d3RmL0ZpbGVTeXN0ZW0uaD4KKyNpbmNsdWRlIDx3dGYvVW5p U3RkRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL2dsaWIvR0xpYlV0aWxpdGllcy5oPgogI2luY2x1 ZGUgPHd0Zi9nbGliL0dSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvZ2xpYi9HVW5pcXVlUHRyLmg+ CkBAIC0xODksOCArMTkwLDkgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAg ICAgIGludCBzeW5jRmRzWzJdOwotICAgICAgICBpZiAocGlwZTIoc3luY0ZkcywgT19DTE9FWEVD KSA9PSAtMSkKKyAgICAgICAgaWYgKHBpcGUoc3luY0ZkcykgPT0gLTEpCiAgICAgICAgICAgICBn X2Vycm9yKCJGYWlsZWQgdG8gbWFrZSBzeW5jZmRzIGZvciBkYnVzLXByb3h5OiAlcyIsIGdfc3Ry ZXJyb3IoZXJybm8pKTsKKyAgICAgICAgc2V0Q2xvc2VPbkV4ZWMoc3luY0Zkc1swXSk7CiAKICAg ICAgICAgR1VuaXF1ZVB0cjxjaGFyPiBzeW5jRmRTdHIoZ19zdHJkdXBfcHJpbnRmKCItLWZkPSVk Iiwgc3luY0Zkc1sxXSkpOwogCkBAIC0yMjQsNyArMjI2LDcgQEAgcHVibGljOgogICAgICAgICBh cmd2W2ldID0gbnVsbHB0cjsKIAogICAgICAgICBHUmVmUHRyPEdTdWJwcm9jZXNzTGF1bmNoZXI+ IGxhdW5jaGVyID0gYWRvcHRHUmVmKGdfc3VicHJvY2Vzc19sYXVuY2hlcl9uZXcoR19TVUJQUk9D RVNTX0ZMQUdTX0lOSEVSSVRfRkRTKSk7Ci0gICAgICAgIGdfc3VicHJvY2Vzc19sYXVuY2hlcl9z ZXRfY2hpbGRfc2V0dXAobGF1bmNoZXIuZ2V0KCksIGNoaWxkU2V0dXBGdW5jLCBHSU5UX1RPX1BP SU5URVIoc3luY0Zkc1sxXSksIG51bGxwdHIpOworICAgICAgICBnX3N1YnByb2Nlc3NfbGF1bmNo ZXJfc2V0X2NoaWxkX3NldHVwKGxhdW5jaGVyLmdldCgpLCBudWxscHRyLCBHSU5UX1RPX1BPSU5U RVIoc3luY0Zkc1sxXSksIG51bGxwdHIpOwogICAgICAgICBnX3N1YnByb2Nlc3NfbGF1bmNoZXJf dGFrZV9mZChsYXVuY2hlci5nZXQoKSwgcHJveHlGZCwgcHJveHlGZCk7CiAgICAgICAgIGdfc3Vi cHJvY2Vzc19sYXVuY2hlcl90YWtlX2ZkKGxhdW5jaGVyLmdldCgpLCBzeW5jRmRzWzFdLCBzeW5j RmRzWzFdKTsKIApAQCAtMjQ4LDEyICsyNTAsNiBAQCBwdWJsaWM6CiAgICAgfTsKIAogcHJpdmF0 ZToKLSAgICBzdGF0aWMgdm9pZCBjaGlsZFNldHVwRnVuYyhncG9pbnRlciB1c2VyZGF0YSkKLSAg ICB7Ci0gICAgICAgIGludCBmZCA9IEdQT0lOVEVSX1RPX0lOVCh1c2VyZGF0YSk7Ci0gICAgICAg IGZjbnRsKGZkLCBGX1NFVEZELCAwKTsgLy8gVW5zZXQgQ0xPRVhFQwotICAgIH0KLQogICAgIHN0 YXRpYyBDU3RyaW5nIG1ha2VQcm94eVBhdGgoY29uc3QgY2hhciogYXBwUnVuRGlyKQogICAgIHsK ICAgICAgICAgaWYgKGdfbWtkaXJfd2l0aF9wYXJlbnRzKGFwcFJ1bkRpciwgMDcwMCkgPT0gLTEp IHsK 420667 2021-02-17 10:32:11 -0800 2021-02-18 11:40:56 -0800 Patch bug-222049-20210217123210.patch text/plain 3369 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmYmJkMjg1Y2M3NTZmOWZk NmMxNjM5MmUxNDgxMmRkNTY4MWRlZmYuLjA5Mzk5ZGE1MDk2ZTE5MjY2MjhkY2VjMmY3MjQ0ZjQ2 NDVkNGUyODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjEtMDItMTcgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBB dm9pZCBhbm90aGVyIGNoaWxkIHNldHVwIGZ1bmN0aW9uIGluIHByb2Nlc3MgbGF1bmNoZXIgY29k ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMDQ5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWRp bmcgY2hpbGQgc2V0dXAgZnVuY3Rpb25zIGlzIGRlc2lyYWJsZSBiZWNhdXNlIGl0IGNvdWxkIGFs bG93IEdTdWJwcm9jZXNzIHRvIHVzZQorICAgICAgICBwb3NpeF9zcGF3bigpIGluc3RlYWQgb2Yg Zm9yaygpIGluIHRoZSBmdXR1cmUuIFRoYXQncyBub3QgcG9zc2libGUgdG8gZG8gaWYgd2UgaGF2 ZSBjb2RlCisgICAgICAgIHRoYXQgbmVlZHMgdG8gcnVuIGJldHdlZW4gZm9yaygpIGFuZCBleGVj KCkuCisKKyAgICAgICAgSW4gdGhpcyBjYXNlLCB0aGUgY2hpbGQgc2V0dXAgaXMgdXNlZCBvbmx5 IHRvIHVuc2V0IENMT0VYRUMuIFdlIGNvdWxkIHNpbXBseSBub3Qgc2V0IGl0IGluCisgICAgICAg IHRoZSBmaXJzdCBwbGFjZS4gVGhpcyBvbmx5IGZhaWxzIGlmIGEgc2Vjb25kYXJ5IHRocmVhZCBk ZWNpZGVzIHRvIGxhdW5jaCBhIHN1YnByb2Nlc3MgYmVmb3JlCisgICAgICAgIFhER0RCdXNQcm94 eUxhdW5jaGVyOjpsYXVuY2ggcmV0dXJucy4gVGhhdCB3aW5kb3cgYWxyZWFkeSBleGlzdHMgaW4g bWFueSBvdGhlciBwbGFjZXMgKGUuZy4KKyAgICAgICAgYW55d2hlcmUgZWxzZSBzZXRDbG9zZU9u RXhlYyBpcyBjYWxsZWQsIHN1Y2ggYXMgZm9yIElQQzo6Q29ubmVjdGlvbiBvYmplY3RzKS4gVGhy ZWFkcyBzaG91bGQKKyAgICAgICAgbm90IGRvIHRoYXQuCisKKyAgICAgICAgVGhpcyBhbHNvIGZp eGVzIGEgYnVnIHdoZXJlIHVuc2V0dGluZyBDTE9FWEVDIHdvdWxkIGZhaWwgaWYgd2UgZ2V0IHVu bHVja3kgYW5kIHJlY2VpdmUKKyAgICAgICAgRUlOVFIuIEEgbG9vcCBpcyByZXF1aXJlZCBoZXJl LiBXVEY6OnNldENsb3NlT25FeGVjIGhhbmRsZXMgdGhhdCBmb3IgdXMuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIuY3BwOgorICAgICAgICAo V2ViS2l0OjpYREdEQnVzUHJveHlMYXVuY2hlcjo6bGF1bmNoKToKKyAgICAgICAgKFdlYktpdDo6 WERHREJ1c1Byb3h5TGF1bmNoZXI6OmNoaWxkU2V0dXBGdW5jKTogRGVsZXRlZC4KKwogMjAyMS0w Mi0xNyAgUGVyIEFybmUgIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIERl bnkgbWFjaC1sb29rdXAgdG8gdGhlIGZvbnRzIHNlcnZpY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2dsaWIvQnViYmxld3JhcExhdW5jaGVyLmNw cAppbmRleCA4ZWVjOThkZGRkZmRjOWRmYjczZDg1MGNlYjA5NjY1MGM3MTcyN2Y4Li5mY2FhNTlm NDA4Njc3MjMxZmRmMDY0OTcyNDIxZjkwZTE5ZTc3ZmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvTGF1bmNoZXIvZ2xpYi9CdWJibGV3cmFwTGF1bmNoZXIu Y3BwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSA8c3lzL2lvY3RsLmg+CiAjaW5jbHVkZSA8 dW5pc3RkLmg+CiAjaW5jbHVkZSA8d3RmL0ZpbGVTeXN0ZW0uaD4KKyNpbmNsdWRlIDx3dGYvVW5p U3RkRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL2dsaWIvR0xpYlV0aWxpdGllcy5oPgogI2luY2x1 ZGUgPHd0Zi9nbGliL0dSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvZ2xpYi9HVW5pcXVlUHRyLmg+ CkBAIC0xODksOCArMTkwLDkgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAg ICAgIGludCBzeW5jRmRzWzJdOwotICAgICAgICBpZiAocGlwZTIoc3luY0ZkcywgT19DTE9FWEVD KSA9PSAtMSkKKyAgICAgICAgaWYgKHBpcGUoc3luY0ZkcykgPT0gLTEpCiAgICAgICAgICAgICBn X2Vycm9yKCJGYWlsZWQgdG8gbWFrZSBzeW5jZmRzIGZvciBkYnVzLXByb3h5OiAlcyIsIGdfc3Ry ZXJyb3IoZXJybm8pKTsKKyAgICAgICAgc2V0Q2xvc2VPbkV4ZWMoc3luY0Zkc1swXSk7CiAKICAg ICAgICAgR1VuaXF1ZVB0cjxjaGFyPiBzeW5jRmRTdHIoZ19zdHJkdXBfcHJpbnRmKCItLWZkPSVk Iiwgc3luY0Zkc1sxXSkpOwogCkBAIC0yMjQsNyArMjI2LDYgQEAgcHVibGljOgogICAgICAgICBh cmd2W2ldID0gbnVsbHB0cjsKIAogICAgICAgICBHUmVmUHRyPEdTdWJwcm9jZXNzTGF1bmNoZXI+ IGxhdW5jaGVyID0gYWRvcHRHUmVmKGdfc3VicHJvY2Vzc19sYXVuY2hlcl9uZXcoR19TVUJQUk9D RVNTX0ZMQUdTX0lOSEVSSVRfRkRTKSk7Ci0gICAgICAgIGdfc3VicHJvY2Vzc19sYXVuY2hlcl9z ZXRfY2hpbGRfc2V0dXAobGF1bmNoZXIuZ2V0KCksIGNoaWxkU2V0dXBGdW5jLCBHSU5UX1RPX1BP SU5URVIoc3luY0Zkc1sxXSksIG51bGxwdHIpOwogICAgICAgICBnX3N1YnByb2Nlc3NfbGF1bmNo ZXJfdGFrZV9mZChsYXVuY2hlci5nZXQoKSwgcHJveHlGZCwgcHJveHlGZCk7CiAgICAgICAgIGdf c3VicHJvY2Vzc19sYXVuY2hlcl90YWtlX2ZkKGxhdW5jaGVyLmdldCgpLCBzeW5jRmRzWzFdLCBz eW5jRmRzWzFdKTsKIApAQCAtMjQ4LDEyICsyNDksNiBAQCBwdWJsaWM6CiAgICAgfTsKIAogcHJp dmF0ZToKLSAgICBzdGF0aWMgdm9pZCBjaGlsZFNldHVwRnVuYyhncG9pbnRlciB1c2VyZGF0YSkK LSAgICB7Ci0gICAgICAgIGludCBmZCA9IEdQT0lOVEVSX1RPX0lOVCh1c2VyZGF0YSk7Ci0gICAg ICAgIGZjbnRsKGZkLCBGX1NFVEZELCAwKTsgLy8gVW5zZXQgQ0xPRVhFQwotICAgIH0KLQogICAg IHN0YXRpYyBDU3RyaW5nIG1ha2VQcm94eVBhdGgoY29uc3QgY2hhciogYXBwUnVuRGlyKQogICAg IHsKICAgICAgICAgaWYgKGdfbWtkaXJfd2l0aF9wYXJlbnRzKGFwcFJ1bkRpciwgMDcwMCkgPT0g LTEpIHsK