222048 2021-02-17 10:15:36 -0800 Use element fullscreen for video on some configurations 2021-02-17 12:32:06 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino benjamin cdumez cmarcelo ews-watchlist sam webkit-bug-importer oldest_to_newest 1730349 0 dino 2021-02-17 10:15:36 -0800 Enable element fullscreen for video on some configurations 1730356 1 webkit-bug-importer 2021-02-17 10:22:39 -0800 <rdar://problem/74439214> 1730358 2 420664 dino 2021-02-17 10:24:57 -0800 Created attachment 420664 Patch 1730359 3 420664 sam 2021-02-17 10:26:42 -0800 Comment on attachment 420664 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420664&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:549 > +#if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) && HAVE(UIKIT_WEBKIT_INTERNALS) This should be #if !defined(ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN) && (PLATFORM(MAC) || HAVE(UIKIT_WEBKIT_INTERNALS)) 1730360 4 420665 dino 2021-02-17 10:27:13 -0800 Created attachment 420665 Updated patch 1730443 5 ews-feeder 2021-02-17 12:32:03 -0800 Committed r273020: <https://commits.webkit.org/r273020> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420665. 420664 2021-02-17 10:24:57 -0800 2021-02-17 10:33:04 -0800 Patch 222048.patch text/plain 1067 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMDIyZjAwNTkyOGFiLi5kZmQzMDMyYzU5YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjEtMDItMTcgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBl bGVtZW50IGZ1bGxzY3JlZW4gZm9yIHZpZGVvIG9uIHNvbWUgY29uZmlndXJhdGlvbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjA0OAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNzQ0MzkyMTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oOgorCiAyMDIx LTAyLTE3ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10g RGVueSBtYWNoLWxvb2t1cCB0byB0aGUgZm9udHMgc2VydmljZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1F bmFibGVDb2NvYS5oCmluZGV4IDc4ZDU4NzNhMzA4OS4uMjhlZWQ0NDYxMGE2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgKKysrIGIvU291cmNlL1dURi93 dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oCkBAIC01NDYsNyArNTQ2LDcgQEAKICNkZWZpbmUgRU5B QkxFX1ZJREVPX1BSRVNFTlRBVElPTl9NT0RFIDEKICNlbmRpZgogCi0jaWYgIWRlZmluZWQoRU5B QkxFX1ZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOKSAmJiBQTEFURk9STShNQUMpCisjaWYg IWRlZmluZWQoRU5BQkxFX1ZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOKSAmJiAoUExBVEZP Uk0oTUFDKSAmJiBIQVZFKFVJS0lUX1dFQktJVF9JTlRFUk5BTFMpCiAjZGVmaW5lIEVOQUJMRV9W SURFT19VU0VTX0VMRU1FTlRfRlVMTFNDUkVFTiAxCiAjZW5kaWYKIAo= 420665 2021-02-17 10:27:13 -0800 2021-02-17 12:32:05 -0800 Updated patch 222048.patch text/plain 1068 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMDIyZjAwNTkyOGFiLi5kZmQzMDMyYzU5YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjEtMDItMTcgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBl bGVtZW50IGZ1bGxzY3JlZW4gZm9yIHZpZGVvIG9uIHNvbWUgY29uZmlndXJhdGlvbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjA0OAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNzQ0MzkyMTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oOgorCiAyMDIx LTAyLTE3ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10g RGVueSBtYWNoLWxvb2t1cCB0byB0aGUgZm9udHMgc2VydmljZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1F bmFibGVDb2NvYS5oCmluZGV4IDc4ZDU4NzNhMzA4OS4uYTg2YjMwZDA2NGUxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgKKysrIGIvU291cmNlL1dURi93 dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oCkBAIC01NDYsNyArNTQ2LDcgQEAKICNkZWZpbmUgRU5B QkxFX1ZJREVPX1BSRVNFTlRBVElPTl9NT0RFIDEKICNlbmRpZgogCi0jaWYgIWRlZmluZWQoRU5B QkxFX1ZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOKSAmJiBQTEFURk9STShNQUMpCisjaWYg IWRlZmluZWQoRU5BQkxFX1ZJREVPX1VTRVNfRUxFTUVOVF9GVUxMU0NSRUVOKSAmJiAoUExBVEZP Uk0oTUFDKSB8fCBIQVZFKFVJS0lUX1dFQktJVF9JTlRFUk5BTFMpKQogI2RlZmluZSBFTkFCTEVf VklERU9fVVNFU19FTEVNRU5UX0ZVTExTQ1JFRU4gMQogI2VuZGlmCiAK