<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>222037</bug_id>
          
          <creation_ts>2021-02-17 06:10:05 -0800</creation_ts>
          <short_desc>Fix Selenium key code for ENTER in testdriver-vendor.js</short_desc>
          <delta_ts>2021-02-19 02:31:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Manuel Rego Casasnovas">rego</reporter>
          <assigned_to name="Manuel Rego Casasnovas">rego</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>clopez</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1730239</commentid>
    <comment_count>0</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2021-02-17 06:10:05 -0800</bug_when>
    <thetext>Fix Selenium key code for ENTER in testdriver-vendor.js</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1730240</commentid>
    <comment_count>1</comment_count>
      <attachid>420635</attachid>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2021-02-17 06:10:20 -0800</bug_when>
    <thetext>Created attachment 420635
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1730241</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2021-02-17 06:11:34 -0800</bug_when>
    <thetext>This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1730242</commentid>
    <comment_count>3</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2021-02-17 06:12:12 -0800</bug_when>
    <thetext>This was a mistake I did in the previous patch, checking other examples in LayoutTests they use eventSender.keyDown(&quot;\n&quot;) and not eventSender.keyDown(&quot;enter&quot;).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1731282</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-02-19 02:30:31 -0800</bug_when>
    <thetext>Committed r273136: &lt;https://commits.webkit.org/r273136&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420635.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1731283</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-02-19 02:31:13 -0800</bug_when>
    <thetext>&lt;rdar://problem/74516053&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>420635</attachid>
            <date>2021-02-17 06:10:20 -0800</date>
            <delta_ts>2021-02-19 02:30:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-222037-20210217151018.patch</filename>
            <type>text/plain</type>
            <size>1785</size>
            <attacher name="Manuel Rego Casasnovas">rego</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyOTgzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBv
cnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpp
bmRleCAxOTI5MGZmOTFiNDJlNWRhMWRiZjk2NWM0NzRjMWVjYmM0MmZhNGRiLi5mNjRjMTExYTkw
MDcxYmE4ODYwMGE5MmNhM2JkMjljNjUyOTljMzMwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p
bXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMS0wMi0xNyAgTWFudWVsIFJlZ28gQ2FzYXNub3Zh
cyAgPHJlZ29AaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggU2VsZW5pdW0ga2V5IGNvZGUgZm9y
IEVOVEVSIGluIHRlc3Rkcml2ZXItdmVuZG9yLmpzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjcyNzI2IHdlIGFkZGVkIGEgYnVuY2ggb2YgU2Vs
ZW5pdW0ga2V5IGNvZGVzLAorICAgICAgICBidXQgdGhlIG9uZSBmb3IgMFhFMDA3IChFTlRFUikg
d2FzIHdyb25nCisgICAgICAgIGFzIGV2ZW50U2VuZGVyLmtleURvd24oKSBleHBlY3RzICJcbiIg
YW5kIG5vdCAiZW50ZXIiLgorICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoZSB3cm9uZyBjb2Rl
LgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3Jlc291cmNlcy90ZXN0ZHJpdmVyLXZl
bmRvci5qczoKKwogMjAyMS0wMi0xNiAgTWFudWVsIFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdh
bGlhLmNvbT4KIAogICAgICAgICBbc2VsZWN0b3JzXSA6Zm9jdXMtdmlzaWJsZSBwYXJzaW5nIGFu
ZCBleHBlcmltZW50YWwgZmxhZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj
L3dlYi1wbGF0Zm9ybS10ZXN0cy9yZXNvdXJjZXMvdGVzdGRyaXZlci12ZW5kb3IuanMgYi9MYXlv
dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3Jlc291cmNlcy90ZXN0ZHJp
dmVyLXZlbmRvci5qcwppbmRleCBiYzBhOGFmNDQzODUwZGJlMmQzMTdkNWY5Mzg5ZWMxMDdjOWI0
YWE4Li4yNWUyNGM1OThhMjQ1NjQ2MWMyOTk2YmIxNWRlMzE0YTZkNzZjZjFiIDEwMDY0NAotLS0g
YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3Jlc291cmNlcy90
ZXN0ZHJpdmVyLXZlbmRvci5qcworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs
YXRmb3JtLXRlc3RzL3Jlc291cmNlcy90ZXN0ZHJpdmVyLXZlbmRvci5qcwpAQCAtMTYwLDcgKzE2
MCw3IEBAIHdpbmRvdy50ZXN0X2RyaXZlcl9pbnRlcm5hbC5zZW5kX2tleXMgPSBmdW5jdGlvbihl
bGVtZW50LCBrZXlzKQogICAgICAgICAwWEUwMDQ6IHsga2V5OiAnXHQnIH0sCiAgICAgICAgIDBY
RTAwNTogeyBrZXk6ICdjbGVhcicgfSwKICAgICAgICAgMFhFMDA2OiB7IGtleTogJ1xyJyB9LAot
ICAgICAgICAwWEUwMDc6IHsga2V5OiAnZW50ZXInIH0sCisgICAgICAgIDBYRTAwNzogeyBrZXk6
ICdcbicgfSwKICAgICAgICAgMHhFMDA4OiB7IGtleTogJ2xlZnRTaGlmdCcsIG1vZGlmaWVyOiAn
c2hpZnRLZXknIH0sCiAgICAgICAgIDB4RTAwOTogeyBrZXk6ICdsZWZ0Q29udHJvbCcsIG1vZGlm
aWVyOiAnY3RybEtleScgfSwKICAgICAgICAgMHhFMDBBOiB7IGtleTogJ2xlZnRBbHQnLCBtb2Rp
ZmllcjogJ2FsdEtleScgfSwK
</data>

          </attachment>
      

    </bug>

</bugzilla>