222020 2021-02-16 19:49:12 -0800 REGRESSION(r272776) [GLIB] imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.broken.html is failing for a different reason 2024-12-19 11:28:19 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221637 InRadar P2 Normal --- 1 lmoura rbuis bugs-noreply dino sabouhallawa webkit-bug-importer oldest_to_newest 1730094 0 lmoura 2021-02-16 19:49:12 -0800 imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.broken.html This test checks if ctx.createPattern(brokenImage, ...) returns null with a broken image[1]. While the current baseline expects FAIL, r272776 changed the reason it's failing in GTK/WPE. Diff: -FAIL Canvas test: 2d.pattern.image.broken assert_equals: ctx.createPattern(img, 'repeat') === null (got [object CanvasPattern][object], expected [object]) expected null but got object "[object CanvasPattern]" +FAIL Canvas test: 2d.pattern.image.broken The object is in an invalid state. The invalid state is raised after failing to create the native image in CanvasRenderingContext2DBase::createPattern(HTMLImageElement...). Meanwhile, the same revision made imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.nonexistent.html pass in WPE, as now InvalidState is thrown. [1] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-createpattern 1732770 1 webkit-bug-importer 2021-02-23 19:50:15 -0800 <rdar://problem/74675235> 2081794 2 rbuis 2024-12-14 08:53:03 -0800 Pull request: https://github.com/WebKit/WebKit/pull/37969 2083066 3 ews-feeder 2024-12-19 11:28:16 -0800 Committed 288110@main (7702ba882df2): <https://commits.webkit.org/288110@main> Reviewed commits have been landed. Closing PR #37969 and removing active labels.