222012 2021-02-16 17:36:41 -0800 [Python-3] Child process environment on Windows can only contain strings 2021-02-17 19:02:38 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 221815 1 don.olmstead don.olmstead ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1730038 0 don.olmstead 2021-02-16 17:36:41 -0800 On Python 3 currently run-webkit-tests is throwing `TypeError: environment can only contain strings` on Windows. 1730046 1 420571 don.olmstead 2021-02-16 17:56:08 -0800 Created attachment 420571 Patch 1730322 2 ews-feeder 2021-02-17 09:39:25 -0800 Committed r273008: <https://commits.webkit.org/r273008> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420571. 1730323 3 webkit-bug-importer 2021-02-17 09:40:24 -0800 <rdar://problem/74437205> 1730686 4 don.olmstead 2021-02-17 18:00:47 -0800 Broke WinCairo 1730690 5 420777 don.olmstead 2021-02-17 18:04:35 -0800 Created attachment 420777 Python 2 fix 1730710 6 ews-feeder 2021-02-17 19:02:37 -0800 Committed r273059: <https://commits.webkit.org/r273059> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420777. 420571 2021-02-16 17:56:08 -0800 2021-02-17 09:39:25 -0800 Patch bug-222012.diff text/plain 3444 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMmJk NWYyNDlhNzMuLjNjN2MxMWRhNzQ5NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTAyLTE2ICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgW1B5dGhvbi0zXSBDaGlsZCBw cm9jZXNzIGVudmlyb25tZW50IG9uIFdpbmRvd3MgY2FuIG9ubHkgY29udGFpbiBzdHJpbmdzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIwMTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHJ1bm5p bmcgUHl0aG9uIDMgb24gV2luZG93cyBhICdUeXBlRXJyb3I6IGVudmlyb25tZW50IGNhbiBvbmx5 IGNvbnRhaW4gc3RyaW5ncycgaXMKKyAgICAgICAgdGhyb3duIGR1cmluZyBleGVjdXRpb24gb2Yg cnVuLXdlYmtpdC10ZXN0cy4gSWYgdGhlIEV4ZWN1dGl2ZSBpcyBydW5uaW5nIG9uIG5hdGl2ZSBX aW5kb3dzCisgICAgICAgIGl0IGNvbnZlcnRzIHRoZSBrZXlzIGFuZCB2YWx1ZXMgb2YgdGhlIGVu dmlyb25tZW50IGRpY3Rpb25hcnkgaW50byBzdHJpbmdzIGFuZCBwYXNzZXMgdGhlbQorICAgICAg ICBpbnRvIHRoZSBwb3BlbiBjYWxsLgorCisgICAgICAgIEluIFNlcnZlclByb2Nlc3MgaXQgd2Fz IG1vZGlmeWluZyB0aGUgZW52aXJvbm1lbnQgYXMgd2VsbC4gVGhpcyBjb2RlIHdhcyByZW1vdmVk IHNvCisgICAgICAgIEV4ZWN1dGl2ZSBpcyB0aGUgb25seSBwbGFjZSB0aGF0IGhhbmRsZXMgdGhp cyBpc3N1ZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVj dXRpdmUucHk6CisgICAgICAgIChFeGVjdXRpdmUucG9wZW4pOgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3Mu X19pbml0X18pOgorCiAyMDIxLTAyLTE2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBTZXQgYSBkZWZhdWx0IHBhdGggZm9yIGRldmljZSBJRCBoYXNoIHNhbHRz CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0 aXZlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5w eQppbmRleCBiZDgwMTUyN2FiNjUuLjA3ZDNmNzNjYzE5OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CkBAIC01MDMsOCArNTAzLDIw IEBAIGNsYXNzIEV4ZWN1dGl2ZShBYnN0cmFjdEV4ZWN1dGl2ZSk6CiAgICAgICAgIGVsc2U6CiAg ICAgICAgICAgICBzdHJpbmdfYXJncyA9IHNlbGYuX3N0cmluZ2lmeV9hcmdzKGFyZ3MpCiAKKyAg ICAgICAgIyBXaW5kb3dzIFB5dGhvbiAzIHRocm93cyBhIFR5cGVFcnJvciBpZiB0aGUgZW52aXJv bm1lbnQgY29udGFpbnMgYGJ5dGVzYCBpbnN0ZWFkIG9mIGBzdHJgCisgICAgICAgIGVudiA9IGt3 YXJncy5wb3AoJ2VudicsIE5vbmUpCisgICAgICAgIGlmIHNlbGYuX2lzX25hdGl2ZV93aW4gYW5k IGVudiBpcyBub3QgTm9uZToKKyAgICAgICAgICAgIG1vZF9lbnYgPSB7fQorICAgICAgICAgICAg Zm9yIGtleSwgdmFsdWUgaW4gZW52Lml0ZW1zKCk6CisgICAgICAgICAgICAgICAgaWYgbm90IGlz aW5zdGFuY2Uoa2V5LCBzdHIpOgorICAgICAgICAgICAgICAgICAgICBrZXkgPSBrZXkuZGVjb2Rl KCd1dGYtOCcpCisgICAgICAgICAgICAgICAgaWYgbm90IGlzaW5zdGFuY2UodmFsdWUsIHN0cik6 CisgICAgICAgICAgICAgICAgICAgIHZhbHVlID0gdmFsdWUuZGVjb2RlKCd1dGYtOCcpCisgICAg ICAgICAgICAgICAgbW9kX2VudltrZXldID0gdmFsdWUKKyAgICAgICAgICAgIGVudiA9IG1vZF9l bnYKKwogICAgICAgICAjIFB5dGhvbiAzIHRyZWF0cyBQb3BlbiBhcyBhIGNvbnRleHQgbWFuYWdl ciwgd2Ugc2hvdWxkIGFsbG93IHRoaXMgaW4gUHl0aG9uIDIKLSAgICAgICAgcmVzdWx0ID0gc3Vi cHJvY2Vzcy5Qb3BlbihzdHJpbmdfYXJncywgKiprd2FyZ3MpCisgICAgICAgIHJlc3VsdCA9IHN1 YnByb2Nlc3MuUG9wZW4oc3RyaW5nX2FyZ3MsIGVudj1lbnYsICoqa3dhcmdzKQogICAgICAgICBp ZiBub3QgY2FsbGFibGUoZ2V0YXR0cihyZXN1bHQsICJfX2VudGVyX18iLCBOb25lKSkgYW5kIG5v dCBjYWxsYWJsZShnZXRhdHRyKHJlc3VsdCwgIl9fZXhpdF9fIiwgTm9uZSkpOgogICAgICAgICAg ICAgcmV0dXJuIHNlbGYuV3JhcHBlZFBvcGVuKHJlc3VsdCkKICAgICAgICAgcmV0dXJuIHJlc3Vs dApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNz LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5CmluZGV4 IGM2MDY1M2EwYmFkNS4uYTc2ODIyYzJhMDUyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5CkBAIC02OSwxNCArNjksOSBAQCBjbGFzcyBTZXJ2ZXJQ cm9jZXNzKG9iamVjdCk6CiAgICAgICAgICAgICBzZWxmLl9jbWQgPSBbJy91c3IvYmluL2FyY2gn LCAnLXt9Jy5mb3JtYXQoc2VsZi5fcG9ydC5hcmNoaXRlY3R1cmUoKSldICsgY21kCiAgICAgICAg IGVsc2U6CiAgICAgICAgICAgICBzZWxmLl9jbWQgPSBjbWQKKyAgICAgICAgc2VsZi5fZW52ID0g ZW52CiAgICAgICAgIHNlbGYuX2NyYXNoX21lc3NhZ2UgPSBjcmFzaF9tZXNzYWdlIG9yICdUaGlz IHRlc3QgbWFya2VkIGFzIGEgY3Jhc2gnCiAKLSAgICAgICAgIyBXaW5kb3dzIGRvZXMgbm90IGFs bG93IHVuaWNvZGUgdmFsdWVzIGluIHRoZSBlbnZpcm9ubWVudAotICAgICAgICBpZiBlbnYgYW5k IHBsYXRmb3JtLmlzX25hdGl2ZV93aW4oKToKLSAgICAgICAgICAgIHNlbGYuX2VudiA9IHtrZXk6 IGVudltrZXldLmVuY29kZSgndXRmLTgnKSBmb3Iga2V5IGluIGVudn0KLSAgICAgICAgZWxzZToK LSAgICAgICAgICAgIHNlbGYuX2VudiA9IGVudgotCiAgICAgICAgICMgU2V0IGlmIHRoZSBwcm9j ZXNzIG91dHB1dHMgbm9uLXN0YW5kYXJkIG5ld2xpbmVzIGxpa2UgJ1xyXG4nIG9yICdccicuCiAg ICAgICAgICMgRG9uJ3Qgc2V0IGlmIHRoZXJlIHdpbGwgYmUgYmluYXJ5IGRhdGEgb3IgdGhlIGRh dGEgbXVzdCBiZSBBU0NJSSBlbmNvZGVkLgogICAgICAgICBzZWxmLl91bml2ZXJzYWxfbmV3bGlu ZXMgPSB1bml2ZXJzYWxfbmV3bGluZXMK 420777 2021-02-17 18:04:35 -0800 2021-02-17 19:02:37 -0800 Python 2 fix bug-222012-followup.diff text/plain 2194 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmYjM5 NzQ5ODYzNzguLmZjNjEyNTNlNjg0MyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTE3ICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgW1B5dGhvbi0zXSBDaGlsZCBw cm9jZXNzIGVudmlyb25tZW50IG9uIFdpbmRvd3MgY2FuIG9ubHkgY29udGFpbiBzdHJpbmdzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIwMTIKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc0NDM3MjA1PgorCisgICAgICAgIFVucmV2aWV3ZWQgdGVz dCBydW5uZXIgZml4LgorCisgICAgICAgIFVzZSBvbGQgUHl0aG9uIDIgYmVoYXZpb3Igb2YgZW5j b2Rpbmcgd2hlbiBydW5uaW5nIHdpdGggdGhhdCB2ZXJzaW9uLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2ZS5weToKKyAgICAgICAgKEV4ZWN1dGl2 ZS5wb3Blbik6CisKIDIwMjEtMDItMTcgIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdW0ZDUl0gQWRkIG5ldyBkYXRhbGlzdCBkcm9wZG93biBmb3Ig dGV4dCBpbnB1dHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS9leGVjdXRpdmUucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0v ZXhlY3V0aXZlLnB5CmluZGV4IDlhMGVjMDFhZWNiMy4uNWFjZDc4MTJhNzdkIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vZXhlY3V0aXZlLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKQEAgLTUx MiwxMiArNTEyLDIwIEBAIGNsYXNzIEV4ZWN1dGl2ZShBYnN0cmFjdEV4ZWN1dGl2ZSk6CiAgICAg ICAgIGVudiA9IGt3YXJncy5wb3AoJ2VudicsIE5vbmUpCiAgICAgICAgIGlmIHNlbGYuX2lzX25h dGl2ZV93aW4gYW5kIGVudiBpcyBub3QgTm9uZToKICAgICAgICAgICAgIG1vZF9lbnYgPSB7fQot ICAgICAgICAgICAgZm9yIGtleSwgdmFsdWUgaW4gZW52Lml0ZW1zKCk6Ci0gICAgICAgICAgICAg ICAgaWYgbm90IGlzaW5zdGFuY2Uoa2V5LCBzdHIpOgotICAgICAgICAgICAgICAgICAgICBrZXkg PSBrZXkuZGVjb2RlKCd1dGYtOCcpCi0gICAgICAgICAgICAgICAgaWYgbm90IGlzaW5zdGFuY2Uo dmFsdWUsIHN0cik6Ci0gICAgICAgICAgICAgICAgICAgIHZhbHVlID0gdmFsdWUuZGVjb2RlKCd1 dGYtOCcpCi0gICAgICAgICAgICAgICAgbW9kX2VudltrZXldID0gdmFsdWUKKyAgICAgICAgICAg IGlmIHN5cy52ZXJzaW9uX2luZm8ubWFqb3IgPj0gMzoKKyAgICAgICAgICAgICAgICBmb3Iga2V5 LCB2YWx1ZSBpbiBlbnYuaXRlbXMoKToKKyAgICAgICAgICAgICAgICAgICAgaWYgbm90IGlzaW5z dGFuY2Uoa2V5LCBzdHIpOgorICAgICAgICAgICAgICAgICAgICAgICAga2V5ID0ga2V5LmRlY29k ZSgndXRmLTgnKQorICAgICAgICAgICAgICAgICAgICBpZiBub3QgaXNpbnN0YW5jZSh2YWx1ZSwg c3RyKToKKyAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVlID0gdmFsdWUuZGVjb2RlKCd1dGYt OCcpCisgICAgICAgICAgICAgICAgICAgIG1vZF9lbnZba2V5XSA9IHZhbHVlCisgICAgICAgICAg ICBlbHNlOgorICAgICAgICAgICAgICAgIGZvciBrZXksIHZhbHVlIGluIGVudi5pdGVtcygpOgor ICAgICAgICAgICAgICAgICAgICBpZiBub3QgaXNpbnN0YW5jZShrZXksIGJ5dGVzKToKKyAgICAg ICAgICAgICAgICAgICAgICAgIGtleSA9IGtleS5lbmNvZGUoJ3V0Zi04JykKKyAgICAgICAgICAg ICAgICAgICAgaWYgbm90IGlzaW5zdGFuY2UodmFsdWUsIGJ5dGVzKToKKyAgICAgICAgICAgICAg ICAgICAgICAgIHZhbHVlID0gdmFsdWUuZW5jb2RlKCd1dGYtOCcpCisgICAgICAgICAgICAgICAg ICAgIG1vZF9lbnZba2V5XSA9IHZhbHVlCiAgICAgICAgICAgICBlbnYgPSBtb2RfZW52CiAKICAg ICAgICAgIyBQeXRob24gMyB0cmVhdHMgUG9wZW4gYXMgYSBjb250ZXh0IG1hbmFnZXIsIHdlIHNo b3VsZCBhbGxvdyB0aGlzIGluIFB5dGhvbiAyCg==