222005 2021-02-16 15:12:38 -0800 REGRESSION (r271493 ) Crash in +[NSAttributedString(WKPrivate) _loadFromHTMLWithOptions:contentLoader:completionHandler:] on background thread 2021-02-16 18:32:15 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson webkit-unassigned ggaren webkit-bug-importer oldest_to_newest 1729971 0 beidson 2021-02-16 15:12:38 -0800 REGRESSION (r271493 ) Crash in +[NSAttributedString(WKPrivate) _loadFromHTMLWithOptions:contentLoader:completionHandler:] on background thread This method is meant to be thread safe by dispatching background thread work back up to WebKit's main thread. If called before Webkit is initialized on the main thread, it gets it wrong. Restore this call site back to dispatch_async to fix. 1730004 1 420556 beidson 2021-02-16 15:54:28 -0800 Created attachment 420556 Patch Even tried to write a test, but TestWebKitAPI isn't set up right for it :) 1730010 2 420556 ggaren 2021-02-16 16:13:24 -0800 Comment on attachment 420556 Patch r=me 1730071 3 ews-feeder 2021-02-16 18:31:35 -0800 Committed r272972: <https://commits.webkit.org/r272972> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420556. 1730072 4 webkit-bug-importer 2021-02-16 18:32:15 -0800 <rdar://problem/74416544> 420556 2021-02-16 15:54:28 -0800 2021-02-16 18:31:36 -0800 Patch patch text/plain 1626 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYmI3NGMzZjJmODViLi5jNzM0ODljNjNkNmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjEtMDItMTYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgor CisgICAgICAgIFJFR1JFU1NJT04gKHIyNzE0OTMgKSBDcmFzaCBpbiArW05TQXR0cmlidXRlZFN0 cmluZyhXS1ByaXZhdGUpIF9sb2FkRnJvbUhUTUxXaXRoT3B0aW9uczpjb250ZW50TG9hZGVyOmNv bXBsZXRpb25IYW5kbGVyOl0gb24gYmFja2dyb3VuZCB0aHJlYWQKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzc0MDM4MzcyPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyMjAwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAg ICAKKyAgICAgICAgVGVzdCBub3QgcG9zc2libGUgYXMgVGVzdFdlYktpdEFQSSBzZWVtcyB0byBh bHdheXMgaW5pdGlhbGl6ZSBXZWJLaXQgb24gdGhlIG1haW4gdGhyZWFkLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9OU0F0dHJpYnV0ZWRTdHJpbmcubW06CisgICAgICAgICgrW05T QXR0cmlidXRlZFN0cmluZyBfbG9hZEZyb21IVE1MV2l0aE9wdGlvbnM6Y29udGVudExvYWRlcjpj b21wbGV0aW9uSGFuZGxlcjpdKTogU3dpdGNoIHRoaXMgUnVuTG9vcDo6bWFpbigpIGJhY2sgdG8g ZGlzcGF0Y2hfYXN5bmMgdG8gbWFpbi4KKwogMjAyMS0wMi0xMCAgS2F0ZSBDaGVuZXkgIDxrYXRo ZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBQQ006IEV4cGlyZWQgcmVwb3J0cyBn ZXQgc2VudCBhdCB0aGUgc2FtZSB0aW1lIGFmdGVyIGEgc2Vzc2lvbiByZXN0YXJ0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvTlNBdHRyaWJ1dGVkU3RyaW5n Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL05TQXR0cmlidXRlZFN0cmlu Zy5tbQppbmRleCBjYzk0MTQwZmU5YjYuLmFjNTVmZmU2ODJiNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL05TQXR0cmlidXRlZFN0cmluZy5tbQorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvTlNBdHRyaWJ1dGVkU3RyaW5nLm1tCkBA IC0zMzUsOSArMzM1LDcgQEAgKyAodm9pZClfbG9hZEZyb21IVE1MV2l0aE9wdGlvbnM6KE5TRGlj dGlvbmFyeTxOU0F0dHJpYnV0ZWRTdHJpbmdEb2N1bWVudFJlYWRpbmcKICAgICBpZiAoW05TVGhy ZWFkIGlzTWFpblRocmVhZF0pCiAgICAgICAgIHJ1bkNvbnZlcnNpb24oKTsKICAgICBlbHNlCi0g ICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbcnVuQ29udmVyc2lvbiA9IG1ha2VCbG9j a1B0cihydW5Db252ZXJzaW9uKV0gewotICAgICAgICAgICAgcnVuQ29udmVyc2lvbigpOwotICAg ICAgICB9KTsKKyAgICAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUo KSwgcnVuQ29udmVyc2lvbik7CiB9CiAKIEBlbmQK