221989 2021-02-16 12:55:24 -0800 [ BigSur Debug Wk 2 ] ASSERT NOT REACHED in WebCore::DisplayList::PaintFrameForMedia::apply 2021-03-02 17:13:00 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222633 InRadar P2 Normal --- 1 jenner peng.liu6 amir_mark jer.noble peng.liu6 sabouhallawa simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1729879 0 jenner 2021-02-16 12:55:24 -0800 imported/w3c/web-platform-tests/html/editing/editing-0/contenteditable/selection-in-contentEditable-at-turning-designMode-on-off.tentative.html is flakey crashing in BigSur Debug in Wk 2. HISTORY URL: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fediting%2Fediting-0%2Fcontenteditable%2Fselection-in-contentEditable-at-turning-designMode-on-off.tentative.html&platform=mac CRASH LOG TEXT: No crash log found for GPUProcess:10707. stdout: stderr: SHOULD NEVER BE REACHED ./platform/graphics/displaylists/DisplayListItems.cpp(817) : void WebCore::DisplayList::PaintFrameForMedia::apply(WebCore::GraphicsContext &) const 1 0x13c59ea49 WTFCrash 2 0x11e96af2b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x122f27783 WebCore::DisplayList::PaintFrameForMedia::apply(WebCore::GraphicsContext&) const 4 0x122f1024e WebCore::DisplayList::ItemHandle::apply(WebCore::GraphicsContext&) 5 0x122f3304b WebCore::DisplayList::Replayer::applyItem(WebCore::DisplayList::ItemHandle) 6 0x122f33b34 WebCore::DisplayList::Replayer::replay(WebCore::FloatRect const&, bool) 7 0x10ff01b93 WebKit::RemoteRenderingBackend::submit(WebCore::DisplayList::DisplayList const&, WebCore::ImageBuffer&) 8 0x10ff01eda WebKit::RemoteRenderingBackend::nextDestinationImageBufferAfterApplyingDisplayLists(WebCore::ImageBuffer&, unsigned long, WebKit::DisplayListReaderHandle&, WebKit::GPUProcessWakeupReason) 9 0x10ff01700 WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList(WebKit::GPUProcessWakeupMessageArguments const&) 10 0x10fec4760 void IPC::callMemberFunctionImpl<WebKit::RemoteRenderingBackend, void (WebKit::RemoteRenderingBackend::*)(WebKit::GPUProcessWakeupMessageArguments const&), std::__1::tuple<WebKit::GPUProcessWakeupMessageArguments>, 0ul>(WebKit::RemoteRenderingBackend*, void (WebKit::RemoteRenderingBackend::*)(WebKit::GPUProcessWakeupMessageArguments const&), std::__1::tuple<WebKit::GPUProcessWakeupMessageArguments>&&, std::__1::integer_sequence<unsigned long, 0ul>) 11 0x10fec3d30 void IPC::callMemberFunction<WebKit::RemoteRenderingBackend, void (WebKit::RemoteRenderingBackend::*)(WebKit::GPUProcessWakeupMessageArguments const&), std::__1::tuple<WebKit::GPUProcessWakeupMessageArguments>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebKit::GPUProcessWakeupMessageArguments>&&, WebKit::RemoteRenderingBackend*, void (WebKit::RemoteRenderingBackend::*)(WebKit::GPUProcessWakeupMessageArguments const&)) 12 0x10fea6776 void IPC::handleMessage<Messages::RemoteRenderingBackend::WakeUpAndApplyDisplayList, WebKit::RemoteRenderingBackend, void (WebKit::RemoteRenderingBackend::*)(WebKit::GPUProcessWakeupMessageArguments const&)>(IPC::Decoder&, WebKit::RemoteRenderingBackend*, void (WebKit::RemoteRenderingBackend::*)(WebKit::GPUProcessWakeupMessageArguments const&)) 13 0x10fea63aa WebKit::RemoteRenderingBackend::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 14 0x10f4f1135 IPC::Connection::dispatchWorkQueueMessageReceiverMessage(IPC::Connection::WorkQueueMessageReceiver&, IPC::Decoder&) 15 0x10f51a87a IPC::Connection::dispatchMessageToWorkQueueReceiver(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >&)::$_10::operator()() 16 0x10f51a74e WTF::Detail::CallableWrapper<IPC::Connection::dispatchMessageToWorkQueueReceiver(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >&)::$_10, void>::call() 17 0x13c5ca332 WTF::Function<void ()>::operator()() const 18 0x13c6ee8de WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0::operator()() const 19 0x13c6eeae2 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::operator()(void*) const 20 0x13c6eeab5 WTF::BlockPtr<void ()> WTF::BlockPtr<void ()>::fromCallable<WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0>(WTF::WorkQueue::dispatch(WTF::Function<void ()>&&)::$_0)::'lambda'(void*)::__invoke(void*) 21 0x7fff201bc5dd _dispatch_call_block_and_release 22 0x7fff201bd7c7 _dispatch_client_callout 23 0x7fff201c35fe _dispatch_lane_serial_drain 24 0x7fff201c40cb _dispatch_lane_invoke 25 0x7fff201cdc5d _dispatch_workloop_worker_thread 26 0x7fff20365499 _pthread_wqthread 27 0x7fff20364467 start_wqthread LEAK: 1 WebPageProxy 1729880 1 webkit-bug-importer 2021-02-16 12:55:45 -0800 <rdar://problem/74403030> 1729892 2 jenner 2021-02-16 13:16:38 -0800 Was not able to duplicate due to crashing being very flakey. The first reported crash occurred at r272861, but changes appear unrelated to the flakey failing test. Starting on Chris who added the test at r264038. CHANGESET URL: https://trac.webkit.org/changeset/264038/webkit 1730022 3 wenson_hsieh 2021-02-16 16:44:22 -0800 This might imply that we're unable to map to a MediaPlayer here: bool RemoteRenderingBackend::applyMediaItem(DisplayList::ItemHandle item, GraphicsContext& context) ... auto& mediaItem = item.get<DisplayList::PaintFrameForMedia>(); auto player = m_gpuConnectionToWebProcess->remoteMediaPlayerManagerProxy().mediaPlayer(mediaItem.identifier()); if (!player) return false; 1731715 4 ryanhaddad 2021-02-19 18:30:12 -0800 *** Bug 222178 has been marked as a duplicate of this bug. *** 1731812 5 peng.liu6 2021-02-20 11:06:41 -0800 (In reply to Wenson Hsieh from comment #3) > This might imply that we're unable to map to a MediaPlayer here: > > bool RemoteRenderingBackend::applyMediaItem(DisplayList::ItemHandle item, > GraphicsContext& context) > > ... > > auto& mediaItem = item.get<DisplayList::PaintFrameForMedia>(); > auto player = > m_gpuConnectionToWebProcess->remoteMediaPlayerManagerProxy(). > mediaPlayer(mediaItem.identifier()); > if (!player) > return false; I think we can just return true here. 1731813 6 421093 peng.liu6 2021-02-20 11:10:13 -0800 Created attachment 421093 Patch 1734536 7 ryanhaddad 2021-03-01 12:10:40 -0800 Can we get this reviewed/landed? 1735100 8 421093 jer.noble 2021-03-02 16:08:45 -0800 Comment on attachment 421093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421093&action=review > Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:126 > - return false; > + return true; Nit: Can we add a WTFLogAlways() (or equivalent) with the mediaItem.identifier() to track this exceptional case? 1735116 9 421093 peng.liu6 2021-03-02 16:22:40 -0800 Comment on attachment 421093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421093&action=review >> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:126 >> + return true; > > Nit: Can we add a WTFLogAlways() (or equivalent) with the mediaItem.identifier() to track this exceptional case? Filed bug 222633 to fix that. 1735125 10 421093 sabouhallawa 2021-03-02 16:39:13 -0800 Comment on attachment 421093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421093&action=review >>> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:126 >>> + return true; >> >> Nit: Can we add a WTFLogAlways() (or equivalent) with the mediaItem.identifier() to track this exceptional case? > > Filed bug 222633 to fix that. I think this will look better if we write it like this: if (auto player = m_gpuConnectionToWebProcess->remoteMediaPlayerManagerProxy().mediaPlayer(mediaItem.identifier())) context.paintFrameForMedia(*player, mediaItem.destination()); return true; 1735135 11 ews-feeder 2021-03-02 17:12:58 -0800 Committed r273775: <https://commits.webkit.org/r273775> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421093. 421093 2021-02-20 11:10:13 -0800 2021-03-02 17:12:59 -0800 Patch bug-221989-20210220111013.patch text/plain 1809 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFiYmQyNDRlMDA0YzIyOGYx NzRiZGUwMGVmODI0ZTM3NDQ3NDliZmMuLmUwZGFlMzMxZGFmODNiYWZmMTQzOTM4MmM2NzM2MDJj YjlkYzg4MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDItMjAgIFBlbmcgTGl1 ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KKworICAgICAgICBbIEJpZ1N1ciBEZWJ1ZyBXayAyIF0g QVNTRVJUIE5PVCBSRUFDSEVEIGluIFdlYkNvcmU6OkRpc3BsYXlMaXN0OjpQYWludEZyYW1lRm9y TWVkaWE6OmFwcGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjE5ODkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc0NDAzMDMwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhp cyB3aWxsIGZpeCBhIGNyYXNoIG9uIGRlYnVnIGJvdHMuCisKKyAgICAgICAgKiBHUFVQcm9jZXNz L2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuY3BwOgorICAgICAgICAoV2ViS2l0OjpS ZW1vdGVSZW5kZXJpbmdCYWNrZW5kOjphcHBseU1lZGlhSXRlbSk6IFdoZW4gd2UgY2Fubm90IGdl dCB0aGUgcGxheWVyLCB0aGUgcGxheWVyCisgICAgICAgIHdpdGggdGhlIGdpdmVuIGlkZW50aWZp ZXIgbXVzdCBoYXZlIGJlZW4gZGVzdHJveWVkLiBUaGlzIGZ1bmN0aW9uIGNhbiByZXR1cm4gdHJ1 ZSB0byBpbmRpY2F0ZQorICAgICAgICB0aGF0IHRoZSBpdGVtIGhhcyBiZWVuIGFwcGxpZWQuCisK IDIwMjEtMDItMjAgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzMxMTUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlUmVuZGVyaW5nQmFja2VuZC5jcHAgYi9T b3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlUmVuZGVyaW5nQmFja2VuZC5j cHAKaW5kZXggYjNlYjZiNjk2YTkzNDk5Mzc3MjIzZDc5MjhmOWEwZDI5OTYxN2YyYS4uMGU2MzY1 NWQwNTIxYWI1M2Y0NWVkNDBhY2U0ZWVlMTdjOTI5MWE1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5k LmNwcApAQCAtMTIzLDcgKzEyMyw3IEBAIGJvb2wgUmVtb3RlUmVuZGVyaW5nQmFja2VuZDo6YXBw bHlNZWRpYUl0ZW0oRGlzcGxheUxpc3Q6Okl0ZW1IYW5kbGUgaXRlbSwgR3JhcGhpCiAgICAgYXV0 byYgbWVkaWFJdGVtID0gaXRlbS5nZXQ8RGlzcGxheUxpc3Q6OlBhaW50RnJhbWVGb3JNZWRpYT4o KTsKICAgICBhdXRvIHBsYXllciA9IG1fZ3B1Q29ubmVjdGlvblRvV2ViUHJvY2Vzcy0+cmVtb3Rl TWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkoKS5tZWRpYVBsYXllcihtZWRpYUl0ZW0uaWRlbnRpZmll cigpKTsKICAgICBpZiAoIXBsYXllcikKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBy ZXR1cm4gdHJ1ZTsKIAogICAgIGNvbnRleHQucGFpbnRGcmFtZUZvck1lZGlhKCpwbGF5ZXIsIG1l ZGlhSXRlbS5kZXN0aW5hdGlvbigpKTsKICAgICByZXR1cm4gdHJ1ZTsK