221976 2021-02-16 10:55:09 -0800 RenderElement::containingBlockForAbsolutePosition may call RenderObject::containingBlock recursively 2021-02-16 14:56:00 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser zalan oldest_to_newest 1729799 0 zalan 2021-02-16 10:55:09 -0800 when the RenderInline is absolute positioned (which should not happen normally as we blockify out of flow boxes) 1729801 1 zalan 2021-02-16 10:55:38 -0800 <rdar://problem/72775667> 1729805 2 420500 zalan 2021-02-16 11:11:47 -0800 Created attachment 420500 Patch 1729809 3 420500 simon.fraser 2021-02-16 11:15:31 -0800 Comment on attachment 420500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420500&action=review > Source/WebCore/ChangeLog:9 > + When a RenderInline (incorrectly) happens to be absolute positioned, containingBlockForAbsolutePosition() calls containingBlock() Do we know why this happens? Should we assert when it does? 1729912 4 420534 zalan 2021-02-16 13:43:34 -0800 Created attachment 420534 Patch 1729960 5 ews-feeder 2021-02-16 14:55:58 -0800 Committed r272931: <https://commits.webkit.org/r272931> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420534. 420500 2021-02-16 11:11:47 -0800 2021-02-16 13:43:31 -0800 Patch bug-221976-20210216111146.patch text/plain 3374 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIxY2IyNTJiMTJjMTA4 M2Q1YzEyMjYzZTk5YWU2ZTMwOThkNzljMC4uNWFmODI5ODAwZDA0NWQ1NWQ4NGEzZWE0ODBmYzkz NzM0YzhmZWIwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAyLTE2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyRWxlbWVudDo6Y29u dGFpbmluZ0Jsb2NrRm9yQWJzb2x1dGVQb3NpdGlvbiBtYXkgY2FsbCBSZW5kZXJPYmplY3Q6OmNv bnRhaW5pbmdCbG9jayByZWN1cnNpdmVseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIxOTc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83Mjc3NTY2 Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVu IGEgUmVuZGVySW5saW5lIChpbmNvcnJlY3RseSkgaGFwcGVucyB0byBiZSBhYnNvbHV0ZSBwb3Np dGlvbmVkLCBjb250YWluaW5nQmxvY2tGb3JBYnNvbHV0ZVBvc2l0aW9uKCkgY2FsbHMgY29udGFp bmluZ0Jsb2NrKCkKKyAgICAgICAgd2l0aCB8dGhpc3wgYW5kIGluIHJldHVybiBjb250YWluaW5n QmxvY2soKSBjYWxscyBiYWNrIG9uIGNvbnRhaW5pbmdCbG9ja0ZvckFic29sdXRlUG9zaXRpb24o KSB3aXRoIHRoZSBzYW1lIHJlbmRlcmVyLgorICAgICAgICBUaGlzIHBhdGNoIGVuc3VyZXMgdGhh dCB3ZSBhbHdheXMgY2FsbCBjb250YWluaW5nQmxvY2soKSBmcm9tIGNvbnRhaW5pbmdCbG9ja0Zv ckFic29sdXRlUG9zaXRpb24oKSB3aXRoIGFuIGFuY2VzdG9yIC1tb3N0bHkgd2l0aCB0aGUgcGFy ZW50KCkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJFbGVtZW50Ojpjb250YWluaW5nQmxvY2tGb3JBYnNvbHV0ZVBvc2l0 aW9uIGNvbnN0KToKKwogMjAyMS0wMi0xNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdW0lGQ10gRG8gbm90IHJlLW1lYXN1cmUgd3JhcHBlZCBjb250ZW50 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKaW5kZXggYjAyYzg4 NWE0MDIxOGJkOWNhOTc5OThhNGNhMDliZjg2YTYxNDM0Ni4uNzE2NmE5MTAyYTUzMWVmZjBiYTdm NzI2M2MzNmE0ZGJlMjNlMDY0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJF bGVtZW50LmNwcApAQCAtNjAxLDE1ICs2MDEsMjIgQEAgUmVuZGVyQmxvY2sqIFJlbmRlckVsZW1l bnQ6OmNvbnRhaW5pbmdCbG9ja0ZvckZpeGVkUG9zaXRpb24oKSBjb25zdAogCiBSZW5kZXJCbG9j ayogUmVuZGVyRWxlbWVudDo6Y29udGFpbmluZ0Jsb2NrRm9yQWJzb2x1dGVQb3NpdGlvbigpIGNv bnN0CiB7Ci0gICAgLy8gQSByZWxhdGl2ZWx5IHBvc2l0aW9uZWQgUmVuZGVySW5saW5lIGZvcndh cmRzIGl0cyBhYnNvbHV0ZSBwb3NpdGlvbmVkIGRlc2NlbmRhbnRzIHRvCi0gICAgLy8gaXRzIG5l YXJlc3Qgbm9uLWFub255bW91cyBjb250YWluaW5nIGJsb2NrICh0byBhdm9pZCBoYXZpbmcgYSBw b3NpdGlvbmVkIG9iamVjdHMgbGlzdCBpbiBhbGwgUmVuZGVySW5saW5lcykuCi0gICAgYXV0byog cmVuZGVyZXIgPSBpc1JlbmRlcklubGluZSgpID8gY29uc3RfY2FzdDxSZW5kZXJFbGVtZW50Kj4o ZG93bmNhc3Q8UmVuZGVyRWxlbWVudD4odGhpcykpIDogcGFyZW50KCk7Ci0gICAgd2hpbGUgKHJl bmRlcmVyICYmICFyZW5kZXJlci0+Y2FuQ29udGFpbkFic29sdXRlbHlQb3NpdGlvbmVkT2JqZWN0 cygpKQotICAgICAgICByZW5kZXJlciA9IHJlbmRlcmVyLT5wYXJlbnQoKTsKKyAgICBhdXRvIG5l YXJlc3ROb25Bbm9ueW1vdXNDb250YWluaW5nQmxvY2tJbmNsdWRpbmdTZWxmID0gWyZdIChhdXRv KiByZW5kZXJlcikgeworICAgICAgICB3aGlsZSAocmVuZGVyZXIgJiYgKCFpczxSZW5kZXJCbG9j az4oKnJlbmRlcmVyKSB8fCByZW5kZXJlci0+aXNBbm9ueW1vdXNCbG9jaygpKSkKKyAgICAgICAg ICAgIHJlbmRlcmVyID0gcmVuZGVyZXItPmNvbnRhaW5pbmdCbG9jaygpOworICAgICAgICByZXR1 cm4gZG93bmNhc3Q8UmVuZGVyQmxvY2s+KHJlbmRlcmVyKTsKKyAgICB9OworCisgICAgaWYgKGlz PFJlbmRlcklubGluZT4oKnRoaXMpICYmIHN0eWxlKCkucG9zaXRpb24oKSA9PSBQb3NpdGlvblR5 cGU6OlJlbGF0aXZlKSB7CisgICAgICAgIC8vIEEgcmVsYXRpdmVseSBwb3NpdGlvbmVkIFJlbmRl cklubGluZSBmb3J3YXJkcyBpdHMgYWJzb2x1dGUgcG9zaXRpb25lZCBkZXNjZW5kYW50cyB0bwor ICAgICAgICAvLyBpdHMgbmVhcmVzdCBub24tYW5vbnltb3VzIGNvbnRhaW5pbmcgYmxvY2sgKHRv IGF2b2lkIGhhdmluZyBwb3NpdGlvbmVkIG9iamVjdHMgbGlzdCBpbiBSZW5kZXJJbmxpbmVzKS4K KyAgICAgICAgcmV0dXJuIG5lYXJlc3ROb25Bbm9ueW1vdXNDb250YWluaW5nQmxvY2tJbmNsdWRp bmdTZWxmKHBhcmVudCgpKTsKKyAgICB9CisgICAgYXV0byogYW5jZXN0b3IgPSBwYXJlbnQoKTsK KyAgICB3aGlsZSAoYW5jZXN0b3IgJiYgIWFuY2VzdG9yLT5jYW5Db250YWluQWJzb2x1dGVseVBv c2l0aW9uZWRPYmplY3RzKCkpCisgICAgICAgIGFuY2VzdG9yID0gYW5jZXN0b3ItPnBhcmVudCgp OwogICAgIC8vIE1ha2Ugc3VyZSB3ZSBvbmx5IHJldHVybiBub24tYW5vbnltb3VzIFJlbmRlckJs b2NrIGFzIGNvbnRhaW5pbmcgYmxvY2suCi0gICAgd2hpbGUgKHJlbmRlcmVyICYmICghaXM8UmVu ZGVyQmxvY2s+KCpyZW5kZXJlcikgfHwgcmVuZGVyZXItPmlzQW5vbnltb3VzQmxvY2soKSkpCi0g ICAgICAgIHJlbmRlcmVyID0gcmVuZGVyZXItPmNvbnRhaW5pbmdCbG9jaygpOwotICAgIHJldHVy biBkb3duY2FzdDxSZW5kZXJCbG9jaz4ocmVuZGVyZXIpOworICAgIHJldHVybiBuZWFyZXN0Tm9u QW5vbnltb3VzQ29udGFpbmluZ0Jsb2NrSW5jbHVkaW5nU2VsZihhbmNlc3Rvcik7CiB9CiAKIHN0 YXRpYyB2b2lkIGFkZExheWVycyhSZW5kZXJFbGVtZW50JiByZW5kZXJlciwgUmVuZGVyTGF5ZXIq IHBhcmVudExheWVyLCBSZW5kZXJFbGVtZW50KiYgbmV3T2JqZWN0LCBSZW5kZXJMYXllciomIGJl Zm9yZUNoaWxkKQo= 420534 2021-02-16 13:43:34 -0800 2021-02-16 14:55:59 -0800 Patch bug-221976-20210216134333.patch text/plain 3418 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIxY2IyNTJiMTJjMTA4 M2Q1YzEyMjYzZTk5YWU2ZTMwOThkNzljMC4uMjljNjNhZjM2NzM0YmExODMxMTBhNmQ1NTI1ZjI3 MDU4NWNiYWFkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAyLTE2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyRWxlbWVudDo6Y29u dGFpbmluZ0Jsb2NrRm9yQWJzb2x1dGVQb3NpdGlvbiBtYXkgY2FsbCBSZW5kZXJPYmplY3Q6OmNv bnRhaW5pbmdCbG9jayByZWN1cnNpdmVseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIxOTc2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83Mjc3NTY2 Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgV2hlbiBh IFJlbmRlcklubGluZSBoYXBwZW5zIHRvIGJlIGFic29sdXRlIHBvc2l0aW9uZWQgKHRoaXMgaXMg YSBoaWdobHkgaW5jb3JyZWN0IHN0YXRlLCBzZWUgd2Via2l0Lm9yZy9iLzIyMTk5NCksIGNvbnRh aW5pbmdCbG9ja0ZvckFic29sdXRlUG9zaXRpb24oKSBjYWxscyBjb250YWluaW5nQmxvY2soKQor ICAgICAgICB3aXRoIHx0aGlzfCBhbmQgaW4gcmV0dXJuIGNvbnRhaW5pbmdCbG9jaygpIGNhbGxz IGJhY2sgb24gY29udGFpbmluZ0Jsb2NrRm9yQWJzb2x1dGVQb3NpdGlvbigpIHdpdGggdGhlIHNh bWUgcmVuZGVyZXIuCisgICAgICAgIFRoaXMgcGF0Y2ggZW5zdXJlcyB0aGF0IHdlIGFsd2F5cyBj YWxsIGNvbnRhaW5pbmdCbG9jaygpIGZyb20gY29udGFpbmluZ0Jsb2NrRm9yQWJzb2x1dGVQb3Np dGlvbigpIHdpdGggYW4gYW5jZXN0b3IgLW1vc3RseSB3aXRoIHRoZSBwYXJlbnQoKS4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckVsZW1lbnQ6OmNvbnRhaW5pbmdCbG9ja0ZvckFic29sdXRlUG9zaXRpb24gY29uc3QpOgor CiAyMDIxLTAyLTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAg W0xGQ11bSUZDXSBEbyBub3QgcmUtbWVhc3VyZSB3cmFwcGVkIGNvbnRlbnQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAppbmRleCBiMDJjODg1YTQwMjE4YmQ5Y2E5 Nzk5OGE0Y2EwOWJmODZhNjE0MzQ2Li43MTY2YTkxMDJhNTMxZWZmMGJhN2Y3MjYzYzM2YTRkYmUy M2UwNjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCkBA IC02MDEsMTUgKzYwMSwyMiBAQCBSZW5kZXJCbG9jayogUmVuZGVyRWxlbWVudDo6Y29udGFpbmlu Z0Jsb2NrRm9yRml4ZWRQb3NpdGlvbigpIGNvbnN0CiAKIFJlbmRlckJsb2NrKiBSZW5kZXJFbGVt ZW50Ojpjb250YWluaW5nQmxvY2tGb3JBYnNvbHV0ZVBvc2l0aW9uKCkgY29uc3QKIHsKLSAgICAv LyBBIHJlbGF0aXZlbHkgcG9zaXRpb25lZCBSZW5kZXJJbmxpbmUgZm9yd2FyZHMgaXRzIGFic29s dXRlIHBvc2l0aW9uZWQgZGVzY2VuZGFudHMgdG8KLSAgICAvLyBpdHMgbmVhcmVzdCBub24tYW5v bnltb3VzIGNvbnRhaW5pbmcgYmxvY2sgKHRvIGF2b2lkIGhhdmluZyBhIHBvc2l0aW9uZWQgb2Jq ZWN0cyBsaXN0IGluIGFsbCBSZW5kZXJJbmxpbmVzKS4KLSAgICBhdXRvKiByZW5kZXJlciA9IGlz UmVuZGVySW5saW5lKCkgPyBjb25zdF9jYXN0PFJlbmRlckVsZW1lbnQqPihkb3duY2FzdDxSZW5k ZXJFbGVtZW50Pih0aGlzKSkgOiBwYXJlbnQoKTsKLSAgICB3aGlsZSAocmVuZGVyZXIgJiYgIXJl bmRlcmVyLT5jYW5Db250YWluQWJzb2x1dGVseVBvc2l0aW9uZWRPYmplY3RzKCkpCi0gICAgICAg IHJlbmRlcmVyID0gcmVuZGVyZXItPnBhcmVudCgpOworICAgIGF1dG8gbmVhcmVzdE5vbkFub255 bW91c0NvbnRhaW5pbmdCbG9ja0luY2x1ZGluZ1NlbGYgPSBbJl0gKGF1dG8qIHJlbmRlcmVyKSB7 CisgICAgICAgIHdoaWxlIChyZW5kZXJlciAmJiAoIWlzPFJlbmRlckJsb2NrPigqcmVuZGVyZXIp IHx8IHJlbmRlcmVyLT5pc0Fub255bW91c0Jsb2NrKCkpKQorICAgICAgICAgICAgcmVuZGVyZXIg PSByZW5kZXJlci0+Y29udGFpbmluZ0Jsb2NrKCk7CisgICAgICAgIHJldHVybiBkb3duY2FzdDxS ZW5kZXJCbG9jaz4ocmVuZGVyZXIpOworICAgIH07CisKKyAgICBpZiAoaXM8UmVuZGVySW5saW5l PigqdGhpcykgJiYgc3R5bGUoKS5wb3NpdGlvbigpID09IFBvc2l0aW9uVHlwZTo6UmVsYXRpdmUp IHsKKyAgICAgICAgLy8gQSByZWxhdGl2ZWx5IHBvc2l0aW9uZWQgUmVuZGVySW5saW5lIGZvcndh cmRzIGl0cyBhYnNvbHV0ZSBwb3NpdGlvbmVkIGRlc2NlbmRhbnRzIHRvCisgICAgICAgIC8vIGl0 cyBuZWFyZXN0IG5vbi1hbm9ueW1vdXMgY29udGFpbmluZyBibG9jayAodG8gYXZvaWQgaGF2aW5n IHBvc2l0aW9uZWQgb2JqZWN0cyBsaXN0IGluIFJlbmRlcklubGluZXMpLgorICAgICAgICByZXR1 cm4gbmVhcmVzdE5vbkFub255bW91c0NvbnRhaW5pbmdCbG9ja0luY2x1ZGluZ1NlbGYocGFyZW50 KCkpOworICAgIH0KKyAgICBhdXRvKiBhbmNlc3RvciA9IHBhcmVudCgpOworICAgIHdoaWxlIChh bmNlc3RvciAmJiAhYW5jZXN0b3ItPmNhbkNvbnRhaW5BYnNvbHV0ZWx5UG9zaXRpb25lZE9iamVj dHMoKSkKKyAgICAgICAgYW5jZXN0b3IgPSBhbmNlc3Rvci0+cGFyZW50KCk7CiAgICAgLy8gTWFr ZSBzdXJlIHdlIG9ubHkgcmV0dXJuIG5vbi1hbm9ueW1vdXMgUmVuZGVyQmxvY2sgYXMgY29udGFp bmluZyBibG9jay4KLSAgICB3aGlsZSAocmVuZGVyZXIgJiYgKCFpczxSZW5kZXJCbG9jaz4oKnJl bmRlcmVyKSB8fCByZW5kZXJlci0+aXNBbm9ueW1vdXNCbG9jaygpKSkKLSAgICAgICAgcmVuZGVy ZXIgPSByZW5kZXJlci0+Y29udGFpbmluZ0Jsb2NrKCk7Ci0gICAgcmV0dXJuIGRvd25jYXN0PFJl bmRlckJsb2NrPihyZW5kZXJlcik7CisgICAgcmV0dXJuIG5lYXJlc3ROb25Bbm9ueW1vdXNDb250 YWluaW5nQmxvY2tJbmNsdWRpbmdTZWxmKGFuY2VzdG9yKTsKIH0KIAogc3RhdGljIHZvaWQgYWRk TGF5ZXJzKFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyLCBSZW5kZXJMYXllciogcGFyZW50TGF5ZXIs IFJlbmRlckVsZW1lbnQqJiBuZXdPYmplY3QsIFJlbmRlckxheWVyKiYgYmVmb3JlQ2hpbGQpCg==