221936 2021-02-15 16:34:50 -0800 [ARM64] Change break instruction comment to indicate possible security failure 2022-02-27 23:28:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff benjamin cdumez cmarcelo ews-watchlist keith_miller mark.lam saam tzagallo webkit-bug-importer oldest_to_newest 1729454 0 msaboff 2021-02-15 16:34:50 -0800 On ARM64, we can use a non-zero immediate value to indicate a possible security failure. 1729455 1 msaboff 2021-02-15 16:35:18 -0800 <rdar://74154659> 1729459 2 420394 msaboff 2021-02-15 16:39:27 -0800 Created attachment 420394 Patch 1729461 3 420394 mark.lam 2021-02-15 16:43:22 -0800 Comment on attachment 420394 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420394&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + using the same value the compiler emits. nit: I would say "C++ compiler" to be more explicit especially since there are so many compilers in our domain. 1729492 4 msaboff 2021-02-15 17:49:02 -0800 (In reply to Mark Lam from comment #3) > > Source/JavaScriptCore/ChangeLog:9 > > + using the same value the compiler emits. > > nit: I would say "C++ compiler" to be more explicit especially since there > are so many compilers in our domain. Done. 1729493 5 msaboff 2021-02-15 17:51:53 -0800 Committed r272892 (234125@main): <https://commits.webkit.org/234125@main> 420394 2021-02-15 16:39:27 -0800 2022-02-27 23:28:05 -0800 Patch 221936.patch text/plain 6167 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcyODg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDIxLTAyLTE1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFtBUk02NF0gQ2hhbmdlIGJyZWFrIGluc3RydWN0aW9uIGNvbW1lbnQgdG8gaW5kaWNhdGUg cG9zc2libGUgc2VjdXJpdHkgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIxOTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2UgY2hhbmdlIHRoZSBjb21tZW50IHZhbHVlIHRvIGluZGljYXRl IGEgcG9zc2libGUgc2VjdXJpdHkgaXNzdWUgYnkKKyAgICAgICAgdXNpbmcgdGhlIHNhbWUgdmFs dWUgdGhlIGNvbXBpbGVyIGVtaXRzLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyQVJNNjQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk02NDo6YnJlYWtwb2lu dCk6CisgICAgICAgICogZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuY3BwOgorICAgICAg ICAoSlNDOjpBUk02NERpc2Fzc2VtYmxlcjo6QTY0T3Bjb2RlRXhjZXB0aW9uR2VuZXJhdGlvbjo6 Zm9ybWF0KToKKyAgICAgICAgKiBkaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5oOgorICAg ICAgICAoSlNDOjpBUk02NERpc2Fzc2VtYmxlcjo6QTY0T3Bjb2RlRXhjZXB0aW9uR2VuZXJhdGlv bjo6aW1tZWRpYXRlMTYpOgorICAgICAgICAqIG9mZmxpbmVhc20vYXJtNjQucmI6CisKIDIwMjEt MDItMTUgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAg IFtKU0NdIFByb3BlcnR5U2xvdCBzaG91bGQgYWxsb3cgcGFzc2luZyBjdXN0b20gc2V0dGVycwpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlckFSTTY0LmgJKHJldmlzaW9uIDI3Mjg4NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk02NC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNjk1 LDcgKzM2OTUsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBNaXNjZWxsYW5lb3VzIG9wZXJhdGlvbnM6 CiAKLSAgICB2b2lkIGJyZWFrcG9pbnQodWludDE2X3QgaW1tID0gMCkKKyAgICB2b2lkIGJyZWFr cG9pbnQodWludDE2X3QgaW1tID0gMHhjNDcxKQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIu YnJrKGltbSk7CiAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxl ci9BUk02NC9BNjRET3Bjb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuY3BwCShyZXZpc2lvbiAyNzI4ODUpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02MzAsNyArNjMwLDcgQEAgY29uc3QgY2hhciogQTY0T3Bjb2Rl RXhjZXB0aW9uR2VuZXJhdGlvbgogICAgICAgICByZXR1cm4gQTY0RE9wY29kZTo6Zm9ybWF0KCk7 CiAKICAgICBhcHBlbmRJbnN0cnVjdGlvbk5hbWUob3BuYW1lKTsKLSAgICBhcHBlbmRVbnNpZ25l ZEltbWVkaWF0ZShpbW1lZGlhdGUxNigpKTsKKyAgICBhcHBlbmRVbnNpZ25lZEhleEltbWVkaWF0 ZShpbW1lZGlhdGUxNigpKTsKICAgICByZXR1cm4gbV9mb3JtYXRCdWZmZXI7CiB9CiAKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjQvQTY0 RE9wY29kZS5oCShyZXZpc2lvbiAyNzI4ODUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlz YXNzZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDA5LDcgKzQw OSw3IEBAIHB1YmxpYzoKICAgICB1bnNpZ25lZCBvcGMoKSB7IHJldHVybiAobV9vcGNvZGU+PjIx KSAmIDB4NzsgfQogICAgIHVuc2lnbmVkIG9wMigpIHsgcmV0dXJuIChtX29wY29kZT4+MikgJiAw eDc7IH0KICAgICB1bnNpZ25lZCBsbCgpIHsgcmV0dXJuIG1fb3Bjb2RlICYgMHgzOyB9Ci0gICAg aW50IGltbWVkaWF0ZTE2KCkgeyByZXR1cm4gKHN0YXRpY19jYXN0PGludD4oKG1fb3Bjb2RlID4+ IDUpICYgMHhmZmZmKSA8PCAxNikgPj4gMTY7IH0KKyAgICB1bnNpZ25lZCBpbW1lZGlhdGUxNigp IHsgcmV0dXJuIChzdGF0aWNfY2FzdDx1bnNpZ25lZD4oKG1fb3Bjb2RlID4+IDUpICYgMHhmZmZm KSA8PCAxNikgPj4gMTY7IH0KIH07CiAKIGNsYXNzIEE2NERPcGNvZGVFeHRyYWN0IDogcHVibGlj IEE2NERPcGNvZGUgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJt NjQucmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJt NjQucmIJKHJldmlzaW9uIDI3Mjg4NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l YXNtL2FybTY0LnJiCSh3b3JraW5nIGNvcHkpCkBAIC0xMDE2LDcgKzEwMTYsNyBAQCBjbGFzcyBJ bnN0cnVjdGlvbgogICAgICAgICAgICAgICAgIGVtaXRBUk02NFVuZmxpcHBlZCgiYmxyIiwgb3Bl cmFuZHMsIDpxdWFkKQogICAgICAgICAgICAgZW5kCiAgICAgICAgIHdoZW4gImJyZWFrIgotICAg ICAgICAgICAgJGFzbS5wdXRzICJicmsgXCMwIgorICAgICAgICAgICAgJGFzbS5wdXRzICJicmsg XCMweGM0NzEiCiAgICAgICAgIHdoZW4gInJldCIKICAgICAgICAgICAgICRhc20ucHV0cyAicmV0 IgogICAgICAgICB3aGVuICJjaWVxIiwgImNiZXEiCkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMjcyODg2KQor KysgU291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAor MjAyMS0wMi0xNSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KKworICAgICAg ICBbQVJNNjRdIENoYW5nZSBicmVhayBpbnN0cnVjdGlvbiBjb21tZW50IHRvIGluZGljYXRlIHBv c3NpYmxlIHNlY3VyaXR5IGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyMTkzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENoYW5nZSB0aGUgQVNTRVJUIGJyZWFrIGNvbW1lbnQgaW1tZWRpYXRl IHRvIHRoZSBzYW1lIHZhbHVlIHRoZSBjb21waWxlciB1c2VzLgorCisgICAgICAgICogd3RmL0Fz c2VydGlvbnMuY3BwOgorICAgICAgICAqIHd0Zi9Bc3NlcnRpb25zLmg6CisKIDIwMjEtMDItMTUg IE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lP TiByMjcyODIzKTogIENyYXNoIGluIEFSTTY0ZSBXYXNtIHRlc3RzCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9Bc3NlcnRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRp b25zLmNwcAkocmV2aXNpb24gMjcyODg1KQorKysgU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTYxMCw3ICs2MTAsNyBAQCB2b2lkIFdURlJlbGVhc2VMb2dT dGFja1RyYWNlKFdURkxvZ0NoYW5uCiAKICNlbGlmIENQVShBUk02NCkgLy8gQ1BVKFg4Nl82NCkK IAotI2RlZmluZSBDUkFTSF9JTlNUICJicmsgIzAiCisjZGVmaW5lIENSQVNIX0lOU1QgImJyayAj MHhjNDcxIgogCiAvLyBTZWUgY29tbWVudCBhYm92ZSBvbiB0aGUgb3JkZXJpbmcuCiAjZGVmaW5l IENSQVNIX0dQUjAgIngxNiIKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgJKHJldmlzaW9uIDI3Mjg4NSkK KysrIFNvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMjM1LDcg KzIzNSw3IEBAIFdURl9FWFBPUlRfUFJJVkFURSBib29sIFdURklzRGVidWdnZXJBdHQKICNlbGlm IENQVShBUk1fVEhVTUIyKQogI2RlZmluZSBXVEZCcmVha3BvaW50VHJhcCgpICBhc20gdm9sYXRp bGUgKCJia3B0ICMwIikKICNlbGlmIENQVShBUk02NCkKLSNkZWZpbmUgV1RGQnJlYWtwb2ludFRy YXAoKSAgYXNtIHZvbGF0aWxlICgiYnJrICMwIikKKyNkZWZpbmUgV1RGQnJlYWtwb2ludFRyYXAo KSAgYXNtIHZvbGF0aWxlICgiYnJrICMweGM0NzEiKQogI2Vsc2UKICNkZWZpbmUgV1RGQnJlYWtw b2ludFRyYXAoKSBXVEZDcmFzaCgpIC8vIE5vdCBpbXBsZW1lbnRlZC4KICNlbmRpZgpJbmRleDog U291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9ibWFsbG9jL0No YW5nZUxvZwkocmV2aXNpb24gMjcyODkxKQorKysgU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDItMTUgIE1pY2hhZWwgU2Fib2Zm ICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgW0FSTTY0XSBDaGFuZ2UgYnJlYWsgaW5z dHJ1Y3Rpb24gY29tbWVudCB0byBpbmRpY2F0ZSBwb3NzaWJsZSBzZWN1cml0eSBmYWlsdXJlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE5MzYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2UgdGhl IEFTU0VSVCBicmVhayBjb21tZW50IGltbWVkaWF0ZSB0byB0aGUgc2FtZSB2YWx1ZSB0aGUgY29t cGlsZXIgdXNlcy4KKworICAgICAgICAqIGJtYWxsb2MvQkFzc2VydC5oOgorCiAyMDIwLTEyLTA3 ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtl XSBSZW1vdmUgV0VCS0lUX1dSQVBfU09VUkNFTElTVApJbmRleDogU291cmNlL2JtYWxsb2MvYm1h bGxvYy9CQXNzZXJ0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9CQXNz ZXJ0LmgJKHJldmlzaW9uIDI3Mjg4NSkKKysrIFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQkFzc2Vy dC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MSw3ICs0MSw3IEBACiAjZWxpZiBCQ1BVKEFSTV9USFVN QjIpCiAjZGVmaW5lIEJCcmVha3BvaW50VHJhcCgpICBfX2FzbV9fIHZvbGF0aWxlICgiYmtwdCAj MCIpCiAjZWxpZiBCQ1BVKEFSTTY0KQotI2RlZmluZSBCQnJlYWtwb2ludFRyYXAoKSAgX19hc21f XyB2b2xhdGlsZSAoImJyayAjMCIpCisjZGVmaW5lIEJCcmVha3BvaW50VHJhcCgpICBfX2FzbV9f IHZvbGF0aWxlICgiYnJrICMweGM0NzEiKQogI2Vsc2UKICNlcnJvciAiVW5zdXBwb3J0ZWQgQ1BV Ii4KICNlbmRpZgo=