221922 2021-02-15 13:35:00 -0800 REGRESSION r272823): Crash in ARM64e Wasm tests 2022-02-27 23:28:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff benjamin cdumez cmarcelo ews-watchlist mark.lam webkit-bug-importer oldest_to_newest 1729342 0 msaboff 2021-02-15 13:35:00 -0800 The Wasm exception throwing tests are crashing on Apple Silicon devices after r272823. 2021-02-15 13:14:12.834908-0800 jsc[15055:74848] ASSERTION FAILED: inStateHash == hashThreadState(outState) ASSERTION FAILED: inStateHash == hashThreadState(outState) 2021-02-15 13:14:12.835412-0800 jsc[15055:74848] /Users/msaboff/src/webkit/OpenSource/Source/WTF/wtf/threads/Signals.cpp(260) : kern_return_t WTF::catch_mach_exception_raise_state(mach_port_t, exception_type_t, const mach_exception_data_t, mach_msg_type_number_t, int *, const thread_state_t, mach_msg_type_number_t, thread_state_t, mach_msg_type_number_t *) /Users/msaboff/src/webkit/OpenSource/Source/WTF/wtf/threads/Signals.cpp(260) : kern_return_t WTF::catch_mach_exception_raise_state(mach_port_t, exception_type_t, const mach_exception_data_t, mach_msg_type_number_t, int *, const thread_state_t, mach_msg_type_number_t, thread_state_t, mach_msg_type_number_t *) 2021-02-15 13:14:12.901046-0800 jsc[15055:74848] 1 0x10030097c WTFCrash 2021-02-15 13:14:12.903189-0800 jsc[15055:74848] 2 0x10083fec4 JSC::IntlDateTimeFormat* JSC::jsCast<JSC::IntlDateTimeFormat*, JSC::JSCell>(JSC::JSCell*) 2021-02-15 13:14:12.904373-0800 jsc[15055:74848] 3 0x1003a070c catch_mach_exception_raise_state 2021-02-15 13:14:12.905560-0800 jsc[15055:74848] 4 0x10035f520 _Xmach_exception_raise_state 2021-02-15 13:14:12.906490-0800 jsc[15055:74848] 5 0x10035f7fc mach_exc_server 2021-02-15 13:14:12.907461-0800 jsc[15055:74848] 6 0x181f20ec8 mach_msg_server_once 2021-02-15 13:14:12.908340-0800 jsc[15055:74848] 7 0x1003a3ff4 invocation function for block in WTF::startMachExceptionHandlerThread()::$_0::operator()() const 2021-02-15 13:14:12.908367-0800 jsc[15055:74848] 8 0x181d9b014 _dispatch_client_callout 2021-02-15 13:14:12.908375-0800 jsc[15055:74848] 9 0x181d9e67c _dispatch_continuation_pop 2021-02-15 13:14:12.908382-0800 jsc[15055:74848] 10 0x181db2470 _dispatch_source_invoke 2021-02-15 13:14:12.908389-0800 jsc[15055:74848] 11 0x181dae7f0 _dispatch_workloop_worker_thread 2021-02-15 13:14:12.908395-0800 jsc[15055:74848] 12 0x181f4ceb4 _pthread_wqthread 2021-02-15 13:14:12.908410-0800 jsc[15055:74848] 13 0x181f4bbe8 start_wqthread Process 15055 exited with status = 9 (0x00000009) 1729346 1 420364 msaboff 2021-02-15 13:41:40 -0800 Created attachment 420364 Patch 1729401 2 420380 msaboff 2021-02-15 14:52:43 -0800 Created attachment 420380 Updated patch after offline discussion with Mark Lam 1729408 3 420380 mark.lam 2021-02-15 15:04:02 -0800 Comment on attachment 420380 Updated patch after offline discussion with Mark Lam View in context: https://bugs.webkit.org/attachment.cgi?id=420380&action=review r=me > Source/WTF/wtf/threads/Signals.cpp:219 > - ptrauth_generic_signature_t inStateHash = hashThreadState(inState); > + ptrauth_generic_signature_t inThreadStateHash = hashThreadState(inState); nit: I thought that `inStateHash` was a good name because it's a "hash of the inState". But this is fine too. 1729424 4 msaboff 2021-02-15 15:22:19 -0800 (In reply to Mark Lam from comment #3) ... > > Source/WTF/wtf/threads/Signals.cpp:219 > > - ptrauth_generic_signature_t inStateHash = hashThreadState(inState); > > + ptrauth_generic_signature_t inThreadStateHash = hashThreadState(inState); > > nit: I thought that `inStateHash` was a good name because it's a "hash of > the inState". But this is fine too. I changed it back locally and will land. 1729430 5 msaboff 2021-02-15 15:31:37 -0800 Committed r272886 (234119@main): <https://commits.webkit.org/234119@main> 1729431 6 webkit-bug-importer 2021-02-15 15:32:14 -0800 <rdar://problem/74368498> 1729432 7 msaboff 2021-02-15 15:33:16 -0800 (In reply to Radar WebKit Bug Importer from comment #6) > <rdar://problem/74368498> <rdar://74289949> 420364 2021-02-15 13:41:40 -0800 2021-02-15 14:52:43 -0800 Patch 221922.patch text/plain 2218 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNzI4NzUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTE1ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gcjI3MjgyMyk6ICBDcmFzaCBp biBBUk02NGUgV2FzbSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIxOTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXBkYXRlZCB0byB1c2UgdGhlIGdlbmVyYWwgcmVnaXN0ZXIgdGhyZWFkIHN0 YXRlIGNvbXBvbmVudCBvZiB0aHJlYWRfc3RhdGVfdCBmb3IKKyAgICAgICAgY29tcHV0aW5nIHJl Z2lzdGVyIHN0YXRlIGhhc2hlcy4KKworICAgICAgICAqIHd0Zi90aHJlYWRzL1NpZ25hbHMuY3Bw OgorICAgICAgICAoV1RGOjpoYXNoVGhyZWFkU3RhdGUpOgorCiAyMDIxLTAyLTE1ICBDb21taXQg UXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCBy ZXZlcnRpbmcgcjI3MjgzMS4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAkocmV2 aXNpb24gMjcyODc0KQorKysgU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTU2LDcgKzE1Niw3IEBAIHN0YXRpYyBleGNlcHRpb25fbWFza190IHRv TWFjaE1hc2soU2lnbmEKIH0KIAogI2lmIENQVShBUk02NEUpICYmIE9TKERBUldJTikKLWlubGlu ZSBwdHJhdXRoX2dlbmVyaWNfc2lnbmF0dXJlX3QgaGFzaFRocmVhZFN0YXRlKGNvbnN0IHRocmVh ZF9zdGF0ZV90IHNvdXJjZSkKK2lubGluZSBwdHJhdXRoX2dlbmVyaWNfc2lnbmF0dXJlX3QgaGFz aFRocmVhZFN0YXRlKGNvbnN0IGFybV90aHJlYWRfc3RhdGU2NF90KiBzb3VyY2UpCiB7CiAgICAg Y29uc3RleHByIHNpemVfdCB0aHJlYWRTdGF0ZVBDUG9pbnRlckluZGV4ID0gb2Zmc2V0b2YoYXJt X3RocmVhZF9zdGF0ZTY0X3QsIF9fb3BhcXVlX3BjKSAvIHNpemVvZih1aW50cHRyX3QpOwogICAg IGNvbnN0ZXhwciBzaXplX3QgdGhyZWFkU3RhdGVTaXplSW5Qb2ludGVycyA9IHNpemVvZihhcm1f dGhyZWFkX3N0YXRlNjRfdCkgLyBzaXplb2YodWludHB0cl90KTsKQEAgLTIxNiw3ICsyMTYsNyBA QCBrZXJuX3JldHVybl90IGNhdGNoX21hY2hfZXhjZXB0aW9uX3JhaXNlCiAgICAgUkVMRUFTRV9B U1NFUlQoc2lnbmFsICE9IFNpZ25hbDo6VW5rbm93bik7CiAKICNpZiBDUFUoQVJNNjRFKSAmJiBP UyhEQVJXSU4pCi0gICAgcHRyYXV0aF9nZW5lcmljX3NpZ25hdHVyZV90IGluU3RhdGVIYXNoID0g aGFzaFRocmVhZFN0YXRlKGluU3RhdGUpOworICAgIHB0cmF1dGhfZ2VuZXJpY19zaWduYXR1cmVf dCBpblRocmVhZFN0YXRlSGFzaCA9IGhhc2hUaHJlYWRTdGF0ZSgmcmVpbnRlcnByZXRfY2FzdDxh cm1fdW5pZmllZF90aHJlYWRfc3RhdGUqPihpblN0YXRlKS0+dHNfNjQpOwogI2VuZGlmCiAKICAg ICBtZW1jcHkob3V0U3RhdGUsIGluU3RhdGUsIGluU3RhdGVDb3VudCAqIHNpemVvZihpblN0YXRl WzBdKSk7CkBAIC0yNTcsNyArMjU3LDcgQEAga2Vybl9yZXR1cm5fdCBjYXRjaF9tYWNoX2V4Y2Vw dGlvbl9yYWlzZQogCiAgICAgaWYgKGRpZEhhbmRsZSkgewogI2lmIENQVShBUk02NEUpICYmIE9T KERBUldJTikKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQoaW5TdGF0ZUhhc2ggPT0gaGFzaFRocmVh ZFN0YXRlKG91dFN0YXRlKSk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKGluVGhyZWFkU3RhdGVI YXNoID09IGhhc2hUaHJlYWRTdGF0ZSgmcmVpbnRlcnByZXRfY2FzdDxhcm1fdW5pZmllZF90aHJl YWRfc3RhdGUqPihvdXRTdGF0ZSktPnRzXzY0KSk7CiAjZW5kaWYKICAgICAgICAgKm91dFN0YXRl Q291bnQgPSBpblN0YXRlQ291bnQ7CiAgICAgICAgIHJldHVybiBLRVJOX1NVQ0NFU1M7Cg== 420380 2021-02-15 14:52:43 -0800 2022-02-27 23:28:17 -0800 Updated patch after offline discussion with Mark Lam 221922-2.patch text/plain 2330 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNzI4NzUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTE1ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gcjI3MjgyMyk6ICBDcmFzaCBp biBBUk02NGUgV2FzbSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIxOTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXBkYXRlZCB0byBwcm9wZXJseSBjb21wdXRlIHRoZSBzaXplIG9mIHRocmVh ZF9zdGF0ZV90IGFzIHdlbGwgYXMgdGhlIG9mZnNldCBvZiAKKyAgICAgICAgdGhlIFBDIGZvdW5k IGluIHRocmVhZF9zdGF0ZV90LgorCisgICAgICAgICogd3RmL3RocmVhZHMvU2lnbmFscy5jcHA6 CisgICAgICAgIChXVEY6Omhhc2hUaHJlYWRTdGF0ZSk6CisKIDIwMjEtMDItMTUgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJl dmVydGluZyByMjcyODMxLgpJbmRleDogU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCShyZXZp c2lvbiAyNzI4NzQpCisrKyBTb3VyY2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNTgsOCArMTU4LDggQEAgc3RhdGljIGV4Y2VwdGlvbl9tYXNrX3QgdG9N YWNoTWFzayhTaWduYQogI2lmIENQVShBUk02NEUpICYmIE9TKERBUldJTikKIGlubGluZSBwdHJh dXRoX2dlbmVyaWNfc2lnbmF0dXJlX3QgaGFzaFRocmVhZFN0YXRlKGNvbnN0IHRocmVhZF9zdGF0 ZV90IHNvdXJjZSkKIHsKLSAgICBjb25zdGV4cHIgc2l6ZV90IHRocmVhZFN0YXRlUENQb2ludGVy SW5kZXggPSBvZmZzZXRvZihhcm1fdGhyZWFkX3N0YXRlNjRfdCwgX19vcGFxdWVfcGMpIC8gc2l6 ZW9mKHVpbnRwdHJfdCk7Ci0gICAgY29uc3RleHByIHNpemVfdCB0aHJlYWRTdGF0ZVNpemVJblBv aW50ZXJzID0gc2l6ZW9mKGFybV90aHJlYWRfc3RhdGU2NF90KSAvIHNpemVvZih1aW50cHRyX3Qp OworICAgIGNvbnN0ZXhwciBzaXplX3QgdGhyZWFkU3RhdGVQQ1BvaW50ZXJJbmRleCA9IChvZmZz ZXRvZihhcm1fdW5pZmllZF90aHJlYWRfc3RhdGUsIHRzXzY0KSArIG9mZnNldG9mKGFybV90aHJl YWRfc3RhdGU2NF90LCBfX29wYXF1ZV9wYykpIC8gc2l6ZW9mKHVpbnRwdHJfdCk7CisgICAgY29u c3RleHByIHNpemVfdCB0aHJlYWRTdGF0ZVNpemVJblBvaW50ZXJzID0gc2l6ZW9mKGFybV91bmlm aWVkX3RocmVhZF9zdGF0ZSkgLyBzaXplb2YodWludHB0cl90KTsKIAogICAgIHB0cmF1dGhfZ2Vu ZXJpY19zaWduYXR1cmVfdCBoYXNoID0gMDsKIApAQCAtMjE2LDcgKzIxNiw3IEBAIGtlcm5fcmV0 dXJuX3QgY2F0Y2hfbWFjaF9leGNlcHRpb25fcmFpc2UKICAgICBSRUxFQVNFX0FTU0VSVChzaWdu YWwgIT0gU2lnbmFsOjpVbmtub3duKTsKIAogI2lmIENQVShBUk02NEUpICYmIE9TKERBUldJTikK LSAgICBwdHJhdXRoX2dlbmVyaWNfc2lnbmF0dXJlX3QgaW5TdGF0ZUhhc2ggPSBoYXNoVGhyZWFk U3RhdGUoaW5TdGF0ZSk7CisgICAgcHRyYXV0aF9nZW5lcmljX3NpZ25hdHVyZV90IGluVGhyZWFk U3RhdGVIYXNoID0gaGFzaFRocmVhZFN0YXRlKGluU3RhdGUpOwogI2VuZGlmCiAKICAgICBtZW1j cHkob3V0U3RhdGUsIGluU3RhdGUsIGluU3RhdGVDb3VudCAqIHNpemVvZihpblN0YXRlWzBdKSk7 CkBAIC0yNTcsNyArMjU3LDcgQEAga2Vybl9yZXR1cm5fdCBjYXRjaF9tYWNoX2V4Y2VwdGlvbl9y YWlzZQogCiAgICAgaWYgKGRpZEhhbmRsZSkgewogI2lmIENQVShBUk02NEUpICYmIE9TKERBUldJ TikKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQoaW5TdGF0ZUhhc2ggPT0gaGFzaFRocmVhZFN0YXRl KG91dFN0YXRlKSk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKGluVGhyZWFkU3RhdGVIYXNoID09 IGhhc2hUaHJlYWRTdGF0ZShvdXRTdGF0ZSkpOwogI2VuZGlmCiAgICAgICAgICpvdXRTdGF0ZUNv dW50ID0gaW5TdGF0ZUNvdW50OwogICAgICAgICByZXR1cm4gS0VSTl9TVUNDRVNTOwo=