221905 2021-02-15 09:39:44 -0800 [macOS] Close XPC connections before entering sandbox 2021-02-15 20:29:45 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan benjamin bfulgham cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1729194 0 pvollan 2021-02-15 09:39:44 -0800 XPC connections that are now allowed in the sandbox should be closed before entering the sandbox. 1729195 1 pvollan 2021-02-15 09:41:51 -0800 <rdar://70359582> 1729270 2 420342 pvollan 2021-02-15 11:32:31 -0800 Created attachment 420342 Patch 1729356 3 420342 bfulgham 2021-02-15 13:56:14 -0800 Comment on attachment 420342 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420342&action=review r=me > Source/WebKit/ChangeLog:9 > + XPC connections that are now allowed in the sandbox should be closed before entering the sandbox. Is it possible to do something like this on iOS? Or do we already do so? 1729534 4 pvollan 2021-02-15 19:55:09 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 420342 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=420342&action=review > > r=me > > > Source/WebKit/ChangeLog:9 > > + XPC connections that are now allowed in the sandbox should be closed before entering the sandbox. > > Is it possible to do something like this on iOS? Or do we already do so? I don’t believe this is needed on iOS, since the specific connection we are closing here, only exists on macOS. Thanks for reviewing! 1729547 5 ews-feeder 2021-02-15 20:29:42 -0800 Committed r272896: <https://commits.webkit.org/r272896> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420342. 420342 2021-02-15 11:32:31 -0800 2021-02-15 20:29:43 -0800 Patch bug-221905-20210215113228.patch text/plain 3112 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNzI2MTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAyLTE1ICBQZXIgQXJuZSAgPHB2b2xsYW5A YXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gQ2xvc2UgWFBDIGNvbm5lY3Rpb25zIGJlZm9y ZSBlbnRlcmluZyBzYW5kYm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjE5MDUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcwMzU5NTgyPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzb2Z0bGlu a2luZyBtYWNybyBmb3IgbGlicmFyaWVzIGluIC91c3IvbGliL3N5c3RlbS8uCisKKyAgICAgICAg KiB3dGYvY29jb2EvU29mdExpbmtpbmcuaDoKKwogMjAyMS0wMi0wOSAgRXJpYyBDYXJsc29uICA8 ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIEFkZCBpbnRlcm5hbCBw cmVmZXJlbmNlIHRvIGNvbnRyb2wgaG93IEFWT3V0cHV0Q29udGV4dCBpcyBhbGxvY2F0ZWQKSW5k ZXg6IFNvdXJjZS9XVEYvd3RmL2NvY29hL1NvZnRMaW5raW5nLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dURi93dGYvY29jb2EvU29mdExpbmtpbmcuaAkocmV2aXNpb24gMjcyNjE3KQorKysgU291 cmNlL1dURi93dGYvY29jb2EvU29mdExpbmtpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiAr NDIsMTcgQEAKICAgICAgICAgcmV0dXJuIGR5bGliOyBcCiAgICAgfQogCisjZGVmaW5lIFNPRlRf TElOS19TWVNURU1fTElCUkFSWShsaWIpIFwKKyAgICBzdGF0aWMgdm9pZCogbGliIyNMaWJyYXJ5 KCkgXAorICAgIHsgXAorICAgICAgICBzdGF0aWMgdm9pZCogZHlsaWIgPSBeeyBcCisgICAgICAg ICAgICB2b2lkICpyZXN1bHQgPSBkbG9wZW4oIi91c3IvbGliL3N5c3RlbS8iICNsaWIgIi5keWxp YiIsIFJUTERfTk9XKTsgXAorICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9NRVNTQUdF KHJlc3VsdCwgIiVzIiwgZGxlcnJvcigpKTsgXAorICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsg XAorICAgICAgICB9KCk7IFwKKyAgICAgICAgcmV0dXJuIGR5bGliOyBcCisgICAgfQorCiAjZGVm aW5lIFNPRlRfTElOS19MSUJSQVJZX09QVElPTkFMKGxpYikgXAogc3RhdGljIHZvaWQqIGxpYiMj TGlicmFyeSgpIFwKIHsgXApJbmRleDogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3Mjg2OCkKKysrIFNvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEt MDItMTUgIFBlciBBcm5lICA8cHZvbGxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBD bG9zZSBYUEMgY29ubmVjdGlvbnMgYmVmb3JlIGVudGVyaW5nIHNhbmRib3gKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTkwNQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNzAzNTk1ODI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgWFBDIGNvbm5lY3Rpb25zIHRoYXQgYXJlIG5vdyBhbGxvd2VkIGluIHRo ZSBzYW5kYm94IHNob3VsZCBiZSBjbG9zZWQgYmVmb3JlIGVudGVyaW5nIHRoZSBzYW5kYm94Lgor CisgICAgICAgICogU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1tOgorICAgICAgICAo V2ViS2l0Ojppbml0aWFsaXplU2FuZGJveFBhcmFtZXRlcnMpOgorCiAyMDIxLTAyLTE1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFBhZ2Ugc2Ny b2xsaW5nIGJ5IHdoZWVsIGV2ZW50cyBkb2Vzbid0IHdvcmsgaW4gbm9uLUFDIG1vZGUgcGFnZXMg aWYgSGFyZHdhcmUgQWNjZWxlcmF0aW9uIFBvbGljeSBpcyBjaGFuZ2VkIGR5bmFtaWNhbGx5IGZy b20gImFsd2F5cyIgdG8gIm5ldmVyIgpJbmRleDogU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL0F1 eGlsaWFyeVByb2Nlc3NNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQv bWFjL0F1eGlsaWFyeVByb2Nlc3NNYWMubW0JKHJldmlzaW9uIDI3MjYxNykKKysrIFNvdXJjZS9X ZWJLaXQvU2hhcmVkL21hYy9BdXhpbGlhcnlQcm9jZXNzTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBA IC02Miw2ICs2MiwxMSBAQAogI2ltcG9ydCA8cm9vdGxlc3MuaD4KICNlbmRpZgogCisjaW1wb3J0 IDx3dGYvU29mdExpbmtpbmcuaD4KKworU09GVF9MSU5LX1NZU1RFTV9MSUJSQVJZKGxpYnN5c3Rl bV9pbmZvKQorU09GVF9MSU5LX09QVElPTkFMKGxpYnN5c3RlbV9pbmZvLCBtYnJfY2xvc2VfY29u bmVjdGlvbnMsIGludCwgKCksICgpKTsKKwogI2lmIFBMQVRGT1JNKE1BQykKICNkZWZpbmUgVVNF X0NBQ0hFX0NPTVBJTEVEX1NBTkRCT1ggMQogI2Vsc2UKQEAgLTY5MCw2ICs2OTUsOCBAQCBzdGF0 aWMgdm9pZCBpbml0aWFsaXplU2FuZGJveFBhcmFtZXRlcnMoCiAjZWxzZQogI2Vycm9yICJVbmtu b3duIGFyY2hpdGVjdHVyZS4iCiAjZW5kaWYKKyAgICBpZiAobWJyX2Nsb3NlX2Nvbm5lY3Rpb25z UHRyKCkpCisgICAgICAgIG1icl9jbG9zZV9jb25uZWN0aW9uc1B0cigpKCk7CiB9CiAKIHZvaWQg QXV4aWxpYXJ5UHJvY2Vzczo6aW5pdGlhbGl6ZVNhbmRib3goY29uc3QgQXV4aWxpYXJ5UHJvY2Vz c0luaXRpYWxpemF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycywgU2FuZGJveEluaXRpYWxpemF0 aW9uUGFyYW1ldGVycyYgc2FuZGJveFBhcmFtZXRlcnMpCg==