221904 2021-02-15 08:20:46 -0800 Flaky JSC test: stress/atomic-increment-bigint64.js 2021-02-26 13:41:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro ysuzuki ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1729163 0 mcatanzaro 2021-02-15 08:20:46 -0800 JSC stress test stress/atomic-increment-bigint64.js has been flaky since Wednesday last week. So far it has failed only on x86_64, but that might be coincidence. I have recorded failures on Wednesday, Thursday, Saturday, and Sunday. The test was added in r272341, on Feb 3, but strangely I don't have any recorded failures prior to Feb 10. That could be luck. The failure looks like this: stress/atomic-increment-bigint64.js.bytecode-cache: ../../.helpers/bytecode-cache-test-helper.sh: line 28: 3922422 Aborted (core dumped) /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/bin/jsc atomic-increment-bigint64.js --useFTLJIT=false --useFunctionDotArguments=true --validateExceptionChecks=true --useDollarVM=true --maxPerThreadStackUsage=1572864 --useFTLJIT=true stress/atomic-increment-bigint64.js.bytecode-cache: Command '/var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/bin/jsc atomic-increment-bigint64.js --useFTLJIT=false --useFunctionDotArguments=true --validateExceptionChecks=true --useDollarVM=true --maxPerThreadStackUsage=1572864 --useFTLJIT=true' failed stress/atomic-increment-bigint64.js.bytecode-cache: ERROR: Unexpected exit code: 134 FAIL: stress/atomic-increment-bigint64.js.bytecode-cache 134 - 128 = 6 which is SIGABRT. Let's see if I can get a backtrace.... 1729221 1 mcatanzaro 2021-02-15 10:23:09 -0800 Test runs fine on my machine, but I got it to crash on my first attemtp when running it on our CI builder: #0 0x00007fad7c7409e5 in raise () from /lib64/libc.so.6 #1 0x00007fad7c729895 in abort () from /lib64/libc.so.6 #2 0x00007fad7f0a849e in JSC::UnlinkedProgramCodeBlock* JSC::CodeCache::getUnlinkedGlobalCodeBlock<JSC::UnlinkedProgramCodeBlock, JSC::ProgramExecutable>(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserStrictMode, JSC::JSParserScriptMode, WTF::OptionSet<JSC::CodeGenerationMode>, JSC::ParserError&, JSC::EvalContextType) () from /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/lib/libJavaScriptCore.so.1 #3 0x00007fad7f0911c4 in JSC::CodeCache::getUnlinkedProgramCodeBlock(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserStrictMode, WTF::OptionSet<JSC::CodeGenerationMode>, JSC::ParserError&) () from /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/lib/libJavaScriptCore.so.1 #4 0x00007fad7f28594a in JSC::ProgramExecutable::initializeGlobalProperties(JSC::VM&, JSC::JSGlobalObject*, JSC::JSScope*) () from /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/lib/libJavaScriptCore.so.1 #5 0x00007fad7ef1b11b in JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*) () from /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/lib/libJavaScriptCore.so.1 #6 0x00007fad7f0c2b5b in JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) () from /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/lib/libJavaScriptCore.so.1 #7 0x0000000000414fdd in WTF::Detail::CallableWrapper<functionDollarAgentStart(JSC::JSGlobalObject*, JSC::CallFrame*)::{lambda()#2}, void>::call() () #8 0x00007fad7f3afdea in WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) () from /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/lib/libJavaScriptCore.so.1 #9 0x00007fad7f4035e9 in WTF::wtfThreadEntryPoint(void*) () from /var/lib/jenkins/workspace/WebKit-JSC/label/x86_64/WebKitBuild/Release/lib/libJavaScriptCore.so.1 #10 0x00007fad7cc2a432 in start_thread () from /lib64/libpthread.so.0 #11 0x00007fad7c805913 in clone () from /lib64/libc.so.6 Sadly it's a release build so there is not much to that backtrace. I can try again with a debug build if needed. 1732132 2 webkit-bug-importer 2021-02-22 08:21:12 -0800 <rdar://problem/74596956> 1732759 3 ysuzuki 2021-02-23 18:16:48 -0800 This sounds like this test is not suitable for bytecode-cache's assumption. We have some code that is executed in the worker threads, and they are not cached because it is not running in the main thread VM. 1733664 4 421609 ysuzuki 2021-02-25 21:48:16 -0800 Created attachment 421609 Patch 1733965 5 ews-feeder 2021-02-26 13:41:44 -0800 Committed r273587: <https://commits.webkit.org/r273587> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421609. 421609 2021-02-25 21:48:16 -0800 2021-02-26 13:41:45 -0800 Patch bug-221904-20210225214815.patch text/plain 2080 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw YzMxYTVlM2NjMWFjNzk4ZjAxMDNmYzIyNDg5Y2Y0ODRkYmZlNjQ4Li43ZWU4ZGNkYzU3ZGE0NmQ3 NjE2ZjFiNTJmM2Y3YmM4Y2E2YmU2YjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0wMi0yNSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIEZsYWt5IEpTQyB0ZXN0OiBzdHJlc3MvYXRvbWljLWluY3JlbWVudC1iaWdp bnQ2NC5qcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIxOTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Ynl0ZWNvZGUtY2FjaGUgdGVzdCBhc3N1bWVzIHRoYXQgY29kZSBjYW4gYmUgY2FjaGVkIG9uY2Ug aXQgaXMgZXhlY3V0ZWQuIEJ1dCB0aGlzCisgICAgICAgIGlzIG5vdCBjb3JyZWN0IGZvciB0aHJl YWRpbmcgdGVzdHMgdXNpbmcgSlNDIHNoZWxsJ3MgYWdlbnQgZmVhdHVyZTogY29kZSBpcyBydW5u aW5nCisgICAgICAgIGRpZmZlcmVudCBWTSBpbiB0aGUgZGlmZmVyZW50IHRocmVhZC4gQW5kIHdl IGhhdmUgbm8gZ3VhcmFudGVlIHRoYXQgdGhpcyB0aHJlYWQgZGVzdHJveXMKKyAgICAgICAgVk0g d2hlbiB0aGUgbWFpbiB0aHJlYWQgaXMgZmluaXNoZWQuIFNvIHRoaXMgaXMgcG9zc2libGUgdGhh dCBieXRlY29kZSB1c2VkIGluIHRoYXQgdGhyZWFkCisgICAgICAgIGlzIG5vdCBjb21taXR0ZWQu CisKKyAgICAgICAgV2UgdXNlIE9wdGlvbnM6OmZvcmNlRGlza0NhY2hlJ3MgUkVMRUFTRV9BU1NF UlQgb25seSBpZiBpdCBpcyBpbiBtYWluIHRocmVhZC4KKworICAgICAgICAqIHJ1bnRpbWUvQ29k ZUNhY2hlLmg6CisKIDIwMjEtMDItMjUgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBbSlNDXSBGaXggdHlwbyBpbiB3YXNtIGVycm9yIG1lc3NhZ2UKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvZGVDYWNoZS5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmgKaW5kZXggNjBhNzdkMmFmM2FkMGFi NzQyYjQwNDdiNDk2NzJmOGYzMjE5Yzk3My4uMGRkZjY0OTFlNzY2NjY0NmFiNTliODY5YjQxNjNm MDg3NDBmNDFiNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29k ZUNhY2hlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmgK QEAgLTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlICJVbmxpbmtlZEZ1bmN0aW9uQ29kZUJsb2NrLmgi CiAjaW5jbHVkZSAiVW5saW5rZWRNb2R1bGVQcm9ncmFtQ29kZUJsb2NrLmgiCiAjaW5jbHVkZSAi VW5saW5rZWRQcm9ncmFtQ29kZUJsb2NrLmgiCisjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4K IAogbmFtZXNwYWNlIEpTQyB7CiAKQEAgLTE2Myw4ICsxNjQsMTAgQEAgY2xhc3MgQ29kZUNhY2hl TWFwIHsKICAgICBmZXRjaEZyb21EaXNrKFZNJiB2bSwgY29uc3QgU291cmNlQ29kZUtleSYga2V5 KQogICAgIHsKICAgICAgICAgVW5saW5rZWRDb2RlQmxvY2tUeXBlKiBjb2RlQmxvY2sgPSBmZXRj aEZyb21EaXNrSW1wbDxVbmxpbmtlZENvZGVCbG9ja1R5cGU+KHZtLCBrZXkpOwotICAgICAgICBp ZiAoVU5MSUtFTFkoT3B0aW9uczo6Zm9yY2VEaXNrQ2FjaGUoKSkpCi0gICAgICAgICAgICBSRUxF QVNFX0FTU0VSVChjb2RlQmxvY2spOworICAgICAgICBpZiAoVU5MSUtFTFkoT3B0aW9uczo6Zm9y Y2VEaXNrQ2FjaGUoKSkpIHsKKyAgICAgICAgICAgIGlmIChpc01haW5UaHJlYWQoKSkKKyAgICAg ICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChjb2RlQmxvY2spOworICAgICAgICB9CiAgICAgICAg IHJldHVybiBjb2RlQmxvY2s7CiAgICAgfQogCg==