221877 2021-02-14 13:43:27 -0800 Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth 2021-02-15 03:06:14 -0800 1 1 1 Unclassified WebKit CSS Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr svillar webkit-bug-importer oldest_to_newest 1729008 0 rbuis 2021-02-14 13:43:27 -0800 Improve readability in RenderFlexibleBox::childIntrinsicLogicalWidth. 1729009 1 420250 rbuis 2021-02-14 13:45:31 -0800 Created attachment 420250 Patch 1729076 2 420250 svillar 2021-02-15 01:46:45 -0800 Comment on attachment 420250 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420250&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:491 > + Optional<LayoutUnit> childOverrideWidth; Nit: override -> overriding (we have recently switched the naming) 1729080 3 420286 rbuis 2021-02-15 02:02:21 -0800 Created attachment 420286 Patch 1729102 4 ews-feeder 2021-02-15 03:05:54 -0800 Committed r272846: <https://commits.webkit.org/r272846> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420286. 1729103 5 webkit-bug-importer 2021-02-15 03:06:14 -0800 <rdar://problem/74344028> 420250 2021-02-14 13:45:31 -0800 2021-02-15 02:02:16 -0800 Patch bug-221877-20210214224529.patch text/plain 2464 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRmZDJjZjM3ZjgzZDU5 ZjYyNzk4MzVhYjBkMmYyZWZjMWYxMDQ3NS4uMjNiZDMwNTU0MGM5YzhkMmFlZjMwMTI0N2Y2NWI1 ZDliZjViNWI4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTE0ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgSW1wcm92ZSByZWFkYWJpbGl0eSBp biBSZW5kZXJGbGV4aWJsZUJveDo6Y2hpbGRJbnRyaW5zaWNMb2dpY2FsV2lkdGgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTg3NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcHJvdmUgcmVhZGFiaWxp dHkgaW4gUmVuZGVyRmxleGlibGVCb3g6OmNoaWxkSW50cmluc2ljTG9naWNhbFdpZHRoIGJ5Cisg ICAgICAgIHVzaW5nIE9wdGlvbmFsIGluc3RlYWQgb2YgLTEsIHdoaWNoIGlzIGEgbWFnaWMgdmFs dWUgdGhhdCBlbmRzIHVwIG5vdAorICAgICAgICBiZWluZyB1c2VkLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZs ZXhpYmxlQm94OjpjaGlsZEludHJpbnNpY0xvZ2ljYWxXaWR0aCBjb25zdCk6CisKIDIwMjEtMDIt MTIgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gU291 bmQgZG9lcyBub3QgcGxheSBvbiBZb3VUdWJlIGFmdGVyIHN3aXRjaGluZyBiYWNrIHRvIGZvcmVn cm91bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJs ZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3Bw CmluZGV4IDY1YmYxZjQzYWEyYWY5MDY1MWUxYWNmNWVhMTBiOWM4MDU2NmJmNzUuLmI0ZmNkZjc3 OWFlMzgzNTVjODU4ZjdhZWU0NTIxMWRjY2JjYjA1NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcApAQCAtNDg4LDE1ICs0ODgsMTYgQEAgTGF5 b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6Y2hpbGRJbnRyaW5zaWNMb2dpY2FsV2lkdGgoY29u c3QgUmVuZGVyQm94JiBjaGlsZCkKICAgICBpZiAoY2hpbGRDcm9zc1NpemVJc0RlZmluaXRlKGNo aWxkLCBjaGlsZC5zdHlsZSgpLmxvZ2ljYWxXaWR0aCgpKSkKICAgICAgICAgcmV0dXJuIGNoaWxk LmxvZ2ljYWxXaWR0aCgpOwogCi0gICAgLy8gVGVtcG9yYXJpbHkgY2xlYXIgcG90ZW50aWFsIG92 ZXJyaWRlcyB0byBjb21wdXRlIHRoZSBsb2dpY2FsIHdpZHRoIG90aGVyd2lzZSBpdCdsbCByZXR1 cm4gdGhlIG92ZXJyaWRlIHNpemUuCi0gICAgYm9vbCBjaGlsZEhhc092ZXJyaWRlV2lkdGggPSBj aGlsZC5oYXNPdmVycmlkaW5nTG9naWNhbFdpZHRoKCk7Ci0gICAgYXV0byBvdmVycmlkZVdpZHRo ID0gY2hpbGRIYXNPdmVycmlkZVdpZHRoID8gY2hpbGQub3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aCgp IDogLTFfbHU7Ci0gICAgaWYgKGNoaWxkSGFzT3ZlcnJpZGVXaWR0aCkKKyAgICBPcHRpb25hbDxM YXlvdXRVbml0PiBjaGlsZE92ZXJyaWRlV2lkdGg7CisgICAgaWYgKGNoaWxkLmhhc092ZXJyaWRp bmdMb2dpY2FsV2lkdGgoKSkgeworICAgICAgICAvLyBUZW1wb3JhcmlseSBjbGVhciBwb3RlbnRp YWwgb3ZlcnJpZGVzIHRvIGNvbXB1dGUgdGhlIGxvZ2ljYWwgd2lkdGggb3RoZXJ3aXNlIGl0J2xs IHJldHVybiB0aGUgb3ZlcnJpZGUgc2l6ZS4KKyAgICAgICAgY2hpbGRPdmVycmlkZVdpZHRoID0g Y2hpbGQub3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aCgpOwogICAgICAgICBjb25zdF9jYXN0PFJlbmRl ckJveCo+KCZjaGlsZCktPmNsZWFyT3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aCgpOworICAgIH0KICAg ICBMb2dpY2FsRXh0ZW50Q29tcHV0ZWRWYWx1ZXMgdmFsdWVzOwogICAgIGNoaWxkLmNvbXB1dGVM b2dpY2FsV2lkdGhJbkZyYWdtZW50KHZhbHVlcyk7Ci0gICAgaWYgKGNoaWxkSGFzT3ZlcnJpZGVX aWR0aCkKLSAgICAgICAgY29uc3RfY2FzdDxSZW5kZXJCb3gqPigmY2hpbGQpLT5zZXRPdmVycmlk aW5nTG9naWNhbFdpZHRoKG92ZXJyaWRlV2lkdGgpOworICAgIGlmIChjaGlsZE92ZXJyaWRlV2lk dGgpCisgICAgICAgIGNvbnN0X2Nhc3Q8UmVuZGVyQm94Kj4oJmNoaWxkKS0+c2V0T3ZlcnJpZGlu Z0xvZ2ljYWxXaWR0aCgqY2hpbGRPdmVycmlkZVdpZHRoKTsKICAgICByZXR1cm4gdmFsdWVzLm1f ZXh0ZW50OwogfQogCg== 420286 2021-02-15 02:02:21 -0800 2021-02-15 03:05:55 -0800 Patch bug-221877-20210215110220.patch text/plain 2505 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyODQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2NiNTRiNzVmZmFmNzdj N2QyM2FjNGQxM2E4YjQxZTk2MmNkNmIyYy4uMDdlZjQyMWU4MDQxZjU2MTA5OGM3YmE2OWExNDYy YWE1OGZjNDQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTE1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgSW1wcm92ZSByZWFkYWJpbGl0eSBp biBSZW5kZXJGbGV4aWJsZUJveDo6Y2hpbGRJbnRyaW5zaWNMb2dpY2FsV2lkdGgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTg3NworCisgICAgICAg IFJldmlld2VkIGJ5IFNlcmdpbyBWaWxsYXIgU2VuaW4uCisKKyAgICAgICAgSW1wcm92ZSByZWFk YWJpbGl0eSBpbiBSZW5kZXJGbGV4aWJsZUJveDo6Y2hpbGRJbnRyaW5zaWNMb2dpY2FsV2lkdGgg YnkKKyAgICAgICAgdXNpbmcgT3B0aW9uYWwgaW5zdGVhZCBvZiAtMSwgd2hpY2ggaXMgYSBtYWdp YyB2YWx1ZSB0aGF0IGVuZHMgdXAgbm90CisgICAgICAgIGJlaW5nIHVzZWQuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyRmxleGlibGVCb3g6OmNoaWxkSW50cmluc2ljTG9naWNhbFdpZHRoIGNvbnN0KToKKwogMjAy MS0wMi0xMiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAg ICAgICBEb24ndCB1cGRhdGUgZm9ybSBjb250cm9sIGVsZW1lbnRzIHZhbGlkaXR5IHN0YXR1cyBp ZiB0aGV5IGFyZSBkZXRhY2hlZCBmcm9tIHRoZSBkb2N1bWVudC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCmluZGV4IDY1YmYxZjQzYWEyYWY5MDY1 MWUxYWNmNWVhMTBiOWM4MDU2NmJmNzUuLmI2MzAwN2VhMjMzYTc3ZGNmZWU1ZGNiZDc0NzhiYTk4 NGExODQ1MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4 aWJsZUJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxl Qm94LmNwcApAQCAtNDg4LDE1ICs0ODgsMTYgQEAgTGF5b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJv eDo6Y2hpbGRJbnRyaW5zaWNMb2dpY2FsV2lkdGgoY29uc3QgUmVuZGVyQm94JiBjaGlsZCkKICAg ICBpZiAoY2hpbGRDcm9zc1NpemVJc0RlZmluaXRlKGNoaWxkLCBjaGlsZC5zdHlsZSgpLmxvZ2lj YWxXaWR0aCgpKSkKICAgICAgICAgcmV0dXJuIGNoaWxkLmxvZ2ljYWxXaWR0aCgpOwogCi0gICAg Ly8gVGVtcG9yYXJpbHkgY2xlYXIgcG90ZW50aWFsIG92ZXJyaWRlcyB0byBjb21wdXRlIHRoZSBs b2dpY2FsIHdpZHRoIG90aGVyd2lzZSBpdCdsbCByZXR1cm4gdGhlIG92ZXJyaWRlIHNpemUuCi0g ICAgYm9vbCBjaGlsZEhhc092ZXJyaWRlV2lkdGggPSBjaGlsZC5oYXNPdmVycmlkaW5nTG9naWNh bFdpZHRoKCk7Ci0gICAgYXV0byBvdmVycmlkZVdpZHRoID0gY2hpbGRIYXNPdmVycmlkZVdpZHRo ID8gY2hpbGQub3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aCgpIDogLTFfbHU7Ci0gICAgaWYgKGNoaWxk SGFzT3ZlcnJpZGVXaWR0aCkKKyAgICBPcHRpb25hbDxMYXlvdXRVbml0PiBjaGlsZE92ZXJyaWRp bmdXaWR0aDsKKyAgICBpZiAoY2hpbGQuaGFzT3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aCgpKSB7Cisg ICAgICAgIC8vIFRlbXBvcmFyaWx5IGNsZWFyIHBvdGVudGlhbCBvdmVycmlkZXMgdG8gY29tcHV0 ZSB0aGUgbG9naWNhbCB3aWR0aCBvdGhlcndpc2UgaXQnbGwgcmV0dXJuIHRoZSBvdmVycmlkZSBz aXplLgorICAgICAgICBjaGlsZE92ZXJyaWRpbmdXaWR0aCA9IGNoaWxkLm92ZXJyaWRpbmdMb2dp Y2FsV2lkdGgoKTsKICAgICAgICAgY29uc3RfY2FzdDxSZW5kZXJCb3gqPigmY2hpbGQpLT5jbGVh ck92ZXJyaWRpbmdMb2dpY2FsV2lkdGgoKTsKKyAgICB9CiAgICAgTG9naWNhbEV4dGVudENvbXB1 dGVkVmFsdWVzIHZhbHVlczsKICAgICBjaGlsZC5jb21wdXRlTG9naWNhbFdpZHRoSW5GcmFnbWVu dCh2YWx1ZXMpOwotICAgIGlmIChjaGlsZEhhc092ZXJyaWRlV2lkdGgpCi0gICAgICAgIGNvbnN0 X2Nhc3Q8UmVuZGVyQm94Kj4oJmNoaWxkKS0+c2V0T3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aChvdmVy cmlkZVdpZHRoKTsKKyAgICBpZiAoY2hpbGRPdmVycmlkaW5nV2lkdGgpCisgICAgICAgIGNvbnN0 X2Nhc3Q8UmVuZGVyQm94Kj4oJmNoaWxkKS0+c2V0T3ZlcnJpZGluZ0xvZ2ljYWxXaWR0aCgqY2hp bGRPdmVycmlkaW5nV2lkdGgpOwogICAgIHJldHVybiB2YWx1ZXMubV9leHRlbnQ7CiB9CiAK