<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22187</bug_id>
          
          <creation_ts>2008-11-11 15:08:00 -0800</creation_ts>
          <short_desc>CLEARTYPE_QUALITY flag is not supported on Win2000</short_desc>
          <delta_ts>2008-11-11 15:34:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P4</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nathan Howell">nathanhowell</reporter>
          <assigned_to name="Ada Chan">adachan</assigned_to>
          <cc>mitz</cc>
    
    <cc>sfalken</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>98354</commentid>
    <comment_count>0</comment_count>
    <who name="Nathan Howell">nathanhowell</who>
    <bug_when>2008-11-11 15:08:00 -0800</bug_when>
    <thetext>OS version numbers are referenced here: http://msdn.microsoft.com/en-us/library/aa383745(VS.85).aspx

LOGFONT says ClearType is supported on XP and up: http://msdn.microsoft.com/en-us/library/ms533931(VS.85).aspx


I&apos;d guess this is a bug in the older Win2003 R2 Platform SDK. The current code breaks when compiling against the Win2008 SP1 (v6.1) PSDK, I&apos;ve included the the small change required to WebKitLibraries to get things building again.


Index: WebKitLibraries/win/tools/vsprops/common.vsprops
===================================================================
--- WebKitLibraries/win/tools/vsprops/common.vsprops    (revision 38308)
+++ WebKitLibraries/win/tools/vsprops/common.vsprops    (working copy)
@@ -9,7 +9,7 @@
        &lt;Tool
                Name=&quot;VCCLCompilerTool&quot;
                AdditionalOptions=&quot;/GS&quot;
-               PreprocessorDefinitions=&quot;WIN32;_WINDOWS;_WIN32_WINNT=0x500;_CRT_SECURE_NO_DEPRECATE;_SCL_SECURE_NO_DEPRECATE;__PRODUCTION__=0$(PRODUCTION);_HAS_EXCEPTIONS=0&quot;
+               PreprocessorDefinitions=&quot;WIN32;_WINDOWS;_WIN32_WINNT=0x501;_CRT_SECURE_NO_DEPRECATE;_SCL_SECURE_NO_DEPRECATE;__PRODUCTION__=0$(PRODUCTION);_HAS_EXCEPTIONS=0&quot;
                ExceptionHandling=&quot;0&quot;
                RuntimeTypeInfo=&quot;false&quot;
                WarningLevel=&quot;4&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>98377</commentid>
    <comment_count>1</comment_count>
      <attachid>25077</attachid>
    <who name="Ada Chan">adachan</who>
    <bug_when>2008-11-11 15:23:12 -0800</bug_when>
    <thetext>Created attachment 25077
Proposed patch - update window versions</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>98379</commentid>
    <comment_count>2</comment_count>
    <who name="Ada Chan">adachan</who>
    <bug_when>2008-11-11 15:34:04 -0800</bug_when>
    <thetext>I&apos;ve checked in r38319 that updates all the window version numbers to correspond to Windows XP.  Very similar to the change that Nathan proposed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25077</attachid>
            <date>2008-11-11 15:23:12 -0800</date>
            <delta_ts>2008-11-11 15:24:07 -0800</delta_ts>
            <desc>Proposed patch - update window versions</desc>
            <filename>20081111.patch.txt</filename>
            <type>text/plain</type>
            <size>1160</size>
            <attacher name="Ada Chan">adachan</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MzE4
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMTEt
MTEgIEFkYSBDaGFuICA8YWRhY2hhbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIHdpbmRv
dyB2ZXJzaW9ucyB0byBjb3JyZXNwb25kIHRvIFdpbmRvd3MgWFAuCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9jb21t
b24udnNwcm9wczoKKwogMjAwOC0xMC0yMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw
bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2YW4uCkluZGV4OiB3aW4v
dG9vbHMvdnNwcm9wcy9jb21tb24udnNwcm9wcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB3aW4vdG9vbHMvdnNw
cm9wcy9jb21tb24udnNwcm9wcwkocmV2aXNpb24gMzgzMTgpCisrKyB3aW4vdG9vbHMvdnNwcm9w
cy9jb21tb24udnNwcm9wcwkod29ya2luZyBjb3B5KQpAQCAtOSw3ICs5LDcgQEAKIAk8VG9vbAog
CQlOYW1lPSJWQ0NMQ29tcGlsZXJUb29sIgogCQlBZGRpdGlvbmFsT3B0aW9ucz0iL0dTIgotCQlQ
cmVwcm9jZXNzb3JEZWZpbml0aW9ucz0iV0lOMzI7X1dJTkRPV1M7X1dJTjMyX1dJTk5UPTB4NTAw
O19DUlRfU0VDVVJFX05PX0RFUFJFQ0FURTtfU0NMX1NFQ1VSRV9OT19ERVBSRUNBVEU7X19QUk9E
VUNUSU9OX189MCQoUFJPRFVDVElPTik7X0hBU19FWENFUFRJT05TPTAiCisJCVByZXByb2Nlc3Nv
ckRlZmluaXRpb25zPSJXSU4zMjtfV0lORE9XUztXSU5WRVI9MHg1MDE7X1dJTjMyX1dJTk5UPTB4
NTAxO19XSU4zMl9JRT0weDYwMDtfQ1JUX1NFQ1VSRV9OT19ERVBSRUNBVEU7X1NDTF9TRUNVUkVf
Tk9fREVQUkVDQVRFO19fUFJPRFVDVElPTl9fPTAkKFBST0RVQ1RJT04pO19IQVNfRVhDRVBUSU9O
Uz0wIgogCQlFeGNlcHRpb25IYW5kbGluZz0iMCIKIAkJUnVudGltZVR5cGVJbmZvPSJmYWxzZSIK
IAkJV2FybmluZ0xldmVsPSI0Igo=
</data>
<flag name="review"
          id="11537"
          type_id="1"
          status="+"
          setter="sfalken"
    />
          </attachment>
      

    </bug>

</bugzilla>