221864 2021-02-12 17:11:32 -0800 Remove some unused methods in MarkedBlock and PreciseAllocation. 2021-02-12 17:29:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1728876 0 mark.lam 2021-02-12 17:11:32 -0800 Patch coming. 1728878 1 420199 mark.lam 2021-02-12 17:12:56 -0800 Created attachment 420199 proposed patch. 1728879 2 420199 ysuzuki 2021-02-12 17:22:18 -0800 Comment on attachment 420199 proposed patch. r=me 1728883 3 mark.lam 2021-02-12 17:28:26 -0800 Thanks for the review. Landed in r272825: <http://trac.webkit.org/r272825>. 1728885 4 webkit-bug-importer 2021-02-12 17:29:16 -0800 <rdar://problem/74299466> 420199 2021-02-12 17:12:56 -0800 2021-02-12 17:22:18 -0800 proposed patch. bug-221864.patch text/plain 4169 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcyODI0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDIxLTAyLTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgc29tZSB1bnVzZWQgbWV0aG9kcyBpbiBNYXJrZWRCbG9jayBhbmQgUHJlY2lzZUFsbG9j YXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjE4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGhlYXAvTWFya2VkQmxvY2suaDoKKyAgICAgICAgKEpTQzo6TWFya2VkQmxvY2s6OkhhbmRsZTo6 dmlzaXRXZWFrU2V0KTogRGVsZXRlZC4KKyAgICAgICAgKEpTQzo6TWFya2VkQmxvY2s6OkhhbmRs ZTo6cmVhcFdlYWtTZXQpOiBEZWxldGVkLgorICAgICAgICAqIGhlYXAvUHJlY2lzZUFsbG9jYXRp b24uY3BwOgorICAgICAgICAoSlNDOjpQcmVjaXNlQWxsb2NhdGlvbjo6c2hyaW5rKTogRGVsZXRl ZC4KKyAgICAgICAgKEpTQzo6UHJlY2lzZUFsbG9jYXRpb246OnZpc2l0V2Vha1NldCk6IERlbGV0 ZWQuCisgICAgICAgIChKU0M6OlByZWNpc2VBbGxvY2F0aW9uOjpyZWFwV2Vha1NldCk6IERlbGV0 ZWQuCisgICAgICAgICogaGVhcC9QcmVjaXNlQWxsb2NhdGlvbi5oOgorCiAyMDIxLTAyLTEyICBN aWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFtBUk02NGVdIEhh cmRlbiBNYWNoIGV4Y2VwdGlvbiBoYW5kbGluZwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvTWFya2VkQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9NYXJrZWRCbG9jay5oCShyZXZpc2lvbiAyNzI3OTcpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9NYXJrZWRCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAog LyoKICAqICBDb3B5cmlnaHQgKEMpIDE5OTktMjAwMCBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUu b3JnKQogICogIENvcHlyaWdodCAoQykgMjAwMSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQot ICogIENvcHlyaWdodCAoQykgMjAwMy0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDMtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl ZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRo ZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGljCkBAIC0xNTEsOSArMTUxLDYgQEAgcHVibGljOgog ICAgICAgICAKICAgICAgICAgdm9pZCBzaHJpbmsoKTsKICAgICAgICAgICAgIAotICAgICAgICB2 b2lkIHZpc2l0V2Vha1NldChTbG90VmlzaXRvciYpOwotICAgICAgICB2b2lkIHJlYXBXZWFrU2V0 KCk7Ci0gICAgICAgICAgICAKICAgICAgICAgLy8gV2hpbGUgYWxsb2NhdGluZyBmcm9tIGEgZnJl ZSBsaXN0LCBNYXJrZWRCbG9jayB0ZW1wb3JhcmlseSBoYXMgYm9ndXMKICAgICAgICAgLy8gY2Vs bCBsaXZlbmVzcyBkYXRhLiBUbyByZXN0b3JlIGFjY3VyYXRlIGNlbGwgbGl2ZW5lc3MgZGF0YSwg Y2FsbCBvbmUKICAgICAgICAgLy8gb2YgdGhlc2UgZnVuY3Rpb25zOgpAQCAtNDk4LDE2ICs0OTUs NiBAQCBpbmxpbmUgdm9pZCBNYXJrZWRCbG9jazo6SGFuZGxlOjpzaHJpbmsoCiAgICAgbV93ZWFr U2V0LnNocmluaygpOwogfQogCi1pbmxpbmUgdm9pZCBNYXJrZWRCbG9jazo6SGFuZGxlOjp2aXNp dFdlYWtTZXQoU2xvdFZpc2l0b3ImIHZpc2l0b3IpCi17Ci0gICAgcmV0dXJuIG1fd2Vha1NldC52 aXNpdCh2aXNpdG9yKTsKLX0KLQotaW5saW5lIHZvaWQgTWFya2VkQmxvY2s6OkhhbmRsZTo6cmVh cFdlYWtTZXQoKQotewotICAgIG1fd2Vha1NldC5yZWFwKCk7Ci19Ci0KIGlubGluZSBzaXplX3Qg TWFya2VkQmxvY2s6OkhhbmRsZTo6Y2VsbFNpemUoKQogewogICAgIHJldHVybiBtX2F0b21zUGVy Q2VsbCAqIGF0b21TaXplOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUHJlY2lz ZUFsbG9jYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L1ByZWNpc2VBbGxvY2F0aW9uLmNwcAkocmV2aXNpb24gMjcyNzk3KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvUHJlY2lzZUFsbG9jYXRpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x LDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNi0yMDIwIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNi0yMDIxIEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNv dXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAt MTk1LDIxICsxOTUsNiBAQCB2b2lkIFByZWNpc2VBbGxvY2F0aW9uOjpsYXN0Q2hhbmNlVG9GaW5h CiAgICAgc3dlZXAoKTsKIH0KIAotdm9pZCBQcmVjaXNlQWxsb2NhdGlvbjo6c2hyaW5rKCkKLXsK LSAgICBtX3dlYWtTZXQuc2hyaW5rKCk7Ci19Ci0KLXZvaWQgUHJlY2lzZUFsbG9jYXRpb246OnZp c2l0V2Vha1NldChTbG90VmlzaXRvciYgdmlzaXRvcikKLXsKLSAgICBtX3dlYWtTZXQudmlzaXQo dmlzaXRvcik7Ci19Ci0KLXZvaWQgUHJlY2lzZUFsbG9jYXRpb246OnJlYXBXZWFrU2V0KCkKLXsK LSAgICByZXR1cm4gbV93ZWFrU2V0LnJlYXAoKTsKLX0KLQogdm9pZCBQcmVjaXNlQWxsb2NhdGlv bjo6ZmxpcCgpCiB7CiAgICAgQVNTRVJUKGhlYXAoKS0+Y29sbGVjdGlvblNjb3BlKCkgPT0gQ29s bGVjdGlvblNjb3BlOjpGdWxsKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1By ZWNpc2VBbGxvY2F0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvUHJlY2lzZUFsbG9jYXRpb24uaAkocmV2aXNpb24gMjcyNzk3KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvUHJlY2lzZUFsbG9jYXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtMSw1 ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAxOSBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMSBBcHBsZSBJbmMuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3Vy Y2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTgw LDExICs4MCw2IEBAIHB1YmxpYzoKICAgICB1bnNpZ25lZCBpbmRleEluU3BhY2UoKSB7IHJldHVy biBtX2luZGV4SW5TcGFjZTsgfQogICAgIHZvaWQgc2V0SW5kZXhJblNwYWNlKHVuc2lnbmVkIGlu ZGV4SW5TcGFjZSkgeyBtX2luZGV4SW5TcGFjZSA9IGluZGV4SW5TcGFjZTsgfQogICAgIAotICAg IHZvaWQgc2hyaW5rKCk7Ci0gICAgCi0gICAgdm9pZCB2aXNpdFdlYWtTZXQoU2xvdFZpc2l0b3Im KTsKLSAgICB2b2lkIHJlYXBXZWFrU2V0KCk7Ci0gICAgCiAgICAgdm9pZCBjbGVhck5ld2x5QWxs b2NhdGVkKCkgeyBtX2lzTmV3bHlBbGxvY2F0ZWQgPSBmYWxzZTsgfQogICAgIHZvaWQgZmxpcCgp OwogICAgIAo=