221855 2021-02-12 16:06:15 -0800 _W3CTestConverter tests don't run on Windows 2021-02-17 18:34:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 221815 1 don.olmstead don.olmstead ews-watchlist glenn jbedard webkit-bug-importer youennf oldest_to_newest 1728832 0 don.olmstead 2021-02-12 16:06:15 -0800 When running Tools/Scripts/test-webkitpy on Windows saw the following when running the webkitpy.w3c.test_converter_unittest.W3CTestConverterTest test suite. Traceback (most recent call last): File "C:\tools\python3\lib\sre_parse.py", line 1039, in parse_template this = chr(ESCAPES[this][1]) KeyError: '\\L' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "C:\webkit\Tools\Scripts\webkitpy\w3c\test_converter_unittest.py", line 89, in test_convert_for_webkit_nothing_to_convert converter.feed(test_html) File "C:\tools\python3\lib\html\parser.py", line 110, in feed self.goahead(0) File "C:\tools\python3\lib\html\parser.py", line 170, in goahead k = self.parse_starttag(i) File "C:\tools\python3\lib\html\parser.py", line 342, in parse_starttag self.handle_startendtag(tag, attrs) File "C:\webkit\Tools\Scripts\webkitpy\w3c\test_converter.py", line 258, in handle_startendtag self.convert_attributes_if_needed(tag, attrs) File "C:\webkit\Tools\Scripts\webkitpy\w3c\test_converter.py", line 214, in convert_attributes_if_needed new_path = re.sub(self.test_harness_re, self.new_test_harness_path + '/testharness', attr[1]) File "C:\tools\python3\lib\re.py", line 210, in sub return _compile(pattern, flags).sub(repl, string, count) File "C:\tools\python3\lib\re.py", line 327, in _subx template = _compile_repl(template, pattern) File "C:\tools\python3\lib\re.py", line 318, in _compile_repl return sre_parse.parse_template(repl, pattern) File "C:\tools\python3\lib\sre_parse.py", line 1042, in parse_template raise s.error('bad escape %s' % this, len(this)) re.error: bad escape \L at position 8 The issue stems from Window's path separator being '\' which gets used when creating a regex. 1728834 1 420188 don.olmstead 2021-02-12 16:08:46 -0800 Created attachment 420188 WIP Patch This fixes the issue on Windows. I'm not entirely sure the workflow so I'd like to run the whole thing through Windows to make sure this actually works works. 1730180 2 youennf 2021-02-17 00:28:29 -0800 LGTM, not sure why webkitpy is unhappy though. Let's try rerunning it. 1730617 3 420747 don.olmstead 2021-02-17 16:06:53 -0800 Created attachment 420747 Patch 1730701 4 ews-feeder 2021-02-17 18:33:57 -0800 Committed r273057: <https://commits.webkit.org/r273057> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420747. 1730702 5 webkit-bug-importer 2021-02-17 18:34:16 -0800 <rdar://problem/74459518> 420188 2021-02-12 16:08:46 -0800 2021-02-17 16:06:53 -0800 WIP Patch bug-221855.diff text/plain 1847 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVyLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9jb252ZXJ0ZXIucHkKaW5kZXggN2Ni YzhmZTliZGMzLi43MGIyYzBhYjAzNDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdzNjL3Rlc3RfY29udmVydGVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNj L3Rlc3RfY29udmVydGVyLnB5CkBAIC0yOSw2ICsyOSw3IEBACiAKIGltcG9ydCBqc29uCiBpbXBv cnQgbG9nZ2luZworaW1wb3J0IG9zCiBpbXBvcnQgcmUKIGltcG9ydCBzeXMKIApAQCAtODMsNyAr ODQsNyBAQCBjbGFzcyBfVzNDVGVzdENvbnZlcnRlcihIVE1MUGFyc2VyKToKIAogICAgICAgICBy ZXNvdXJjZXNfcGF0aCA9IHNlbGYucGF0aF9mcm9tX3dlYmtpdF9yb290KCdMYXlvdXRUZXN0cycs ICdyZXNvdXJjZXMnKQogICAgICAgICByZXNvdXJjZXNfcmVscGF0aCA9IHNlbGYuX2ZpbGVzeXN0 ZW0ucmVscGF0aChyZXNvdXJjZXNfcGF0aCwgbmV3X3BhdGgpCi0gICAgICAgIHNlbGYubmV3X3Rl c3RfaGFybmVzc19wYXRoID0gcmVzb3VyY2VzX3JlbHBhdGgKKyAgICAgICAgc2VsZi5uZXdfdGVz dF9oYXJuZXNzX3BhdGggPSByZXNvdXJjZXNfcmVscGF0aC5yZXBsYWNlKG9zLnNlcCwgJy8nKQog ICAgICAgICBzZWxmLmNvbnZlcnRfdGVzdF9oYXJuZXNzX2xpbmtzID0gY29udmVydF90ZXN0X2hh cm5lc3NfbGlua3MKIAogICAgICAgICAjIFRoZXNlIHNldHRpbmdzIG1pZ2h0IHZhcnkgYmV0d2Vl biBXZWJLaXQgYW5kIEJsaW5rCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3cz Yy90ZXN0X2NvbnZlcnRlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNj L3Rlc3RfY29udmVydGVyX3VuaXR0ZXN0LnB5CmluZGV4IGU2MDYxMTYwMTZjMy4uZjYyNTcyNmY2 YWVjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRl cl91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZl cnRlcl91bml0dGVzdC5weQpAQCAtMzcwLDcgKzM3MCw3IEBAIENPTlRFTlQgT0YgVEVTVAogICAg ICAgICBzZWxmLmFzc2VydEVxdWFscyhsZW4oY29udmVydGVkLmZpbmRBbGwoc3JjPW9yaWdfcGF0 aF9wYXR0ZXJuKSksIDAsICd0ZXN0aGFybmVzcyBzcmMgcGF0aCB3YXMgbm90IGNvbnZlcnRlZCcp CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKGxlbihjb252ZXJ0ZWQuZmluZEFsbChocmVmPW9y aWdfcGF0aF9wYXR0ZXJuKSksIDAsICd0ZXN0aGFybmVzcyBocmVmIHBhdGggd2FzIG5vdCBjb252 ZXJ0ZWQnKQogCi0gICAgICAgIG5ld19yZWxwYXRoID0gb3MucGF0aC5yZWxwYXRoKHJlc291cmNl c19kaXIsIHRlc3RfcGF0aCkKKyAgICAgICAgbmV3X3JlbHBhdGggPSBvcy5wYXRoLnJlbHBhdGgo cmVzb3VyY2VzX2RpciwgdGVzdF9wYXRoKS5yZXBsYWNlKG9zLnNlcCwgJy8nKQogICAgICAgICBy ZWxwYXRoX3BhdHRlcm4gPSByZS5jb21waWxlKG5ld19yZWxwYXRoKQogICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhsZW4oY29udmVydGVkLmZpbmRBbGwoc3JjPXJlbHBhdGhfcGF0dGVybikpLCBu dW1fc3JjX3BhdGhzLCAndGVzdGhhcm5lc3Mgc3JjIHJlbGF0aXZlIHBhdGggbm90IGNvcnJlY3Qn KQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhsZW4oY29udmVydGVkLmZpbmRBbGwoaHJlZj1y ZWxwYXRoX3BhdHRlcm4pKSwgbnVtX2hyZWZfcGF0aHMsICd0ZXN0aGFybmVzcyBocmVmIHJlbGF0 aXZlIHBhdGggbm90IGNvcnJlY3QnKQo= 420747 2021-02-17 16:06:53 -0800 2021-02-17 18:33:58 -0800 Patch bug-221855.diff text/plain 2804 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1ODVi MTg4MjIyMjkuLmYwMWI5M2MxNDJlNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAyLTE3ICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgX1czQ1Rlc3RDb252ZXJ0ZXIg dGVzdHMgZG9uJ3QgcnVuIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyMTg1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluIF9XM0NUZXN0Q29udmVydGVyIGl0IHJldHJpZXZlcyBhIHJl bGF0aXZlIHBhdGggYW5kIHRoZW4gdXNlcyB0aGF0IHRvIHBvcHVsYXRlIGEKKyAgICAgICAgcmVn dWxhciBleHByZXNzaW9uLiBPbiBXaW5kb3dzIHRoZSBwYXRoIHNlcGFyYXRvciBpcyBgXGAgd2hp Y2ggY2F1c2VzIGEgcmUuZXJyb3IgZHVlIHRvCisgICAgICAgIGEgYmFkIGVzY2FwZS4gTm9ybWFs aXplIHRoZSBwYXRoIHRvIHVzZSBgL2AgaW4gdGhpcyBjb2RlLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS93M2MvdGVzdF9jb252ZXJ0ZXIucHk6CisgICAgICAgIChfVzNDVGVzdENvbnZl cnRlci5fX2luaXRfXyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9jb252 ZXJ0ZXJfdW5pdHRlc3QucHk6CisgICAgICAgIChXM0NUZXN0Q29udmVydGVyVGVzdC52ZXJpZnlf dGVzdF9oYXJuZXNzX3BhdGhzKToKKwogMjAyMS0wMi0xNyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9s bXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtQeXRob24tM10gVW5pY29kZURlY29kZUVycm9y IHdoZW4gY2hlY2tpbmcgZm9yIGFuIGludGVycHJldGVyIG9uIFdpbmRvd3MKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVyLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS93M2MvdGVzdF9jb252ZXJ0ZXIucHkKaW5kZXggN2NiYzhmZTliZGMzLi43 MGIyYzBhYjAzNDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3Rf Y29udmVydGVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVy dGVyLnB5CkBAIC0yOSw2ICsyOSw3IEBACiAKIGltcG9ydCBqc29uCiBpbXBvcnQgbG9nZ2luZwor aW1wb3J0IG9zCiBpbXBvcnQgcmUKIGltcG9ydCBzeXMKIApAQCAtODMsNyArODQsNyBAQCBjbGFz cyBfVzNDVGVzdENvbnZlcnRlcihIVE1MUGFyc2VyKToKIAogICAgICAgICByZXNvdXJjZXNfcGF0 aCA9IHNlbGYucGF0aF9mcm9tX3dlYmtpdF9yb290KCdMYXlvdXRUZXN0cycsICdyZXNvdXJjZXMn KQogICAgICAgICByZXNvdXJjZXNfcmVscGF0aCA9IHNlbGYuX2ZpbGVzeXN0ZW0ucmVscGF0aChy ZXNvdXJjZXNfcGF0aCwgbmV3X3BhdGgpCi0gICAgICAgIHNlbGYubmV3X3Rlc3RfaGFybmVzc19w YXRoID0gcmVzb3VyY2VzX3JlbHBhdGgKKyAgICAgICAgc2VsZi5uZXdfdGVzdF9oYXJuZXNzX3Bh dGggPSByZXNvdXJjZXNfcmVscGF0aC5yZXBsYWNlKG9zLnNlcCwgJy8nKQogICAgICAgICBzZWxm LmNvbnZlcnRfdGVzdF9oYXJuZXNzX2xpbmtzID0gY29udmVydF90ZXN0X2hhcm5lc3NfbGlua3MK IAogICAgICAgICAjIFRoZXNlIHNldHRpbmdzIG1pZ2h0IHZhcnkgYmV0d2VlbiBXZWJLaXQgYW5k IEJsaW5rCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZl cnRlcl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVy dGVyX3VuaXR0ZXN0LnB5CmluZGV4IGU2MDYxMTYwMTZjMy4uZjYyNTcyNmY2YWVjIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRlcl91bml0dGVzdC5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRlcl91bml0dGVz dC5weQpAQCAtMzcwLDcgKzM3MCw3IEBAIENPTlRFTlQgT0YgVEVTVAogICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhsZW4oY29udmVydGVkLmZpbmRBbGwoc3JjPW9yaWdfcGF0aF9wYXR0ZXJuKSks IDAsICd0ZXN0aGFybmVzcyBzcmMgcGF0aCB3YXMgbm90IGNvbnZlcnRlZCcpCiAgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWxzKGxlbihjb252ZXJ0ZWQuZmluZEFsbChocmVmPW9yaWdfcGF0aF9wYXR0 ZXJuKSksIDAsICd0ZXN0aGFybmVzcyBocmVmIHBhdGggd2FzIG5vdCBjb252ZXJ0ZWQnKQogCi0g ICAgICAgIG5ld19yZWxwYXRoID0gb3MucGF0aC5yZWxwYXRoKHJlc291cmNlc19kaXIsIHRlc3Rf cGF0aCkKKyAgICAgICAgbmV3X3JlbHBhdGggPSBvcy5wYXRoLnJlbHBhdGgocmVzb3VyY2VzX2Rp ciwgdGVzdF9wYXRoKS5yZXBsYWNlKG9zLnNlcCwgJy8nKQogICAgICAgICByZWxwYXRoX3BhdHRl cm4gPSByZS5jb21waWxlKG5ld19yZWxwYXRoKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhs ZW4oY29udmVydGVkLmZpbmRBbGwoc3JjPXJlbHBhdGhfcGF0dGVybikpLCBudW1fc3JjX3BhdGhz LCAndGVzdGhhcm5lc3Mgc3JjIHJlbGF0aXZlIHBhdGggbm90IGNvcnJlY3QnKQogICAgICAgICBz ZWxmLmFzc2VydEVxdWFscyhsZW4oY29udmVydGVkLmZpbmRBbGwoaHJlZj1yZWxwYXRoX3BhdHRl cm4pKSwgbnVtX2hyZWZfcGF0aHMsICd0ZXN0aGFybmVzcyBocmVmIHJlbGF0aXZlIHBhdGggbm90 IGNvcnJlY3QnKQo=