<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>221842</bug_id>
          
          <creation_ts>2021-02-12 13:37:27 -0800</creation_ts>
          <short_desc>[Python-3] base64.encodestring is deprecated</short_desc>
          <delta_ts>2021-02-12 15:50:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>221815</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Don Olmstead">don.olmstead</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1728756</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2021-02-12 13:37:27 -0800</bug_when>
    <thetext>base64.encodestring has been deprecated since 3.1. In 3.8 it is an alias of encodebytes. It is completely removed in 3.9.

Found when running tests on Windows

[1480/1658] webkitpy.w3c.wpt_github_unittest.WPTGitHubTest.test_auth_token erred:

  Traceback (most recent call last):
    File &quot;C:\webkit\Tools\Scripts\webkitpy\w3c\wpt_github_unittest.py&quot;, line 50, in test_auth_token
      string_utils.decode(base64.encodestring(string_utils.encode(&apos;rutabaga:decafbad&apos;)), target_type=str).strip())
  AttributeError: module &apos;base64&apos; has no attribute &apos;encodestring&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1728812</commentid>
    <comment_count>1</comment_count>
      <attachid>420184</attachid>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2021-02-12 15:01:30 -0800</bug_when>
    <thetext>Created attachment 420184
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1728825</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-02-12 15:50:00 -0800</bug_when>
    <thetext>Committed r272820: &lt;https://commits.webkit.org/r272820&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420184.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1728826</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-02-12 15:50:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/74296121&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>420184</attachid>
            <date>2021-02-12 15:01:30 -0800</date>
            <delta_ts>2021-02-12 15:50:01 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-221842.diff</filename>
            <type>text/plain</type>
            <size>1406</size>
            <attacher name="Don Olmstead">don.olmstead</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3MDJm
YmVlYjUzNTMuLmEyNjI4ZDc0MTY0ZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi
L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTEyICBEb24gT2xtc3Rl
YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgW1B5dGhvbi0zXSBiYXNlNjQu
ZW5jb2Rlc3RyaW5nIGlzIGRlcHJlY2F0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTIyMTg0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIEluIFB5dGhvbiAzLjkgYmFzZTY0LmVuY29kZXN0cmluZyB3YXMg
Y29tcGxldGVseSByZW1vdmVkLiBSZXBsYWNpbmcgd2l0aCBiYXNlNjQuYjY0ZW5jb2RlCisgICAg
ICAgIHdoaWNoIHdvcmtzIGluIFB5dGhvbiAyLzMgYW5kIGlzIHVzZWQgYnkgdGhlIGNvZGUgYmVp
bmcgdGVzdGVkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS93M2Mvd3B0X2dpdGh1Yl91
bml0dGVzdC5weToKKyAgICAgICAgKFdQVEdpdEh1YlRlc3QudGVzdF9hdXRoX3Rva2VuKToKKwog
MjAyMS0wMi0xMiAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAg
ICAgIHdlYmtpdHB5Lnhjb2RlIG9ubHkgcmVsZXZhbnQgZm9yIGRhcndpbiBwbGF0Zm9ybXMKZGlm
ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3dwdF9naXRodWJfdW5pdHRlc3Qu
cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy93cHRfZ2l0aHViX3VuaXR0ZXN0LnB5Cmlu
ZGV4IDkyZWY4NGMzYThjMy4uN2Y4ODhhOGRmMDNjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz
L3dlYmtpdHB5L3czYy93cHRfZ2l0aHViX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv
d2Via2l0cHkvdzNjL3dwdF9naXRodWJfdW5pdHRlc3QucHkKQEAgLTQ3LDQgKzQ3LDQgQEAgY2xh
c3MgV1BUR2l0SHViVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfYXV0aF90
b2tlbihzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgKICAgICAgICAgICAgIHNlbGYu
d3B0X2dpdGh1Yi5hdXRoX3Rva2VuKCksCi0gICAgICAgICAgICBzdHJpbmdfdXRpbHMuZGVjb2Rl
KGJhc2U2NC5lbmNvZGVzdHJpbmcoc3RyaW5nX3V0aWxzLmVuY29kZSgncnV0YWJhZ2E6ZGVjYWZi
YWQnKSksIHRhcmdldF90eXBlPXN0cikuc3RyaXAoKSkKKyAgICAgICAgICAgIHN0cmluZ191dGls
cy5kZWNvZGUoYmFzZTY0LmI2NGVuY29kZShzdHJpbmdfdXRpbHMuZW5jb2RlKCdydXRhYmFnYTpk
ZWNhZmJhZCcpKSwgdGFyZ2V0X3R5cGU9c3RyKS5zdHJpcCgpKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>