221812 2021-02-12 07:26:24 -0800 [LFC][Integration] Make accessibility/aria-modal-in-aria-hidden.html more robust 2021-02-12 13:02:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned aboxhall apinheiro bfulgham cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white simon.fraser webkit-bug-importer zalan oldest_to_newest 1728554 0 koivisto 2021-02-12 07:26:24 -0800 It is very dependent on exact interactions between the internal testing API and the DOM. 1728555 1 420122 koivisto 2021-02-12 07:30:34 -0800 Created attachment 420122 patch 1728569 2 420130 koivisto 2021-02-12 08:55:36 -0800 Created attachment 420130 patch 1728742 3 ews-feeder 2021-02-12 13:01:40 -0800 Committed r272801: <https://commits.webkit.org/r272801> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420130. 1728743 4 webkit-bug-importer 2021-02-12 13:02:16 -0800 <rdar://problem/74288549> 420122 2021-02-12 07:30:34 -0800 2021-02-12 08:55:36 -0800 patch lfc-aria-modal-in-aria-hidden.patch text/plain 3717 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MmYyY2U2NWZmMjUuLjNjODYxOGNhNzZlMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA CisyMDIxLTAyLTEyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAg ICBbTEZDXVtJbnRlZ3JhdGlvbl0gTWFrZSBhY2Nlc3NpYmlsaXR5L2FyaWEtbW9kYWwtaW4tYXJp YS1oaWRkZW4uaHRtbCBtb3JlIHJvYnVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIxODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSXQgaXMgdmVyeSBkZXBlbmRlbnQgb24gZXhhY3QgaW50ZXJhY3Rp b25zIGJldHdlZW4gdGhlIGludGVybmFsIHRlc3RpbmcgQVBJIGFuZCB0aGUgRE9NLgorICAgICAg ICBJdCBhbHNvIHNlZW1zIHRvIGJlIHBhcnRpYWxseSB0ZXN0aW5nIGEgd3JvbmcgdGhpbmcgKHBy b2JhYmx5IGFzIHdvcmthcm91bmQgZm9yIGFib3ZlKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvYXJpYS1tb2RhbC1pbi1hcmlhLWhpZGRlbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLmh0bWw6CisKKyAgICAgICAgRG8g cmVuZGVyaW5nIHVwZGF0ZSBiZXR3ZWVuIGV2ZXJ5IG11dGF0aW9uIGFuZCBjaGVjaywgbm90IGp1 c3QgdGhlIGxhc3Qgb25lLgorICAgICAgICBGaXggdGhlIG1pZGRsZSB0ZXN0IHRvIHVzZSBpc0ln bm9yZWQgdG9vLgorICAgICAgICAoaXNWYWxpZCgpIGlzIG5vdCBldmVuIGEgZnVuY3Rpb24sIGl0 IGlzIGEgcHJvcGVydHksIHNvIHRoaXMgcmVsaWVkIG9uIGdldHRpbmcgbnVsbCB0byBwYXNzKQor CiAyMDIxLTAyLTExICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIGV2ZW50LmN0cmxLZXkgYW5kIG90aGVyIGFyZSBmYWxzZSBpbiBrZXlk b3duIGV2ZW50CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtbW9k YWwtaW4tYXJpYS1oaWRkZW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0 eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLWV4cGVjdGVkLnR4dAppbmRleCA0ZjNhZmRmZjky YzYuLmE1OTFiODkwMzgyYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9h cmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L2FyaWEtbW9kYWwtaW4tYXJpYS1oaWRkZW4tZXhwZWN0ZWQudHh0CkBAIC00 LDcgKzQsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogCiAKIFBBU1MgYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCdiZ0NvbnRlbnQnKS5pc0lnbm9yZWQg aXMgZmFsc2UKLVBBU1MgIWJhY2tncm91bmRDb250ZW50IHx8ICFiYWNrZ3JvdW5kQ29udGVudC5p c1ZhbGlkKCkgaXMgdHJ1ZQorUEFTUyBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxl RWxlbWVudEJ5SWQoJ2JnQ29udGVudCcpLmlzSWdub3JlZCBpcyB0cnVlCiBQQVNTIGFjY2Vzc2li aWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgnYmdDb250ZW50JykuaXNJZ25v cmVkIGlzIGZhbHNlCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tb2RhbC1pbi1hcmlhLWhpZGRlbi5o dG1sIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVu Lmh0bWwKaW5kZXggNTYxZGUzNzdhNGM0Li4xY2MwNjVkNjFlOGQgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tb2RhbC1pbi1hcmlhLWhpZGRlbi5odG1sCisrKyBi L0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tb2RhbC1pbi1hcmlhLWhpZGRlbi5odG1s CkBAIC0yMiwyMSArMjIsMjkgQEAKICAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0aGF0IHdo ZW4gc29tZXRoaW5nIGlzIGFyaWEtbW9kYWwgaW5zaWRlIGFuIGFyaWEtaGlkZGVuIGl0IGlzIGln bm9yZWQuIik7CiAgICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOwogCi0gICAgaWYgKHdp bmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgewotICAgICAgICBzaG91bGRCZUZhbHNlKCJh Y2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoJ2JnQ29udGVudCcp LmlzSWdub3JlZCIpOwotICAgICAgICAKLSAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImJveCIpLnNldEF0dHJpYnV0ZSgiYXJpYS1tb2RhbCIsICJ0cnVlIik7CisgICAgYXN5bmMgZnVu Y3Rpb24gdGVzdCgpIHsKKyAgICAgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxl cikgeworICAgICAgICAgICAgc2hvdWxkQmVGYWxzZSgiYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIu YWNjZXNzaWJsZUVsZW1lbnRCeUlkKCdiZ0NvbnRlbnQnKS5pc0lnbm9yZWQiKTsKKworICAgICAg ICAgICAgYXdhaXQgbmV3IFByb21pc2UocmVxdWVzdEFuaW1hdGlvbkZyYW1lKTsKKworICAgICAg ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImJveCIpLnNldEF0dHJpYnV0ZSgiYXJpYS1t b2RhbCIsICJ0cnVlIik7CisKKyAgICAgICAgICAgIGF3YWl0IG5ldyBQcm9taXNlKHJlcXVlc3RB bmltYXRpb25GcmFtZSk7CisKKyAgICAgICAgICAgIHNob3VsZEJlVHJ1ZSgiYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCdiZ0NvbnRlbnQnKS5pc0lnbm9yZWQi KTsKKworICAgICAgICAgICAgYXdhaXQgbmV3IFByb21pc2UocmVxdWVzdEFuaW1hdGlvbkZyYW1l KTsKIAotICAgICAgICB2YXIgYmFja2dyb3VuZENvbnRlbnQgPSBhY2Nlc3NpYmlsaXR5Q29udHJv bGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoJ2JnQ29udGVudCcpOwotICAgICAgICBzaG91bGRC ZVRydWUoIiFiYWNrZ3JvdW5kQ29udGVudCB8fCAhYmFja2dyb3VuZENvbnRlbnQuaXNWYWxpZCgp Iik7CisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGFpbmVyIikuc2V0 QXR0cmlidXRlKCJhcmlhLWhpZGRlbiIsICJ0cnVlIik7CiAKLSAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImNvbnRhaW5lciIpLnNldEF0dHJpYnV0ZSgiYXJpYS1oaWRkZW4iLCAidHJ1 ZSIpOworICAgICAgICAgICAgYXdhaXQgbmV3IFByb21pc2UocmVxdWVzdEFuaW1hdGlvbkZyYW1l KTsKIAotICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgc2hvdWxk QmVGYWxzZSgiYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCdi Z0NvbnRlbnQnKS5pc0lnbm9yZWQiKTsKICAgICAgICAgICAgIGZpbmlzaEpTVGVzdCgpOwotICAg ICAgICB9LCAwKTsKLSAgICB9ICAgIAorICAgICAgICB9CisgICAgfQorICAgIHRlc3QoKTsKIAog PC9zY3JpcHQ+CiAK 420130 2021-02-12 08:55:36 -0800 2021-02-12 13:01:42 -0800 patch lfc-aria-modal-in-aria-hidden-2.patch text/plain 3772 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MmYyY2U2NWZmMjUuLjNjODYxOGNhNzZlMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA CisyMDIxLTAyLTEyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAg ICBbTEZDXVtJbnRlZ3JhdGlvbl0gTWFrZSBhY2Nlc3NpYmlsaXR5L2FyaWEtbW9kYWwtaW4tYXJp YS1oaWRkZW4uaHRtbCBtb3JlIHJvYnVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIxODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSXQgaXMgdmVyeSBkZXBlbmRlbnQgb24gZXhhY3QgaW50ZXJhY3Rp b25zIGJldHdlZW4gdGhlIGludGVybmFsIHRlc3RpbmcgQVBJIGFuZCB0aGUgRE9NLgorICAgICAg ICBJdCBhbHNvIHNlZW1zIHRvIGJlIHBhcnRpYWxseSB0ZXN0aW5nIGEgd3JvbmcgdGhpbmcgKHBy b2JhYmx5IGFzIHdvcmthcm91bmQgZm9yIGFib3ZlKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvYXJpYS1tb2RhbC1pbi1hcmlhLWhpZGRlbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogYWNj ZXNzaWJpbGl0eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLmh0bWw6CisKKyAgICAgICAgRG8g cmVuZGVyaW5nIHVwZGF0ZSBiZXR3ZWVuIGV2ZXJ5IG11dGF0aW9uIGFuZCBjaGVjaywgbm90IGp1 c3QgdGhlIGxhc3Qgb25lLgorICAgICAgICBGaXggdGhlIG1pZGRsZSB0ZXN0IHRvIHVzZSBpc0ln bm9yZWQgdG9vLgorICAgICAgICAoaXNWYWxpZCgpIGlzIG5vdCBldmVuIGEgZnVuY3Rpb24sIGl0 IGlzIGEgcHJvcGVydHksIHNvIHRoaXMgcmVsaWVkIG9uIGdldHRpbmcgbnVsbCB0byBwYXNzKQor CiAyMDIxLTAyLTExICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgog CiAgICAgICAgIFtXUEVdIGV2ZW50LmN0cmxLZXkgYW5kIG90aGVyIGFyZSBmYWxzZSBpbiBrZXlk b3duIGV2ZW50CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtbW9k YWwtaW4tYXJpYS1oaWRkZW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0 eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLWV4cGVjdGVkLnR4dAppbmRleCA0ZjNhZmRmZjky YzYuLmVmZjhlOTM1ZjhkYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9h cmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L2FyaWEtbW9kYWwtaW4tYXJpYS1oaWRkZW4tZXhwZWN0ZWQudHh0CkBAIC00 LDcgKzQsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogCiAKIFBBU1MgYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCdiZ0NvbnRlbnQnKS5pc0lnbm9yZWQg aXMgZmFsc2UKLVBBU1MgIWJhY2tncm91bmRDb250ZW50IHx8ICFiYWNrZ3JvdW5kQ29udGVudC5p c1ZhbGlkKCkgaXMgdHJ1ZQorUEFTUyAhYmFja2dyb3VuZENvbnRlbnQgfHwgYmFja2dyb3VuZENv bnRlbnQuaXNJZ25vcmVkIGlzIHRydWUKIFBBU1MgYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNj ZXNzaWJsZUVsZW1lbnRCeUlkKCdiZ0NvbnRlbnQnKS5pc0lnbm9yZWQgaXMgZmFsc2UKIFBBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNj ZXNzaWJpbGl0eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLmh0bWwgYi9MYXlvdXRUZXN0cy9h Y2Nlc3NpYmlsaXR5L2FyaWEtbW9kYWwtaW4tYXJpYS1oaWRkZW4uaHRtbAppbmRleCA1NjFkZTM3 N2E0YzQuLjU0OWM1ZjRhNGMyMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0 eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNz aWJpbGl0eS9hcmlhLW1vZGFsLWluLWFyaWEtaGlkZGVuLmh0bWwKQEAgLTIyLDIxICsyMiwzMCBA QAogICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgd2hlbiBzb21ldGhpbmcgaXMgYXJp YS1tb2RhbCBpbnNpZGUgYW4gYXJpYS1oaWRkZW4gaXQgaXMgaWdub3JlZC4iKTsKICAgICB3aW5k b3cuanNUZXN0SXNBc3luYyA9IHRydWU7CiAKLSAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlD b250cm9sbGVyKSB7Ci0gICAgICAgIHNob3VsZEJlRmFsc2UoImFjY2Vzc2liaWxpdHlDb250cm9s bGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgnYmdDb250ZW50JykuaXNJZ25vcmVkIik7Ci0gICAg ICAgIAotICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYm94Iikuc2V0QXR0cmlidXRl KCJhcmlhLW1vZGFsIiwgInRydWUiKTsKKyAgICBhc3luYyBmdW5jdGlvbiB0ZXN0KCkgeworICAg ICAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgICAgICBz aG91bGRCZUZhbHNlKCJhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5 SWQoJ2JnQ29udGVudCcpLmlzSWdub3JlZCIpOworCisgICAgICAgICAgICBhd2FpdCBuZXcgUHJv bWlzZShyZXF1ZXN0QW5pbWF0aW9uRnJhbWUpOworCisgICAgICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiYm94Iikuc2V0QXR0cmlidXRlKCJhcmlhLW1vZGFsIiwgInRydWUiKTsKKwor ICAgICAgICAgICAgYXdhaXQgbmV3IFByb21pc2UocmVxdWVzdEFuaW1hdGlvbkZyYW1lKTsKKwor ICAgICAgICAgICAgYmFja2dyb3VuZENvbnRlbnQgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5h Y2Nlc3NpYmxlRWxlbWVudEJ5SWQoJ2JnQ29udGVudCcpOworICAgICAgICAgICAgc2hvdWxkQmVU cnVlKCIhYmFja2dyb3VuZENvbnRlbnQgfHwgYmFja2dyb3VuZENvbnRlbnQuaXNJZ25vcmVkIik7 CisKKyAgICAgICAgICAgIGF3YWl0IG5ldyBQcm9taXNlKHJlcXVlc3RBbmltYXRpb25GcmFtZSk7 CiAKLSAgICAgICAgdmFyIGJhY2tncm91bmRDb250ZW50ID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xs ZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCdiZ0NvbnRlbnQnKTsKLSAgICAgICAgc2hvdWxkQmVU cnVlKCIhYmFja2dyb3VuZENvbnRlbnQgfHwgIWJhY2tncm91bmRDb250ZW50LmlzVmFsaWQoKSIp OworICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnRhaW5lciIpLnNldEF0 dHJpYnV0ZSgiYXJpYS1oaWRkZW4iLCAidHJ1ZSIpOwogCi0gICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJjb250YWluZXIiKS5zZXRBdHRyaWJ1dGUoImFyaWEtaGlkZGVuIiwgInRydWUi KTsKKyAgICAgICAgICAgIGF3YWl0IG5ldyBQcm9taXNlKHJlcXVlc3RBbmltYXRpb25GcmFtZSk7 CiAKLSAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKICAgICAgICAgICAgIHNob3VsZEJl RmFsc2UoImFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgnYmdD b250ZW50JykuaXNJZ25vcmVkIik7CiAgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKLSAgICAg ICAgfSwgMCk7Ci0gICAgfSAgICAKKyAgICAgICAgfQorICAgIH0KKyAgICB0ZXN0KCk7CiAKIDwv c2NyaXB0PgogCg==