221787 2021-02-11 17:08:00 -0800 CodeBlock::propagateTransitions() should also handle OpSetPrivateBrand's LLInt IC. 2021-02-11 18:15:06 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1728374 0 mark.lam 2021-02-11 17:08:00 -0800 ... just like it does for OpPutById and OpPutPrivateName. 1728380 1 420073 mark.lam 2021-02-11 17:22:33 -0800 Created attachment 420073 proposed patch. 1728384 2 420073 ysuzuki 2021-02-11 17:38:39 -0800 Comment on attachment 420073 proposed patch. r=me 1728404 3 mark.lam 2021-02-11 18:11:29 -0800 Thanks for the review. Landed in r272765: <http://trac.webkit.org/r272765>. 1728405 4 webkit-bug-importer 2021-02-11 18:12:16 -0800 <rdar://problem/74259585> 1728406 5 mark.lam 2021-02-11 18:15:06 -0800 (In reply to Mark Lam from comment #3) > Thanks for the review. Landed in r272765: <http://trac.webkit.org/r272765>. Sorry, ignore that. Landed in r272766: <http://trac.webkit.org/r272766>. 420073 2021-02-11 17:22:33 -0800 2021-02-11 17:38:39 -0800 proposed patch. bug-221787.patch text/plain 3733 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcyNzYwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDIxLTAyLTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD b2RlQmxvY2s6OnByb3BhZ2F0ZVRyYW5zaXRpb25zKCkgc2hvdWxkIGFsc28gaGFuZGxlIE9wU2V0 UHJpdmF0ZUJyYW5kJ3MgTExJbnQgSUMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjE3ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6 OkNvZGVCbG9jazo6cHJvcGFnYXRlVHJhbnNpdGlvbnMpOgorCiAyMDIxLTAyLTExICBBbGV4ZXkg U2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBTZXRJbnRlZ3JpdHlM ZXZlbCBzaG91bGQgY2FsbCBbW0RlZmluZU93blByb3BlcnR5XV0gd2l0aCBwYXJ0aWFsIGRlc2Ny aXB0b3IKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2su Y3BwCShyZXZpc2lvbiAyNzI3NTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv Q29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5 cmlnaHQgKEMpIDIwMDgtMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBD b3B5cmlnaHQgKEMpIDIwMDgtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAg KiBDb3B5cmlnaHQgKEMpIDIwMDggQ2FtZXJvbiBad2FyaWNoIDxjd3p3YXJpY2hAdXdhdGVybG9v LmNhPgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkg Zm9ybXMsIHdpdGggb3Igd2l0aG91dApAQCAtMTEzMywxMiArMTEzMywxMSBAQCB2b2lkIENvZGVC bG9jazo6cHJvcGFnYXRlVHJhbnNpdGlvbnMoY29uCiAgICAgICAgICAgICAgICAgU3RydWN0dXJl SUQgbmV3U3RydWN0dXJlSUQgPSBtZXRhZGF0YS5tX25ld1N0cnVjdHVyZUlEOwogICAgICAgICAg ICAgICAgIGlmICghb2xkU3RydWN0dXJlSUQgfHwgIW5ld1N0cnVjdHVyZUlEKQogICAgICAgICAg ICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICAgICAgU3RydWN0dXJlKiBvbGRTdHJ1Y3R1 cmUgPQotICAgICAgICAgICAgICAgICAgICB2bS5oZWFwLnN0cnVjdHVyZUlEVGFibGUoKS5nZXQo b2xkU3RydWN0dXJlSUQpOwotICAgICAgICAgICAgICAgIFN0cnVjdHVyZSogbmV3U3RydWN0dXJl ID0KLSAgICAgICAgICAgICAgICAgICAgdm0uaGVhcC5zdHJ1Y3R1cmVJRFRhYmxlKCkuZ2V0KG5l d1N0cnVjdHVyZUlEKTsKLSAgICAgICAgICAgICAgICBpZiAodm0uaGVhcC5pc01hcmtlZChvbGRT dHJ1Y3R1cmUpKQorICAgICAgICAgICAgICAgIFN0cnVjdHVyZSogb2xkU3RydWN0dXJlID0gdm0u aGVhcC5zdHJ1Y3R1cmVJRFRhYmxlKCkuZ2V0KG9sZFN0cnVjdHVyZUlEKTsKKyAgICAgICAgICAg ICAgICBpZiAodm0uaGVhcC5pc01hcmtlZChvbGRTdHJ1Y3R1cmUpKSB7CisgICAgICAgICAgICAg ICAgICAgIFN0cnVjdHVyZSogbmV3U3RydWN0dXJlID0gdm0uaGVhcC5zdHJ1Y3R1cmVJRFRhYmxl KCkuZ2V0KG5ld1N0cnVjdHVyZUlEKTsKICAgICAgICAgICAgICAgICAgICAgdmlzaXRvci5hcHBl bmRVbmJhcnJpZXJlZChuZXdTdHJ1Y3R1cmUpOworICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgIH0pOwogCiAgICAgICAgICAgICBtX21ldGFkYXRhLT5mb3JFYWNoPE9wUHV0UHJpdmF0ZU5h bWU+KFsmXSAoYXV0byYgbWV0YWRhdGEpIHsKQEAgLTExNTIsMTIgKzExNTEsMjkgQEAgdm9pZCBD b2RlQmxvY2s6OnByb3BhZ2F0ZVRyYW5zaXRpb25zKGNvbgogICAgICAgICAgICAgICAgIGlmICgh dm0uaGVhcC5pc01hcmtlZChwcm9wZXJ0eSkpCiAgICAgICAgICAgICAgICAgICAgIHJldHVybjsK IAotICAgICAgICAgICAgICAgIFN0cnVjdHVyZSogb2xkU3RydWN0dXJlID0KLSAgICAgICAgICAg ICAgICAgICAgdm0uaGVhcC5zdHJ1Y3R1cmVJRFRhYmxlKCkuZ2V0KG9sZFN0cnVjdHVyZUlEKTsK LSAgICAgICAgICAgICAgICBTdHJ1Y3R1cmUqIG5ld1N0cnVjdHVyZSA9Ci0gICAgICAgICAgICAg ICAgICAgIHZtLmhlYXAuc3RydWN0dXJlSURUYWJsZSgpLmdldChuZXdTdHJ1Y3R1cmVJRCk7Ci0g ICAgICAgICAgICAgICAgaWYgKHZtLmhlYXAuaXNNYXJrZWQob2xkU3RydWN0dXJlKSkKKyAgICAg ICAgICAgICAgICBTdHJ1Y3R1cmUqIG9sZFN0cnVjdHVyZSA9IHZtLmhlYXAuc3RydWN0dXJlSURU YWJsZSgpLmdldChvbGRTdHJ1Y3R1cmVJRCk7CisgICAgICAgICAgICAgICAgaWYgKHZtLmhlYXAu aXNNYXJrZWQob2xkU3RydWN0dXJlKSkgeworICAgICAgICAgICAgICAgICAgICBTdHJ1Y3R1cmUq IG5ld1N0cnVjdHVyZSA9IHZtLmhlYXAuc3RydWN0dXJlSURUYWJsZSgpLmdldChuZXdTdHJ1Y3R1 cmVJRCk7CiAgICAgICAgICAgICAgICAgICAgIHZpc2l0b3IuYXBwZW5kVW5iYXJyaWVyZWQobmV3 U3RydWN0dXJlKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9KTsKKworICAgICAg ICAgICAgbV9tZXRhZGF0YS0+Zm9yRWFjaDxPcFNldFByaXZhdGVCcmFuZD4oWyZdIChhdXRvJiBt ZXRhZGF0YSkgeworICAgICAgICAgICAgICAgIFN0cnVjdHVyZUlEIG9sZFN0cnVjdHVyZUlEID0g bWV0YWRhdGEubV9vbGRTdHJ1Y3R1cmVJRDsKKyAgICAgICAgICAgICAgICBTdHJ1Y3R1cmVJRCBu ZXdTdHJ1Y3R1cmVJRCA9IG1ldGFkYXRhLm1fbmV3U3RydWN0dXJlSUQ7CisgICAgICAgICAgICAg ICAgaWYgKCFvbGRTdHJ1Y3R1cmVJRCB8fCAhbmV3U3RydWN0dXJlSUQpCisgICAgICAgICAgICAg ICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgICAgIEpTQ2VsbCogYnJhbmQgPSBtZXRhZGF0 YS5tX2JyYW5kLmdldCgpOworICAgICAgICAgICAgICAgIEFTU0VSVChicmFuZCk7CisgICAgICAg ICAgICAgICAgaWYgKCF2bS5oZWFwLmlzTWFya2VkKGJyYW5kKSkKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuOworCisgICAgICAgICAgICAgICAgU3RydWN0dXJlKiBvbGRTdHJ1Y3R1cmUgPSB2 bS5oZWFwLnN0cnVjdHVyZUlEVGFibGUoKS5nZXQob2xkU3RydWN0dXJlSUQpOworICAgICAgICAg ICAgICAgIGlmICh2bS5oZWFwLmlzTWFya2VkKG9sZFN0cnVjdHVyZSkpIHsKKyAgICAgICAgICAg ICAgICAgICAgU3RydWN0dXJlKiBuZXdTdHJ1Y3R1cmUgPSB2bS5oZWFwLnN0cnVjdHVyZUlEVGFi bGUoKS5nZXQobmV3U3RydWN0dXJlSUQpOworICAgICAgICAgICAgICAgICAgICB2aXNpdG9yLmFw cGVuZFVuYmFycmllcmVkKG5ld1N0cnVjdHVyZSk7CisgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgfSk7CiAgICAgICAgIH0KICAgICB9Cg==