221773 2021-02-11 12:51:38 -0800 [Cocoa] IPC decoder is using decoded size to allocate memory for an array 2021-04-25 10:51:28 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224984 InRadar P2 Normal --- 1 darin darin ggaren webkit-bug-importer oldest_to_newest 1728246 0 darin 2021-02-11 12:51:38 -0800 [Cocoa] IPC decoder is using decoded size to allocate memory for an array 1728247 1 420032 darin 2021-02-11 12:53:17 -0800 Created attachment 420032 Patch 1728249 2 darin 2021-02-11 12:53:50 -0800 rdar://72808726 1728252 3 420032 ggaren 2021-02-11 13:04:06 -0800 Comment on attachment 420032 Patch r=me I wonder if we should honor some safe nominal capacity, like std::min(1024, size), for performance. 1728259 4 darin 2021-02-11 13:29:08 -0800 (In reply to Geoffrey Garen from comment #3) > I wonder if we should honor some safe nominal capacity, like std::min(1024, > size), for performance. We don’t do that for CFArray or for vectors, but I agree that it *might* be a valuable optimization for cases like these. 1728261 5 darin 2021-02-11 13:30:38 -0800 Committed r272744: <https://trac.webkit.org/changeset/272744> 420032 2021-02-11 12:53:17 -0800 2021-02-11 13:04:06 -0800 Patch bug-221773-20210211125316.patch text/plain 1812 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0Y2E5MDljN2IzYTYxNWI4 YjU0NTUzYjcyNmQ5ZDZiYzAxODhkMTUuLmUyY2U1MWViNTk2ODRkMjA5NWEwOGViZWMzNDRhNmQ4 MWNhYTFhNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDItMTEgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gSVBDIGRlY29kZXIgaXMg dXNpbmcgZGVjb2RlZCBzaXplIHRvIGFsbG9jYXRlIG1lbW9yeSBmb3IgYW4gYXJyYXkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTc3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL0NvY29h L0FyZ3VtZW50Q29kZXJzQ29jb2EubW06CisgICAgICAgIChJUEM6OmRlY29kZUFycmF5SW50ZXJu YWwpOiBBcyB3aXRoIG90aGVyIHNpbWlsYXIgc3RydWN0dXJlcywgc3VjaCBhIFZlY3RvciBhbmQK KyAgICAgICAgQ0ZBcnJheSwgZG9uJ3QgdXNlIHRoZSBzaXplIHRvIHByZWFsbG9jYXRlIHNwYWNl IHdoZW4gZGVjb2RpbmcgYW4gTlNBcnJheS4gVGhlCisgICAgICAgIGRlY29kZWQgc2l6ZSBpcyBw b3RlbnRpYWxseSBpbmNvcnJlY3QsIHdoaWNoIHdlIHdpbGwgZGlzY292ZXIgaW5kaXJlY3RseSB3 aGVuCisgICAgICAgIGRlY29kaW5nIHRoZSBhcnJheSBlbGVtZW50czsgd2UgY2FuJ3Qgc2FmZWx5 IHVzZSB0aGUgc2l6ZSB0byBtYWtlIGEgY2hvaWNlIGFib3V0CisgICAgICAgIGFsbG9jYXRpbmcg bWVtb3J5IGJlZm9yZWhhbmQuCisKIDIwMjEtMDItMTEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNPU10gRW5hYmxlIEF1ZGlvIENhcHR1cmUgaW4gR1BV UHJvY2VzcyBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2Nv YS9Bcmd1bWVudENvZGVyc0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvQXJn dW1lbnRDb2RlcnNDb2NvYS5tbQppbmRleCA3ZDJkZTc2M2FkOGU0NWZmZWFkMzE1YTBmMmRlNDY0 NzhjMDYwYjU0Li5iZDNhZWMzMWMzM2RiNTdmNmY4MjI3ZTM1NjkxYWEzYjg3NDBmODdhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9Bcmd1bWVudENvZGVyc0NvY29hLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL0FyZ3VtZW50Q29kZXJzQ29jb2EubW0K QEAgLTE3Niw3ICsxNzYsNyBAQCBzdGF0aWMgT3B0aW9uYWw8UmV0YWluUHRyPGlkPj4gZGVjb2Rl QXJyYXlJbnRlcm5hbChEZWNvZGVyJiBkZWNvZGVyLCBOU0FycmF5PENsYQogICAgIGlmICghZGVj b2Rlci5kZWNvZGUoc2l6ZSkpCiAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAKLSAgICBS ZXRhaW5QdHI8TlNNdXRhYmxlQXJyYXk+IGFycmF5ID0gYWRvcHROUyhbW05TTXV0YWJsZUFycmF5 IGFsbG9jXSBpbml0V2l0aENhcGFjaXR5OnNpemVdKTsKKyAgICBhdXRvIGFycmF5ID0gYWRvcHRO UyhbW05TTXV0YWJsZUFycmF5IGFsbG9jXSBpbml0XSk7CiAgICAgZm9yICh1aW50NjRfdCBpID0g MDsgaSA8IHNpemU7ICsraSkgewogICAgICAgICBhdXRvIHZhbHVlID0gZGVjb2RlT2JqZWN0KGRl Y29kZXIsIGFsbG93ZWRDbGFzc2VzKTsKICAgICAgICAgaWYgKCF2YWx1ZSkK