221756 2021-02-11 08:51:56 -0800 JSC EWSes should be triggered by change in any jsc file 2021-02-11 10:51:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain ap don.olmstead jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1728109 0 aakash_jain 2021-02-11 08:51:56 -0800 JSC EWSes should be triggered by change in any jsc file. It wasn't triggered on https://bugs.webkit.org/show_bug.cgi?id=221726 which changed Source/cmake/OptionsJSCOnly.cmake 1728112 1 419995 aakash_jain 2021-02-11 08:56:53 -0800 Created attachment 419995 Patch 1728116 2 419995 jbedard 2021-02-11 09:03:57 -0800 Comment on attachment 419995 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419995&action=review > Tools/CISupport/ews-build/steps.py:-338 > - 'Source/JavaScriptCore/', Are the regexes not case-sensitive? 1728131 3 aakash_jain 2021-02-11 09:21:32 -0800 (In reply to Jonathan Bedard from comment #2) > Are the regexes not case-sensitive? Nope, we use re.IGNORECASE in re.search() 1728165 4 ews-feeder 2021-02-11 10:50:45 -0800 Committed r272738: <https://commits.webkit.org/r272738> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419995. 1728166 5 webkit-bug-importer 2021-02-11 10:51:13 -0800 <rdar://problem/74241656> 419995 2021-02-11 08:56:53 -0800 2021-02-11 10:50:46 -0800 Patch bug-221756-20210211115652.patch text/plain 6617 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MjczMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAyLTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBKU0MgRVdTZXMgc2hvdWxkIGJlIHRyaWdnZXJlZCBieSBjaGFuZ2UgaW4g YW55IGpzYyBmaWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjE3NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChDaGVja1BhdGNo UmVsZXZhbmNlKTogVXNlZCBnZW5lcmljIGpzYyByZWdleC4KKyAgICAgICAgKiBDSVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBNYWRlIHRoZSB1bml0LXRlc3RzIG1vcmUgZ2Vu ZXJpYyBieSB1c2luZyBmb3IgbG9vcCB0byBjaGVjayBtdWx0aXBsZSBmaWxlbmFtZXMuCisKIDIw MjEtMDItMTEgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0Zs YXRwYWsgU0RLXSBTdXBwb3J0IG11bHRpcGxlIGJ1aWxkcyBydW5uaW5nIGF0IHRoZSBzYW1lIHRp bWUKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjcyNzMxKQor KysgVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAt MzM0LDIzICszMzQsMTMgQEAgY2xhc3MgQ2hlY2tQYXRjaFJlbGV2YW5jZShidWlsZHN0ZXAuQnVp bAogICAgIF0KIAogICAgIGpzY19wYXRocyA9IFsKKyAgICAgICAgJy4qanNjLionLAorICAgICAg ICAnLipqYXZhc2NyaXB0Y29yZS4qJywKICAgICAgICAgJ0pTVGVzdHMvJywKLSAgICAgICAgJ1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS8nLAogICAgICAgICAnU291cmNlL1dURi8nLAogICAgICAgICAn U291cmNlL2JtYWxsb2MvJywKLSAgICAgICAgJ01ha2VmaWxlJywKLSAgICAgICAgJ01ha2VmaWxl LnNoYXJlZCcsCi0gICAgICAgICdTb3VyY2UvTWFrZWZpbGUnLAotICAgICAgICAnU291cmNlL01h a2VmaWxlLnNoYXJlZCcsCisgICAgICAgICcuKk1ha2VmaWxlLionLAogICAgICAgICAnVG9vbHMv U2NyaXB0cy9idWlsZC13ZWJraXQnLAotICAgICAgICAnVG9vbHMvU2NyaXB0cy9idWlsZC1qc2Mn LAotICAgICAgICAnVG9vbHMvU2NyaXB0cy9qc2Mtc3RyZXNzLXRlc3QtaGVscGVycy8nLAotICAg ICAgICAnVG9vbHMvU2NyaXB0cy9ydW4tanNjJywKLSAgICAgICAgJ1Rvb2xzL1NjcmlwdHMvcnVu LWpzYy1iZW5jaG1hcmtzJywKLSAgICAgICAgJ1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3Mt dGVzdHMnLAotICAgICAgICAnVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMn LAotICAgICAgICAnVG9vbHMvU2NyaXB0cy9ydW4tbGF5b3V0LWpzYycsCi0gICAgICAgICdUb29s cy9TY3JpcHRzL3VwZGF0ZS1qYXZhc2NyaXB0Y29yZS10ZXN0LXJlc3VsdHMnLAogICAgICAgICAn VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtJywKICAgICBdCiAKSW5kZXg6IFRvb2xzL0NJU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjcyNzMxKQorKysg VG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtMjM5MCwyNyArMjM5MCw0NCBAQCBjbGFzcyBUZXN0Q2hlY2tQYXRjaFJlbGV2YW5jZShC dWlsZFN0ZXBNCiAgICAgICAgIHJldHVybiBzZWxmLnRlYXJEb3duQnVpbGRTdGVwKCkKIAogICAg IGRlZiB0ZXN0X3JlbGV2YW50X2pzY19wYXRjaChzZWxmKToKLSAgICAgICAgQ2hlY2tQYXRjaFJl bGV2YW5jZS5fZ2V0X3BhdGNoID0gbGFtYmRhIHg6ICdTYW1wbGUgcGF0Y2g7IGZpbGU6IEpTVGVz dHMvJworICAgICAgICBmaWxlX25hbWVzID0gWydKU1Rlc3RzLycsICdTb3VyY2UvSmF2YVNjcmlw dENvcmUvJywgJ1NvdXJjZS9XVEYvJywgJ1NvdXJjZS9ibWFsbG9jLycsICdNYWtlZmlsZScsICdN YWtlZmlsZS5zaGFyZWQnLAorICAgICAgICAgICAgICAgICAgICAgICdTb3VyY2UvTWFrZWZpbGUn LCAnU291cmNlL01ha2VmaWxlLnNoYXJlZCcsICdUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCcs ICdUb29scy9TY3JpcHRzL2J1aWxkLWpzYycsCisgICAgICAgICAgICAgICAgICAgICAgJ1Rvb2xz L1NjcmlwdHMvanNjLXN0cmVzcy10ZXN0LWhlbHBlcnMvJywgJ1Rvb2xzL1NjcmlwdHMvcnVuLWpz YycsICdUb29scy9TY3JpcHRzL3J1bi1qc2MtYmVuY2htYXJrcycsCisgICAgICAgICAgICAgICAg ICAgICAgJ1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMnLCAnVG9vbHMvU2NyaXB0 cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMnLCAnVG9vbHMvU2NyaXB0cy9ydW4tbGF5b3V0LWpz YycsCisgICAgICAgICAgICAgICAgICAgICAgJ1Rvb2xzL1NjcmlwdHMvdXBkYXRlLWphdmFzY3Jp cHRjb3JlLXRlc3QtcmVzdWx0cycsICdUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0nLAorICAg ICAgICAgICAgICAgICAgICAgICdTb3VyY2UvY21ha2UvT3B0aW9uc0pTQ09ubHkuY21ha2UnXQor CiAgICAgICAgIHNlbGYuc2V0dXBTdGVwKENoZWNrUGF0Y2hSZWxldmFuY2UoKSkKICAgICAgICAg c2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnSlNDLVRlc3RzLUVXUycpCiAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwoQ2hlY2tQYXRjaFJlbGV2YW5jZS5oYWx0T25GYWlsdXJlLCBUcnVl KQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKENoZWNrUGF0Y2hSZWxldmFuY2UuZmx1bmtPbkZh aWx1cmUsIFRydWUpCi0gICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywg c3RhdGVfc3RyaW5nPSdQYXRjaCBjb250YWlucyByZWxldmFudCBjaGFuZ2VzJykKLSAgICAgICAg cmV0dXJuIHNlbGYucnVuU3RlcCgpCisgICAgICAgIGZvciBmaWxlX25hbWUgaW4gZmlsZV9uYW1l czoKKyAgICAgICAgICAgIENoZWNrUGF0Y2hSZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4 OiAnU2FtcGxlIHBhdGNoOyBmaWxlOiB7fScuZm9ybWF0KGZpbGVfbmFtZSkKKyAgICAgICAgICAg IHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXRjaCBj b250YWlucyByZWxldmFudCBjaGFuZ2VzJykKKyAgICAgICAgICAgIHJjID0gc2VsZi5ydW5TdGVw KCkKKyAgICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgdGVzdF9yZWxldmFudF93azFfcGF0Y2go c2VsZik6Ci0gICAgICAgIENoZWNrUGF0Y2hSZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4 OiAnU2FtcGxlIHBhdGNoOyBmaWxlOiBTb3VyY2UvV2ViS2l0TGVnYWN5JworICAgICAgICBmaWxl X25hbWVzID0gWydTb3VyY2UvV2ViS2l0TGVnYWN5JywgJ1NvdXJjZS9XZWJDb3JlJywgJ1NvdXJj ZS9XZWJJbnNwZWN0b3JVSScsICdTb3VyY2UvV2ViRHJpdmVyJywgJ1NvdXJjZS9XVEYnLAorICAg ICAgICAgICAgICAgICAgICAgICdTb3VyY2UvYm1hbGxvYycsICdTb3VyY2UvSmF2YVNjcmlwdENv cmUnLCAnU291cmNlL1RoaXJkUGFydHknLCAnTGF5b3V0VGVzdHMnLCAnVG9vbHMnXQorCiAgICAg ICAgIHNlbGYuc2V0dXBTdGVwKENoZWNrUGF0Y2hSZWxldmFuY2UoKSkKICAgICAgICAgc2VsZi5z ZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnbWFjT1MtQ2F0YWxpbmEtUmVsZWFzZS1XSzEtVGVz dHMtRVdTJykKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0 ZV9zdHJpbmc9J1BhdGNoIGNvbnRhaW5zIHJlbGV2YW50IGNoYW5nZXMnKQotICAgICAgICByZXR1 cm4gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgZm9yIGZpbGVfbmFtZSBpbiBmaWxlX25hbWVzOgor ICAgICAgICAgICAgQ2hlY2tQYXRjaFJlbGV2YW5jZS5fZ2V0X3BhdGNoID0gbGFtYmRhIHg6ICdT YW1wbGUgcGF0Y2g7IGZpbGU6IHt9Jy5mb3JtYXQoZmlsZV9uYW1lKQorICAgICAgICAgICAgc2Vs Zi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1BhdGNoIGNvbnRh aW5zIHJlbGV2YW50IGNoYW5nZXMnKQorICAgICAgICAgICAgcmMgPSBzZWxmLnJ1blN0ZXAoKQor ICAgICAgICByZXR1cm4gcmMKIAogICAgIGRlZiB0ZXN0X3JlbGV2YW50X2JpZ3N1cl9idWlsZGVy X3BhdGNoKHNlbGYpOgotICAgICAgICBDaGVja1BhdGNoUmVsZXZhbmNlLl9nZXRfcGF0Y2ggPSBs YW1iZGEgeDogJ1NhbXBsZSBwYXRjaDsgZmlsZTogU291cmNlL3h5eicKKyAgICAgICAgZmlsZV9u YW1lcyA9IFsnU291cmNlL3h5eicsICdUb29scy9hYmMnXQogICAgICAgICBzZWxmLnNldHVwU3Rl cChDaGVja1BhdGNoUmVsZXZhbmNlKCkpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxk ZXJuYW1lJywgJ21hY09TLUJpZ1N1ci1SZWxlYXNlLUJ1aWxkLUVXUycpCi0gICAgICAgIHNlbGYu ZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXRjaCBjb250YWlu cyByZWxldmFudCBjaGFuZ2VzJykKLSAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisgICAg ICAgIGZvciBmaWxlX25hbWUgaW4gZmlsZV9uYW1lczoKKyAgICAgICAgICAgIENoZWNrUGF0Y2hS ZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2FtcGxlIHBhdGNoOyBmaWxlOiB7fScu Zm9ybWF0KGZpbGVfbmFtZSkKKyAgICAgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9 U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXRjaCBjb250YWlucyByZWxldmFudCBjaGFuZ2VzJykK KyAgICAgICAgICAgIHJjID0gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgcmV0dXJuIHJjCiAKICAg ICBkZWYgdGVzdF9yZWxldmFudF93aW5kb3dzX3drMV9wYXRjaChzZWxmKToKICAgICAgICAgQ2hl Y2tQYXRjaFJlbGV2YW5jZS5fZ2V0X3BhdGNoID0gbGFtYmRhIHg6ICdTYW1wbGUgcGF0Y2g7IGZp bGU6IFNvdXJjZS9XZWJLaXRMZWdhY3knCkBAIC0yNDIxLDEwICsyNDM4LDIwIEBAIGNsYXNzIFRl c3RDaGVja1BhdGNoUmVsZXZhbmNlKEJ1aWxkU3RlcE0KIAogICAgIGRlZiB0ZXN0X3JlbGV2YW50 X3dlYmtpdHB5X3BhdGNoKHNlbGYpOgogICAgICAgICBmaWxlX25hbWVzID0gWydUb29scy9TY3Jp cHRzL3dlYmtpdHB5JywgJ1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzJywgJ1Rvb2xzL1NjcmlwdHMv Y29tbWl0LWxvZy1lZGl0b3InXQorICAgICAgICBzZWxmLnNldHVwU3RlcChDaGVja1BhdGNoUmVs ZXZhbmNlKCkpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJ1dlYktp dFB5LVRlc3RzLUVXUycpCisgICAgICAgIGZvciBmaWxlX25hbWUgaW4gZmlsZV9uYW1lczoKKyAg ICAgICAgICAgIENoZWNrUGF0Y2hSZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2Ft cGxlIHBhdGNoOyBmaWxlOiB7fScuZm9ybWF0KGZpbGVfbmFtZSkKKyAgICAgICAgICAgIHNlbGYu ZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXRjaCBjb250YWlu cyByZWxldmFudCBjaGFuZ2VzJykKKyAgICAgICAgICAgIHJjID0gc2VsZi5ydW5TdGVwKCkKKyAg ICAgICAgcmV0dXJuIHJjCisKKyAgICBkZWYgdGVzdF9yZWxldmFudF9iaW5kaW5nc190ZXN0c19w YXRjaChzZWxmKToKKyAgICAgICAgZmlsZV9uYW1lcyA9IFsnU291cmNlL1dlYkNvcmUnLCAnVG9v bHMnXQorICAgICAgICBzZWxmLnNldHVwU3RlcChDaGVja1BhdGNoUmVsZXZhbmNlKCkpCisgICAg ICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJ0JpbmRpbmdzLVRlc3RzLUVXUycp CiAgICAgICAgIGZvciBmaWxlX25hbWUgaW4gZmlsZV9uYW1lczoKICAgICAgICAgICAgIENoZWNr UGF0Y2hSZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2FtcGxlIHBhdGNoOyBmaWxl OiB7fScuZm9ybWF0KGZpbGVfbmFtZSkKLSAgICAgICAgICAgIHNlbGYuc2V0dXBTdGVwKENoZWNr UGF0Y2hSZWxldmFuY2UoKSkKLSAgICAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJu YW1lJywgJ1dlYktpdFB5LVRlc3RzLUVXUycpCiAgICAgICAgICAgICBzZWxmLmV4cGVjdE91dGNv bWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nUGF0Y2ggY29udGFpbnMgcmVsZXZhbnQg Y2hhbmdlcycpCiAgICAgICAgICAgICByYyA9IHNlbGYucnVuU3RlcCgpCiAgICAgICAgIHJldHVy biByYwo=