221742 2021-02-10 21:13:17 -0800 REGRESSION (r272414?): [macOS] TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure 2021-05-10 08:56:03 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad cdumez ap cdumez eric.carlson jenner jer.noble peng.liu6 webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1727949 0 ryanhaddad 2021-02-10 21:13:17 -0800 The following test is a flaky failure on iOS and macOS bots: TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo LEAK: 1 WebProcessPool LEAK: 1 WebPageProxy /Volumes/Data/slave/bigsur-debug/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:282 Value of: [webView _isPlayingAudio] Actual: false Expected: true https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.MediaSessionTest.RemoteCommands 1727950 1 webkit-bug-importer 2021-02-10 21:13:29 -0800 <rdar://problem/74220428> 1727951 2 ryanhaddad 2021-02-10 21:14:15 -0800 Pasted in the wrong history link. Here is the right one: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo 1727952 3 ryanhaddad 2021-02-10 21:16:50 -0800 It looks like this test has been flaky on iOS for a while, but the macOS flakiness is relatively new (appears to have started with https://trac.webkit.org/changeset/272414/webkit according to test history) 1727953 4 ryanhaddad 2021-02-10 21:21:04 -0800 (In reply to Ryan Haddad from comment #3) > It looks like this test has been flaky on iOS for a while Looking more closely, that is known and tracked by https://bugs.webkit.org/show_bug.cgi?id=221499 1728320 5 ap 2021-02-11 15:17:42 -0800 Dupe of bug 221499? 1728321 6 ap 2021-02-11 15:18:17 -0800 Sorry, I now see that you said that - but should we dupe? 1728757 7 ryanhaddad 2021-02-12 13:44:23 -0800 (In reply to Alexey Proskuryakov from comment #6) > Sorry, I now see that you said that - but should we dupe? The macOS failure is still in need of investigation. 1756701 8 427708 cdumez 2021-05-04 15:59:10 -0700 Created attachment 427708 Patch 1756938 9 ews-feeder 2021-05-05 07:48:12 -0700 Committed r277018 (237334@main): <https://commits.webkit.org/237334@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427708. 1757028 10 cdumez 2021-05-05 12:15:19 -0700 Reopening since the test is still flaky. 1757086 11 427803 cdumez 2021-05-05 13:45:34 -0700 Created attachment 427803 Patch 1757278 12 427803 youennf 2021-05-06 00:47:51 -0700 Comment on attachment 427803 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427803&action=review > Tools/ChangeLog:10 > + relying on [webView _isPlayingAudio]. Also use a test page with a single video element instead Does this uncover a potential issue with _isPlayingAudio in case of crash? > Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:320 > + [webView objectByEvaluatingJavaScriptWithUserGesture:@"document.getElementsByTagName('video')[0].play() && true"]; Why not just doing @"play()"? 1757397 13 cdumez 2021-05-06 07:47:45 -0700 (In reply to youenn fablet from comment #12) > Comment on attachment 427803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427803&action=review > > > Tools/ChangeLog:10 > > + relying on [webView _isPlayingAudio]. Also use a test page with a single video element instead > > Does this uncover a potential issue with _isPlayingAudio in case of crash? Maybe, we'll see if this speculative fix is successful. > > Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:320 > > + [webView objectByEvaluatingJavaScriptWithUserGesture:@"document.getElementsByTagName('video')[0].play() && true"]; > > Why not just doing @"play()"? Good point, will update. 1757398 14 427884 cdumez 2021-05-06 07:48:41 -0700 Created attachment 427884 Patch 1757400 15 cdumez 2021-05-06 07:50:08 -0700 (In reply to Chris Dumez from comment #13) > (In reply to youenn fablet from comment #12) > > Comment on attachment 427803 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=427803&action=review > > > > > Tools/ChangeLog:10 > > > + relying on [webView _isPlayingAudio]. Also use a test page with a single video element instead > > > > Does this uncover a potential issue with _isPlayingAudio in case of crash? > > Maybe, we'll see if this speculative fix is successful. Although I don't think this has anything to do with crash recovery since _isPlayingAudio would refuse to become true *before* the crash on the bots. 1757487 16 ews-feeder 2021-05-06 10:21:03 -0700 Committed r277101 (237403@main): <https://commits.webkit.org/237403@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427884. 1757634 17 jenner 2021-05-06 14:05:16 -0700 *** Bug 225475 has been marked as a duplicate of this bug. *** 1757744 18 ap 2021-05-06 17:36:27 -0700 Given the above, do we need a separate bug about [webView _isPlayingAudio] not working reliably? Please file one if we do. 1758502 19 cdumez 2021-05-10 08:56:03 -0700 No recent API test failures on macOS, it looks like this was successful. 427708 2021-05-04 15:59:10 -0700 2021-05-05 13:45:32 -0700 Patch bug-221742-20210504155909.patch text/plain 1880 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2OTg1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWViNjA2MDhjNDA2ZTU0YTRhOGZmM2ZiMjJjYzkwOTUy NmNjZGY1Ny4uZmY1ZGRiYWQ1OTQ0OTdkNDI4YWNkYTBiYmU5NDJlYzJkMGZmMTJjNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTA1LTA0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjI3MjQxND8pOiBbbWFjT1NdIFRlc3RXZWJLaXRBUEkuR1BVUHJvY2Vz cy5DcmFzaFdoaWxlUGxheWluZ1ZpZGVvIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNzQyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS83NDIyMDQyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtlIHN1cmUgdGhlIHZpZGVvIGlzIGxvb3Bpbmcgc28gdGhhdCBpdCBj YW5ub3Qgc3RvcCBwbGF5aW5nIGJlZm9yZSB0aGUgZW5kIG9mIHRoZSB0ZXN0LgorICAgICAgICBU aGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4IHNpbmNlIEkgaGF2ZW4ndCBiZWVuIGFibGUgdG8gcmVw cm9kdWNlIHRoZSBpc3N1ZS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Q29jb2EvR1BVUHJvY2Vzcy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA1LTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdHJ5IGFu ZCByZS1lbmFibGUgQXBwbGVMYW5ndWFnZXNUZXN0LlVwZGF0ZUFwcGxlTGFuZ3VhZ2VzIG9uIEFw cGxlIFNpbGljb24uCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dENvY29hL0dQVVByb2Nlc3MubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL0dQVVByb2Nlc3MubW0KaW5kZXggMzdmZGI2MjM0YmVjN2VhMzA1MWIwODRmOTcwZGRiYWUy NzRiNDQ3Zi4uZGIwNzRjMTU4ZDUyMzJiYTM3MjUzNzRiNjI3OTIzMjNkNTE2ZTJmNSAxMDA2NDQK LS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9HUFVQcm9jZXNzLm1t CisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvR1BVUHJvY2Vzcy5t bQpAQCAtMzE3LDYgKzMxNywxMyBAQCBURVNUKEdQVVByb2Nlc3MsIENyYXNoV2hpbGVQbGF5aW5n VmlkZW8pCiAgICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOkAibGFy Z2UtdmlkZW9zLXdpdGgtYXVkaW8iXTsKIAogICAgIF9fYmxvY2sgYm9vbCBkb25lID0gZmFsc2U7 CisgICAgW3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0OkAiZG9jdW1lbnQuZ2V0RWxlbWVudHNC eVRhZ05hbWUoJ3ZpZGVvJylbMF0ubG9vcCA9IHRydWU7IiBjb21wbGV0aW9uSGFuZGxlcjpeKGlk IHJlc3VsdCwgTlNFcnJvciAqZXJyb3IpIHsKKyAgICAgICAgRVhQRUNUX1RSVUUoIWVycm9yKTsK KyAgICAgICAgZG9uZSA9IHRydWU7CisgICAgfV07CisgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6 cnVuKCZkb25lKTsKKworICAgIGRvbmUgPSBmYWxzZTsKICAgICBbd2ViVmlldyBldmFsdWF0ZUph dmFTY3JpcHQ6QCJkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgndmlkZW8nKVswXS5wbGF5 KCkgJiYgdHJ1ZSIgY29tcGxldGlvbkhhbmRsZXI6XihpZCByZXN1bHQsIE5TRXJyb3IgKmVycm9y KSB7CiAgICAgICAgIEVYUEVDVF9UUlVFKCFlcnJvcik7CiAgICAgICAgIGRvbmUgPSB0cnVlOwo= 427803 2021-05-05 13:45:34 -0700 2021-05-06 07:48:39 -0700 Patch bug-221742-20210505134533.patch text/plain 4328 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MDE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDBiOTM5OGQ0YmMxMjhlNWNlYjM3MTRiNGM0YzY5YTZl ZDMwYmY0ZC4uNmRkMGNhMGQ0OTNhOWFjNzVhYzE0ODNlNzRmZTZmMjQ2N2JjNGQ2OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA1LTA1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjI3MjQxND8pOiBbbWFjT1NdIFRlc3RXZWJLaXRBUEkuR1BVUHJvY2Vz cy5DcmFzaFdoaWxlUGxheWluZ1ZpZGVvIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNzQyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS83NDIyMDQyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDaGVjayB0aGF0IHZpZGVvLmN1cnJlbnRUaW1lIGlzIGNoYW5naW5nIHRv IGRldGVybWluZSBpZiB0aGUgdmlkZW8gaXMgcGxheWluZywgaW5zdGVhZCBvZgorICAgICAgICBy ZWx5aW5nIG9uIFt3ZWJWaWV3IF9pc1BsYXlpbmdBdWRpb10uIEFsc28gdXNlIGEgdGVzdCBwYWdl IHdpdGggYSBzaW5nbGUgdmlkZW8gZWxlbWVudCBpbnN0ZWFkCisgICAgICAgIG9mIG11bHRpcGxl LiBJIGFtIGhvcGluZyB0aGlzIHdpbGwgbWFrZSB0aGUgdGVzdCBtb3JlIHJlbGlhYmxlIG9yIGF0 IGxlYXN0IHNoYWRlIHNvbWUgbGlnaHQgb24KKyAgICAgICAgd2h5IHRoaXMgaXMgZmxha3kuCisK KyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0dQVVByb2Nlc3MubW06 CisgICAgICAgIChURVNUKToKKwogMjAyMS0wNS0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFBvcnQgRmlsZXN5c3RlbTo6ZmlsZU1ldGFkYXRhKCkgJiBGaWxl c3lzdGVtOjpnZXRGaWxlTW9kaWZpY2F0aW9uVGltZSgpIHRvIHN0ZDo6ZmlsZXN5c3RlbQpkaWZm IC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9HUFVQcm9jZXNz Lm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9HUFVQcm9jZXNzLm1t CmluZGV4IGRiMDc0YzE1OGQ1MjMyYmEzNzI1Mzc0YjYyNzkyMzIzZDUxNmUyZjUuLmU3ZWVkNWU0 YjlhYzI0M2M0YTRkOTFiZDc5M2Y0MTI2Mzg0NTIyN2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvR1BVUHJvY2Vzcy5tbQorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0dQVVByb2Nlc3MubW0KQEAgLTMxNCwyMSArMzE0 LDEwIEBAIFRFU1QoR1BVUHJvY2VzcywgQ3Jhc2hXaGlsZVBsYXlpbmdWaWRlbykKICAgICBXS1By ZWZlcmVuY2VzU2V0Qm9vbFZhbHVlRm9yS2V5Rm9yVGVzdGluZygoX19icmlkZ2UgV0tQcmVmZXJl bmNlc1JlZilbY29uZmlndXJhdGlvbiBwcmVmZXJlbmNlc10sIHRydWUsIFdLU3RyaW5nQ3JlYXRl V2l0aFVURjhDU3RyaW5nKCJVc2VHUFVQcm9jZXNzRm9yTWVkaWFFbmFibGVkIikpOwogCiAgICAg YXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJh bWU6Q0dSZWN0TWFrZSgwLCAwLCA0MDAsIDQwMCkgY29uZmlndXJhdGlvbjpjb25maWd1cmF0aW9u LmdldCgpXSk7Ci0gICAgW3dlYlZpZXcgc3luY2hyb25vdXNseUxvYWRUZXN0UGFnZU5hbWVkOkAi bGFyZ2UtdmlkZW9zLXdpdGgtYXVkaW8iXTsKKyAgICBbd2ViVmlldyBzeW5jaHJvbm91c2x5TG9h ZFRlc3RQYWdlTmFtZWQ6QCJsYXJnZS12aWRlby13aXRoLWF1ZGlvIl07CiAKLSAgICBfX2Jsb2Nr IGJvb2wgZG9uZSA9IGZhbHNlOwotICAgIFt3ZWJWaWV3IGV2YWx1YXRlSmF2YVNjcmlwdDpAImRv Y3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycpWzBdLmxvb3AgPSB0cnVlOyIgY29t cGxldGlvbkhhbmRsZXI6XihpZCByZXN1bHQsIE5TRXJyb3IgKmVycm9yKSB7Ci0gICAgICAgIEVY UEVDVF9UUlVFKCFlcnJvcik7Ci0gICAgICAgIGRvbmUgPSB0cnVlOwotICAgIH1dOwotICAgIFRl c3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZG9uZSk7Ci0KLSAgICBkb25lID0gZmFsc2U7Ci0gICAg W3dlYlZpZXcgZXZhbHVhdGVKYXZhU2NyaXB0OkAiZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05h bWUoJ3ZpZGVvJylbMF0ucGxheSgpICYmIHRydWUiIGNvbXBsZXRpb25IYW5kbGVyOl4oaWQgcmVz dWx0LCBOU0Vycm9yICplcnJvcikgewotICAgICAgICBFWFBFQ1RfVFJVRSghZXJyb3IpOwotICAg ICAgICBkb25lID0gdHJ1ZTsKLSAgICB9XTsKLSAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4o JmRvbmUpOworICAgIFt3ZWJWaWV3IG9iamVjdEJ5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1 bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgndmlkZW8nKVswXS5sb29wID0gdHJ1ZTsiXTsKKyAg ICBbd2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0V2l0aFVzZXJHZXN0dXJlOkAi ZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3ZpZGVvJylbMF0ucGxheSgpICYmIHRydWUi XTsKIAogICAgIGF1dG8gd2ViVmlld1BJRCA9IFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmll cl07CiAKQEAgLTM0MywxMSArMzMyLDIwIEBAIFRFU1QoR1BVUHJvY2VzcywgQ3Jhc2hXaGlsZVBs YXlpbmdWaWRlbykKICAgICAgICAgcmV0dXJuOwogICAgIGF1dG8gZ3B1UHJvY2Vzc1BJRCA9IFtw cm9jZXNzUG9vbCBfZ3B1UHJvY2Vzc0lkZW50aWZpZXJdOwogCi0gICAgLy8gQXVkaW8gc2hvdWxk IGJlIHBsYXlpbmcuCi0gICAgdGltZW91dCA9IDA7Ci0gICAgd2hpbGUgKCFbd2ViVmlldyBfaXNQ bGF5aW5nQXVkaW9dICYmIHRpbWVvdXQrKyA8IDEwMCkKLSAgICAgICAgVGVzdFdlYktpdEFQSTo6 VXRpbDo6c2xlZXAoMC4xKTsKLSAgICBFWFBFQ1RfVFJVRShbd2ViVmlldyBfaXNQbGF5aW5nQXVk aW9dKTsKKyAgICAvLyBWaWRlbyBzaG91bGQgYmUgcGxheWluZy4KKyAgICBhdXRvIGVuc3VyZUlz UGxheWluZyA9IFsmXSB7CisgICAgICAgIGRvdWJsZSBpbml0aWFsVGltZSA9IFtbd2ViVmlldyBv YmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAiZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05h bWUoJ3ZpZGVvJylbMF0uY3VycmVudFRpbWUiXSBkb3VibGVWYWx1ZV07CisgICAgICAgIHRpbWVv dXQgPSAwOworICAgICAgICBkb3VibGUgY3VycmVudFRpbWUgPSBpbml0aWFsVGltZTsKKyAgICAg ICAgZG8geworICAgICAgICAgICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6c2xlZXAoMC4xKTsKKyAg ICAgICAgICAgIGN1cnJlbnRUaW1lID0gW1t3ZWJWaWV3IG9iamVjdEJ5RXZhbHVhdGluZ0phdmFT Y3JpcHQ6QCJkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgndmlkZW8nKVswXS5jdXJyZW50 VGltZSJdIGRvdWJsZVZhbHVlXTsKKyAgICAgICAgICAgIGlmIChmYWJzKGN1cnJlbnRUaW1lIC0g aW5pdGlhbFRpbWUpID4gMC4wMSkKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfSB3 aGlsZSAodGltZW91dCsrIDwgMTAwKTsKKyAgICAgICAgcmV0dXJuIGZhYnMoY3VycmVudFRpbWUg LSBpbml0aWFsVGltZSkgPiAwLjAxOworICAgIH07CisgICAgRVhQRUNUX1RSVUUoZW5zdXJlSXNQ bGF5aW5nKCkpOwogCiAgICAgLy8gS2lsbCB0aGUgR1BVIFByb2Nlc3MuCiAgICAga2lsbChncHVQ cm9jZXNzUElELCA5KTsKQEAgLTM2NCwxMCArMzYyLDcgQEAgVEVTVChHUFVQcm9jZXNzLCBDcmFz aFdoaWxlUGxheWluZ1ZpZGVvKQogICAgIEVYUEVDVF9FUSh3ZWJWaWV3UElELCBbd2ViVmlldyBf d2ViUHJvY2Vzc0lkZW50aWZpZXJdKTsKIAogICAgIC8vIEF1ZGlvIHNob3VsZCByZXN1bWUgcGxh eWluZy4KLSAgICB0aW1lb3V0ID0gMDsKLSAgICB3aGlsZSAoIVt3ZWJWaWV3IF9pc1BsYXlpbmdB dWRpb10gJiYgdGltZW91dCsrIDwgMTAwKQotICAgICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpz bGVlcCgwLjEpOwotICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IF9pc1BsYXlpbmdBdWRpb10pOwor ICAgIEVYUEVDVF9UUlVFKGVuc3VyZUlzUGxheWluZygpKTsKIAogICAgIEVYUEVDVF9FUShncHVQ cm9jZXNzUElELCBbcHJvY2Vzc1Bvb2wgX2dwdVByb2Nlc3NJZGVudGlmaWVyXSk7CiAgICAgRVhQ RUNUX0VRKHdlYlZpZXdQSUQsIFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl0pOwo= 427884 2021-05-06 07:48:41 -0700 2021-05-06 10:21:04 -0700 Patch bug-221742-20210506074841.patch text/plain 4282 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3MDg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDBmM2QxZmRmMjZjZTBkN2NhNTNjMTFkMTg5OWM5ZmZk NzFlYmFkMy4uM2Q2ZjQ3ZDgzNmQ4MWExNjhlMjlhNWU5ZDY2NTBhYTI4OWNkNWVmNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA1LTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjI3MjQxND8pOiBbbWFjT1NdIFRlc3RXZWJLaXRBUEkuR1BVUHJvY2Vz cy5DcmFzaFdoaWxlUGxheWluZ1ZpZGVvIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNzQyCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS83NDIyMDQyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0 LgorCisgICAgICAgIENoZWNrIHRoYXQgdmlkZW8uY3VycmVudFRpbWUgaXMgY2hhbmdpbmcgdG8g ZGV0ZXJtaW5lIGlmIHRoZSB2aWRlbyBpcyBwbGF5aW5nLCBpbnN0ZWFkIG9mCisgICAgICAgIHJl bHlpbmcgb24gW3dlYlZpZXcgX2lzUGxheWluZ0F1ZGlvXS4gQWxzbyB1c2UgYSB0ZXN0IHBhZ2Ug d2l0aCBhIHNpbmdsZSB2aWRlbyBlbGVtZW50IGluc3RlYWQKKyAgICAgICAgb2YgbXVsdGlwbGUu IEkgYW0gaG9waW5nIHRoaXMgd2lsbCBtYWtlIHRoZSB0ZXN0IG1vcmUgcmVsaWFibGUgb3IgYXQg bGVhc3Qgc2hhZGUgc29tZSBsaWdodCBvbgorICAgICAgICB3aHkgdGhpcyBpcyBmbGFreS4KKwor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvR1BVUHJvY2Vzcy5tbToK KyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA1LTA1ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5v QGlnYWxpYS5jb20+CiAKICAgICAgICAgW2J1aWxkLndlYmtpdC5vcmddIEFkZCBuZXcgcG9zdC1j b21taXQgYnVpbGRlciBXUEUtTGludXgtNjQtYml0LVJlbGVhc2UtTm9uLVVuaWZpZWQtQnVpbGQK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvR1BVUHJv Y2Vzcy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvR1BVUHJvY2Vz cy5tbQppbmRleCBkYjA3NGMxNThkNTIzMmJhMzcyNTM3NGI2Mjc5MjMyM2Q1MTZlMmY1Li44NDA5 Njk3NTYxNDQ2ZWJmOGFlOGM2NWZkYmM5ZTEwMjI5NDNkMWYzIDEwMDY0NAotLS0gYS9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0dQVVByb2Nlc3MubW0KKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9HUFVQcm9jZXNzLm1tCkBAIC0zMTQsMjEg KzMxNCwxMCBAQCBURVNUKEdQVVByb2Nlc3MsIENyYXNoV2hpbGVQbGF5aW5nVmlkZW8pCiAgICAg V0tQcmVmZXJlbmNlc1NldEJvb2xWYWx1ZUZvcktleUZvclRlc3RpbmcoKF9fYnJpZGdlIFdLUHJl ZmVyZW5jZXNSZWYpW2NvbmZpZ3VyYXRpb24gcHJlZmVyZW5jZXNdLCB0cnVlLCBXS1N0cmluZ0Ny ZWF0ZVdpdGhVVEY4Q1N0cmluZygiVXNlR1BVUHJvY2Vzc0Zvck1lZGlhRW5hYmxlZCIpKTsKIAog ICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0 aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgNDAwLCA0MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJh dGlvbi5nZXQoKV0pOwotICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1l ZDpAImxhcmdlLXZpZGVvcy13aXRoLWF1ZGlvIl07CisgICAgW3dlYlZpZXcgc3luY2hyb25vdXNs eUxvYWRUZXN0UGFnZU5hbWVkOkAibGFyZ2UtdmlkZW8td2l0aC1hdWRpbyJdOwogCi0gICAgX19i bG9jayBib29sIGRvbmUgPSBmYWxzZTsKLSAgICBbd2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6 QCJkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFnTmFtZSgndmlkZW8nKVswXS5sb29wID0gdHJ1ZTsi IGNvbXBsZXRpb25IYW5kbGVyOl4oaWQgcmVzdWx0LCBOU0Vycm9yICplcnJvcikgewotICAgICAg ICBFWFBFQ1RfVFJVRSghZXJyb3IpOwotICAgICAgICBkb25lID0gdHJ1ZTsKLSAgICB9XTsKLSAg ICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOwotCi0gICAgZG9uZSA9IGZhbHNlOwot ICAgIFt3ZWJWaWV3IGV2YWx1YXRlSmF2YVNjcmlwdDpAImRvY3VtZW50LmdldEVsZW1lbnRzQnlU YWdOYW1lKCd2aWRlbycpWzBdLnBsYXkoKSAmJiB0cnVlIiBjb21wbGV0aW9uSGFuZGxlcjpeKGlk IHJlc3VsdCwgTlNFcnJvciAqZXJyb3IpIHsKLSAgICAgICAgRVhQRUNUX1RSVUUoIWVycm9yKTsK LSAgICAgICAgZG9uZSA9IHRydWU7Ci0gICAgfV07Ci0gICAgVGVzdFdlYktpdEFQSTo6VXRpbDo6 cnVuKCZkb25lKTsKKyAgICBbd2ViVmlldyBvYmplY3RCeUV2YWx1YXRpbmdKYXZhU2NyaXB0OkAi ZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3ZpZGVvJylbMF0ubG9vcCA9IHRydWU7Il07 CisgICAgW3dlYlZpZXcgb2JqZWN0QnlFdmFsdWF0aW5nSmF2YVNjcmlwdFdpdGhVc2VyR2VzdHVy ZTpAInBsYXkoKSJdOwogCiAgICAgYXV0byB3ZWJWaWV3UElEID0gW3dlYlZpZXcgX3dlYlByb2Nl c3NJZGVudGlmaWVyXTsKIApAQCAtMzQzLDExICszMzIsMjAgQEAgVEVTVChHUFVQcm9jZXNzLCBD cmFzaFdoaWxlUGxheWluZ1ZpZGVvKQogICAgICAgICByZXR1cm47CiAgICAgYXV0byBncHVQcm9j ZXNzUElEID0gW3Byb2Nlc3NQb29sIF9ncHVQcm9jZXNzSWRlbnRpZmllcl07CiAKLSAgICAvLyBB dWRpbyBzaG91bGQgYmUgcGxheWluZy4KLSAgICB0aW1lb3V0ID0gMDsKLSAgICB3aGlsZSAoIVt3 ZWJWaWV3IF9pc1BsYXlpbmdBdWRpb10gJiYgdGltZW91dCsrIDwgMTAwKQotICAgICAgICBUZXN0 V2ViS2l0QVBJOjpVdGlsOjpzbGVlcCgwLjEpOwotICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IF9p c1BsYXlpbmdBdWRpb10pOworICAgIC8vIFZpZGVvIHNob3VsZCBiZSBwbGF5aW5nLgorICAgIGF1 dG8gZW5zdXJlSXNQbGF5aW5nID0gWyZdIHsKKyAgICAgICAgZG91YmxlIGluaXRpYWxUaW1lID0g W1t3ZWJWaWV3IG9iamVjdEJ5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5nZXRFbGVt ZW50c0J5VGFnTmFtZSgndmlkZW8nKVswXS5jdXJyZW50VGltZSJdIGRvdWJsZVZhbHVlXTsKKyAg ICAgICAgdGltZW91dCA9IDA7CisgICAgICAgIGRvdWJsZSBjdXJyZW50VGltZSA9IGluaXRpYWxU aW1lOworICAgICAgICBkbyB7CisgICAgICAgICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpzbGVl cCgwLjEpOworICAgICAgICAgICAgY3VycmVudFRpbWUgPSBbW3dlYlZpZXcgb2JqZWN0QnlFdmFs dWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycp WzBdLmN1cnJlbnRUaW1lIl0gZG91YmxlVmFsdWVdOworICAgICAgICAgICAgaWYgKGZhYnMoY3Vy cmVudFRpbWUgLSBpbml0aWFsVGltZSkgPiAwLjAxKQorICAgICAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICB9IHdoaWxlICh0aW1lb3V0KysgPCAxMDApOworICAgICAgICByZXR1cm4gZmFicyhj dXJyZW50VGltZSAtIGluaXRpYWxUaW1lKSA+IDAuMDE7CisgICAgfTsKKyAgICBFWFBFQ1RfVFJV RShlbnN1cmVJc1BsYXlpbmcoKSk7CiAKICAgICAvLyBLaWxsIHRoZSBHUFUgUHJvY2Vzcy4KICAg ICBraWxsKGdwdVByb2Nlc3NQSUQsIDkpOwpAQCAtMzY0LDEwICszNjIsNyBAQCBURVNUKEdQVVBy b2Nlc3MsIENyYXNoV2hpbGVQbGF5aW5nVmlkZW8pCiAgICAgRVhQRUNUX0VRKHdlYlZpZXdQSUQs IFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl0pOwogCiAgICAgLy8gQXVkaW8gc2hvdWxk IHJlc3VtZSBwbGF5aW5nLgotICAgIHRpbWVvdXQgPSAwOwotICAgIHdoaWxlICghW3dlYlZpZXcg X2lzUGxheWluZ0F1ZGlvXSAmJiB0aW1lb3V0KysgPCAxMDApCi0gICAgICAgIFRlc3RXZWJLaXRB UEk6OlV0aWw6OnNsZWVwKDAuMSk7Ci0gICAgRVhQRUNUX1RSVUUoW3dlYlZpZXcgX2lzUGxheWlu Z0F1ZGlvXSk7CisgICAgRVhQRUNUX1RSVUUoZW5zdXJlSXNQbGF5aW5nKCkpOwogCiAgICAgRVhQ RUNUX0VRKGdwdVByb2Nlc3NQSUQsIFtwcm9jZXNzUG9vbCBfZ3B1UHJvY2Vzc0lkZW50aWZpZXJd KTsKICAgICBFWFBFQ1RfRVEod2ViVmlld1BJRCwgW3dlYlZpZXcgX3dlYlByb2Nlc3NJZGVudGlm aWVyXSk7Cg==