221740 2021-02-10 21:00:58 -0800 Crash when UI-side compositing is enabled on macOS 2021-02-11 08:10:15 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser jer.noble simon.fraser thorton webkit-bug-importer oldest_to_newest 1727942 0 simon.fraser 2021-02-10 21:00:58 -0800 Crash when UI-side compositing is enabled on macOS 1727943 1 419944 simon.fraser 2021-02-10 21:02:31 -0800 Created attachment 419944 Patch 1727946 2 simon.fraser 2021-02-10 21:05:31 -0800 Backtrace is: frame #1: 0x0000000381eadbe6 WebKit`WebKit::WebPage::mainFrame(this=0x0000000000000000) const at WebPage.cpp:5476:12 frame #2: 0x0000000381ead615 WebKit`WebKit::WebPage::mainFrameView(this=0x0000000000000000) const at WebPage.cpp:5481:24 * frame #3: 0x00000003818f56d1 WebKit`auto WebKit::WebProcess::updatePageScreenProperties(this=0x00007ffee961bd00, page=0x00000003b71f6528)::$_16::operator()<WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> > >(WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> >&) const at WebProcessCocoa.mm:1169:53 frame #4: 0x00000003818bd523 WebKit`bool WTF::allOf<WTF::SizedIteratorRange<WTF::HashMap<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::PageIdentifierType> >, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::PageIdentifierType> >, WTF::HashTraits<WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> > > >, WTF::HashTableValuesIterator<WTF::HashTable<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> > > >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::PageIdentifierType> >, WTF::HashMap<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::PageIdentifierType> >, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::PageIdentifierType> >, WTF::HashTraits<WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> > > >::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::PageIdentifierType> > >, WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WTF::RefPtr<WebKit::WebPage, WTF::RawPtrTraits<WebKit::WebPage>, WTF::DefaultRefDerefTraits<WebKit::WebPage> > > >, WebKit::WebProcess::updatePageScreenProperties()::$_16>(container=0x00007ffee961bdc0, allOfFunction=(anonymous class) @ 0x00007ffee961bd00)::$_16) at Algorithms.h:51:14 frame #5: 0x00000003818bd3be WebKit`WebKit::WebProcess::updatePageScreenProperties(this=0x00000003b71f2000) at WebProcessCocoa.mm:1168:36 frame #6: 0x0000000381eb21eb WebKit`WebKit::WebPage::windowScreenDidChange(this=0x00007ffc36010408, displayID=4294967289, nominalFramesPerSecond=Optional<unsigned int> @ 0x00007ffee961bf48) at WebPage.cpp:2084:29 frame #7: 0x000000038075eaca WebKit`WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea(this=0x00000003b71f5aa0, webPage=0x00007ffc36010408, parameters=0x00007ffee961c990) at RemoteLayerTreeDrawingArea.mm:75:13 frame #8: 0x000000038075ff05 WebKit`WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea(this=0x00000003b71f5aa0, webPage=0x00007ffc36010408, parameters=0x00007ffee961c990) at RemoteLayerTreeDrawingArea.mm:64:1 frame #9: 0x0000000381cd7712 WebKit`std::__1::__unique_if<WebKit::RemoteLayerTreeDrawingArea>::__unique_single std::__1::make_unique<WebKit::RemoteLayerTreeDrawingArea, WebKit::WebPage&, WebKit::WebPageCreationParameters const&>(__args=0x00007ffc36010408, __args=0x00007ffee961c990) at memory:3131:32 frame #10: 0x0000000381cca584 WebKit`decltype(args=0x00007ffc36010408, args=0x00007ffee961c990) WTF::makeUnique<WebKit::RemoteLayerTreeDrawingArea, WebKit::WebPage&, WebKit::WebPageCreationParameters const&>(WebKit::WebPage&, WebKit::WebPageCreationParameters const&) at StdLibExtras.h:507:12 frame #11: 0x0000000381cca463 WebKit`WebKit::DrawingArea::create(webPage=0x00007ffc36010408, parameters=0x00007ffee961c990) at DrawingArea.cpp:56:16 frame #12: 0x0000000381ea4100 WebKit`WebKit::WebPage::WebPage(this=0x00007ffc36010408, pageID=(m_identifier = 6), parameters=0x00007ffee961c990) at WebPage.cpp:632:21 frame #13: 0x0000000381ea2925 WebKit`WebKit::WebPage::WebPage(this=0x00007ffc36010408, pageID=(m_identifier = 6), parameters=0x00007ffee961c990) at WebPage.cpp:517:1 frame #14: 0x0000000381ea2831 WebKit`WebKit::WebPage::create(pageID=(m_identifier = 6), parameters=0x00007ffee961c990) at WebPage.cpp:413:39 frame #15: 0x000000038190bfd4 WebKit`WebKit::WebProcess::createWebPage(this=0x00000003b71f2000, pageID=(m_identifier = 6), parameters=0x00007ffee961c990) at WebProcess.cpp:736:34 frame #16: 0x000000038210df0c WebKit`void IPC::callMemberFunctionImpl<WebKit::WebProcess, void (WebKit::WebProcess::*)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters>, 0ul, 1ul>(object=0x00000003b71f2000, function=f0 be 90 81 03 00 00 00 00 00 00 00 00 00 00 00, args=size=2, (null)=std::__1::index_sequence<0UL, 1UL> @ 0x00007ffee961c8c8)(WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters&&), std::__1::tuple<WTF::ObjectIdentifier<WebCore::PageIdentifierType>, WebKit::WebPageCreationParameters>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) at HandleMessage.h:42:5 1728091 3 ews-feeder 2021-02-11 08:09:15 -0800 Committed r272728: <https://commits.webkit.org/r272728> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419944. 1728092 4 webkit-bug-importer 2021-02-11 08:10:15 -0800 <rdar://problem/74234544> 419944 2021-02-10 21:02:31 -0800 2021-02-11 08:09:16 -0800 Patch bug-221740-20210210210230.patch text/plain 1752 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM5MTQ5YmZlZmEzYzkyNTU2 ZjI5MjQ0YTAzZDUwNzNhOTFhNDEzNTMuLjVkYjAzMmY1NGZlNTQwYTJlOGRkODMxOGFkODU3NjFh MTFiYmUwNmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDItMTAgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggd2hlbiBVSS1z aWRlIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQgb24gbWFjT1MKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTc0MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gVUktc2lkZSBjb21wb3NpdGluZyBpcyBl bmFibGVkIG9uIG1hY09TLCBXZWJQcm9jZXNzOjp1cGRhdGVQYWdlU2NyZWVuUHJvcGVydGllcygp CisgICAgICAgIGNyYXNoZXMgYmVjYXVzZSBhbGxPZihtX3BhZ2VNYXAudmFsdWVzKCksIC4uLikg cmV0dXJuIGEgbnVsbCBXZWJQYWdlLiBXZSdyZSBpbnNpZGUgCisgICAgICAgIFdlYlByb2Nlc3M6 OmNyZWF0ZVdlYlBhZ2UoKSBoZXJlLCBzbyBoYXZlbid0IHNldCB0aGUgSGFzaE1hcCB2YWx1ZSB5 ZXQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToKKyAg ICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6dXBkYXRlUGFnZVNjcmVlblByb3BlcnRpZXMpOgor CiAyMDIxLTAyLTEwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKHIyNjk4MjQpIElPU3VyZmFjZSBhbGxvY2F0aW9uIGZhaWx1cmUg Y2F1c2VzIGNyYXNoIGluIFJlbW90ZUxheWVyQmFja2luZ1N0b3JlOjpkaXNwbGF5KCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0g Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4 IGM5NWQ1MzY4ZWViZTYwZDFiNjU3MTNmYWYzYmNjMTFjYjg2Y2IwYjEuLmFmOTNmYzc0YTYwZjAy OTNjYWJkNTdiYTJmNTE3NWMzZDkwY2FjNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQpAQCAtMTE2Niw3ICsxMTY2LDcgQEAgdm9p ZCBXZWJQcm9jZXNzOjp1cGRhdGVQYWdlU2NyZWVuUHJvcGVydGllcygpCiAgICAgfQogCiAgICAg Ym9vbCBhbGxQYWdlc0FyZU9uSERSU2NyZWVucyA9IGFsbE9mKG1fcGFnZU1hcC52YWx1ZXMoKSwg W10gKGF1dG8mIHBhZ2UpIHsKLSAgICAgICAgcmV0dXJuIHNjcmVlblN1cHBvcnRzSGlnaER5bmFt aWNSYW5nZShwYWdlLT5tYWluRnJhbWVWaWV3KCkpOworICAgICAgICByZXR1cm4gcGFnZSAmJiBz Y3JlZW5TdXBwb3J0c0hpZ2hEeW5hbWljUmFuZ2UocGFnZS0+bWFpbkZyYW1lVmlldygpKTsKICAg ICB9KTsKICAgICBzZXRTaG91bGRPdmVycmlkZVNjcmVlblN1cHBvcnRzSGlnaER5bmFtaWNSYW5n ZSh0cnVlLCBhbGxQYWdlc0FyZU9uSERSU2NyZWVucyk7CiAjZW5kaWYK