221728 2021-02-10 16:37:48 -0800 Web Inspector: Grid section in Layout panel gets out of sync with grid overlay after reopening Web Inspector 2021-02-11 11:12:24 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev rcaliman bburg ews-watchlist hi inspector-bugzilla-changes joepeck rcaliman webkit-bug-importer oldest_to_newest 1727873 0 nvasilyev 2021-02-10 16:37:48 -0800 Steps: 1. Open https://labs.jensimmons.com 2. Open Elements tab, Layout panel 3. Check `div.header-wrapper` 4. Close Web Inspector; the grid overlay stays on 5. Open Web Inspector again Expected: `div.header-wrapper` remains checked Actual: `div.header-wrapper` is unchecked Notes: We should hide the overlays when closing Web Inspector. 1727874 1 webkit-bug-importer 2021-02-10 16:37:56 -0800 <rdar://problem/74212444> 1728161 2 420002 rcaliman 2021-02-11 10:44:17 -0800 Created attachment 420002 Patch 1728162 3 420002 bburg 2021-02-11 10:46:11 -0800 Comment on attachment 420002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420002&action=review r=me > Source/WebCore/ChangeLog:9 > + Hide all shown grid overlays when the WebInspector is closed. Nit: Web Inspector 1728177 4 ews-feeder 2021-02-11 11:12:22 -0800 Committed r272739: <https://commits.webkit.org/r272739> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420002. 420002 2021-02-11 10:44:17 -0800 2021-02-11 11:12:23 -0800 Patch bug-221728-20210211194416.patch text/plain 1734 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MGJmMmZkYjNiZGE0NjVlYjQ2MmMxMmY1ZTI3MTMwNGE3NjgxYzJlLi45 YTA0YTg2NDlmZTIxMWQyNWY1YmZlOTVjZWU3YThjNTZiYjEwOTJiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMjEtMDItMTEgIFJhenZhbiBDYWxpbWFuICA8cmNhbGltYW5AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEdyaWQgc2VjdGlvbiBpbiBMYXlvdXQgcGFu ZWwgZ2V0cyBvdXQgb2Ygc3luYyB3aXRoIGdyaWQgb3ZlcmxheSBhZnRlciByZW9wZW5pbmcgV2Vi IEluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIxNzI4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDIxMjQ0ND4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIaWRlIGFsbCBzaG93biBncmlk IG92ZXJsYXlzIHdoZW4gdGhlIFdlYkluc3BlY3RvciBpcyBjbG9zZWQuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvckRPTUFnZW50Ojp3aWxsRGVzdHJveUZyb250ZW5kQW5kQmFja2VuZCk6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6aGlnaGxpZ2h0Tm9kZUxpc3QpOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmJ1aWxkT2JqZWN0Rm9yTm9kZSk6Cisg ICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRPYmplY3RGb3JBY2Nlc3Np YmlsaXR5UHJvcGVydGllcyk6CisKIDIwMjEtMDItMTEgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBw bGUuY29tPgogCiAgICAgICAgIFJldHVybmluZyBzUkdCIGZyb20gQ0cgY29sb3Igc3BhY2UgZnVu Y3Rpb25zIG9uIGZhaWx1cmUgaXMgdG9vIGVycm9yIHByb25lCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRPTUFnZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IGZhMTU4 YWQyN2E2YmU3MGYwYzNmMDc2YjgyNWNhMTI4YzdlNjQ4ZTMuLjQ4ZjEyMGUzMWEzZGViM2I3NDE2 MGI4ZTc1ZWQyZDE3YzkyYzU5NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9hZ2VudHMvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9hZ2VudHMvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCkBAIC0zMjUsNiArMzI1LDggQEAgdm9p ZCBJbnNwZWN0b3JET01BZ2VudDo6d2lsbERlc3Ryb3lGcm9udGVuZEFuZEJhY2tlbmQoSW5zcGVj dG9yOjpEaXNjb25uZWN0UmVhc28KICAgICBzZXRTZWFyY2hpbmdGb3JOb2RlKGlnbm9yZWQsIGZh bHNlLCBudWxscHRyLCBmYWxzZSk7CiAgICAgaGlkZUhpZ2hsaWdodCgpOwogCisgICAgbV9vdmVy bGF5LT5jbGVhckFsbEdyaWRPdmVybGF5cygpOworCiAgICAgbV9pbnN0cnVtZW50aW5nQWdlbnRz LnNldFBlcnNpc3RlbnRET01BZ2VudChudWxscHRyKTsKICAgICBtX2RvY3VtZW50UmVxdWVzdGVk ID0gZmFsc2U7CiAgICAgcmVzZXQoKTsK