221726 2021-02-10 16:15:15 -0800 [CMake] Enable hidden visibility on JSCOnly 2021-02-10 18:22:31 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead annulen ews-watchlist gyuyoung.kim keith_miller mark.lam msaboff ryuan.choi saam sergio tzagallo ysuzuki oldest_to_newest 1727863 0 don.olmstead 2021-02-10 16:15:15 -0800 ... 1727871 1 419920 don.olmstead 2021-02-10 16:29:51 -0800 Created attachment 419920 Patch 1727875 2 419921 don.olmstead 2021-02-10 16:40:00 -0800 Created attachment 419921 Patch + a jsc.cpp modification to prevent EWS ignoring The EWS for JSCOnly builds ignored the actual patch so modifying a file to make them not skip a build. 1727896 3 419920 ysuzuki 2021-02-10 17:29:33 -0800 Comment on attachment 419920 Patch r=me 1727911 4 ews-feeder 2021-02-10 18:22:28 -0800 Committed r272699: <https://commits.webkit.org/r272699> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419920. 419920 2021-02-10 16:29:51 -0800 2021-02-10 18:22:30 -0800 Patch bug-221726.diff text/plain 2008 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwY2RlMGMxMmVhOGMuLjAw NGFlODM1Mzk3NiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAyLTEwICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j b20+CisKKyAgICAgICAgW0NNYWtlXSBFbmFibGUgaGlkZGVuIHZpc2liaWxpdHkgb24gSlNDT25s eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNzI2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHVybiBv biBoaWRkZW4gdmlzaWJpbGl0eSBmb3IgYWxsICpOSVggcG9ydHMgb2YgSlNDT25seS4gVG8gcHJv cGVybHkgZXhwb3J0IHRoZSBzeW1ib2xzCisgICAgICAgIGZyb20gV1RGL2JtYWxsb2MgT0JKRUNU IGxpYnJhcmllcyBhcmUgdXNlZC4gVGhpcyByZXF1aXJlcyBDTWFrZSAzLjEyIG9yIGxhdGVyIHRv CisgICAgICAgIGZ1bmN0aW9uIHByb3Blcmx5LgorCisgICAgICAgICogU291cmNlL2NtYWtlL09w dGlvbnNKU0NPbmx5LmNtYWtlOgorCiAyMDIxLTAyLTEwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBPcHRpb25hbGx5IGJ1aWxkIENvZyBh cyBleHRlcm5hbCBwcm9qZWN0IGFuZCByZXBsYWNlbWVudCBmb3IgTWluaUJyb3dzZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25seS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9P cHRpb25zSlNDT25seS5jbWFrZQppbmRleCA5ZGUwZmVmMTAzMTIuLjJkOGIzOGY1ZGIxZiAxMDA2 NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNKU0NPbmx5LmNtYWtlCisrKyBiL1NvdXJjZS9j bWFrZS9PcHRpb25zSlNDT25seS5jbWFrZQpAQCAtMiw2ICsyLDE5IEBAIGZpbmRfcGFja2FnZShU aHJlYWRzIFJFUVVJUkVEKQogCiBpZiAoTVNWQykKICAgICBpbmNsdWRlKE9wdGlvbnNNU1ZDKQor ZWxzZSAoKQorICAgICMgQ01ha2UgdXNlcyBPQkpFQ1QgbGlicmFyaWVzIGFzIGEgY3Jvc3MgcGxh dGZvcm0gd2F5IG9mIGRvaW5nIC0td2hvbGUtYXJjaGl2ZSB3aGljaCBpcyBuZWVkZWQKKyAgICAj IHdoZW4gY29tcGlsaW5nIGJtYWxsb2MvV1RGIGludG8gSmF2YVNjcmlwdENvcmUuIEhvd2V2ZXIg dGhleSB3ZXJlIGV4dHJlbWVseSBsaW1pdGVkIHByaW9yIHRvCisgICAgIyBDTWFrZSAzLjEyIDxo dHRwczovL2dpdGxhYi5raXR3YXJlLmNvbS9jbWFrZS9jbWFrZS8tL2lzc3Vlcy8xODAxMD4KKyAg ICAjCisgICAgIyBGSVhNRTogUmVtb3ZlIHdoZW4gY21ha2VfbWluaW11bV9yZXF1aXJlZCBpcyBy YWlzZWQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTcyNworICAg IGlmIChDTUFLRV9WRVJTSU9OIFZFUlNJT05fTEVTUyAzLjEyKQorICAgICAgICBtZXNzYWdlKEZB VEFMX0VSUk9SICJDTWFrZSAzLjEyIG9yIGdyZWF0ZXIgaXMgcmVxdWlyZWQgdG8gY29tcGlsZSBK U0NPbmx5IikKKyAgICBlbmRpZiAoKQorCisgICAgc2V0KENNQUtFX0NfVklTSUJJTElUWV9QUkVT RVQgaGlkZGVuKQorICAgIHNldChDTUFLRV9DWFhfVklTSUJJTElUWV9QUkVTRVQgaGlkZGVuKQor ICAgIHNldChDTUFLRV9WSVNJQklMSVRZX0lOTElORVNfSElEREVOIE9OKQogZW5kaWYgKCkKIAog YWRkX2RlZmluaXRpb25zKC1EQlVJTERJTkdfSlNDT05MWV9fKQpAQCAtNTIsNiArNjUsOCBAQCBl bmRpZiAoKQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyODYy CiBpZiAoTk9UIEVOQUJMRV9TVEFUSUNfSlNDIEFORCBOT1QgV0lOMzIpCiAgICAgc2V0KEphdmFT Y3JpcHRDb3JlX0xJQlJBUllfVFlQRSBTSEFSRUQpCisgICAgc2V0KGJtYWxsb2NfTElCUkFSWV9U WVBFIE9CSkVDVCkKKyAgICBzZXQoV1RGX0xJQlJBUllfVFlQRSBPQkpFQ1QpCiBlbmRpZiAoKQog CiBpZiAoV0lOMzIpCg== 419921 2021-02-10 16:40:00 -0800 2021-02-10 16:40:00 -0800 Patch + a jsc.cpp modification to prevent EWS ignoring bug-221726-ews-build.diff text/plain 1708 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2pzYy5jcHAKaW5kZXggMzFkOWFiY2IzMWUxLi43NDAwOTU3YTM2ODIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qc2MuY3BwCkBAIC0xMzEsNiArMTMxLDggQEAKICNpbmNsdWRlIDx3dGYvbGludXgv UHJvY2Vzc01lbW9yeUZvb3RwcmludC5oPgogI2VuZGlmCiAKKy8vIFRSWUlORyBUTyBGT1JDRSBB TiBFV1MgQlVJTEQKKwogI2lmIE9TKERBUldJTikgfHwgT1MoTElOVVgpCiBzdHJ1Y3QgTWVtb3J5 Rm9vdHByaW50IDogUHJvY2Vzc01lbW9yeUZvb3RwcmludCB7CiAgICAgTWVtb3J5Rm9vdHByaW50 KGNvbnN0IFByb2Nlc3NNZW1vcnlGb290cHJpbnQmIHNyYykKZGlmZiAtLWdpdCBhL1NvdXJjZS9j bWFrZS9PcHRpb25zSlNDT25seS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zSlNDT25seS5j bWFrZQppbmRleCA5ZGUwZmVmMTAzMTIuLjJkOGIzOGY1ZGIxZiAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL09wdGlvbnNKU0NPbmx5LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zSlND T25seS5jbWFrZQpAQCAtMiw2ICsyLDE5IEBAIGZpbmRfcGFja2FnZShUaHJlYWRzIFJFUVVJUkVE KQogCiBpZiAoTVNWQykKICAgICBpbmNsdWRlKE9wdGlvbnNNU1ZDKQorZWxzZSAoKQorICAgICMg Q01ha2UgdXNlcyBPQkpFQ1QgbGlicmFyaWVzIGFzIGEgY3Jvc3MgcGxhdGZvcm0gd2F5IG9mIGRv aW5nIC0td2hvbGUtYXJjaGl2ZSB3aGljaCBpcyBuZWVkZWQKKyAgICAjIHdoZW4gY29tcGlsaW5n IGJtYWxsb2MvV1RGIGludG8gSmF2YVNjcmlwdENvcmUuIEhvd2V2ZXIgdGhleSB3ZXJlIGV4dHJl bWVseSBsaW1pdGVkIHByaW9yIHRvCisgICAgIyBDTWFrZSAzLjEyIDxodHRwczovL2dpdGxhYi5r aXR3YXJlLmNvbS9jbWFrZS9jbWFrZS8tL2lzc3Vlcy8xODAxMD4KKyAgICAjCisgICAgIyBGSVhN RTogUmVtb3ZlIHdoZW4gY21ha2VfbWluaW11bV9yZXF1aXJlZCBpcyByYWlzZWQgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTcyNworICAgIGlmIChDTUFLRV9WRVJT SU9OIFZFUlNJT05fTEVTUyAzLjEyKQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJDTWFr ZSAzLjEyIG9yIGdyZWF0ZXIgaXMgcmVxdWlyZWQgdG8gY29tcGlsZSBKU0NPbmx5IikKKyAgICBl bmRpZiAoKQorCisgICAgc2V0KENNQUtFX0NfVklTSUJJTElUWV9QUkVTRVQgaGlkZGVuKQorICAg IHNldChDTUFLRV9DWFhfVklTSUJJTElUWV9QUkVTRVQgaGlkZGVuKQorICAgIHNldChDTUFLRV9W SVNJQklMSVRZX0lOTElORVNfSElEREVOIE9OKQogZW5kaWYgKCkKIAogYWRkX2RlZmluaXRpb25z KC1EQlVJTERJTkdfSlNDT05MWV9fKQpAQCAtNTIsNiArNjUsOCBAQCBlbmRpZiAoKQogIyBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcyODYyCiBpZiAoTk9UIEVOQUJM RV9TVEFUSUNfSlNDIEFORCBOT1QgV0lOMzIpCiAgICAgc2V0KEphdmFTY3JpcHRDb3JlX0xJQlJB UllfVFlQRSBTSEFSRUQpCisgICAgc2V0KGJtYWxsb2NfTElCUkFSWV9UWVBFIE9CSkVDVCkKKyAg ICBzZXQoV1RGX0xJQlJBUllfVFlQRSBPQkpFQ1QpCiBlbmRpZiAoKQogCiBpZiAoV0lOMzIpCg==