221714 2021-02-10 13:48:36 -0800 We should not static_assert on an ENABLE() macro. 2021-02-10 14:01:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1727746 0 mark.lam 2021-02-10 13:48:36 -0800 This is because the ENABLE() macro reduces to a macro expression `(defined ENABLE_##WTF_FEATURE && ENABLE_##WTF_FEATURE)` which is not a C++ expression that a static_assert can evaluate. rdar://74197896 1727750 1 419897 mark.lam 2021-02-10 13:53:29 -0800 Created attachment 419897 proposed patch. 1727753 2 419897 ysuzuki 2021-02-10 13:55:58 -0800 Comment on attachment 419897 proposed patch. r=me 1727758 3 mark.lam 2021-02-10 14:01:40 -0800 Thanks for the review. Landed in r272685: <http://trac.webkit.org/r272685>. 419897 2021-02-10 13:53:29 -0800 2021-02-10 13:55:58 -0800 proposed patch. bug-221714.patch text/plain 3681 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcyNjg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDIxLTAyLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBX ZSBzaG91bGQgbm90IHN0YXRpY19hc3NlcnQgb24gYW4gRU5BQkxFKCkgbWFjcm8uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE3MTQKKyAgICAgICAg cmRhcjovLzc0MTk3ODk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHRoZSBFTkFCTEUoKSBtYWNybyByZWR1Y2VzIHRvIGEg bWFjcm8gZXhwcmVzc2lvbgorICAgICAgICBgKGRlZmluZWQgRU5BQkxFXyMjV1RGX0ZFQVRVUkUg JiYgRU5BQkxFXyMjV1RGX0ZFQVRVUkUpYCB3aGljaCBpcyBub3QgYSBDKysKKyAgICAgICAgZXhw cmVzc2lvbiB0aGF0IGEgc3RhdGljX2Fzc2VydCBjYW4gZXZhbHVhdGUuCisKKyAgICAgICAgKiBs bGludC9MTEludERhdGEuY3BwOgorICAgICAgICAqIGxsaW50L0xMSW50RGF0YS5oOgorICAgICAg ICAoSlNDOjpMTEludDo6Z2V0Q29kZVB0cik6CisgICAgICAgIChKU0M6OkxMSW50OjpnZXRXaWRl MTZDb2RlUHRyKToKKyAgICAgICAgKEpTQzo6TExJbnQ6OmdldFdpZGUzMkNvZGVQdHIpOgorCiAy MDIxLTAyLTEwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIERv bid0IGNyYXNoIHdoZW4gcmVwYXJzaW5nIGFuIGFycm93IGZ1bmN0aW9uIGFuZCB0aGUgcGFyc2lu ZyBpbnZhcmlhbnQgaXMgYnJva2VuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TExJbnREYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xM SW50RGF0YS5oCShyZXZpc2lvbiAyNzI2ODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTExJbnREYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29w eXJpZ2h0IChDKSAyMDExLTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICog Q29weXJpZ2h0IChDKSAyMDExLTIwMjEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgog ICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVk IHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xNTUsNiArMTU1LDEwIEBAIEFMV0FZ U19JTkxJTkUgTWFjcm9Bc3NlbWJsZXJDb2RlUHRyPHRhZz4KICAgICByZXR1cm4gTWFjcm9Bc3Nl bWJsZXJDb2RlUHRyPHRhZz46OmNyZWF0ZUZyb21FeGVjdXRhYmxlQWRkcmVzcyhyZXRhZ2dlZE9w Y29kZSk7CiB9CiAKKyNpZiBFTkFCTEUoQVJNNjRFKSAmJiAhRU5BQkxFKENPTVBVVEVEX0dPVE9f T1BDT0RFUykKKyNlcnJvciBFTkFCTEUoQVJNNjRFKSByZXF1aXJlcyBFTkFCTEUoQ09NUFVURURf R09UT19PUENPREVTKSBmb3IgZ2V0Q29kZVB0ciAoYW5kIGl0cyB2YXJpYW50cykuCisjZW5kaWYK KwogdGVtcGxhdGU8UHRyVGFnIHRhZz4KIEFMV0FZU19JTkxJTkUgTWFjcm9Bc3NlbWJsZXJDb2Rl UHRyPHRhZz4gZ2V0Q29kZVB0cihPcGNvZGVJRCBvcGNvZGVJRCkKIHsKQEAgLTE2Miw3ICsxNjYs NiBAQCBBTFdBWVNfSU5MSU5FIE1hY3JvQXNzZW1ibGVyQ29kZVB0cjx0YWc+CiAgICAgY29uc3Qg T3Bjb2RlKiBvcGNvZGUgPSBnZXRPcGNvZGVBZGRyZXNzKG9wY29kZUlEKTsKICAgICByZXR1cm4g Z2V0Q29kZVB0ckltcGw8dGFnPigqb3Bjb2RlLCBvcGNvZGUpOwogI2Vsc2UKLSAgICBzdGF0aWNf YXNzZXJ0KCFFTkFCTEUoQVJNNjRFKSk7CiAgICAgcmV0dXJuIGdldENvZGVQdHJJbXBsPHRhZz4o Z2V0T3Bjb2RlKG9wY29kZUlEKSwgbnVsbHB0cik7CiAjZW5kaWYKIH0KQEAgLTE3NCw3ICsxNzcs NiBAQCBBTFdBWVNfSU5MSU5FIE1hY3JvQXNzZW1ibGVyQ29kZVB0cjx0YWc+CiAgICAgY29uc3Qg T3Bjb2RlKiBvcGNvZGUgPSBnZXRPcGNvZGVXaWRlMTZBZGRyZXNzKG9wY29kZUlEKTsKICAgICBy ZXR1cm4gZ2V0Q29kZVB0ckltcGw8dGFnPigqb3Bjb2RlLCBvcGNvZGUpOwogI2Vsc2UKLSAgICBz dGF0aWNfYXNzZXJ0KCFFTkFCTEUoQVJNNjRFKSk7CiAgICAgcmV0dXJuIGdldENvZGVQdHJJbXBs PHRhZz4oZ2V0T3Bjb2RlV2lkZTE2KG9wY29kZUlEKSwgbnVsbHB0cik7CiAjZW5kaWYKIH0KQEAg LTE4Niw3ICsxODgsNiBAQCBBTFdBWVNfSU5MSU5FIE1hY3JvQXNzZW1ibGVyQ29kZVB0cjx0YWc+ CiAgICAgY29uc3QgT3Bjb2RlKiBvcGNvZGUgPSBnZXRPcGNvZGVXaWRlMzJBZGRyZXNzKG9wY29k ZUlEKTsKICAgICByZXR1cm4gZ2V0Q29kZVB0ckltcGw8dGFnPigqb3Bjb2RlLCBvcGNvZGUpOwog I2Vsc2UKLSAgICBzdGF0aWNfYXNzZXJ0KCFFTkFCTEUoQVJNNjRFKSk7CiAgICAgcmV0dXJuIGdl dENvZGVQdHJJbXBsPHRhZz4oZ2V0T3Bjb2RlV2lkZTMyKG9wY29kZUlEKSwgbnVsbHB0cik7CiAj ZW5kaWYKIH0KQEAgLTI5NSw3ICsyOTYsNiBAQCBBTFdBWVNfSU5MSU5FIE1hY3JvQXNzZW1ibGVy Q29kZVB0cjx0YWc+CiAgICAgY29uc3QgT3Bjb2RlKiBvcGNvZGUgPSBnZXRPcGNvZGVBZGRyZXNz KG9wY29kZUlEKTsKICAgICByZXR1cm4gZ2V0Q29kZVB0ckltcGw8dGFnPigqb3Bjb2RlLCBvcGNv ZGUpOwogI2Vsc2UKLSAgICBzdGF0aWNfYXNzZXJ0KCFFTkFCTEUoQVJNNjRFKSk7CiAgICAgcmV0 dXJuIGdldENvZGVQdHJJbXBsPHRhZz4oZ2V0T3Bjb2RlKG9wY29kZUlEKSwgbnVsbHB0cik7CiAj ZW5kaWYKIH0KQEAgLTMwNyw3ICszMDcsNiBAQCBBTFdBWVNfSU5MSU5FIE1hY3JvQXNzZW1ibGVy Q29kZVB0cjx0YWc+CiAgICAgY29uc3QgT3Bjb2RlKiBvcGNvZGUgPSBnZXRPcGNvZGVXaWRlMTZB ZGRyZXNzKG9wY29kZUlEKTsKICAgICByZXR1cm4gZ2V0Q29kZVB0ckltcGw8dGFnPigqb3Bjb2Rl LCBvcGNvZGUpOwogI2Vsc2UKLSAgICBzdGF0aWNfYXNzZXJ0KCFFTkFCTEUoQVJNNjRFKSk7CiAg ICAgcmV0dXJuIGdldENvZGVQdHJJbXBsPHRhZz4oZ2V0T3Bjb2RlV2lkZTE2KG9wY29kZUlEKSwg bnVsbHB0cik7CiAjZW5kaWYKIH0KQEAgLTMxOSw3ICszMTgsNiBAQCBBTFdBWVNfSU5MSU5FIE1h Y3JvQXNzZW1ibGVyQ29kZVB0cjx0YWc+CiAgICAgY29uc3QgT3Bjb2RlKiBvcGNvZGUgPSBnZXRP cGNvZGVXaWRlMzJBZGRyZXNzKG9wY29kZUlEKTsKICAgICByZXR1cm4gZ2V0Q29kZVB0ckltcGw8 dGFnPigqb3Bjb2RlLCBvcGNvZGUpOwogI2Vsc2UKLSAgICBzdGF0aWNfYXNzZXJ0KCFFTkFCTEUo QVJNNjRFKSk7CiAgICAgcmV0dXJuIGdldENvZGVQdHJJbXBsPHRhZz4oZ2V0T3Bjb2RlV2lkZTMy KG9wY29kZUlEKSwgbnVsbHB0cik7CiAjZW5kaWYKIH0K