221709 2021-02-10 12:06:36 -0800 Bubblewrap should determine which libdirs to bind properly 2021-03-15 06:15:13 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All Linux RESOLVED FIXED P2 Normal --- 1 nina webkit-unassigned bugs-noreply cgarcia webkit-bug-importer oldest_to_newest 1727696 0 nina 2021-02-10 12:06:36 -0800 On some 32-bit systems, webkitgtk with bubblewrap will not work as is, since glibc will direct its ld cache lookups through lib32 by default if it exists; if this path is not bound, the dynamic linker will fail to find the right libs. Right now the bubblewrap launcher unconditionally binds lib64. Therefore, it should be changed to conditionally bind either lib32 or lib64. 1727698 1 419884 nina 2021-02-10 12:08:32 -0800 Created attachment 419884 patch not sure what the best way to do preprocessor conditional check for 64-bit systems would be here; this should probably be robust (but ugly) 1727710 2 419888 nina 2021-02-10 12:30:41 -0800 Created attachment 419888 better patch use a WTF macro to check the pointer size 1739408 3 ews-feeder 2021-03-15 06:15:10 -0700 Committed r274417: <https://commits.webkit.org/r274417> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419888. 419884 2021-02-10 12:08:32 -0800 2021-02-10 12:30:41 -0800 patch out.diff text/plain 1873 nina ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMmIxZjY0N2Y1YjZiLi40ZDBhOThlNjhmMGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMjEtMDItMTAgIERhbmllbCBLb2xlc2EgIDxka29sZXNhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dMSUJdIEJlIG1vcmUgc2VsZWN0aXZlIGFib3V0IGJ1Ymxld3JhcHBpbmcg bGliZGlycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIxNzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg T24gMzItYml0IHN5c3RlbXMsIGJ1YmJsZXdyYXAgbGliMzIgaW5zdGVhZCBvZiBsaWI2NC4gVGhp cyB1bmJyZWFrcworICAgICAgICBzYW5kYm94IG9uIHNvbWUgZGlzdHJpYnV0aW9ucyB0aGF0IGhh dmUgbGliMzIgKHdoaWNoIGdsaWJjIGRlZmF1bHRzCisgICAgICAgIGl0cyBsZCBjYWNoZSBsb29r dXBzIHRvKSBidXQgY29uZmlndXJlIGRlZmF1bHQgbGliZGlyIHRvIGxpYiByYXRoZXIKKyAgICAg ICAgdGhhbiBsaWIzMi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJs ZXdyYXBMYXVuY2hlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OmJ1YmJsZXdyYXBTcGF3bik6CisK IDIwMjEtMDItMTAgIFBhdHJpY2sgR3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW1dQRV1bR1RLXSBBZGQgc3VwcG9ydCBmb3IgY2xpZW50IGNlcnRpZmljYXRlIGF1dGhl bnRpY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9n bGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVu Y2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKaW5kZXggNjliNGRjNmE2YTBiLi5kYzY2 MGYzOTkyNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2ds aWIvQnViYmxld3JhcExhdW5jaGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9M YXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKQEAgLTc1OCw5ICs3NTgsMTUgQEAg R1JlZlB0cjxHU3VicHJvY2Vzcz4gYnViYmxld3JhcFNwYXduKEdTdWJwcm9jZXNzTGF1bmNoZXIq IGxhdW5jaGVyLCBjb25zdCBQcm9jZXMKICAgICAgICAgIi0tcm8tYmluZC10cnkiLCAiL3Vzci9s aWIiLCAiL3Vzci9saWIiLAogICAgICAgICAiLS1yby1iaW5kLXRyeSIsICIvdXNyL2xvY2FsL2xp YiIsICIvdXNyL2xvY2FsL2xpYiIsCiAgICAgICAgICItLXJvLWJpbmQtdHJ5IiwgTElCRElSLCBM SUJESVIsCisjaWYgR19NQVhTSVpFID4gMHhGRkZGRkZGRgogICAgICAgICAiLS1yby1iaW5kLXRy eSIsICIvbGliNjQiLCAiL2xpYjY0IiwKICAgICAgICAgIi0tcm8tYmluZC10cnkiLCAiL3Vzci9s aWI2NCIsICIvdXNyL2xpYjY0IiwKICAgICAgICAgIi0tcm8tYmluZC10cnkiLCAiL3Vzci9sb2Nh bC9saWI2NCIsICIvdXNyL2xvY2FsL2xpYjY0IiwKKyNlbHNlCisgICAgICAgICItLXJvLWJpbmQt dHJ5IiwgIi9saWIzMiIsICIvbGliMzIiLAorICAgICAgICAiLS1yby1iaW5kLXRyeSIsICIvdXNy L2xpYjMyIiwgIi91c3IvbGliMzIiLAorICAgICAgICAiLS1yby1iaW5kLXRyeSIsICIvdXNyL2xv Y2FsL2xpYjMyIiwgIi91c3IvbG9jYWwvbGliMzIiLAorI2VuZGlmCiAKICAgICAgICAgIi0tcm8t YmluZC10cnkiLCBQS0dMSUJFWEVDRElSLCBQS0dMSUJFWEVDRElSLAogICAgIH07Cg== 419888 2021-02-10 12:30:41 -0800 2021-03-15 06:15:11 -0700 better patch out.diff text/plain 1865 nina ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMmIxZjY0N2Y1YjZiLi40ZDBhOThlNjhmMGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMjEtMDItMTAgIERhbmllbCBLb2xlc2EgIDxka29sZXNhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dMSUJdIEJlIG1vcmUgc2VsZWN0aXZlIGFib3V0IGJ1Ymxld3JhcHBpbmcg bGliZGlycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIxNzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg T24gMzItYml0IHN5c3RlbXMsIGJ1YmJsZXdyYXAgbGliMzIgaW5zdGVhZCBvZiBsaWI2NC4gVGhp cyB1bmJyZWFrcworICAgICAgICBzYW5kYm94IG9uIHNvbWUgZGlzdHJpYnV0aW9ucyB0aGF0IGhh dmUgbGliMzIgKHdoaWNoIGdsaWJjIGRlZmF1bHRzCisgICAgICAgIGl0cyBsZCBjYWNoZSBsb29r dXBzIHRvKSBidXQgY29uZmlndXJlIGRlZmF1bHQgbGliZGlyIHRvIGxpYiByYXRoZXIKKyAgICAg ICAgdGhhbiBsaWIzMi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9MYXVuY2hlci9nbGliL0J1YmJs ZXdyYXBMYXVuY2hlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OmJ1YmJsZXdyYXBTcGF3bik6CisK IDIwMjEtMDItMTAgIFBhdHJpY2sgR3JpZmZpcyAgPHBncmlmZmlzQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW1dQRV1bR1RLXSBBZGQgc3VwcG9ydCBmb3IgY2xpZW50IGNlcnRpZmljYXRlIGF1dGhl bnRpY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9n bGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9MYXVu Y2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKaW5kZXggNjliNGRjNmE2YTBiLi5kYzY2 MGYzOTkyNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0xhdW5jaGVyL2ds aWIvQnViYmxld3JhcExhdW5jaGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9M YXVuY2hlci9nbGliL0J1YmJsZXdyYXBMYXVuY2hlci5jcHAKQEAgLTc1OCw5ICs3NTgsMTUgQEAg R1JlZlB0cjxHU3VicHJvY2Vzcz4gYnViYmxld3JhcFNwYXduKEdTdWJwcm9jZXNzTGF1bmNoZXIq IGxhdW5jaGVyLCBjb25zdCBQcm9jZXMKICAgICAgICAgIi0tcm8tYmluZC10cnkiLCAiL3Vzci9s aWIiLCAiL3Vzci9saWIiLAogICAgICAgICAiLS1yby1iaW5kLXRyeSIsICIvdXNyL2xvY2FsL2xp YiIsICIvdXNyL2xvY2FsL2xpYiIsCiAgICAgICAgICItLXJvLWJpbmQtdHJ5IiwgTElCRElSLCBM SUJESVIsCisjaWYgQ1BVKEFERFJFU1M2NCkKICAgICAgICAgIi0tcm8tYmluZC10cnkiLCAiL2xp YjY0IiwgIi9saWI2NCIsCiAgICAgICAgICItLXJvLWJpbmQtdHJ5IiwgIi91c3IvbGliNjQiLCAi L3Vzci9saWI2NCIsCiAgICAgICAgICItLXJvLWJpbmQtdHJ5IiwgIi91c3IvbG9jYWwvbGliNjQi LCAiL3Vzci9sb2NhbC9saWI2NCIsCisjZWxzZQorICAgICAgICAiLS1yby1iaW5kLXRyeSIsICIv bGliMzIiLCAiL2xpYjMyIiwKKyAgICAgICAgIi0tcm8tYmluZC10cnkiLCAiL3Vzci9saWIzMiIs ICIvdXNyL2xpYjMyIiwKKyAgICAgICAgIi0tcm8tYmluZC10cnkiLCAiL3Vzci9sb2NhbC9saWIz MiIsICIvdXNyL2xvY2FsL2xpYjMyIiwKKyNlbmRpZgogCiAgICAgICAgICItLXJvLWJpbmQtdHJ5 IiwgUEtHTElCRVhFQ0RJUiwgUEtHTElCRVhFQ0RJUiwKICAgICB9Owo=