22170 2008-11-10 19:41:24 -0800 Make Vector::clear() release the Vector's memory (1MB savings on membuster) 2008-11-11 01:24:00 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 98252 0 mjs 2008-11-10 19:41:24 -0800 Many parts of WebKit assume that after calling clear() on a WTF::Vector, the memory is returned. But it isn't. Fulfilling this assumption saves 1MB on the Mozilla membuster test. 98253 1 25041 mjs 2008-11-10 19:44:20 -0800 Created attachment 25041 patch to really really clear vectors 25041 2008-11-10 19:44:20 -0800 2008-11-10 19:51:01 -0800 patch to really really clear vectors vector-clear.patch.txt text/plain 2432 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4Mjg0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMTEt MTAgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gTWFrZSBWZWN0b3I6OmNs ZWFyKCkgcmVsZWFzZSB0aGUgVmVjdG9yJ3MgbWVtb3J5ICgxTUIgc2F2aW5ncyBvbiBtZW1idXN0 ZXIpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE3 MAorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorICAgICAgICAoV1RGOjpWZWN0b3JCdWZmZXJC YXNlOjpkZWFsbG9jYXRlQnVmZmVyKTogU2V0IGNhcGFjaXR5IHRvIDAgYXMKKyAgICAgICAgd2Vs bCBhcyBzaXplLCBvdGhlcndpc2Ugc2hyaW5raW5nIGNhcGFjaXR5IHRvIDAgY2FuIGZhaWwgdG8g cmVzZXQKKyAgICAgICAgdGhlIGNhcGFjaXR5IGFuZCB0aHVzIGNhdXNlIGEgZnV0dXJlIGNyYXNo LgorICAgICAgICAoV1RGOjpWZWN0b3I6On5WZWN0b3IpOiBTaHJpbmsgc2l6ZSBub3QgY2FwYWNp dHk7IHdlIG9ubHkgbmVlZAorICAgICAgICB0byBjYWxsIGRlc3RydWN0dXJlcywgdGhlIGJ1ZmZl ciB3aWxsIGJlIGZyZWVkIGFueXdheS4KKyAgICAgICAgKFdURjo6VmVjdG9yOjpjbGVhcik6IENo YW5nZSB0aGlzIHRvIHNocmlua0NhcGFjaXR5KDApLCBub3QganVzdCBzaHJpbmsoMCkuCisgICAg ICAgIChXVEY6Ojo6c2hyaW5rQ2FwYWNpdHkpOiBVc2Ugc2hyaW5rKCkgaW5zdGVhZCBvZiByZXNp emUoKSBmb3IgY2FzZSB3aGVyZQorICAgICAgICB0aGUgc2l6ZSBpcyBncmVhdGVyIHRoYW4gdGhl IG5ldyBjYXBhY2l0eSwgdG8gd29yayB3aXRoIHR5cGVzIHRoYXQgaGF2ZSBubworICAgICAgICBk ZWZhdWx0IGNvbnN0cnVjdG9yLgorCiAyMDA4LTExLTEwICBDYW1lcm9uIFp3YXJpY2ggIDx6d2Fy aWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4K SW5kZXg6IHd0Zi9WZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB3dGYvVmVjdG9yLmgJKHJldmlzaW9u IDM4MjgzKQorKysgd3RmL1ZlY3Rvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNzksOCArMjc5LDEw IEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgICAgIHZvaWQgZGVhbGxvY2F0ZUJ1ZmZlcihUKiBi dWZmZXJUb0RlYWxsb2NhdGUpCiAgICAgICAgIHsKLSAgICAgICAgICAgIGlmIChtX2J1ZmZlciA9 PSBidWZmZXJUb0RlYWxsb2NhdGUpCisgICAgICAgICAgICBpZiAobV9idWZmZXIgPT0gYnVmZmVy VG9EZWFsbG9jYXRlKSB7CiAgICAgICAgICAgICAgICAgbV9idWZmZXIgPSAwOworICAgICAgICAg ICAgICAgIG1fY2FwYWNpdHkgPSAwOworICAgICAgICAgICAgfQogICAgICAgICAgICAgZmFzdEZy ZWUoYnVmZmVyVG9EZWFsbG9jYXRlKTsKICAgICAgICAgfQogCkBAIC00NDIsNyArNDQ0LDcgQEAg bmFtZXNwYWNlIFdURiB7CiAKICAgICAgICAgflZlY3RvcigpCiAgICAgICAgIHsKLSAgICAgICAg ICAgIGNsZWFyKCk7CisgICAgICAgICAgICBpZiAobV9zaXplKSBzaHJpbmsoMCk7CiAgICAgICAg IH0KIAogICAgICAgICBWZWN0b3IoY29uc3QgVmVjdG9yJik7CkBAIC00OTMsNyArNDk1LDcgQEAg bmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHZvaWQgcmVzZXJ2ZUNhcGFjaXR5KHNpemVfdCBuZXdD YXBhY2l0eSk7CiAgICAgICAgIHZvaWQgc2hyaW5rQ2FwYWNpdHkoc2l6ZV90IG5ld0NhcGFjaXR5 KTsKIAotICAgICAgICB2b2lkIGNsZWFyKCkgeyBpZiAobV9zaXplKSBzaHJpbmsoMCk7IH0KKyAg ICAgICAgdm9pZCBjbGVhcigpIHsgc2hyaW5rQ2FwYWNpdHkoMCk7IH0KIAogICAgICAgICB0ZW1w bGF0ZTx0eXBlbmFtZSBVPiB2b2lkIGFwcGVuZChjb25zdCBVKiwgc2l6ZV90KTsKICAgICAgICAg dGVtcGxhdGU8dHlwZW5hbWUgVT4gdm9pZCBhcHBlbmQoY29uc3QgVSYpOwpAQCAtNzI1LDcgKzcy Nyw4IEBAIG5hbWVzcGFjZSBXVEYgewogICAgICAgICBpZiAobmV3Q2FwYWNpdHkgPj0gY2FwYWNp dHkoKSkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICByZXNpemUobWluKG1fc2l6ZSwg bmV3Q2FwYWNpdHkpKTsKKyAgICAgICAgaWYgKG5ld0NhcGFjaXR5IDwgc2l6ZSgpKSAKKyAgICAg ICAgICAgIHNocmluayhuZXdDYXBhY2l0eSk7CiAKICAgICAgICAgVCogb2xkQnVmZmVyID0gYmVn aW4oKTsKICAgICAgICAgaWYgKG5ld0NhcGFjaXR5ID4gMCkgewo=