221684 2021-02-10 10:02:55 -0800 Do not differentiate between Release and Production via ENABLE_DEVELOPER_MODE 2021-02-10 14:26:31 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221621 InRadar P2 Normal --- 1 ap ap calvaris cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim hi jer.noble philipj sam sergio webkit-bug-importer oldest_to_newest 1727592 0 ap 2021-02-10 10:02:55 -0800 There is some code that sets ENABLE_DEVELOPER_MODE in xcconfigs depending on whether the build is Production or Debug/Release. It is invalid to create behaviors that are different between these. There is almost no difference in usage scenarios between build modes - either can be produced by CI for validation, either can be used for local testing, etc. Seeing how it's used for making media elements debuggable, I'm certain that there is a better way to achieve the goal. I don't think that implementing this better way needs to be done as part of this patch. Not really sure what's up with developer modein WebInspectorUI, seems unused? 1727595 1 419863 ap 2021-02-10 10:06:21 -0800 Created attachment 419863 proposed patch 1727723 2 ews-feeder 2021-02-10 12:55:07 -0800 Committed r272679: <https://commits.webkit.org/r272679> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419863. 1727769 3 webkit-bug-importer 2021-02-10 14:26:31 -0800 <rdar://problem/74206304> 419863 2021-02-10 10:06:21 -0800 2021-02-10 12:55:09 -0800 proposed patch ENGINEERING_BUILD.txt text/plain 6174 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MjY1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAyLTEwICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIERvIG5vdCBkaWZmZXJlbnRp YXRlIGJldHdlZW4gUmVsZWFzZSBhbmQgUHJvZHVjdGlvbiB2aWEgRU5BQkxFX0RFVkVMT1BFUl9N T0RFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE2 ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBp cyBpbnZhbGlkIHRvIGNyZWF0ZSBiZWhhdmlvcnMgdGhhdCBhcmUgZGlmZmVyZW50IGJldHdlZW4g dGhlc2UuIFRoZXJlIGlzCisgICAgICAgIGFsbW9zdCBubyBkaWZmZXJlbmNlIGluIHVzYWdlIHNj ZW5hcmlvcyBiZXR3ZWVuIGJ1aWxkIG1vZGVzIC0gZWl0aGVyIGNhbiBiZQorICAgICAgICBwcm9k dWNlZCBieSBDSSBmb3IgdmFsaWRhdGlvbiwgZWl0aGVyIGNhbiBiZSB1c2VkIGZvciBsb2NhbCB0 ZXN0aW5nLCBldGMuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOgor ICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZzoKKyAgICAgICAg KiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlh RWxlbWVudDo6ZW5zdXJlTWVkaWFDb250cm9sc0luamVjdGVkU2NyaXB0KToKKwogMjAyMS0wMi0x MCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQg YnVpbGQgZml4LgpJbmRleDogU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2Nv bmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9CYXNlLnhj Y29uZmlnCShyZXZpc2lvbiAyNzI2NTkpCisrKyBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9u cy9CYXNlLnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3MCw2IEBAIEdDQ19HRU5F UkFURV9ERUJVR0dJTkdfU1lNQk9MUyA9IFlFUzsKIEdDQ19OT19DT01NT05fQkxPQ0tTID0gWUVT OwogR0NDX09CSkNfQ0FMTF9DWFhfQ0RUT1JTID0gWUVTOwogR0NDX1BSRUNPTVBJTEVfUFJFRklY X0hFQURFUiA9IFlFUzsKLUdDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMgPSAkKGluaGVyaXRl ZCkgJChERVZFTE9QRVJfTU9ERV9ERUZJTkVTKTsKIEdDQ19TWU1CT0xTX1BSSVZBVEVfRVhURVJO ID0gWUVTOwogR0NDX1RIUkVBRFNBRkVfU1RBVElDUyA9IE5POwogR0NDX1RSRUFUX1dBUk5JTkdT X0FTX0VSUk9SUyA9IFlFUzsKQEAgLTkzLDkgKzkyLDYgQEAgR0NDX1dBUk5fVU5VU0VEX0ZVTkNU SU9OID0gWUVTOwogR0NDX1dBUk5fVU5VU0VEX1ZBUklBQkxFID0gWUVTOwogV0FSTklOR19DRkxB R1MgPSAtV2FsbCAtV2V4dHJhIC1XY2FzdC1xdWFsIC1XY2hhci1zdWJzY3JpcHRzIC1XY29uZGl0 aW9uYWwtdW5pbml0aWFsaXplZCAtV2V4dHJhLXRva2VucyAtV2Zvcm1hdD0yIC1XaW5pdC1zZWxm IC1XbWlzc2luZy1mb3JtYXQtYXR0cmlidXRlIC1XbWlzc2luZy1ub3JldHVybiAtV3BhY2tlZCAt V3BvaW50ZXItYXJpdGggLVdyZWR1bmRhbnQtZGVjbHMgLVd1bmRlZiAtV3dyaXRlLXN0cmluZ3Mg LVdleGl0LXRpbWUtZGVzdHJ1Y3RvcnMgLVdnbG9iYWwtY29uc3RydWN0b3JzIC1XdGF1dG9sb2dp Y2FsLWNvbXBhcmUgLVdpbXBsaWNpdC1mYWxsdGhyb3VnaCAtV3ZsYSAtV25vLXVua25vd24td2Fy bmluZy1vcHRpb24gLVdsaXRlcmFsLWNvbnZlcnNpb247CiAKLURFVkVMT1BFUl9NT0RFX0RFRklO RVMgPSAkKERFVkVMT1BFUl9NT0RFX0RFRklORVNfJChERVZFTE9QRVJfTU9ERSkpOwotREVWRUxP UEVSX01PREVfREVGSU5FU18xID0gRU5BQkxFX0RFVkVMT1BFUl9NT0RFPTE7Ci0KIFRBUkdFVF9N QUNPU19MRUdBQ1lfVkVSU0lPTl9JREVOVElGSUVSID0gJChUQVJHRVRfTUFDT1NfTEVHQUNZX1ZF UlNJT05fSURFTlRJRklFUl8kKE1BQ09TWF9ERVBMT1lNRU5UX1RBUkdFVDpiYXNlKSkKIFRBUkdF VF9NQUNPU19MRUdBQ1lfVkVSU0lPTl9JREVOVElGSUVSXzEwID0gMTAkKE1BQ09TWF9ERVBMT1lN RU5UX1RBUkdFVDpzdWZmaXg6aWRlbnRpZmllcikKIApJbmRleDogU291cmNlL1dlYkNvcmUvQ29u ZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZwkocmV2aXNpb24gMjcy NjU5KQorKysgU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29u ZmlnCSh3b3JraW5nIGNvcHkpCkBAIC00OSw4ICs0OSw2IEBAIE1BQ09TWF9ERVBMT1lNRU5UX1RB UkdFVF8xMDE1MDAgPSAxMC4xNTsKIE1BQ09TWF9ERVBMT1lNRU5UX1RBUkdFVF8xMTAwMDAgPSAx MS4wOwogTUFDT1NYX0RFUExPWU1FTlRfVEFSR0VUXzEyMDAwMCA9IDEyLjA7CiAKLURFVkVMT1BF Ul9NT0RFID0gMTsKLQogR0NDX1dBUk5fQUJPVVRfREVQUkVDQVRFRF9GVU5DVElPTlMgPSBZRVM7 CiBERUJVR19JTkZPUk1BVElPTl9GT1JNQVQgPSBkd2FyZjsKIApJbmRleDogU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiAyNzI2NTkpCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MTU2 LDcgKzcxNTYsNyBAQCBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OmVuc3VyZU1lZGlhQ29udHJvCiAg ICAgICAgIGlmIChmdW5jdGlvblZhbHVlLmlzQ2FsbGFibGUodm0pKQogICAgICAgICAgICAgcmV0 dXJuIHRydWU7CiAKLSNpZiBFTkFCTEUoREVWRUxPUEVSX01PREUpIHx8ICFkZWZpbmVkKE5ERUJV RykKKyNpZiAhZGVmaW5lZChOREVCVUcpCiAgICAgICAgIC8vIFNldHRpbmcgYSBzY3JpcHRVUkwg YWxsb3dzIHRoZSBzb3VyY2UgdG8gYmUgZGVidWdnYWJsZSBpbiB0aGUgaW5zcGVjdG9yLgogICAg ICAgICBVUkwgc2NyaXB0VVJMID0gVVJMKHsgfSwgIm1lZGlhQ29udHJvbHNTY3JpcHQiX3MpOwog I2Vsc2UKSW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMjcyNjYwKQorKysg U291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE3IEBACisyMDIxLTAyLTEwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgor CisgICAgICAgIERvIG5vdCBkaWZmZXJlbnRpYXRlIGJldHdlZW4gUmVsZWFzZSBhbmQgUHJvZHVj dGlvbiB2aWEgRU5BQkxFX0RFVkVMT1BFUl9NT0RFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE2ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBpbnZhbGlkIHRvIGNyZWF0ZSBiZWhhdmlvcnMg dGhhdCBhcmUgZGlmZmVyZW50IGJldHdlZW4gdGhlc2UuIFRoZXJlIGlzCisgICAgICAgIGFsbW9z dCBubyBkaWZmZXJlbmNlIGluIHVzYWdlIHNjZW5hcmlvcyBiZXR3ZWVuIGJ1aWxkIG1vZGVzIC0g ZWl0aGVyIGNhbiBiZQorICAgICAgICBwcm9kdWNlZCBieSBDSSBmb3IgdmFsaWRhdGlvbiwgZWl0 aGVyIGNhbiBiZSB1c2VkIGZvciBsb2NhbCB0ZXN0aW5nLCBldGMuCisKKyAgICAgICAgKiBDb25m aWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOgorICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0RlYnVn UmVsZWFzZS54Y2NvbmZpZzoKKwogMjAyMS0wMi0wOSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSByZW5hbWUgYEVOR0lORUVSSU5HX0JVSUxEYCB0 byBgRU5BQkxFX0RFVkVMT1BFUl9NT0RFYCB0byBtYXRjaCBvdGhlciBwbGF0Zm9ybXMKSW5kZXg6 IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29u ZmlnCShyZXZpc2lvbiAyNzI2NTkpCisrKyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ29uZmlndXJh dGlvbnMvQmFzZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtNDUsNyArNDUsNiBAQCBHQ0Nf RkFTVF9PQkpDX0RJU1BBVENIID0gWUVTOwogR0NDX0dFTkVSQVRFX0RFQlVHR0lOR19TWU1CT0xT ID0gWUVTOwogR0NDX05PX0NPTU1PTl9CTE9DS1MgPSBZRVM7CiBHQ0NfUFJFQ09NUElMRV9QUkVG SVhfSEVBREVSID0gTk87Ci1HQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChpbmhlcml0 ZWQpICQoREVWRUxPUEVSX01PREVfREVGSU5FUyk7CiBHQ0NfVEhSRUFEU0FGRV9TVEFUSUNTID0g Tk87CiBHQ0NfVFJFQVRfV0FSTklOR1NfQVNfRVJST1JTID0gWUVTOwogR0NDX1ZFUlNJT04gPSBj b20uYXBwbGUuY29tcGlsZXJzLmxsdm0uY2xhbmcuMV8wOwpAQCAtNjQsOSArNjMsNiBAQCBHQ0Nf V0FSTl9VTlVTRURfRlVOQ1RJT04gPSBZRVM7CiBHQ0NfV0FSTl9VTlVTRURfVkFSSUFCTEUgPSBZ RVMKIFdBUk5JTkdfQ0ZMQUdTID0gLVdhbGwgLVcgLVdjYXN0LXF1YWwgLVdjaGFyLXN1YnNjcmlw dHMgLVdjb25kaXRpb25hbC11bmluaXRpYWxpemVkIC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2lu Zy1mb3JtYXQtYXR0cmlidXRlIC1XcG9pbnRlci1hcml0aCAtV3dyaXRlLXN0cmluZ3MgLVduby11 bnVzZWQtcGFyYW1ldGVyIC1XZXhpdC10aW1lLWRlc3RydWN0b3JzIC1XdmxhIC1XbGl0ZXJhbC1j b252ZXJzaW9uOwogCi1ERVZFTE9QRVJfTU9ERV9ERUZJTkVTID0gJChERVZFTE9QRVJfTU9ERV9E RUZJTkVTXyQoREVWRUxPUEVSX01PREUpKTsKLURFVkVMT1BFUl9NT0RFX0RFRklORVNfMSA9IEVO QUJMRV9ERVZFTE9QRVJfTU9ERT0xOwotCiBTVVBQT1JURURfUExBVEZPUk1TID0gaXBob25lb3Mg aXBob25lc2ltdWxhdG9yIG1hY29zeCBhcHBsZXR2b3MgYXBwbGV0dnNpbXVsYXRvciB3YXRjaG9z IHdhdGNoc2ltdWxhdG9yOwogU1VQUE9SVFNfTUFDQ0FUQUxZU1QgPSBZRVM7CiAKSW5kZXg6IFNv dXJjZS9XZWJJbnNwZWN0b3JVSS9Db25maWd1cmF0aW9ucy9EZWJ1Z1JlbGVhc2UueGNjb25maWcK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkluc3BlY3RvclVJL0NvbmZpZ3VyYXRpb25zL0RlYnVn UmVsZWFzZS54Y2NvbmZpZwkocmV2aXNpb24gMjcyNjU5KQorKysgU291cmNlL1dlYkluc3BlY3Rv clVJL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpA QCAtMjYsOCArMjYsNiBAQCBNQUNPU1hfREVQTE9ZTUVOVF9UQVJHRVRfMTAxNTAwID0gMTAuMTU7 CiBNQUNPU1hfREVQTE9ZTUVOVF9UQVJHRVRfMTEwMDAwID0gMTEuMDsKIE1BQ09TWF9ERVBMT1lN RU5UX1RBUkdFVF8xMjAwMDAgPSAxMi4wOwogCi1ERVZFTE9QRVJfTU9ERSA9IDE7Ci0KIEdDQ19X QVJOX0FCT1VUX0RFUFJFQ0FURURfRlVOQ1RJT05TID0gWUVTOwogREVCVUdfSU5GT1JNQVRJT05f Rk9STUFUID0gZHdhcmY7CiAK