221680 2021-02-10 09:23:54 -0800 [iOS][FCR] Add reduced motion animation for indeterminate progress bars 2021-02-10 11:27:43 -0800 1 1 1 Unclassified WebKit Forms Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 akeerthi akeerthi cdumez changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr webkit-bug-importer wenson_hsieh oldest_to_newest 1727569 0 akeerthi 2021-02-10 09:23:54 -0800 ... 1727570 1 akeerthi 2021-02-10 09:24:11 -0800 <rdar://problem/74191515> 1727571 2 419855 akeerthi 2021-02-10 09:26:04 -0800 Created attachment 419855 Patch 1727572 3 419855 wenson_hsieh 2021-02-10 09:28:47 -0800 Comment on attachment 419855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419855&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:2217 > + context.fillRoundedRect(FloatRoundedRect(barRect, barCornerRadii), controlColor.colorWithAlphaByte(alpha * 255.0f)); Nit - could we just use `colorWithAlpha(alpha)` instead? 1727579 4 akeerthi 2021-02-10 09:36:11 -0800 (In reply to Wenson Hsieh from comment #3) > Comment on attachment 419855 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419855&action=review > > > Source/WebCore/rendering/RenderThemeIOS.mm:2217 > > + context.fillRoundedRect(FloatRoundedRect(barRect, barCornerRadii), controlColor.colorWithAlphaByte(alpha * 255.0f)); > > Nit - could we just use `colorWithAlpha(alpha)` instead? `colorWithAlpha` is only defined on Color, whereas controlColor is an SRGBA<uint8_t>. 1727580 5 419855 wenson_hsieh 2021-02-10 09:38:16 -0800 Comment on attachment 419855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419855&action=review >>> Source/WebCore/rendering/RenderThemeIOS.mm:2217 >>> + context.fillRoundedRect(FloatRoundedRect(barRect, barCornerRadii), controlColor.colorWithAlphaByte(alpha * 255.0f)); >> >> Nit - could we just use `colorWithAlpha(alpha)` instead? > > `colorWithAlpha` is only defined on Color, whereas controlColor is an SRGBA<uint8_t>. I see — looks fine then! 1727659 6 ews-feeder 2021-02-10 11:27:40 -0800 Committed r272665: <https://commits.webkit.org/r272665> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419855. 419855 2021-02-10 09:26:04 -0800 2021-02-10 11:27:41 -0800 Patch bug-221680-20210210122610.patch text/plain 4098 akeerthi U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGI5YWIzZDNmMDExN2Ni MDY0NzEwZjJhZmY5NmZlMDFlOTViOWVhZC4uNjcwZjYwODEzYWQ4NDM3OGFkMzE5ZjM5YTcwNzUz M2MxNWY1MTYyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTEwICBBZGl0 eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXVtGQ1JdIEFk ZCByZWR1Y2VkIG1vdGlvbiBhbmltYXRpb24gZm9yIGluZGV0ZXJtaW5hdGUgcHJvZ3Jlc3MgYmFy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNjgw CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDE5MTUxNT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcmVkdWNlZCBtb3Rpb24gYW5pbWF0aW9u IGZvciBpbmRldGVybWluYXRlIHByb2dyZXNzIGJhcnMgaXMgYW4KKyAgICAgICAgb3BhY2l0eSBw dWxzZSBmcm9tIDMwJSB0byA2MCUuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVJ T1MubW06CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUlPUzo6cGFpbnRQcm9ncmVzc0Jh cldpdGhGb3JtQ29udHJvbFJlZnJlc2gpOgorCiAyMDIxLTAyLTA4ICBBZGl0eWEgS2VlcnRoaSAg PGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXVtGQ1JdIFVzZSBVSUNvbG9yUGlj a2VyVmlld0NvbnRyb2xsZXIgZm9yIGNvbG9yIGlucHV0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRoZW1lSU9TLm1tCmluZGV4IDM0NmZlYTY3OTY3OTEwMzM0ODgyMzRmZWNiNjU4 MTY0MmI4YWM5OWYuLjk0NTA1ODhjYmNlNzRkOGI1MWY0MTI0ZWMyYzljYjUzODE1NGJmMGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MubW0KQEAgLTcwLDYgKzcw LDcgQEAKICNpbXBvcnQgIlJlbmRlclZpZXcuaCIKICNpbXBvcnQgIlJ1bnRpbWVFbmFibGVkRmVh dHVyZXMuaCIKICNpbXBvcnQgIlNldHRpbmdzLmgiCisjaW1wb3J0ICJUaGVtZS5oIgogI2ltcG9y dCAiVVRJVXRpbGl0aWVzLmgiCiAjaW1wb3J0ICJVc2VyQWdlbnRTY3JpcHRzLmgiCiAjaW1wb3J0 ICJVc2VyQWdlbnRTdHlsZVNoZWV0cy5oIgpAQCAtMjE0Miw2ICsyMTQzLDkgQEAgYm9vbCBSZW5k ZXJUaGVtZUlPUzo6cGFpbnRSYWRpbyhjb25zdCBSZW5kZXJPYmplY3QmIGJveCwgY29uc3QgUGFp bnRJbmZvJiBwYWludEkKIC8vIHByb2dyZXNzIGJhciBpcyByZXBhaW50ZWQuCiBjb25zdGV4cHIg U2Vjb25kcyBwcm9ncmVzc0FuaW1hdGlvblJlcGVhdEludGVydmFsID0gMzNfbXM7CiAKK2NvbnN0 ZXhwciBhdXRvIHJlZHVjZWRNb3Rpb25Qcm9ncmVzc0FuaW1hdGlvbk1pbk9wYWNpdHkgPSAwLjNm OworY29uc3RleHByIGF1dG8gcmVkdWNlZE1vdGlvblByb2dyZXNzQW5pbWF0aW9uTWF4T3BhY2l0 eSA9IDAuNmY7CisKIFNlY29uZHMgUmVuZGVyVGhlbWVJT1M6OmFuaW1hdGlvblJlcGVhdEludGVy dmFsRm9yUHJvZ3Jlc3NCYXIoY29uc3QgUmVuZGVyUHJvZ3Jlc3MmIHJlbmRlclByb2dyZXNzKSBj b25zdAogewogICAgIGlmICghcmVuZGVyUHJvZ3Jlc3Muc2V0dGluZ3MoKS5pT1NGb3JtQ29udHJv bFJlZnJlc2hFbmFibGVkKCkpCkBAIC0yMTc2LDYgKzIxODAsNyBAQCBib29sIFJlbmRlclRoZW1l SU9TOjpwYWludFByb2dyZXNzQmFyV2l0aEZvcm1Db250cm9sUmVmcmVzaChjb25zdCBSZW5kZXJP YmplY3QmCiAKICAgICBmbG9hdCBiYXJXaWR0aDsKICAgICBmbG9hdCBiYXJMZWZ0ID0gcmVjdC54 KCk7CisgICAgZmxvYXQgYWxwaGEgPSAxLjBmOwogCiAgICAgaWYgKHJlbmRlclByb2dyZXNzLmlz RGV0ZXJtaW5hdGUoKSkgewogICAgICAgICBiYXJXaWR0aCA9IGNsYW1wVG88ZmxvYXQ+KHJlbmRl clByb2dyZXNzLnBvc2l0aW9uKCksIDAuMGYsIDEuMGYpICogdHJhY2tSZWN0LndpZHRoKCk7CkBA IC0yMTgzLDIzICsyMTg4LDMzIEBAIGJvb2wgUmVuZGVyVGhlbWVJT1M6OnBhaW50UHJvZ3Jlc3NC YXJXaXRoRm9ybUNvbnRyb2xSZWZyZXNoKGNvbnN0IFJlbmRlck9iamVjdCYKICAgICAgICAgaWYg KCFyZW5kZXJQcm9ncmVzcy5zdHlsZSgpLmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSkKICAgICAg ICAgICAgIGJhckxlZnQgPSB0cmFja1JlY3QubWF4WCgpIC0gYmFyV2lkdGg7CiAgICAgfSBlbHNl IHsKLSAgICAgICAgYmFyV2lkdGggPSAwLjI1ZiAqIHRyYWNrUmVjdC53aWR0aCgpOwotCiAgICAg ICAgIFNlY29uZHMgZWxhcHNlZCA9IE1vbm90b25pY1RpbWU6Om5vdygpIC0gcmVuZGVyUHJvZ3Jl c3MuYW5pbWF0aW9uU3RhcnRUaW1lKCk7CiAgICAgICAgIGZsb2F0IHBvc2l0aW9uID0gZm1vZGYo ZWxhcHNlZC52YWx1ZSgpLCAxLjBmKTsKLSAgICAgICAgZmxvYXQgb2Zmc2V0ID0gcG9zaXRpb24g KiAodHJhY2tSZWN0LndpZHRoKCkgKyBiYXJXaWR0aCk7Ci0KICAgICAgICAgYm9vbCByZXZlcnNl RGlyZWN0aW9uID0gc3RhdGljX2Nhc3Q8aW50PihlbGFwc2VkLnZhbHVlKCkpICUgMjsKLSAgICAg ICAgaWYgKHJldmVyc2VEaXJlY3Rpb24pCi0gICAgICAgICAgICBiYXJMZWZ0ID0gdHJhY2tSZWN0 Lm1heFgoKSAtIG9mZnNldDsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgYmFyTGVmdCAtPSBi YXJXaWR0aCAtIG9mZnNldDsKIAotICAgICAgICBjb250ZXh0LmNsaXBSb3VuZGVkUmVjdChyb3Vu ZGVkVHJhY2tSZWN0KTsKKyAgICAgICAgaWYgKFRoZW1lOjpzaW5nbGV0b24oKS51c2VyUHJlZmVy c1JlZHVjZWRNb3Rpb24oKSkgeworICAgICAgICAgICAgYmFyV2lkdGggPSB0cmFja1JlY3Qud2lk dGgoKTsKKworICAgICAgICAgICAgZmxvYXQgZGlmZmVyZW5jZSA9IHBvc2l0aW9uICogKHJlZHVj ZWRNb3Rpb25Qcm9ncmVzc0FuaW1hdGlvbk1heE9wYWNpdHkgLSByZWR1Y2VkTW90aW9uUHJvZ3Jl c3NBbmltYXRpb25NaW5PcGFjaXR5KTsKKyAgICAgICAgICAgIGlmIChyZXZlcnNlRGlyZWN0aW9u KQorICAgICAgICAgICAgICAgIGFscGhhID0gcmVkdWNlZE1vdGlvblByb2dyZXNzQW5pbWF0aW9u TWF4T3BhY2l0eSAtIGRpZmZlcmVuY2U7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgYWxwaGEgPSByZWR1Y2VkTW90aW9uUHJvZ3Jlc3NBbmltYXRpb25NaW5PcGFjaXR5ICsgZGlm ZmVyZW5jZTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGJhcldpZHRoID0gMC4yNWYg KiB0cmFja1JlY3Qud2lkdGgoKTsKKworICAgICAgICAgICAgZmxvYXQgb2Zmc2V0ID0gcG9zaXRp b24gKiAodHJhY2tSZWN0LndpZHRoKCkgKyBiYXJXaWR0aCk7CisgICAgICAgICAgICBpZiAocmV2 ZXJzZURpcmVjdGlvbikKKyAgICAgICAgICAgICAgICBiYXJMZWZ0ID0gdHJhY2tSZWN0Lm1heFgo KSAtIG9mZnNldDsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBiYXJMZWZ0IC09 IGJhcldpZHRoIC0gb2Zmc2V0OworCisgICAgICAgICAgICBjb250ZXh0LmNsaXBSb3VuZGVkUmVj dChyb3VuZGVkVHJhY2tSZWN0KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIEZsb2F0UmVjdCBi YXJSZWN0KGJhckxlZnQsIGJhclRvcCwgYmFyV2lkdGgsIGJhckhlaWdodCk7Ci0gICAgY29udGV4 dC5maWxsUm91bmRlZFJlY3QoRmxvYXRSb3VuZGVkUmVjdChiYXJSZWN0LCBiYXJDb3JuZXJSYWRp aSksIGNvbnRyb2xDb2xvcik7CisgICAgY29udGV4dC5maWxsUm91bmRlZFJlY3QoRmxvYXRSb3Vu ZGVkUmVjdChiYXJSZWN0LCBiYXJDb3JuZXJSYWRpaSksIGNvbnRyb2xDb2xvci5jb2xvcldpdGhB bHBoYUJ5dGUoYWxwaGEgKiAyNTUuMGYpKTsKIAogICAgIHJldHVybiBmYWxzZTsKIH0K