221625 2021-02-09 13:41:51 -0800 [GTK] Export additional methods of SourceBufferPrivate to support hidden visibility 2021-02-10 14:28:17 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead mcatanzaro webkit-bug-importer oldest_to_newest 1727213 0 don.olmstead 2021-02-09 13:41:51 -0800 .... 1727220 1 419757 don.olmstead 2021-02-09 13:48:37 -0800 Created attachment 419757 Patch 1727223 2 mcatanzaro 2021-02-09 13:52:34 -0800 I can only imagine why these are needed, especially since WebCore is the toplevel library... I guess a test program is using them? 1727267 3 don.olmstead 2021-02-09 14:38:19 -0800 (In reply to Michael Catanzaro from comment #2) > I can only imagine why these are needed, especially since WebCore is the > toplevel library... I guess a test program is using them? From https://ews-build.webkit.org/#/builders/36/builds/27419 which didn't export those symbols. lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::setMediaSourceEnded(bool)' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::reenqueueMediaIfNeeded(WTF::MediaTime const&, unsigned long, unsigned long)' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::addTrackBuffer(WTF::AtomString const&, WTF::RefPtr<WebCore::MediaDescription, WTF::RawPtrTraits<WebCore::MediaDescription>, WTF::DefaultRefDerefTraits<WebCore::MediaDescription> >&&)' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::resetTrackBuffers()' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::clearTrackBuffers()' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::setAllTrackBuffersNeedRandomAccess()' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::removeCodedFrames(WTF::MediaTime const&, WTF::MediaTime const&, WTF::MediaTime const&, bool, WTF::CompletionHandler<void ()>&&)' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::resetTimestampOffsetInTrackBuffers()' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::seekToTime(WTF::MediaTime const&)' lib/libWebCoreTestSupport.a(lib/../Source/WebCore/CMakeFiles/WebCoreTestSupport.dir/platform/mock/mediasource/MockSourceBufferPrivate.cpp.o):MockSourceBufferPrivate.cpp:vtable for WebCore::MockSourceBufferPrivate: error: undefined reference to 'WebCore::SourceBufferPrivate::updateTrackIds(WTF::Vector<std::pair<WTF::AtomString, WTF::AtomString>, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&&)' 1727394 4 ews-feeder 2021-02-09 19:25:05 -0800 Committed r272632: <https://commits.webkit.org/r272632> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419757. 1727774 5 webkit-bug-importer 2021-02-10 14:28:17 -0800 <rdar://problem/74206399> 419757 2021-02-09 13:48:37 -0800 2021-02-09 19:25:06 -0800 Patch bug-221625.diff text/plain 4147 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhOTU0NmIyNDA2MzcuLjE3MmJhNzRmODI2NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIxLTAyLTA5ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u eS5jb20+CisKKyAgICAgICAgW0dUS10gRXhwb3J0IGFkZGl0aW9uYWwgbWV0aG9kcyBvZiBTb3Vy Y2VCdWZmZXJQcml2YXRlIHRvIHN1cHBvcnQgaGlkZGVuIHZpc2liaWxpdHkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYyNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhZGRpdGlvbmFsIFdFQkNP UkVfRVhQT1JUcyB0byBTb3VyY2VCdWZmZXJQcml2YXRlIHRoYXQgd2VyZSBmb3VuZCB3aGVuIGxp bmtpbmcgR1RLIHdpdGgKKyAgICAgICAgaGlkZGVuIHZpc2liaWxpdHkgdHVybmVkIG9uLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvU291cmNlQnVmZmVyUHJpdmF0ZS5oOgorICAgICAg ICAoV2ViQ29yZTo6U291cmNlQnVmZmVyUHJpdmF0ZTo6cmVtb3ZlQ29kZWRGcmFtZXMpOgorCiAy MDIxLTAyLTA5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q11bSUZDXSBEaXNhYmxlIEJJREkgcHJvY2Vzc2luZyBmb3IgbW9kZXJuIGxpbmUgbGF5b3V0CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Tb3VyY2VCdWZmZXJQ cml2YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Tb3VyY2VCdWZmZXJQ cml2YXRlLmgKaW5kZXggN2E1YWYyYjdmN2Y5Li41MmFiN2U1ZTYwMTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NvdXJjZUJ1ZmZlclByaXZhdGUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Tb3VyY2VCdWZmZXJQcml2YXRlLmgK QEAgLTc1LDI2ICs3NSwyNiBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIGJvb2wgY2FuU3dpdGNo VG9UeXBlKGNvbnN0IENvbnRlbnRUeXBlJikgeyByZXR1cm4gZmFsc2U7IH0KIAotICAgIHZpcnR1 YWwgdm9pZCBzZXRNZWRpYVNvdXJjZUVuZGVkKGJvb2wpOworICAgIFdFQkNPUkVfRVhQT1JUIHZp cnR1YWwgdm9pZCBzZXRNZWRpYVNvdXJjZUVuZGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBz ZXRNb2RlKFNvdXJjZUJ1ZmZlckFwcGVuZE1vZGUgbW9kZSkgeyBtX2FwcGVuZE1vZGUgPSBtb2Rl OyB9Ci0gICAgdmlydHVhbCB2b2lkIHJlZW5xdWV1ZU1lZGlhSWZOZWVkZWQoY29uc3QgTWVkaWFU aW1lJiBjdXJyZW50TWVkaWFUaW1lLCB1aW50NjRfdCBwZW5kaW5nQXBwZW5kRGF0YUNhcGFjaXR5 LCB1aW50NjRfdCBtYXhpbXVtQnVmZmVyU2l6ZSk7Ci0gICAgdmlydHVhbCB2b2lkIGFkZFRyYWNr QnVmZmVyKGNvbnN0IEF0b21TdHJpbmcmIHRyYWNrSWQsIFJlZlB0cjxNZWRpYURlc2NyaXB0aW9u PiYmKTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVzZXRUcmFja0J1ZmZlcnMoKTsKLSAgICB2aXJ0dWFs IHZvaWQgY2xlYXJUcmFja0J1ZmZlcnMoKTsKLSAgICB2aXJ0dWFsIHZvaWQgc2V0QWxsVHJhY2tC dWZmZXJzTmVlZFJhbmRvbUFjY2VzcygpOworICAgIFdFQkNPUkVfRVhQT1JUIHZpcnR1YWwgdm9p ZCByZWVucXVldWVNZWRpYUlmTmVlZGVkKGNvbnN0IE1lZGlhVGltZSYgY3VycmVudE1lZGlhVGlt ZSwgdWludDY0X3QgcGVuZGluZ0FwcGVuZERhdGFDYXBhY2l0eSwgdWludDY0X3QgbWF4aW11bUJ1 ZmZlclNpemUpOworICAgIFdFQkNPUkVfRVhQT1JUIHZpcnR1YWwgdm9pZCBhZGRUcmFja0J1ZmZl cihjb25zdCBBdG9tU3RyaW5nJiB0cmFja0lkLCBSZWZQdHI8TWVkaWFEZXNjcmlwdGlvbj4mJik7 CisgICAgV0VCQ09SRV9FWFBPUlQgdmlydHVhbCB2b2lkIHJlc2V0VHJhY2tCdWZmZXJzKCk7Cisg ICAgV0VCQ09SRV9FWFBPUlQgdmlydHVhbCB2b2lkIGNsZWFyVHJhY2tCdWZmZXJzKCk7CisgICAg V0VCQ09SRV9FWFBPUlQgdmlydHVhbCB2b2lkIHNldEFsbFRyYWNrQnVmZmVyc05lZWRSYW5kb21B Y2Nlc3MoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0R3JvdXBTdGFydFRpbWVzdGFtcChjb25zdCBN ZWRpYVRpbWUmIG1lZGlhVGltZSkgeyBtX2dyb3VwU3RhcnRUaW1lc3RhbXAgPSBtZWRpYVRpbWU7 IH0KICAgICB2aXJ0dWFsIHZvaWQgc2V0R3JvdXBTdGFydFRpbWVzdGFtcFRvRW5kVGltZXN0YW1w KCkgeyBtX2dyb3VwU3RhcnRUaW1lc3RhbXAgPSBtX2dyb3VwRW5kVGltZXN0YW1wOyB9CiAgICAg dmlydHVhbCB2b2lkIHNldFNob3VsZEdlbmVyYXRlVGltZXN0YW1wcyhib29sIGZsYWcpIHsgbV9z aG91bGRHZW5lcmF0ZVRpbWVzdGFtcHMgPSBmbGFnOyB9CiAgICAgV0VCQ09SRV9FWFBPUlQgdmly dHVhbCB2b2lkIHVwZGF0ZUJ1ZmZlcmVkRnJvbVRyYWNrQnVmZmVycyhib29sIHNvdXJjZUlzRW5k ZWQpOwotICAgIHZpcnR1YWwgdm9pZCByZW1vdmVDb2RlZEZyYW1lcyhjb25zdCBNZWRpYVRpbWUm IHN0YXJ0LCBjb25zdCBNZWRpYVRpbWUmIGVuZCwgY29uc3QgTWVkaWFUaW1lJiBjdXJyZW50TWVk aWFUaW1lLCBib29sIGlzRW5kZWQsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiA9IFtdIHsg fSk7CisgICAgV0VCQ09SRV9FWFBPUlQgdmlydHVhbCB2b2lkIHJlbW92ZUNvZGVkRnJhbWVzKGNv bnN0IE1lZGlhVGltZSYgc3RhcnQsIGNvbnN0IE1lZGlhVGltZSYgZW5kLCBjb25zdCBNZWRpYVRp bWUmIGN1cnJlbnRNZWRpYVRpbWUsIGJvb2wgaXNFbmRlZCwgQ29tcGxldGlvbkhhbmRsZXI8dm9p ZCgpPiYmID0gW10geyB9KTsKICAgICBXRUJDT1JFX0VYUE9SVCB2aXJ0dWFsIHZvaWQgZXZpY3RD b2RlZEZyYW1lcyh1aW50NjRfdCBuZXdEYXRhU2l6ZSwgdWludDY0X3QgcGVuZGluZ0FwcGVuZERh dGFDYXBhY2l0eSwgdWludDY0X3QgbWF4aW11bUJ1ZmZlclNpemUsIGNvbnN0IE1lZGlhVGltZSYg Y3VycmVudFRpbWUsIGNvbnN0IE1lZGlhVGltZSYgZHVyYXRpb24sIGJvb2wgaXNFbmRlZCk7Ci0g ICAgdmlydHVhbCB2b2lkIHJlc2V0VGltZXN0YW1wT2Zmc2V0SW5UcmFja0J1ZmZlcnMoKTsKKyAg ICBXRUJDT1JFX0VYUE9SVCB2aXJ0dWFsIHZvaWQgcmVzZXRUaW1lc3RhbXBPZmZzZXRJblRyYWNr QnVmZmVycygpOwogICAgIHZpcnR1YWwgdm9pZCBzdGFydENoYW5naW5nVHlwZSgpIHsgbV9wZW5k aW5nSW5pdGlhbGl6YXRpb25TZWdtZW50Rm9yQ2hhbmdlVHlwZSA9IHRydWU7IH0KICAgICB2aXJ0 dWFsIHZvaWQgc2V0VGltZXN0YW1wT2Zmc2V0KGNvbnN0IE1lZGlhVGltZSYgdGltZXN0YW1wT2Zm c2V0KSB7IG1fdGltZXN0YW1wT2Zmc2V0ID0gdGltZXN0YW1wT2Zmc2V0OyB9CiAgICAgdmlydHVh bCB2b2lkIHNldEFwcGVuZFdpbmRvd1N0YXJ0KGNvbnN0IE1lZGlhVGltZSYgYXBwZW5kV2luZG93 U3RhcnQpIHsgbV9hcHBlbmRXaW5kb3dTdGFydCA9IGFwcGVuZFdpbmRvd1N0YXJ0O30KICAgICB2 aXJ0dWFsIHZvaWQgc2V0QXBwZW5kV2luZG93RW5kKGNvbnN0IE1lZGlhVGltZSYgYXBwZW5kV2lu ZG93RW5kKSB7IG1fYXBwZW5kV2luZG93RW5kID0gYXBwZW5kV2luZG93RW5kOyB9Ci0gICAgdmly dHVhbCB2b2lkIHNlZWtUb1RpbWUoY29uc3QgTWVkaWFUaW1lJik7Ci0gICAgdmlydHVhbCB2b2lk IHVwZGF0ZVRyYWNrSWRzKFZlY3RvcjxzdGQ6OnBhaXI8QXRvbVN0cmluZywgQXRvbVN0cmluZz4+ JiYgdHJhY2tJZFBhaXJzKTsKKyAgICBXRUJDT1JFX0VYUE9SVCB2aXJ0dWFsIHZvaWQgc2Vla1Rv VGltZShjb25zdCBNZWRpYVRpbWUmKTsKKyAgICBXRUJDT1JFX0VYUE9SVCB2aXJ0dWFsIHZvaWQg dXBkYXRlVHJhY2tJZHMoVmVjdG9yPHN0ZDo6cGFpcjxBdG9tU3RyaW5nLCBBdG9tU3RyaW5nPj4m JiB0cmFja0lkUGFpcnMpOwogCiAgICAgdm9pZCBzZXRDbGllbnQoU291cmNlQnVmZmVyUHJpdmF0 ZUNsaWVudCogY2xpZW50KSB7IG1fY2xpZW50ID0gY2xpZW50OyB9CiAgICAgdm9pZCBzZXRJc0F0 dGFjaGVkKGJvb2wgZmxhZykgeyBtX2lzQXR0YWNoZWQgPSBmbGFnOyB9Cg==