221621 2021-02-09 11:56:23 -0800 [Cocoa] rename `ENGINEERING_BUILD` to `ENABLE_DEVELOPER_MODE` to match other platforms 2021-02-10 14:28:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221613 https://bugs.webkit.org/show_bug.cgi?id=221371 https://bugs.webkit.org/show_bug.cgi?id=221684 InRadar P2 Normal --- 1 hi hi ap bburg calvaris cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim hi jer.noble joepeck mcatanzaro philipj sergio webkit-bug-importer oldest_to_newest 1727157 0 hi 2021-02-09 11:56:23 -0800 see <https://bugs.webkit.org/show_bug.cgi?id=221371#c16> 1727162 1 419749 hi 2021-02-09 11:59:19 -0800 Created attachment 419749 Patch 1727178 2 ap 2021-02-09 12:21:55 -0800 It's great to rename it from ENGINEERING_BUILD, but I am still concerned about introducing this concept. It's not OK to have different code between Release and Production. It's not OK to assume that local builds are Release, and CI builds are Production (they often aren't). 1727268 3 hi 2021-02-09 14:38:39 -0800 (In reply to Alexey Proskuryakov from comment #2) > It's great to rename it from ENGINEERING_BUILD, but I am still concerned about introducing this concept. It's not OK to have different code between Release and Production. It's not OK to assume that local builds are Release, and CI builds are Production (they often aren't). It sounds like you don't want this to land then? IMO there's a huge amount of utility in being able to have minor tweaks that make debugging easier for local builds (e.g. giving a name to the injected media controls scripts so it's visible in Web Inspector). I'm not trying to "shame" you or change your mind or anything like that, I'm just asking because if this isn't going to land then we should land Bug 221613 in the meantime (or perhaps remove `ENGINEERING_BUILD` altogether) so non-Xcode builds aren't blocked. FYI WebInspectorUI has been doing something similar to this for years with `COMBINE_INSPECTOR_RESOURCES`/`COMBINE_TEST_RESOURCES` and AFAIK there haven't been any issues there. 1727276 4 419749 hi 2021-02-09 14:51:51 -0800 Comment on attachment 419749 Patch Seeing as `ENGINEERING_BUILD` is already in trunk and this patch just renames it so that non-Xcode builds aren't broken, I'm going to land this. I'm not doing this as any sort of "put my foot down and say we're keeping it" kind of thing. I'm more than willing to revisit the discussion (and even remove it if that's the agreed upon result). I just want to unblock non-Xcode builds. 1727292 5 ews-feeder 2021-02-09 15:06:58 -0800 Committed r272617: <https://commits.webkit.org/r272617> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419749. 1727294 6 ap 2021-02-09 15:07:13 -0800 We should remove ENGINEERING_BUILD altogether, and find a different way to achieve the goal. It's not doing quite what you want it to do, and it's going to get farther away from what's needed in the future. 1727297 7 mcatanzaro 2021-02-09 15:11:50 -0800 I don't think it will ever be possible to remove DEVELOPER_MODE from other ports. E.g. it's used in CMake to decide whether to hide internal symbols, which can't be done in development builds since that would prevent linking API tests, layout test runner, etc. 1727396 8 ap 2021-02-09 19:30:31 -0800 I am not concerned about other ports. It is the invalid distinction between Debug/Release and production builds on Apple platforms that should not exist. Devin, I’m going to post a patch to remove it tomorrow if you don’t beat me to it. We can think about better ways to achieve the goal separately. 1727775 9 webkit-bug-importer 2021-02-10 14:28:35 -0800 <rdar://problem/74206419> 419749 2021-02-09 11:59:19 -0800 2021-02-09 15:07:00 -0800 Patch 221621.diff text/plain 6165 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NGFhYmRmYTkwNWEuLjc2ZTFkYzRhZGM2MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDIxLTAyLTA5ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KKworICAgICAgICBbQ29jb2FdIHJlbmFtZSBgRU5HSU5FRVJJTkdfQlVJTERgIHRvIGBFTkFC TEVfREVWRUxPUEVSX01PREVgIHRvIG1hdGNoIG90aGVyIHBsYXRmb3JtcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNjIxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9CYXNl LnhjY29uZmlnOgorICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZp ZzoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmVuc3VyZU1lZGlhQ29udHJv bHNJbmplY3RlZFNjcmlwdCk6CisKIDIwMjEtMDItMDggIERldmluIFJvdXNzbyAgPGRyb3Vzc29A YXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFkZCBzdXBwb3J0IGZvciB0aGUgbGFuZ3VhZ2Uv c3VidGl0bGUgdHJhY2tzIGJ1dHRvbiB1c2luZyBgVUlNZW51YApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZyBiL1NvdXJjZS9XZWJDb3JlL0Nv bmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5kZXggNzdjYmJiZTFkMTUzLi5iZjQ4MzViY2Y5 MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25m aWcKKysrIGIvU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwpAQCAt NzAsNyArNzAsNyBAQCBHQ0NfR0VORVJBVEVfREVCVUdHSU5HX1NZTUJPTFMgPSBZRVM7CiBHQ0Nf Tk9fQ09NTU9OX0JMT0NLUyA9IFlFUzsKIEdDQ19PQkpDX0NBTExfQ1hYX0NEVE9SUyA9IFlFUzsK IEdDQ19QUkVDT01QSUxFX1BSRUZJWF9IRUFERVIgPSBZRVM7Ci1HQ0NfUFJFUFJPQ0VTU09SX0RF RklOSVRJT05TID0gJChpbmhlcml0ZWQpICQoRU5HSU5FRVJJTkdfQlVJTERfREVGSU5FUyk7CitH Q0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChpbmhlcml0ZWQpICQoREVWRUxPUEVSX01P REVfREVGSU5FUyk7CiBHQ0NfU1lNQk9MU19QUklWQVRFX0VYVEVSTiA9IFlFUzsKIEdDQ19USFJF QURTQUZFX1NUQVRJQ1MgPSBOTzsKIEdDQ19UUkVBVF9XQVJOSU5HU19BU19FUlJPUlMgPSBZRVM7 CkBAIC05Myw4ICs5Myw4IEBAIEdDQ19XQVJOX1VOVVNFRF9GVU5DVElPTiA9IFlFUzsKIEdDQ19X QVJOX1VOVVNFRF9WQVJJQUJMRSA9IFlFUzsKIFdBUk5JTkdfQ0ZMQUdTID0gLVdhbGwgLVdleHRy YSAtV2Nhc3QtcXVhbCAtV2NoYXItc3Vic2NyaXB0cyAtV2NvbmRpdGlvbmFsLXVuaW5pdGlhbGl6 ZWQgLVdleHRyYS10b2tlbnMgLVdmb3JtYXQ9MiAtV2luaXQtc2VsZiAtV21pc3NpbmctZm9ybWF0 LWF0dHJpYnV0ZSAtV21pc3Npbmctbm9yZXR1cm4gLVdwYWNrZWQgLVdwb2ludGVyLWFyaXRoIC1X cmVkdW5kYW50LWRlY2xzIC1XdW5kZWYgLVd3cml0ZS1zdHJpbmdzIC1XZXhpdC10aW1lLWRlc3Ry dWN0b3JzIC1XZ2xvYmFsLWNvbnN0cnVjdG9ycyAtV3RhdXRvbG9naWNhbC1jb21wYXJlIC1XaW1w bGljaXQtZmFsbHRocm91Z2ggLVd2bGEgLVduby11bmtub3duLXdhcm5pbmctb3B0aW9uIC1XbGl0 ZXJhbC1jb252ZXJzaW9uOwogCi1FTkdJTkVFUklOR19CVUlMRF9ERUZJTkVTID0gJChFTkdJTkVF UklOR19CVUlMRF9ERUZJTkVTXyQoRU5HSU5FRVJJTkdfQlVJTEQpKTsKLUVOR0lORUVSSU5HX0JV SUxEX0RFRklORVNfMSA9IEVOR0lORUVSSU5HX0JVSUxEPTE7CitERVZFTE9QRVJfTU9ERV9ERUZJ TkVTID0gJChERVZFTE9QRVJfTU9ERV9ERUZJTkVTXyQoREVWRUxPUEVSX01PREUpKTsKK0RFVkVM T1BFUl9NT0RFX0RFRklORVNfMSA9IEVOQUJMRV9ERVZFTE9QRVJfTU9ERT0xOwogCiBUQVJHRVRf TUFDT1NfTEVHQUNZX1ZFUlNJT05fSURFTlRJRklFUiA9ICQoVEFSR0VUX01BQ09TX0xFR0FDWV9W RVJTSU9OX0lERU5USUZJRVJfJChNQUNPU1hfREVQTE9ZTUVOVF9UQVJHRVQ6YmFzZSkpCiBUQVJH RVRfTUFDT1NfTEVHQUNZX1ZFUlNJT05fSURFTlRJRklFUl8xMCA9IDEwJChNQUNPU1hfREVQTE9Z TUVOVF9UQVJHRVQ6c3VmZml4OmlkZW50aWZpZXIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Db25maWd1cmF0aW9ucy9EZWJ1Z1JlbGVhc2UueGNjb25maWcgYi9Tb3VyY2UvV2ViQ29yZS9D b25maWd1cmF0aW9ucy9EZWJ1Z1JlbGVhc2UueGNjb25maWcKaW5kZXggYmVjNTViZmY3MWMxLi40 MWQ3MTgwZDMyMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0Rl YnVnUmVsZWFzZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9E ZWJ1Z1JlbGVhc2UueGNjb25maWcKQEAgLTQ5LDcgKzQ5LDcgQEAgTUFDT1NYX0RFUExPWU1FTlRf VEFSR0VUXzEwMTUwMCA9IDEwLjE1OwogTUFDT1NYX0RFUExPWU1FTlRfVEFSR0VUXzExMDAwMCA9 IDExLjA7CiBNQUNPU1hfREVQTE9ZTUVOVF9UQVJHRVRfMTIwMDAwID0gMTIuMDsKIAotRU5HSU5F RVJJTkdfQlVJTEQgPSAxOworREVWRUxPUEVSX01PREUgPSAxOwogCiBHQ0NfV0FSTl9BQk9VVF9E RVBSRUNBVEVEX0ZVTkNUSU9OUyA9IFlFUzsKIERFQlVHX0lORk9STUFUSU9OX0ZPUk1BVCA9IGR3 YXJmOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggNmI0YmVi N2M2ZDE0Li5lZGZjY2IxM2U5NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcApAQCAtNzE1Niw3ICs3MTU2LDcgQEAgYm9vbCBIVE1MTWVkaWFFbGVtZW50OjplbnN1 cmVNZWRpYUNvbnRyb2xzSW5qZWN0ZWRTY3JpcHQoKQogICAgICAgICBpZiAoZnVuY3Rpb25WYWx1 ZS5pc0NhbGxhYmxlKHZtKSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogCi0jaWYgRU5HSU5F RVJJTkdfQlVJTEQgfHwgIWRlZmluZWQoTkRFQlVHKQorI2lmIEVOQUJMRShERVZFTE9QRVJfTU9E RSkgfHwgIWRlZmluZWQoTkRFQlVHKQogICAgICAgICAvLyBTZXR0aW5nIGEgc2NyaXB0VVJMIGFs bG93cyB0aGUgc291cmNlIHRvIGJlIGRlYnVnZ2FibGUgaW4gdGhlIGluc3BlY3Rvci4KICAgICAg ICAgVVJMIHNjcmlwdFVSTCA9IFVSTCh7IH0sICJtZWRpYUNvbnRyb2xzU2NyaXB0Il9zKTsKICNl bHNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBjNTE2NWJmZjE1NGIuLjZiN2Y5MWVkZTBk NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDItMDkg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gcmVu YW1lIGBFTkdJTkVFUklOR19CVUlMRGAgdG8gYEVOQUJMRV9ERVZFTE9QRVJfTU9ERWAgdG8gbWF0 Y2ggb3RoZXIgcGxhdGZvcm1zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjE2MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWc6CisgICAgICAgICogQ29u ZmlndXJhdGlvbnMvRGVidWdSZWxlYXNlLnhjY29uZmlnOgorCiAyMDIxLTAyLTA4ICBQYXRyaWNr IEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQg YENTUy5zZXRMYXlvdXRDb250ZXh0VHlwZUNoYW5nZWRNb2RlYCBmb3IgZ2V0dGluZyBpbmZvcm1h dGlvbiBhYm91dCBhbGwgbGF5b3V0IGNvbnRleHRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCmluZGV4IDU0MzUzZjIyN2U2OS4uNzYz ZDAxMTI2MWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ29uZmlndXJhdGlv bnMvQmFzZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ29uZmlndXJhdGlv bnMvQmFzZS54Y2NvbmZpZwpAQCAtNDUsNyArNDUsNyBAQCBHQ0NfRkFTVF9PQkpDX0RJU1BBVENI ID0gWUVTOwogR0NDX0dFTkVSQVRFX0RFQlVHR0lOR19TWU1CT0xTID0gWUVTOwogR0NDX05PX0NP TU1PTl9CTE9DS1MgPSBZRVM7CiBHQ0NfUFJFQ09NUElMRV9QUkVGSVhfSEVBREVSID0gTk87Ci1H Q0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChpbmhlcml0ZWQpICQoRU5HSU5FRVJJTkdf QlVJTERfREVGSU5FUyk7CitHQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChpbmhlcml0 ZWQpICQoREVWRUxPUEVSX01PREVfREVGSU5FUyk7CiBHQ0NfVEhSRUFEU0FGRV9TVEFUSUNTID0g Tk87CiBHQ0NfVFJFQVRfV0FSTklOR1NfQVNfRVJST1JTID0gWUVTOwogR0NDX1ZFUlNJT04gPSBj b20uYXBwbGUuY29tcGlsZXJzLmxsdm0uY2xhbmcuMV8wOwpAQCAtNjQsOCArNjQsOCBAQCBHQ0Nf V0FSTl9VTlVTRURfRlVOQ1RJT04gPSBZRVM7CiBHQ0NfV0FSTl9VTlVTRURfVkFSSUFCTEUgPSBZ RVMKIFdBUk5JTkdfQ0ZMQUdTID0gLVdhbGwgLVcgLVdjYXN0LXF1YWwgLVdjaGFyLXN1YnNjcmlw dHMgLVdjb25kaXRpb25hbC11bmluaXRpYWxpemVkIC1XZm9ybWF0LXNlY3VyaXR5IC1XbWlzc2lu Zy1mb3JtYXQtYXR0cmlidXRlIC1XcG9pbnRlci1hcml0aCAtV3dyaXRlLXN0cmluZ3MgLVduby11 bnVzZWQtcGFyYW1ldGVyIC1XZXhpdC10aW1lLWRlc3RydWN0b3JzIC1XdmxhIC1XbGl0ZXJhbC1j b252ZXJzaW9uOwogCi1FTkdJTkVFUklOR19CVUlMRF9ERUZJTkVTID0gJChFTkdJTkVFUklOR19C VUlMRF9ERUZJTkVTXyQoRU5HSU5FRVJJTkdfQlVJTEQpKTsKLUVOR0lORUVSSU5HX0JVSUxEX0RF RklORVNfMSA9IEVOR0lORUVSSU5HX0JVSUxEPTE7CitERVZFTE9QRVJfTU9ERV9ERUZJTkVTID0g JChERVZFTE9QRVJfTU9ERV9ERUZJTkVTXyQoREVWRUxPUEVSX01PREUpKTsKK0RFVkVMT1BFUl9N T0RFX0RFRklORVNfMSA9IEVOQUJMRV9ERVZFTE9QRVJfTU9ERT0xOwogCiBTVVBQT1JURURfUExB VEZPUk1TID0gaXBob25lb3MgaXBob25lc2ltdWxhdG9yIG1hY29zeCBhcHBsZXR2b3MgYXBwbGV0 dnNpbXVsYXRvciB3YXRjaG9zIHdhdGNoc2ltdWxhdG9yOwogU1VQUE9SVFNfTUFDQ0FUQUxZU1Qg PSBZRVM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ29uZmlndXJhdGlvbnMv RGVidWdSZWxlYXNlLnhjY29uZmlnIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NvbmZpZ3VyYXRp b25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZwppbmRleCBlZjA3M2NkOWY2ZTYuLmY5YmMwZmFhY2Mx YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NvbmZpZ3VyYXRpb25zL0RlYnVn UmVsZWFzZS54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ29uZmlndXJhdGlv bnMvRGVidWdSZWxlYXNlLnhjY29uZmlnCkBAIC0yNiw3ICsyNiw3IEBAIE1BQ09TWF9ERVBMT1lN RU5UX1RBUkdFVF8xMDE1MDAgPSAxMC4xNTsKIE1BQ09TWF9ERVBMT1lNRU5UX1RBUkdFVF8xMTAw MDAgPSAxMS4wOwogTUFDT1NYX0RFUExPWU1FTlRfVEFSR0VUXzEyMDAwMCA9IDEyLjA7CiAKLUVO R0lORUVSSU5HX0JVSUxEID0gMTsKK0RFVkVMT1BFUl9NT0RFID0gMTsKIAogR0NDX1dBUk5fQUJP VVRfREVQUkVDQVRFRF9GVU5DVElPTlMgPSBZRVM7CiBERUJVR19JTkZPUk1BVElPTl9GT1JNQVQg PSBkd2FyZjsK