221620 2021-02-09 11:53:57 -0800 Make Caches::writeRecord and Caches::readRecord more robust 2021-07-06 12:34:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez cgarcia ews-watchlist webkit-bug-importer youennf oldest_to_newest 1727153 0 achristensen 2021-02-09 11:53:57 -0800 Make Caches::writeRecord and Caches::readRecord more robust 1727155 1 419748 achristensen 2021-02-09 11:54:47 -0800 Created attachment 419748 Patch 1727156 2 achristensen 2021-02-09 11:55:07 -0800 Crash record at https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Release-WK2-Tests-EWS/r419742-829/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https-crash-log.txt 1729848 3 webkit-bug-importer 2021-02-16 11:54:16 -0800 <rdar://problem/74400704> 1774902 4 419748 youennf 2021-07-06 02:08:04 -0700 Comment on attachment 419748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419748&action=review > Source/WebKit/ChangeLog:9 > + Some events happen during teardown. No reason to crash. This seems ok to add a null check. The underlying issue is probably that: - we request space, which is an asynchronous operation as we may prompt user - somehow we are requested to clear the caches - user grants request space and we are back with no available storage. I think this can be fixed by bailing out early in Caches::requestSpace callback in case m_isInitialized is false. 1774991 5 achristensen 2021-07-06 10:41:04 -0700 r279597 1775008 6 achristensen 2021-07-06 11:30:46 -0700 Reverted in r279599 1775009 7 achristensen 2021-07-06 11:32:21 -0700 Reopening to attach new patch. 1775010 8 432953 achristensen 2021-07-06 11:32:23 -0700 Created attachment 432953 Patch 1775044 9 ews-feeder 2021-07-06 12:34:15 -0700 Committed r279607 (239430@main): <https://commits.webkit.org/239430@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432953. 419748 2021-02-09 11:54:47 -0800 2021-07-06 11:32:18 -0700 Patch bug-221620-20210209115446.patch text/plain 2339 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE3ZTVlZjAyMjZiZTZmNDg3 Y2MzZThjYTYxNTJlZWM2MzExYzViMGQuLjUxODVhOWFlZGZjMjJiZjAzMmRhOTQ3MGJhNWVhZDhi MjA1MGU2MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDItMDkgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBNYWtlIENhY2hl czo6d3JpdGVSZWNvcmQgYW5kIENhY2hlczo6cmVhZFJlY29yZCBtb3JlIHJvYnVzdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNjIwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBzYXcgbnVsbCBkZXJl ZmVyZW5jZWQgaW4gRVdTLCBhbmQgZXZlcnl3aGVyZSBlbHNlIHdlIGNoZWNrIG1fc3RvcmFnZSBm b3IgbnVsbC4KKyAgICAgICAgU29tZSBldmVudHMgaGFwcGVuIGR1cmluZyB0ZWFyZG93bi4gIE5v IHJlYXNvbiB0byBjcmFzaC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hl U3RvcmFnZUVuZ2luZUNhY2hlcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6 Q2FjaGVzOjp3cml0ZVJlY29yZCk6CisgICAgICAgIChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6Q2Fj aGVzOjpyZWFkUmVjb3JkKToKKwogMjAyMS0wMi0wOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVzZSBDb21wbGV0aW9uSGFuZGxlciBpbnN0 ZWFkIG9mIERyYXdUb1BERkNhbGxiYWNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hlcy5jcHAgYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hlcy5jcHAKaW5k ZXggMGIwOWI4MDY3NGRiYzE3NGQyYWU1MzUxMzIxNTYxNTY3M2U3NTM4NS4uZDY4ZGY4YWIxOWMz MWVkZmI2OGUwOWQ2MzZjMWFjYzAwZTM1YTNkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2FjaGVz LmNwcApAQCAtNTQ5LDYgKzU0OSw5IEBAIHZvaWQgQ2FjaGVzOjp3cml0ZVJlY29yZChjb25zdCBD YWNoZSYgY2FjaGUsIGNvbnN0IFJlY29yZEluZm9ybWF0aW9uJiByZWNvcmRJbmZvCiAgICAgICAg IHJldHVybjsKICAgICB9CiAKKyAgICBpZiAoIW1fc3RvcmFnZSkKKyAgICAgICAgcmV0dXJuIGNh bGxiYWNrKFdURjo6bnVsbG9wdCk7CisKICAgICBtX3N0b3JhZ2UtPnN0b3JlKENhY2hlOjplbmNv ZGUocmVjb3JkSW5mb3JtYXRpb24sIHJlY29yZCksIHsgfSwgW3RoaXMsIHByb3RlY3RlZFRoaXMg PSBtYWtlUmVmKCp0aGlzKSwgcHJvdGVjdGVkU3RvcmFnZSA9IG1ha2VSZWYoKm1fc3RvcmFnZSks IGNhbGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKGludCBlcnJvcikgbXV0YWJsZSB7CiAgICAg ICAgIGlmIChlcnJvcikgewogICAgICAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoQ2FjaGVTdG9y YWdlLCAiQ2FjaGVzOjp3cml0ZVJlY29yZCBmYWlsZWQgd2l0aCBlcnJvciAlZCIsIGVycm9yKTsK QEAgLTU3NSw2ICs1NzgsOSBAQCB2b2lkIENhY2hlczo6cmVhZFJlY29yZChjb25zdCBOZXR3b3Jr Q2FjaGU6OktleSYga2V5LCBXVEY6OkZ1bmN0aW9uPHZvaWQoRXhwZWN0ZQogICAgICAgICByZXR1 cm47CiAgICAgfQogCisgICAgaWYgKCFtX3N0b3JhZ2UpCisgICAgICAgIHJldHVybiBjYWxsYmFj ayhtYWtlVW5leHBlY3RlZChFcnJvcjo6SW50ZXJuYWwpKTsKKwogICAgIG1fc3RvcmFnZS0+cmV0 cmlldmUoa2V5LCA0LCBbcHJvdGVjdGVkU3RvcmFnZSA9IG1ha2VSZWYoKm1fc3RvcmFnZSksIGNh bGxiYWNrID0gV1RGTW92ZShjYWxsYmFjayldKHN0ZDo6dW5pcXVlX3B0cjxTdG9yYWdlOjpSZWNv cmQ+IHN0b3JhZ2UsIGNvbnN0IFN0b3JhZ2U6OlRpbWluZ3MmKSBtdXRhYmxlIHsKICAgICAgICAg aWYgKCFzdG9yYWdlKSB7CiAgICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihDYWNoZVN0b3Jh Z2UsICJDYWNoZXM6OnJlYWRSZWNvcmQgZmFpbGVkIHJlYWRpbmcgcmVjb3JkIGZyb20gZGlzayIp Owo= 432953 2021-07-06 11:32:23 -0700 2021-07-06 12:34:16 -0700 Patch bug-221620-20210706113222.patch text/plain 2150 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzk1OTkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTA2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBDYWNoZXM6 OndyaXRlUmVjb3JkIGFuZCBDYWNoZXM6OnJlYWRSZWNvcmQgbW9yZSByb2J1c3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYyMAorCisgICAgICAg IFJldmlld2VkIGJ5IFlvdWVubiBGYWJsZXQuCisKKyAgICAgICAgSSBzYXcgbnVsbCBkZXJlZmVy ZW5jZWQgaW4gRVdTLCBhbmQgZXZlcnl3aGVyZSBlbHNlIHdlIGNoZWNrIG1fc3RvcmFnZSBmb3Ig bnVsbC4KKyAgICAgICAgU29tZSBldmVudHMgaGFwcGVuIGR1cmluZyB0ZWFyZG93bi4gIE5vIHJl YXNvbiB0byBjcmFzaC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3Rv cmFnZUVuZ2luZUNhY2hlcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6Q2Fj aGVzOjp3cml0ZVJlY29yZCk6CisgICAgICAgIChXZWJLaXQ6OkNhY2hlU3RvcmFnZTo6Q2FjaGVz OjpyZWFkUmVjb3JkKToKKwogMjAyMS0wNy0wNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc5NTk3 LgpJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VF bmdpbmVDYWNoZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2FjaGVzLmNwcAkocmV2aXNpb24gMjc5NTk5KQor KysgU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3JhZ2VFbmdpbmVD YWNoZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NDksNiArNTQ5LDkgQEAgdm9pZCBDYWNoZXM6 OndyaXRlUmVjb3JkKGNvbnN0IENhY2hlJiBjYQogICAgICAgICByZXR1cm47CiAgICAgfQogCisg ICAgaWYgKCFtX3N0b3JhZ2UpCisgICAgICAgIHJldHVybiBjYWxsYmFjayhzdGQ6Om51bGxvcHQp OworCiAgICAgbV9zdG9yYWdlLT5zdG9yZShDYWNoZTo6ZW5jb2RlKHJlY29yZEluZm9ybWF0aW9u LCByZWNvcmQpLCB7IH0sIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIHBy b3RlY3RlZFN0b3JhZ2UgPSBtYWtlUmVmKCptX3N0b3JhZ2UpLCBjYWxsYmFjayA9IFdURk1vdmUo Y2FsbGJhY2spXShpbnQgZXJyb3IpIG11dGFibGUgewogICAgICAgICBpZiAoZXJyb3IpIHsKICAg ICAgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKENhY2hlU3RvcmFnZSwgIkNhY2hlczo6d3JpdGVS ZWNvcmQgZmFpbGVkIHdpdGggZXJyb3IgJWQiLCBlcnJvcik7CkBAIC01NzEsNiArNTc0LDkgQEAg dm9pZCBDYWNoZXM6OnJlYWRSZWNvcmQoY29uc3QgTmV0d29ya0NhYwogICAgICAgICByZXR1cm4g Y2FsbGJhY2sobWFrZVVuZXhwZWN0ZWQoRXJyb3I6OkludGVybmFsKSk7CiAgICAgfQogCisgICAg aWYgKCFtX3N0b3JhZ2UpCisgICAgICAgIHJldHVybiBjYWxsYmFjayhtYWtlVW5leHBlY3RlZChF cnJvcjo6SW50ZXJuYWwpKTsKKwogICAgIG1fc3RvcmFnZS0+cmV0cmlldmUoa2V5LCA0LCBbcHJv dGVjdGVkU3RvcmFnZSA9IG1ha2VSZWYoKm1fc3RvcmFnZSksIGNhbGxiYWNrID0gV1RGTW92ZShj YWxsYmFjayldKHN0ZDo6dW5pcXVlX3B0cjxTdG9yYWdlOjpSZWNvcmQ+IHN0b3JhZ2UsIGNvbnN0 IFN0b3JhZ2U6OlRpbWluZ3MmKSBtdXRhYmxlIHsKICAgICAgICAgaWYgKCFzdG9yYWdlKSB7CiAg ICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihDYWNoZVN0b3JhZ2UsICJDYWNoZXM6OnJlYWRS ZWNvcmQgZmFpbGVkIHJlYWRpbmcgcmVjb3JkIGZyb20gZGlzayIpOwo=