22162 2008-11-10 12:18:37 -0800 Remove cachedValueGetter from the JavaScriptCore API implementation 2008-11-10 12:26:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 98190 0 zwarich 2008-11-10 12:18:37 -0800 There is no more need for the cachedValueGetter hack now that we have PropertySlot::setValue(), so we should remove it. 98191 1 25024 zwarich 2008-11-10 12:20:12 -0800 Created attachment 25024 Proposed patch 98192 2 25024 ggaren 2008-11-10 12:22:00 -0800 Comment on attachment 25024 Proposed patch r=me Please mark the Radar as fixed, too. 98193 3 zwarich 2008-11-10 12:26:02 -0800 Landed in r38268. 25024 2008-11-10 12:20:12 -0800 2008-11-10 12:22:00 -0800 Proposed patch hack.diff text/plain 2937 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MjY2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMTEt MTAgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjE2MjogUmVtb3ZlIGNhY2hl ZFZhbHVlR2V0dGVyIGZyb20gdGhlIEphdmFTY3JpcHRDb3JlIEFQSSBpbXBsZW1lbnRhdGlvbgor ICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYyPgor CisgICAgICAgIFRoZXJlIGlzIG5vIG1vcmUgbmVlZCBmb3IgdGhlIGNhY2hlZFZhbHVlR2V0dGVy IGhhY2sgbm93IHRoYXQgd2UgaGF2ZQorICAgICAgICBQcm9wZXJ0eVNsb3Q6OnNldFZhbHVlKCks IHNvIHdlIHNob3VsZCByZW1vdmUgaXQuCisKKyAgICAgICAgKiBBUEkvSlNDYWxsYmFja09iamVj dC5oOgorICAgICAgICAqIEFQSS9KU0NhbGxiYWNrT2JqZWN0RnVuY3Rpb25zLmg6CisgICAgICAg IChKU0M6Ojo6Z2V0T3duUHJvcGVydHlTbG90KToKKwogMjAwOC0xMS0xMCAgQ2FtZXJvbiBad2Fy aWNoICA8endhcmljaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCkluZGV4OiBBUEkvSlNDYWxsYmFja09iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEFQSS9KU0Nh bGxiYWNrT2JqZWN0LmgJKHJldmlzaW9uIDM4MjY2KQorKysgQVBJL0pTQ2FsbGJhY2tPYmplY3Qu aAkod29ya2luZyBjb3B5KQpAQCAtODIsNyArODIsNiBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBK U1ZhbHVlKiBjYWxsKEV4ZWNTdGF0ZSosIEpTT2JqZWN0KiBmdW5jdGlvbk9iamVjdCwgSlNWYWx1 ZSogdGhpc1ZhbHVlLCBjb25zdCBBcmdMaXN0Jik7CiAgICAgc3RhdGljIEpTT2JqZWN0KiBjb25z dHJ1Y3QoRXhlY1N0YXRlKiwgSlNPYmplY3QqIGNvbnN0cnVjdG9yLCBjb25zdCBBcmdMaXN0Jik7 CiAgICAKLSAgICBzdGF0aWMgSlNWYWx1ZSogY2FjaGVkVmFsdWVHZXR0ZXIoRXhlY1N0YXRlKiwg Y29uc3QgSWRlbnRpZmllciYsIGNvbnN0IFByb3BlcnR5U2xvdCYpOwogICAgIHN0YXRpYyBKU1Zh bHVlKiBzdGF0aWNWYWx1ZUdldHRlcihFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiwgY29u c3QgUHJvcGVydHlTbG90Jik7CiAgICAgc3RhdGljIEpTVmFsdWUqIHN0YXRpY0Z1bmN0aW9uR2V0 dGVyKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBjb25zdCBQcm9wZXJ0eVNsb3QmKTsK ICAgICBzdGF0aWMgSlNWYWx1ZSogY2FsbGJhY2tHZXR0ZXIoRXhlY1N0YXRlKiwgY29uc3QgSWRl bnRpZmllciYsIGNvbnN0IFByb3BlcnR5U2xvdCYpOwpJbmRleDogQVBJL0pTQ2FsbGJhY2tPYmpl Y3RGdW5jdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBBUEkvSlNDYWxsYmFja09iamVjdEZ1bmN0aW9u cy5oCShyZXZpc2lvbiAzODI2NikKKysrIEFQSS9KU0NhbGxiYWNrT2JqZWN0RnVuY3Rpb25zLmgJ KHdvcmtpbmcgY29weSkKQEAgLTEyNywxMCArMTI3LDcgQEAgYm9vbCBKU0NhbGxiYWNrT2JqZWN0 PEJhc2U+OjpnZXRPd25Qcm9wZQogICAgICAgICAgICAgICAgIHByb3BlcnR5TmFtZVJlZiA9IE9w YXF1ZUpTU3RyaW5nOjpjcmVhdGUocHJvcGVydHlOYW1lLnVzdHJpbmcoKSk7CiAgICAgICAgICAg ICBKU0xvY2s6OkRyb3BBbGxMb2NrcyBkcm9wQWxsTG9ja3MoZXhlYyk7CiAgICAgICAgICAgICBp ZiAoSlNWYWx1ZVJlZiB2YWx1ZSA9IGdldFByb3BlcnR5KGN0eCwgdGhpc1JlZiwgcHJvcGVydHlO YW1lUmVmLmdldCgpLCB0b1JlZihleGVjLT5leGNlcHRpb25TbG90KCkpKSkgewotICAgICAgICAg ICAgICAgIC8vIGNhY2hlIHRoZSB2YWx1ZSBzbyB3ZSBkb24ndCBoYXZlIHRvIGNvbXB1dGUgaXQg YWdhaW4KLSAgICAgICAgICAgICAgICAvLyBGSVhNRTogVGhpcyB2aW9sYXRlcyB0aGUgUHJvcGVy dHlTbG90IGRlc2lnbiBhIGxpdHRsZSBiaXQuCi0gICAgICAgICAgICAgICAgLy8gV2Ugc2hvdWxk IGVpdGhlciB1c2UgdGhpcyBvcHRpbWl6YXRpb24gZXZlcnl3aGVyZSwgb3Igbm93aGVyZS4KLSAg ICAgICAgICAgICAgICBzbG90LnNldEN1c3RvbSh0b0pTKHZhbHVlKSwgY2FjaGVkVmFsdWVHZXR0 ZXIpOworICAgICAgICAgICAgICAgIHNsb3Quc2V0VmFsdWUodG9KUyh2YWx1ZSkpOwogICAgICAg ICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAgfQogICAgICAgICB9CkBAIC00MzAs MTQgKzQyNyw2IEBAIGJvb2wgSlNDYWxsYmFja09iamVjdDxCYXNlPjo6aW5oZXJpdHMoSlMKIH0K IAogdGVtcGxhdGUgPGNsYXNzIEJhc2U+Ci1KU1ZhbHVlKiBKU0NhbGxiYWNrT2JqZWN0PEJhc2U+ OjpjYWNoZWRWYWx1ZUdldHRlcihFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiwgY29uc3Qg UHJvcGVydHlTbG90JiBzbG90KQotewotICAgIEpTVmFsdWUqIHYgPSBzbG90LnNsb3RCYXNlKCk7 Ci0gICAgQVNTRVJUKHYpOwotICAgIHJldHVybiB2OwotfQotCi10ZW1wbGF0ZSA8Y2xhc3MgQmFz ZT4KIEpTVmFsdWUqIEpTQ2FsbGJhY2tPYmplY3Q8QmFzZT46OnN0YXRpY1ZhbHVlR2V0dGVyKEV4 ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBjb25zdCBQcm9w ZXJ0eVNsb3QmIHNsb3QpCiB7CiAgICAgSlNDYWxsYmFja09iamVjdCogdGhpc09iaiA9IGFzQ2Fs bGJhY2tPYmplY3Qoc2xvdC5zbG90QmFzZSgpKTsK