221613 2021-02-09 10:08:52 -0800 Check if ENGINEERING_BUILD is defined before testing it 2021-02-09 12:02:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=221371 https://bugs.webkit.org/show_bug.cgi?id=221621 P2 Normal --- 1 mcatanzaro mcatanzaro calvaris cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble mcatanzaro philipj sergio oldest_to_newest 1727111 0 mcatanzaro 2021-02-09 10:08:52 -0800 Small warning added in bug #221371: [1385/2409] Building CXX object Source...ources/UnifiedSource-950a39b6-10.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-950a39b6-10.cpp:2: ../../Source/WebCore/html/HTMLMediaElement.cpp:7159:5: warning: "ENGINEERING_BUILD" is not defined, evaluates to 0 [-Wundef] 7159 | #if ENGINEERING_BUILD || !defined(NDEBUG) | ^~~~~~~~~~~~~~~~~ Let's test if it's defined first. 1727136 1 419743 mcatanzaro 2021-02-09 11:02:45 -0800 Created attachment 419743 Patch 1727167 2 419743 mcatanzaro 2021-02-09 12:02:01 -0800 Comment on attachment 419743 Patch This will conflict with and is obsoleted by Devin's patch in bug #221621. 419743 2021-02-09 11:02:45 -0800 2021-02-09 12:02:01 -0800 Patch bug-221613-20210209130244.patch text/plain 1502 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFjN2M4NTUyYmQzZmQy YjkwMmYwMjZkNjJjZTNhMmIxZDFkZjA2MC4uZGY2ZmM5YTgxYWYwMDdhYzQxM2FmOGU4MDAwNmI5 MTY3YjE3OTA4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTAyLTA5ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIENoZWNrIGlm IEVOR0lORUVSSU5HX0JVSUxEIGlzIGRlZmluZWQgYmVmb3JlIHRlc3RpbmcgaXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYxMworCisgICAgICAg IFVucmV2aWV3ZWQsIGp1c3QgYXZvaWQgdGVzdGluZyBFTkdJTkVFUklOR19CVUlMRCBpZiBpdCdz IG5vdCBiZWVuIGRlZmluZWQuCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZW5zdXJlTWVkaWFDb250cm9s c0luamVjdGVkU2NyaXB0KToKKwogMjAyMS0wMi0wOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gY2FuVXNlRm9yVGV4dCBzaG91bGQgYWxzbyBj aGVjayBpZiB0aGUgc3BhY2UgZ2x5cGggY29tZXMgZnJvbSB0aGUgcHJpbWFyeSBmb250CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA2YjRiZWI3YzZkMTRlNWYz OWJiYmU1YzFiMzA5NjY0MjI1ZjdmYWM1Li40ZTY1ZDZkMzQwMjRhZDFkNjlkOTY1YThmZDYxMjBk Yjc0YTIzMGM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAg LTcxNTYsNyArNzE1Niw3IEBAIGJvb2wgSFRNTE1lZGlhRWxlbWVudDo6ZW5zdXJlTWVkaWFDb250 cm9sc0luamVjdGVkU2NyaXB0KCkKICAgICAgICAgaWYgKGZ1bmN0aW9uVmFsdWUuaXNDYWxsYWJs ZSh2bSkpCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKIAotI2lmIEVOR0lORUVSSU5HX0JVSUxE IHx8ICFkZWZpbmVkKE5ERUJVRykKKyNpZiAoZGVmaW5lZChFTkdJTkVFUklOR19CVUlMRCkgJiYg RU5HSU5FRVJJTkdfQlVJTEQpIHx8ICFkZWZpbmVkKE5ERUJVRykKICAgICAgICAgLy8gU2V0dGlu ZyBhIHNjcmlwdFVSTCBhbGxvd3MgdGhlIHNvdXJjZSB0byBiZSBkZWJ1Z2dhYmxlIGluIHRoZSBp bnNwZWN0b3IuCiAgICAgICAgIFVSTCBzY3JpcHRVUkwgPSBVUkwoeyB9LCAibWVkaWFDb250cm9s c1NjcmlwdCJfcyk7CiAjZWxzZQo=