22161 2008-11-10 11:49:01 -0800 Assertion failure in RenderThemeWin::systemColor when loading microsoftpdc.com 2008-11-10 14:13:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows XP RESOLVED FIXED data:text/html,<span style="outline-color: invert"></span> InRadar, PlatformOnly P2 Normal --- 1 aroben aroben oldest_to_newest 98184 0 aroben 2008-11-10 11:49:01 -0800 To reproduce: 1. Go to http://www.microsoftpdc.com/ You'll hit the following assertion: ASSERT(sysColorIndex != -1); Here's the backtrace: > WebKit_debug.dll!WebCore::RenderThemeWin::systemColor(int cssValueId=248) Line 805 + 0x22 bytes C++ WebKit_debug.dll!WebCore::colorForCSSValue(int cssValueId=248) Line 5598 + 0x1f bytes C++ WebKit_debug.dll!WebCore::CSSStyleSelector::getColorFromPrimitiveValue(WebCore::CSSPrimitiveValue * primitiveValue=0x075b0900) Line 5625 + 0xd bytes C++ WebKit_debug.dll!WebCore::CSSStyleSelector::applyProperty(int id=1071, WebCore::CSSValue * value=0x075b0900) Line 3198 + 0x13 bytes C++ WebKit_debug.dll!WebCore::CSSStyleSelector::applyDeclarations(bool applyFirst=false, bool isImportant=false, int startIndex=0, int endIndex=0) Line 2646 C++ WebKit_debug.dll!WebCore::CSSStyleSelector::styleForElement(WebCore::Element * e=0x076c28d8, WebCore::RenderStyle * defaultParent=0x00000000, bool allowSharing=true, bool resolveForRootDefault=false) Line 1146 C++ WebKit_debug.dll!WebCore::Node::styleForRenderer() Line 1048 + 0x24 bytes C++ WebKit_debug.dll!WebCore::Node::createRendererIfNeeded() Line 1030 + 0xc bytes C++ WebKit_debug.dll!WebCore::Element::attach() Line 656 C++ WebKit_debug.dll!WebCore::HTMLParser::insertNode(WebCore::Node * n=0x076c28d8, bool flat=false) Line 348 + 0x12 bytes C++ WebKit_debug.dll!WebCore::HTMLParser::handleError(WebCore::Node * n=0x076c28d8, bool flat=false, const WebCore::AtomicString & localName={...}, int tagPriority=1) Line 652 C++ WebKit_debug.dll!WebCore::HTMLParser::insertNode(WebCore::Node * n=0x076c28d8, bool flat=false) Line 326 + 0x18 bytes C++ WebKit_debug.dll!WebCore::HTMLParser::handleError(WebCore::Node * n=0x076c28d8, bool flat=false, const WebCore::AtomicString & localName={...}, int tagPriority=1) Line 652 C++ WebKit_debug.dll!WebCore::HTMLParser::insertNode(WebCore::Node * n=0x076c28d8, bool flat=false) Line 326 + 0x18 bytes C++ WebKit_debug.dll!WebCore::HTMLParser::parseToken(WebCore::Token * t=0x070fa03c) Line 257 + 0x18 bytes C++ WebKit_debug.dll!WebCore::HTMLTokenizer::processToken() Line 1923 + 0x19 bytes C++ WebKit_debug.dll!WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString & src={...}, WebCore::HTMLTokenizer::State state={...}) Line 1502 + 0xf bytes C++ WebKit_debug.dll!WebCore::HTMLTokenizer::write(const WebCore::SegmentedString & str={...}, bool appendData=true) Line 1752 + 0x1d bytes C++ WebKit_debug.dll!WebCore::FrameLoader::write(const char * str=0x07165040, int len=42, bool flush=false) Line 1041 + 0x21 bytes C++ WebKit_debug.dll!WebCore::FrameLoader::addData(const char * bytes=0x07165040, int length=42) Line 1889 C++ WebKit_debug.dll!WebFrameLoaderClient::receivedData(const char * data=0x07165040, int length=42, const WebCore::String & textEncoding={us-ascii}) Line 401 C++ WebKit_debug.dll!WebFrameLoaderClient::committedLoad(WebCore::DocumentLoader * loader=0x076e1028, const char * data=0x07165040, int length=42) Line 372 C++ WebKit_debug.dll!WebCore::FrameLoader::committedLoad(WebCore::DocumentLoader * loader=0x076e1028, const char * data=0x07165040, int length=42) Line 3458 + 0x24 bytes C++ WebKit_debug.dll!WebCore::DocumentLoader::commitLoad(const char * data=0x07165040, int length=42) Line 356 C++ WebKit_debug.dll!WebCore::DocumentLoader::receivedData(const char * data=0x07165040, int length=42) Line 368 C++ WebKit_debug.dll!WebCore::FrameLoader::receivedData(const char * data=0x07165040, int length=42) Line 2344 C++ WebKit_debug.dll!WebCore::MainResourceLoader::addData(const char * data=0x07165040, int length=42, bool allAtOnce=false) Line 146 C++ WebKit_debug.dll!WebCore::ResourceLoader::didReceiveData(const char * data=0x07165040, int length=42, __int64 lengthReceived=42, bool allAtOnce=false) Line 251 + 0x1b bytes C++ WebKit_debug.dll!WebCore::MainResourceLoader::didReceiveData(const char * data=0x07165040, int length=42, __int64 lengthReceived=42, bool allAtOnce=false) Line 315 C++ WebKit_debug.dll!WebCore::ResourceLoader::didReceiveData(WebCore::ResourceHandle * __formal=0x04e5f2d0, const char * data=0x07165040, int length=42, int lengthReceived=42) Line 393 + 0x1f bytes C++ WebKit_debug.dll!WebCore::didReceiveData(_CFURLConnection * conn=0x07752ef8, const __CFData * data=0x07165028, long originalLength=42, const void * clientInfo=0x04e5f2d0) Line 109 + 0x2a bytes C++ 98185 1 aroben 2008-11-10 11:49:14 -0800 The problem is that the following rule has been specified in the site's CSS: a, img { outline-color: invert; } But RenderThemeWin doesn't support "invert" as a color value. In Release builds, this will cause the outline to be opaque black, but should not crash. 98186 2 aroben 2008-11-10 11:49:44 -0800 <rdar://problem/6340628> 98204 3 25026 aroben 2008-11-10 14:10:13 -0800 Created attachment 25026 Patch + ChangeLog 98205 4 25026 mitz 2008-11-10 14:11:16 -0800 Comment on attachment 25026 Patch + ChangeLog r=me 98206 5 aroben 2008-11-10 14:13:38 -0800 Committed in r38274 <http://trac.webkit.org/changeset/38274> 25026 2008-11-10 14:10:13 -0800 2008-11-10 14:11:16 -0800 Patch + ChangeLog 0001-Fix-Bug-22161-Assertion-failure-in-RenderThemeWin.patch text/plain 5193 aroben RnJvbSBmMTQ0YTgwMWY5OTVlNzFhNzA2YjA3ZmU2YzNlMzZmNjE2NjdiYzMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBN b24sIDEwIE5vdiAyMDA4IDE3OjA5OjU2IC0wNTAwClN1YmplY3Q6IFtQRlJdIEZpeCBCdWcgMjIx NjE6IEFzc2VydGlvbiBmYWlsdXJlIGluIFJlbmRlclRoZW1lV2luOjpzeXN0ZW1Db2xvciB3aGVu IGxvYWRpbmcgbWljcm9zb2Z0cGRjLmNvbQoKV2ViQ29yZToKCiAgICAgICAgRml4IEJ1ZyAyMjE2 MTogQXNzZXJ0aW9uIGZhaWx1cmUgaW4gUmVuZGVyVGhlbWVXaW46OnN5c3RlbUNvbG9yIHdoZW4K ICAgICAgICBsb2FkaW5nIG1pY3Jvc29mdHBkYy5jb20KCiAgICAgICAgPGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE2MT4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCgogICAgICAgIFRlc3Q6IGZhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFzc2Vy dGlvbi5odG1sCgogICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcDoKICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVXaW46OnN5c3RlbUNvbG9yKTogSWYgd2UgY2FuJ3QgZGV0 ZXJtaW5lIGEgZ29vZAogICAgICAgIFdpbjMyIHN5c3RlbSBjb2xvciB0byB1c2UsIGRlZmVyIHRv IFJlbmRlclRoZW1lIGluc3RlYWQgb2YgYXNzZXJ0aW5nLgogICAgICAgIFRoaXMgbWF0Y2hlcyB3 aGF0IFJlbmRlclRoZW1lTWFjIGRvZXMuCgpMYXlvdXRUZXN0czoKCiAgICAgICAgVGVzdCBmb3Ig QnVnIDIyMTYxOiBBc3NlcnRpb24gZmFpbHVyZSBpbiBSZW5kZXJUaGVtZVdpbjo6c3lzdGVtQ29s b3IKICAgICAgICB3aGVuIGxvYWRpbmcgbWljcm9zb2Z0cGRjLmNvbQoKICAgICAgICA8aHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYxPgoKICAgICAgICBOb3RlIHRo YXQgdGhpcyB0ZXN0IHdvdWxkIG9ubHkgZmFpbCBpZiBEdW1wUmVuZGVyVHJlZSB1c2VkCiAgICAg ICAgUmVuZGVyVGhlbWVXaW4sIHdoaWNoIGl0IGRvZXNuJ3QuIEkgZGlkIHRlc3QgdGhhdCBsb2Nh bGx5LCB0aG91Z2guCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg ICAqIGZhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFzc2VydGlvbi1leHBlY3RlZC50eHQ6IEFkZGVk LgogICAgICAgICogZmFzdC9jc3Mvb3V0bGluZS1pbnZlcnQtYXNzZXJ0aW9uLmh0bWw6IEFkZGVk LgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxNSArKysrKysrKysrKysrKysKIC4uLi9mYXN0L2Nzcy9vdXRsaW5lLWludmVydC1hc3Nl cnRpb24tZXhwZWN0ZWQudHh0IHwgICAgNSArKysrKwogTGF5b3V0VGVzdHMvZmFzdC9jc3Mvb3V0 bGluZS1pbnZlcnQtYXNzZXJ0aW9uLmh0bWwgfCAgICA5ICsrKysrKysrKwogV2ViQ29yZS9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysr KysrKysKIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcCAgICAgICAgICAgICAg IHwgICAgNCArKystCiA1IGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlvbnMoKyksIDEgZGVsZXRp b25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvZmFzdC9jc3Mvb3V0bGluZS1p bnZlcnQtYXNzZXJ0aW9uLWV4cGVjdGVkLnR4dAogY3JlYXRlIG1vZGUgMTAwNjQ0IExheW91dFRl c3RzL2Zhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFzc2VydGlvbi5odG1sCgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVjZWVj NTUuLjEyODAwMjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOC0xMS0xMCAgQWRhbSBSb2Jl biAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgVGVzdCBmb3IgQnVnIDIyMTYxOiBBc3Nl cnRpb24gZmFpbHVyZSBpbiBSZW5kZXJUaGVtZVdpbjo6c3lzdGVtQ29sb3IKKyAgICAgICAgd2hl biBsb2FkaW5nIG1pY3Jvc29mdHBkYy5jb20KKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYxPgorCisgICAgICAgIE5vdGUgdGhhdCB0aGlzIHRl c3Qgd291bGQgb25seSBmYWlsIGlmIER1bXBSZW5kZXJUcmVlIHVzZWQKKyAgICAgICAgUmVuZGVy VGhlbWVXaW4sIHdoaWNoIGl0IGRvZXNuJ3QuIEkgZGlkIHRlc3QgdGhhdCBsb2NhbGx5LCB0aG91 Z2guCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBm YXN0L2Nzcy9vdXRsaW5lLWludmVydC1hc3NlcnRpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2Nzcy9vdXRsaW5lLWludmVydC1hc3NlcnRpb24uaHRtbDogQWRkZWQuCisK IDIwMDgtMTEtMDkgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9jc3Mvb3V0bGluZS1pbnZlcnQtYXNzZXJ0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFzc2VydGlvbi1leHBlY3RlZC50eHQKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYjBjYzA1MAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFzc2VydGlvbi1leHBlY3RlZC50eHQK QEAgLTAsMCArMSw1IEBACitUZXN0IGZvciBCdWcgMjIxNjE6IEFzc2VydGlvbiBmYWlsdXJlIGlu IFJlbmRlclRoZW1lV2luOjpzeXN0ZW1Db2xvciB3aGVuIGxvYWRpbmcgbWljcm9zb2Z0cGRjLmNv bQorCitUaGVyZSBzaG91bGQgYmUgbm8gYXNzZXJ0aW9ucyB3aGVuIGxvYWRpbmcgdGhpcyBwYWdl LgorCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFz c2VydGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvb3V0bGluZS1pbnZlcnQtYXNzZXJ0 aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOWQyMmUwNAotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFzc2Vy dGlvbi5odG1sCkBAIC0wLDAgKzEsOSBAQAorPHNjcmlwdD4KKyAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7Cis8L3NjcmlwdD4KKworPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYxIj5CdWcgMjIxNjE6IEFzc2VydGlvbiBmYWlsdXJl IGluIFJlbmRlclRoZW1lV2luOjpzeXN0ZW1Db2xvciB3aGVuIGxvYWRpbmcgbWljcm9zb2Z0cGRj LmNvbTwvYT48L3A+Cis8cD5UaGVyZSBzaG91bGQgYmUgbm8gYXNzZXJ0aW9ucyB3aGVuIGxvYWRp bmcgdGhpcyBwYWdlLjwvcD4KKworPHNwYW4gc3R5bGU9Im91dGxpbmUtY29sb3I6IGludmVydCI+ PC9zcGFuPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCA1M2QwM2ZhLi5mYzg5OGI2IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDA4LTExLTEwICBBZGFt IFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggQnVnIDIyMTYxOiBBc3Nl cnRpb24gZmFpbHVyZSBpbiBSZW5kZXJUaGVtZVdpbjo6c3lzdGVtQ29sb3Igd2hlbgorICAgICAg ICBsb2FkaW5nIG1pY3Jvc29mdHBkYy5jb20KKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTYxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL291dGxpbmUtaW52ZXJ0LWFzc2Vy dGlvbi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVXaW46OnN5c3RlbUNvbG9yKTogSWYgd2UgY2FuJ3Qg ZGV0ZXJtaW5lIGEgZ29vZAorICAgICAgICBXaW4zMiBzeXN0ZW0gY29sb3IgdG8gdXNlLCBkZWZl ciB0byBSZW5kZXJUaGVtZSBpbnN0ZWFkIG9mIGFzc2VydGluZy4KKyAgICAgICAgVGhpcyBtYXRj aGVzIHdoYXQgUmVuZGVyVGhlbWVNYWMgZG9lcy4KKworMjAwOC0xMS0xMCAgQWRhbSBSb2JlbiAg PGFyb2JlbkBhcHBsZS5jb20+CisKICAgICAgICAgRml4IEJ1ZyAyMjE1ODogV291bGQgbGlrZSB0 byB0dXJuIG9uIFdlYkNvcmUgbG9nZ2luZyBjaGFubmVscyB2aWEgYW4KICAgICAgICAgZW52aXJv bm1lbnQgdmFyaWFibGUKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVXaW4uY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwCmluZGV4IDE0 ZGNiZjEuLjRlMzBhZmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l V2luLmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAKQEAgLTgw Miw3ICs4MDIsOSBAQCBzdGF0aWMgaW50IGNzc1ZhbHVlSWRUb1N5c0NvbG9ySW5kZXgoaW50IGNz c1ZhbHVlSWQpCiBDb2xvciBSZW5kZXJUaGVtZVdpbjo6c3lzdGVtQ29sb3IoaW50IGNzc1ZhbHVl SWQpIGNvbnN0CiB7CiAgICAgaW50IHN5c0NvbG9ySW5kZXggPSBjc3NWYWx1ZUlkVG9TeXNDb2xv ckluZGV4KGNzc1ZhbHVlSWQpOwotICAgIEFTU0VSVChzeXNDb2xvckluZGV4ICE9IC0xKTsKKyAg ICBpZiAoc3lzQ29sb3JJbmRleCA9PSAtMSkKKyAgICAgICAgcmV0dXJuIFJlbmRlclRoZW1lOjpz eXN0ZW1Db2xvcihjc3NWYWx1ZUlkKTsKKwogICAgIENPTE9SUkVGIGNvbG9yID0gR2V0U3lzQ29s b3Ioc3lzQ29sb3JJbmRleCk7CiAgICAgcmV0dXJuIENvbG9yKEdldFJWYWx1ZShjb2xvciksIEdl dEdWYWx1ZShjb2xvciksIEdldEJWYWx1ZShjb2xvcikpOwogfQotLSAKMS42LjAuMy43MjkuZzZl YTQxMAoK