22159 2008-11-10 10:42:21 -0800 Repaint issue with outlines in child objects 2009-06-02 09:56:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ddkilzer mitz oldest_to_newest 98173 0 simon.fraser 2008-11-10 10:42:21 -0800 The attached testcase shows a bug where the focus ring is not correctly invalidated when a text input is moved by layout. It happens to use an animation on another element, but that's just incidental. There are no transforms here. 98174 1 25021 simon.fraser 2008-11-10 10:42:37 -0800 Created attachment 25021 Testcase 99594 2 25332 simon.fraser 2008-11-20 21:15:32 -0800 Created attachment 25332 Simple testcase with outline This bug has nothing to do with focus, or animations. There's a basic repaint bug with outlines. 99600 3 simon.fraser 2008-11-20 21:26:59 -0800 The problem is that RenderBox::absoluteClippedOverflowRect() only looks at the outline size on the style of the element being laid out, but not any of its contents. We could either grovel through the child objects looking at outline size, or just use view->maximalOutlineSize(). 99603 4 mitz 2008-11-20 21:31:54 -0800 I think it's going to have to be view->maximalOutlineSize() :-( 99614 5 25338 simon.fraser 2008-11-20 22:18:19 -0800 Created attachment 25338 Patch, testcase, changelog Patch includes some new bases for repaint tests whose repaint rects alter with this change (because of focus rings) 99687 6 25338 darin 2008-11-21 13:22:21 -0800 Comment on attachment 25338 Patch, testcase, changelog > + if (style()->outlineWidth() > 0 && style()->outlineSize() > maximalOutlineSize(PaintPhaseOutline)) > + static_cast<RenderView*>(document()->renderer())->setMaximalOutlineSize(style()->outlineSize()); Since you had to move this code, maybe there's a way to write a brief comment explaining the order dependency? I feel a little uncomfortable reviewing this with Hyatt on vacation. You should check with him afterwards just in case he thinks this will result in excessive painting. r=me 99697 7 simon.fraser 2008-11-21 14:01:20 -0800 Yes, the over-repaint is a worry, especially since any focus ring makes setMaximalOutlineSize() non-zero. The alternatives would be: 1. Store outline dimensions on RenderBox, and explicitly account for them whem computing repaint rects (but they don't affect overflow, unlike shadows, so we can't just put them in the overflow sizes), or 2. Set a bit on RenderObject to say that it has outlined children, and only inflate by maxOutlineSize when the object or children have outline. 99707 8 simon.fraser 2008-11-21 14:49:35 -0800 Committed r38678 M WebCore/ChangeLog M WebCore/rendering/RenderBox.cpp M LayoutTests/platform/mac/fast/repaint/outline-repaint-glitch-expected.checksum A LayoutTests/platform/mac/fast/repaint/outline-child-repaint-expected.checksum A LayoutTests/platform/mac/fast/repaint/outline-child-repaint-expected.png M LayoutTests/platform/mac/fast/repaint/4776765-expected.checksum A LayoutTests/platform/mac/fast/repaint/outline-child-repaint-expected.txt M LayoutTests/platform/mac/fast/repaint/delete-into-nested-block-expected.png M LayoutTests/platform/mac/fast/repaint/4776765-expected.png M LayoutTests/platform/mac/fast/repaint/delete-into-nested-block-expected.checksum M LayoutTests/platform/mac/fast/repaint/outline-repaint-glitch-expected.png M LayoutTests/ChangeLog A LayoutTests/fast/repaint/outline-child-repaint.html r38678 = 0ebe80da11f747b44e3ba9e89ae67bf891820c51 (trunk) I'll send mail to Hyatt to look at this change. 100900 9 simon.fraser 2008-12-01 15:42:35 -0800 Maybe this should have used getAbsoluteRepaintRectWithOutline()? 124002 10 ddkilzer 2009-06-02 09:56:04 -0700 *** Bug 14050 has been marked as a duplicate of this bug. *** 25021 2008-11-10 10:42:37 -0800 2008-11-10 10:42:37 -0800 Testcase moving_text_field.html text/html 1072 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+TW92aW5nIFRleHQgRmllbGRz PC90aXRsZT4KICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0iaW5pdGlhbC1zY2FsZT0x LjAiIC8+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KCiAgICBib2R5 IHsKICAgICAgbWFyZ2luOiAyMHB4OwogICAgfQogICAgI29uZSB7CiAgICAgIG1hcmdpbi10b3A6 IDEwMHB4OwovKiAgICAgIC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGUoMTAwcHgsIDEwMHB4 KTsqLwogICAgfQogICAgCiAgICAuZmx1Y3R1YXRlIHsKICAgICAgLXdlYmtpdC1hbmltYXRpb24t bmFtZTogZmx1Y3R1YXRlOwogICAgICAtd2Via2l0LWFuaW1hdGlvbi1kdXJhdGlvbjogMnM7CiAg ICAgIC13ZWJraXQtYW5pbWF0aW9uLWl0ZXJhdGlvbi1jb3VudDogaW5maW5pdGU7CiAgICAgIC13 ZWJraXQtYW5pbWF0aW9uLWRpcmVjdGlvbjogYWx0ZXJuYXRlOwogICAgICAtd2Via2l0LWFuaW1h dGlvbi10aW1pbmctZnVuY3Rpb246IGxpbmVhcjsKICAgICAgYm9yZGVyOiAxcHggc29saWQgZ3Jh eTsKICAgIH0KICAgIEAtd2Via2l0LWtleWZyYW1lcyBmbHVjdHVhdGUgewogICAgICAwJSB7IGhl aWdodDogMTAwcHg7IH0KICAgICAgMTAwJSB7IGhlaWdodDogMjAwcHg7IH0KICAgIH0KICAgIDwv c3R5bGU+CjwvaGVhZD4KPGJvZHkgb25sb2FkPSJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZmll bGQnKS5mb2N1cygpIj4KCjxkaXYgY2xhc3M9ImZsdWN0dWF0ZSI+CiAgSSBnZXQgYmlnZ2VyIGFu ZCBzbWFsbGVyLgo8L2Rpdj4KCjxkaXYgaWQ9Im9uZSI+CjxwPkxhYmVsOiA8aW5wdXQgaWQ9ImZp ZWxkIiB0eXBlPSJ0ZXh0Ij48L3A+CjwvZGl2PgoKPC9ib2R5Pgo8L2h0bWw+Cg== 25332 2008-11-20 21:15:32 -0800 2008-11-20 21:15:32 -0800 Simple testcase with outline repaint-outline.html text/html 749 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+T3V0bGluZSByZXBhaW50PC90 aXRsZT4KICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0iaW5pdGlhbC1zY2FsZT0xLjAi IC8+CiAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KICAgICNvbmUgewog ICAgfQogICAgCiAgICAjb25lID4gZGl2IHsKICAgICAgb3V0bGluZTogNXB4IHNvbGlkIGJsdWU7 CiAgICB9CiAgICAKICAgIDwvc3R5bGU+CiAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCIgY2hhcnNldD0idXRmLTgiPgogICAgICBmdW5jdGlvbiBzdGFydFRlc3QoKQogICAgICB7CiAg ICAgICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgICBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnb25lJykuc3R5bGUubWFyZ2luVG9wID0gJzEwMHB4JzsKICAgICAgICB9 LCA1MDApOwogICAgICB9CiAgICA8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keSBvbmxvYWQ9InN0YXJ0 VGVzdCgpIj4KCjxkaXYgaWQ9Im9uZSI+CjxkaXY+TGFiZWw8L2Rpdj4KPC9kaXY+Cgo8L2JvZHk+ CjwvaHRtbD4= 25338 2008-11-20 22:18:19 -0800 2008-11-21 13:22:21 -0800 Patch, testcase, changelog 22159_patch.txt text/plain 11167 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMjliMzVlLi45YmMzNDQ5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMDgtMTEt MjAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyMTU5CisgICAgICAgIAorICAgICAgICBBZGQgdGVzdGNhc2Ug Zm9yIHJlcGFpbnQgaXNzdWUgd2l0aCBvdXRsaW5lcyBvbiBjaGlsZCBvYmplY3RzLAorICAgICAg ICBhbmQgcmVkbyBiYXNlcyBhZmZlY3RlZCBieSB0aGlzIGNoYW5nZS4KKyAgICAgICAgCisgICAg ICAgICogZmFzdC9yZXBhaW50L291dGxpbmUtY2hpbGQtcmVwYWludC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50LzQ3NzY3NjUtZXhwZWN0ZWQuY2hlY2tz dW06CisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC80Nzc2NzY1LWV4cGVjdGVk LnBuZzoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2RlbGV0ZS1pbnRvLW5l c3RlZC1ibG9jay1leHBlY3RlZC5jaGVja3N1bToKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFz dC9yZXBhaW50L2RlbGV0ZS1pbnRvLW5lc3RlZC1ibG9jay1leHBlY3RlZC5wbmc6CisgICAgICAg ICogcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9vdXRsaW5lLWNoaWxkLXJlcGFpbnQtZXhwZWN0 ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQv b3V0bGluZS1jaGlsZC1yZXBhaW50LWV4cGVjdGVkLnBuZzogQWRkZWQuCisgICAgICAgICogcGxh dGZvcm0vbWFjL2Zhc3QvcmVwYWludC9vdXRsaW5lLWNoaWxkLXJlcGFpbnQtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L291dGxpbmUtcmVw YWludC1nbGl0Y2gtZXhwZWN0ZWQuY2hlY2tzdW06CisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zh c3QvcmVwYWludC9vdXRsaW5lLXJlcGFpbnQtZ2xpdGNoLWV4cGVjdGVkLnBuZzoKKworMjAwOC0x MS0yMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBS ZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NjIzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3Jl cGFpbnQvb3V0bGluZS1jaGlsZC1yZXBhaW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlcGFp bnQvb3V0bGluZS1jaGlsZC1yZXBhaW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMC4uODg2OWNhZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVw YWludC9vdXRsaW5lLWNoaWxkLXJlcGFpbnQuaHRtbApAQCAtMCwwICsxLDUwIEBACis8aHRtbD4K KzxoZWFkPgorICAgIDxzY3JpcHQgc3JjPSJyZXBhaW50LmpzIiB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAg ICAgZnVuY3Rpb24gcmVwYWludFRlc3QoKQorICAgICAgICB7CisgICAgICAgICAgICB2YXIgY29u dGFpbmVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnRhaW5lcicpOworICAgICAgICAg ICAgY29udGFpbmVyLnN0eWxlLnRvcCA9ICIyNTBweCI7CisgICAgICAgIH0KKyAgICA8L3Njcmlw dD4KKyAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgorICAgICAgI2Nv bnRhaW5lciB7CisgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgbGVmdDogMTBw eDsKKyAgICAgICAgdG9wOiAxNTBweDsKKyAgICAgICAgd2lkdGg6IDIwMHB4OworICAgICAgICBo ZWlnaHQ6IDUwcHg7CisgICAgICB9CisgICAgICAub3V0bGluZWQgeworICAgICAgICBvdXRsaW5l OiAxMHB4IHNvbGlkIGdyZWVuOworICAgICAgICBoZWlnaHQ6IDMwcHg7CisgICAgICAgIGJhY2tn cm91bmQtY29sb3I6ICNEREQ7CisgICAgICB9CisKKyAgICAgICN1bmRlcmxheSB7CisgICAgICAg IHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgdG9wOiAyNDBweDsKKyAgICAgICAgbGVmdDog MHB4OworICAgICAgICB3aWR0aDogMjAwcHg7CisgICAgICAgIGhlaWdodDogMzBweDsKKyAgICAg ICAgYm9yZGVyOiAxMHB4IHNvbGlkIHJlZDsKKyAgICAgIH0KKyAgICA8L3N0eWxlPgorPC9oZWFk PgorPGJvZHkgb25sb2FkPSJydW5SZXBhaW50VGVzdCgpOyI+CisgICAgPHA+CisgICAgICAgIFRo aXMgaXMgYSByZXBhaW50IHRlc3QgZm9yIDxpPjxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE1OSI+aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyMTU5PC9hPgorICAgICAgICBSZXBhaW50IGlzc3VlIHdpdGggb3V0bGluZXMg aW4gY2hpbGQgb2JqZWN0czwvaT4uCisgICAgPC9wPgorICAgIDxwPklmIHRoZSB0ZXN0IHBhc3Nl cywgeW91IHNob3VsZCBub3Qgc2VlIGFueSByZWQgYmVsb3c8L3A+CisgICAgPGhyPgorCisgICAg PGRpdiBpZD0idW5kZXJsYXkiPgorICAgIDwvZGl2PgorICAgIDxkaXYgaWQ9ImNvbnRhaW5lciI+ CisgICAgICA8ZGl2IGNsYXNzPSJvdXRsaW5lZCI+CisgICAgICA8L2Rpdj4KKyAgICA8L2Rpdj4K KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9m YXN0L3JlcGFpbnQvNDc3Njc2NS1leHBlY3RlZC5jaGVja3N1bSBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L3JlcGFpbnQvNDc3Njc2NS1leHBlY3RlZC5jaGVja3N1bQppbmRleCBjMDQz ZjFjLi4xNzNjNzM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9y ZXBhaW50LzQ3NzY3NjUtZXhwZWN0ZWQuY2hlY2tzdW0KKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2Zhc3QvcmVwYWludC80Nzc2NzY1LWV4cGVjdGVkLmNoZWNrc3VtCkBAIC0xICsxIEBA Ci1kOWVmYjNkOGRkNmU5NGJjNjNmZjNkMTU1OGRjNDEwNgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKK2QyYjRkNTFhYjYyY2ExMjRjZDQ4N2JkMzhkMDU1ZGRiClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVw YWludC80Nzc2NzY1LWV4cGVjdGVkLnBuZyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0 L3JlcGFpbnQvNDc3Njc2NS1leHBlY3RlZC5wbmcKaW5kZXggMTg0ZWFlMC4uMTJjMWRjMSAxMDA2 NDQKQmluYXJ5IGZpbGVzIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC80 Nzc2NzY1LWV4cGVjdGVkLnBuZyBhbmQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9y ZXBhaW50LzQ3NzY3NjUtZXhwZWN0ZWQucG5nIGRpZmZlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9kZWxldGUtaW50by1uZXN0ZWQtYmxvY2stZXhw ZWN0ZWQuY2hlY2tzdW0gYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2Rl bGV0ZS1pbnRvLW5lc3RlZC1ibG9jay1leHBlY3RlZC5jaGVja3N1bQppbmRleCBiMjM2MmY4Li44 ODg0YjNlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50 L2RlbGV0ZS1pbnRvLW5lc3RlZC1ibG9jay1leHBlY3RlZC5jaGVja3N1bQorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2RlbGV0ZS1pbnRvLW5lc3RlZC1ibG9jay1l eHBlY3RlZC5jaGVja3N1bQpAQCAtMSArMSBAQAotZDIxOTYwY2FmYjE3NzgyOGQ0YmVmODc2ZGM5 NTBiNTAKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCisyZGE2NDkyYjhkZTc0ZTdkOGY3OTY4 NGFjY2FkNmFhNwpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvZGVsZXRlLWludG8tbmVzdGVkLWJsb2Nr LWV4cGVjdGVkLnBuZyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvZGVs ZXRlLWludG8tbmVzdGVkLWJsb2NrLWV4cGVjdGVkLnBuZwppbmRleCAzZGVlYWY2Li5hOTJmZjM3 IDEwMDY0NApCaW5hcnkgZmlsZXMgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBh aW50L2RlbGV0ZS1pbnRvLW5lc3RlZC1ibG9jay1leHBlY3RlZC5wbmcgYW5kIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9kZWxldGUtaW50by1uZXN0ZWQtYmxvY2stZXhw ZWN0ZWQucG5nIGRpZmZlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zh c3QvcmVwYWludC9vdXRsaW5lLWNoaWxkLXJlcGFpbnQtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L291dGxpbmUtY2hpbGQtcmVwYWludC1l eHBlY3RlZC5jaGVja3N1bQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4wNzc3 ZmU2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVw YWludC9vdXRsaW5lLWNoaWxkLXJlcGFpbnQtZXhwZWN0ZWQuY2hlY2tzdW0KQEAgLTAsMCArMSBA QAorMDdlMTczMzdiYmU5MWE3ZjQ3ZTM2YWE2MDg3OGY3NjYKXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50 L291dGxpbmUtY2hpbGQtcmVwYWludC1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZmFzdC9yZXBhaW50L291dGxpbmUtY2hpbGQtcmVwYWludC1leHBlY3RlZC5wbmcKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZmM0ODI1ZgpCaW5hcnkgZmlsZXMgL2Rl di9udWxsIGFuZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvb3V0bGlu ZS1jaGlsZC1yZXBhaW50LWV4cGVjdGVkLnBuZyBkaWZmZXIKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvb3V0bGluZS1jaGlsZC1yZXBhaW50LWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvb3V0bGluZS1j aGlsZC1yZXBhaW50LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi5lNzM4YWM0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2Zhc3QvcmVwYWludC9vdXRsaW5lLWNoaWxkLXJlcGFpbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMjYgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgw LDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJs b2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBh dCAoOCw4KSBzaXplIDc4NHg1ODQKKyAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwwKSBzaXpl IDc4NHgxOAorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAxNTF4MTgK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAxNTE6ICJUaGlzIGlzIGEgcmVwYWlu dCB0ZXN0IGZvciAiCisgICAgICAgIFJlbmRlcklubGluZSB7SX0gYXQgKDAsMCkgc2l6ZSA1Nzh4 MTgKKyAgICAgICAgICBSZW5kZXJJbmxpbmUge0F9IGF0ICgwLDApIHNpemUgMzA3eDE4IFtjb2xv cj0jMDAwMEVFXQorICAgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgxNTEsMCkgc2l6 ZSAzMDd4MTgKKyAgICAgICAgICAgICAgdGV4dCBydW4gYXQgKDE1MSwwKSB3aWR0aCAzMDc6ICJo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTkiCisgICAgICAgICAg UmVuZGVyVGV4dCB7I3RleHR9IGF0ICg0NTgsMCkgc2l6ZSAyNzF4MTgKKyAgICAgICAgICAgIHRl eHQgcnVuIGF0ICg0NTgsMCkgd2lkdGggNDogIiAiCisgICAgICAgICAgICB0ZXh0IHJ1biBhdCAo NDYyLDApIHdpZHRoIDI2NzogIlJlcGFpbnQgaXNzdWUgd2l0aCBvdXRsaW5lcyBpbiBjaGlsZCBv YmplY3RzIgorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDcyOSwwKSBzaXplIDR4MTgK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoNzI5LDApIHdpZHRoIDQ6ICIuIgorICAgICAgUmVuZGVy QmxvY2sge1B9IGF0ICgwLDM0KSBzaXplIDc4NHgxOAorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4 dH0gYXQgKDAsMCkgc2l6ZSAzMjJ4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0 aCAzMjI6ICJJZiB0aGUgdGVzdCBwYXNzZXMsIHlvdSBzaG91bGQgbm90IHNlZSBhbnkgcmVkIGJl bG93IgorICAgICAgUmVuZGVyQmxvY2sge0hSfSBhdCAoMCw2OCkgc2l6ZSA3ODR4MiBbYm9yZGVy OiAoMXB4IGluc2V0ICMwMDAwMDApXQorbGF5ZXIgYXQgKDAsMjQwKSBzaXplIDIyMHg1MAorICBS ZW5kZXJCbG9jayAocG9zaXRpb25lZCkge0RJVn0gYXQgKDAsMjQwKSBzaXplIDIyMHg1MCBbYm9y ZGVyOiAoMTBweCBzb2xpZCAjRkYwMDAwKV0KK2xheWVyIGF0ICgxMCwyNTApIHNpemUgMjAweDUw CisgIFJlbmRlckJsb2NrIChwb3NpdGlvbmVkKSB7RElWfSBhdCAoMTAsMjUwKSBzaXplIDIwMHg1 MAorICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDApIHNpemUgMjAweDMwIFtiZ2NvbG9yPSNE RERERERdCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50 L291dGxpbmUtcmVwYWludC1nbGl0Y2gtZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L291dGxpbmUtcmVwYWludC1nbGl0Y2gtZXhwZWN0ZWQu Y2hlY2tzdW0KaW5kZXggYjY3NzJhYi4uMzZmMjY5MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9vdXRsaW5lLXJlcGFpbnQtZ2xpdGNoLWV4cGVjdGVk LmNoZWNrc3VtCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvb3V0 bGluZS1yZXBhaW50LWdsaXRjaC1leHBlY3RlZC5jaGVja3N1bQpAQCAtMSArMSBAQAotNDgxYjlk NmY2NGE0N2JhODc3NmVhNjhjZTRmN2NjZDgKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCitm ZWYxYjA4OTYyYTRmMmVkZjE4NzBjYzc3YjhiZGNhNApcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvb3V0 bGluZS1yZXBhaW50LWdsaXRjaC1leHBlY3RlZC5wbmcgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvZmFzdC9yZXBhaW50L291dGxpbmUtcmVwYWludC1nbGl0Y2gtZXhwZWN0ZWQucG5nCmluZGV4 IGI5YTJlMGYuLjUwYTI3MjcgMTAwNjQ0CkJpbmFyeSBmaWxlcyBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L3JlcGFpbnQvb3V0bGluZS1yZXBhaW50LWdsaXRjaC1leHBlY3RlZC5wbmcg YW5kIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9vdXRsaW5lLXJlcGFp bnQtZ2xpdGNoLWV4cGVjdGVkLnBuZyBkaWZmZXIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjAzNDBhYi4uMGI5NDEzMSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwy NCBAQAogMjAwOC0xMS0yMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K IAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTkKKworICAgICAgICBSZW5kZXJC b3g6OmFic29sdXRlQ2xpcHBlZE92ZXJmbG93UmVjdCgpIG5lZWRzIHRvIGluZmxhdGUgdGhlIHJl Y3QgYnkKKyAgICAgICAgbWF4aW1hbE91dGxpbmVTaXplKCksIHNpbmNlIGEgY2hpbGQgbWlnaHQg aGF2ZSBhbiBvdXRsaW5lIHdoaWNoIHByb2plY3RzCisgICAgICAgIG91dHNpZGUgdGhlIHBhcmVu dCBvdmVyZmxvd1JlY3QoKS4KKyAgICAgICAgCisgICAgICAgIFdlIGFsc28gbmVlZCB0byBlbnN1 cmUgdGhhdCBtYXhpbWFsT3V0bGluZVNpemUoKSBpcyB1cGRhdGVkIGVhcmx5IGluIHN0eWxlRGlk Q2hhbmdlLAorICAgICAgICBzbyB0aGF0IGl0IGlzIHZhbGlkIGZvciB0aGVzZSByZXBhaW50cy4K KyAgICAgICAgCisgICAgICAgIFRlc3Q6IGZhc3QvcmVwYWludC9vdXRsaW5lLWNoaWxkLXJlcGFp bnQuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJCb3g6OnN0eWxlRGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJveDo6YWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KToKKworMjAwOC0xMS0yMCAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBi eSBEYW4gQmVybnN0ZWluCiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NjIzCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3gu Y3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCAyMzZhNDg3Li5mOGJh NWUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTEwNyw2ICsxMDcsOSBAQCB2b2lkIFJl bmRlckJveDo6c3R5bGVXaWxsQ2hhbmdlKFJlbmRlclN0eWxlOjpEaWZmIGRpZmYsIGNvbnN0IFJl bmRlclN0eWxlKiBuZXdTdAogCiB2b2lkIFJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2UoUmVuZGVy U3R5bGU6OkRpZmYgZGlmZiwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKQogeworICAgIGlm IChzdHlsZSgpLT5vdXRsaW5lV2lkdGgoKSA+IDAgJiYgc3R5bGUoKS0+b3V0bGluZVNpemUoKSA+ IG1heGltYWxPdXRsaW5lU2l6ZShQYWludFBoYXNlT3V0bGluZSkpCisgICAgICAgIHN0YXRpY19j YXN0PFJlbmRlclZpZXcqPihkb2N1bWVudCgpLT5yZW5kZXJlcigpKS0+c2V0TWF4aW1hbE91dGxp bmVTaXplKHN0eWxlKCktPm91dGxpbmVTaXplKCkpOworCiAgICAgUmVuZGVyT2JqZWN0OjpzdHls ZURpZENoYW5nZShkaWZmLCBvbGRTdHlsZSk7CiAKICAgICBpZiAobmVlZHNMYXlvdXQoKSAmJiBv bGRTdHlsZSAmJiAob2xkU3R5bGUtPmhlaWdodCgpLmlzUGVyY2VudCgpIHx8IG9sZFN0eWxlLT5t aW5IZWlnaHQoKS5pc1BlcmNlbnQoKSB8fCBvbGRTdHlsZS0+bWF4SGVpZ2h0KCkuaXNQZXJjZW50 KCkpKQpAQCAtMjA0LDkgKzIwNyw2IEBAIHZvaWQgUmVuZGVyQm94OjpzdHlsZURpZENoYW5nZShS ZW5kZXJTdHlsZTo6RGlmZiBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2xkU3R5CiAgICAgLy8g U2V0IHRoZSB0ZXh0IGNvbG9yIGlmIHdlJ3JlIHRoZSBib2R5LgogICAgIGlmIChpc0JvZHkoKSkK ICAgICAgICAgZG9jdW1lbnQoKS0+c2V0VGV4dENvbG9yKHN0eWxlKCktPmNvbG9yKCkpOwotCi0g ICAgaWYgKHN0eWxlKCktPm91dGxpbmVXaWR0aCgpID4gMCAmJiBzdHlsZSgpLT5vdXRsaW5lU2l6 ZSgpID4gbWF4aW1hbE91dGxpbmVTaXplKFBhaW50UGhhc2VPdXRsaW5lKSkKLSAgICAgICAgc3Rh dGljX2Nhc3Q8UmVuZGVyVmlldyo+KGRvY3VtZW50KCktPnJlbmRlcmVyKCkpLT5zZXRNYXhpbWFs T3V0bGluZVNpemUoc3R5bGUoKS0+b3V0bGluZVNpemUoKSk7CiB9CiAKIGludCBSZW5kZXJCb3g6 Om1pblByZWZXaWR0aCgpIGNvbnN0CkBAIC0xMTYzLDcgKzExNjMsOCBAQCBJbnRSZWN0IFJlbmRl ckJveDo6YWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KCkKIAogICAgIEludFJlY3QgciA9IG92 ZXJmbG93UmVjdChmYWxzZSk7CiAKLSAgICBpZiAoUmVuZGVyVmlldyogdiA9IHZpZXcoKSkKKyAg ICBSZW5kZXJWaWV3KiB2ID0gdmlldygpOworICAgIGlmICh2KQogICAgICAgICByLm1vdmUodi0+ bGF5b3V0RGVsdGEoKSk7CiAKICAgICBpZiAoc3R5bGUoKSkgewpAQCAtMTE3MSwxMSArMTE3Miwx MiBAQCBJbnRSZWN0IFJlbmRlckJveDo6YWJzb2x1dGVDbGlwcGVkT3ZlcmZsb3dSZWN0KCkKICAg ICAgICAgICAgIC8vIFRoZSB0aGVtZSBtYXkgd2lzaCB0byBpbmZsYXRlIHRoZSByZWN0IHVzZWQg d2hlbiByZXBhaW50aW5nLgogICAgICAgICAgICAgdGhlbWUoKS0+YWRqdXN0UmVwYWludFJlY3Qo dGhpcywgcik7CiAKLSAgICAgICAgLy8gRklYTUU6IFRlY2huaWNhbGx5IHRoZSBvdXRsaW5lIGlu ZmxhdGlvbiBjb3VsZCBmaXQgd2l0aGluIHRoZSB0aGVtZSBpbmZsYXRpb24uCi0gICAgICAgIGlm ICghaXNJbmxpbmUoKSAmJiBjb250aW51YXRpb24oKSkKLSAgICAgICAgICAgIHIuaW5mbGF0ZShj b250aW51YXRpb24oKS0+c3R5bGUoKS0+b3V0bGluZVNpemUoKSk7Ci0gICAgICAgIGVsc2UKLSAg ICAgICAgICAgIHIuaW5mbGF0ZShzdHlsZSgpLT5vdXRsaW5lU2l6ZSgpKTsKKyAgICAgICAgLy8g V2UgaGF2ZSB0byB1c2UgbWF4aW1hbE91dGxpbmVTaXplKCkgYmVjYXVzZSBhIGNoaWxkIG1pZ2h0 IGhhdmUgYW4gb3V0bGluZQorICAgICAgICAvLyB0aGF0IHByb2plY3RzIG91dHNpZGUgb2Ygb3Vy IG92ZXJmbG93UmVjdC4KKyAgICAgICAgaWYgKHYpIHsKKyAgICAgICAgICAgIEFTU0VSVChzdHls ZSgpLT5vdXRsaW5lU2l6ZSgpIDw9IHYtPm1heGltYWxPdXRsaW5lU2l6ZSgpKTsKKyAgICAgICAg ICAgIHIuaW5mbGF0ZSh2LT5tYXhpbWFsT3V0bGluZVNpemUoKSk7CisgICAgICAgIH0KICAgICB9 CiAgICAgY29tcHV0ZUFic29sdXRlUmVwYWludFJlY3Qocik7CiAgICAgcmV0dXJuIHI7Cg==