221585 2021-02-08 16:04:19 -0800 Work around some order dependent issues by parenting remote layers before applying other properties 2021-02-10 17:37:48 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam darin simon.fraser webkit-bug-importer oldest_to_newest 1726866 0 sam 2021-02-08 16:04:19 -0800 Workaround some order dependent issues by parenting remote layers before applying other properties 1726897 1 419656 sam 2021-02-08 17:06:37 -0800 Created attachment 419656 Patch 1727518 2 ews-feeder 2021-02-10 06:37:26 -0800 Committed r272647: <https://commits.webkit.org/r272647> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419656. 1727654 3 419656 darin 2021-02-10 11:18:35 -0800 Comment on attachment 419656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419656&action=review > Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:99 > + const RemoteLayerTreeTransaction::LayerProperties& properties = *propertiesPointer; Why not auto& here? 1727784 4 webkit-bug-importer 2021-02-10 14:31:19 -0800 <rdar://problem/74206528> 1727830 5 sam 2021-02-10 14:57:36 -0800 (In reply to Darin Adler from comment #3) > Comment on attachment 419656 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419656&action=review > > > Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:99 > > + const RemoteLayerTreeTransaction::LayerProperties& properties = *propertiesPointer; > > Why not auto& here? No solid reason other than I was duplication the code below and didn't notice. 419656 2021-02-08 17:06:37 -0800 2021-02-10 06:37:27 -0800 Patch bug-221585-20210208170636.patch text/plain 6018 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzI1NTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDIxLTAyLTA4ICBTYW0gV2Vpbmln ICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBXb3JrYXJvdW5kIHNvbWUgb3JkZXIgZGVw ZW5kZW50IGlzc3VlcyBieSBwYXJlbnRpbmcgcmVtb3RlIGxheWVycyBiZWZvcmUgYXBwbHlpbmcg b3RoZXIgcHJvcGVydGllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjIxNTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBydW5zIHRoZSB1cGRhdGVDaGlsZHJlbiAocmVuYW1lZCB0byBhcHBseUhp ZXJhcmNoeVVwZGF0ZXMgZm9yIGNvbnNpc3RlbmN5KSBwYXJ0IG9mCisgICAgICAgIHRoZSBSZW1v dGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIgZm9yIGFsbCB0aGUgdHJhbnNhY3Rpb24gY2hhbmdl cyBwcmlvciB0byBydW5uaW5nIHRoZQorICAgICAgICByZXN0IG9mIGFwcGx5UHJvcGVydGllcyB0 byB3b3JrIGFyb3VuZCBzb21lIGRvd25zdHJlYW0gYnVncyB0aGF0IGN1cnJlbnRseSByZXF1aXJl IHBhcmVudGVkCisgICAgICAgIGxheWVycyB0byB3b3JrLiBUaGlzIGxpa2VseSB3b24ndCBiZSBy ZXF1aXJlZCBmb3JldmVyLCBidXQgaXQgc2hvdWxkIGJlIGhhcm1sZXNzIHRvIGRvLgorCisgICAg ICAgICogU2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxp ZXIuaDoKKyAgICAgICAgKiBTaGFyZWQvUmVtb3RlTGF5ZXJUcmVlL1JlbW90ZUxheWVyVHJlZVBy b3BlcnR5QXBwbGllci5tbToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlUHJvcGVy dHlBcHBsaWVyOjphcHBseVByb3BlcnRpZXMpOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVMYXll clRyZWVQcm9wZXJ0eUFwcGxpZXI6OmFwcGx5SGllcmFyY2h5VXBkYXRlcyk6CisgICAgICAgIChX ZWJLaXQ6OlJlbW90ZUxheWVyVHJlZVByb3BlcnR5QXBwbGllcjo6dXBkYXRlQ2hpbGRyZW4pOiBE ZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJU cmVlSG9zdC5tbToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlTGF5ZXJUcmVlSG9zdDo6dXBkYXRl TGF5ZXJUcmVlKToKKwogMjAyMS0wMi0wOCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgTWFrZSB0aGUgVXNlckNvbnRlbnRDb250cm9sbGVyIGZvciBTZXJ2aWNl V29ya2VyIHBhZ2VzIGJlIG5vbi1vcHRpb25hbC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvU2hhcmVk L1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1NoYXJlZC9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJU cmVlUHJvcGVydHlBcHBsaWVyLmgJKHJldmlzaW9uIDI3MjU1NykKKysrIFNvdXJjZS9XZWJLaXQv U2hhcmVkL1JlbW90ZUxheWVyVHJlZS9SZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIuaAko d29ya2luZyBjb3B5KQpAQCAtMzYsMTEgKzM2LDEyIEBAIGNsYXNzIFJlbW90ZUxheWVyVHJlZUhv c3Q7CiBjbGFzcyBSZW1vdGVMYXllclRyZWVQcm9wZXJ0eUFwcGxpZXIgewogcHVibGljOgogICAg IHVzaW5nIFJlbGF0ZWRMYXllck1hcCA9IEhhc2hNYXA8V2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6 UGxhdGZvcm1MYXllcklELCBzdGQ6OnVuaXF1ZV9wdHI8UmVtb3RlTGF5ZXJUcmVlTm9kZT4+Owor ICAgIAorICAgIHN0YXRpYyB2b2lkIGFwcGx5SGllcmFyY2h5VXBkYXRlcyhSZW1vdGVMYXllclRy ZWVOb2RlJiwgY29uc3QgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyUHJvcGVydGll cyYsIGNvbnN0IFJlbGF0ZWRMYXllck1hcCYpOwogICAgIHN0YXRpYyB2b2lkIGFwcGx5UHJvcGVy dGllcyhSZW1vdGVMYXllclRyZWVOb2RlJiwgUmVtb3RlTGF5ZXJUcmVlSG9zdCosIGNvbnN0IFJl bW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpMYXllclByb3BlcnRpZXMmLCBjb25zdCBSZWxhdGVk TGF5ZXJNYXAmLCBSZW1vdGVMYXllckJhY2tpbmdTdG9yZTo6TGF5ZXJDb250ZW50c1R5cGUpOwog ICAgIHN0YXRpYyB2b2lkIGFwcGx5UHJvcGVydGllc1RvTGF5ZXIoQ0FMYXllciAqLCBSZW1vdGVM YXllclRyZWVIb3N0KiwgY29uc3QgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyUHJv cGVydGllcyYsIFJlbW90ZUxheWVyQmFja2luZ1N0b3JlOjpMYXllckNvbnRlbnRzVHlwZSk7CiAK IHByaXZhdGU6Ci0gICAgc3RhdGljIHZvaWQgdXBkYXRlQ2hpbGRyZW4oUmVtb3RlTGF5ZXJUcmVl Tm9kZSYsIGNvbnN0IFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpMYXllclByb3BlcnRpZXMm LCBjb25zdCBSZWxhdGVkTGF5ZXJNYXAmKTsKICAgICBzdGF0aWMgdm9pZCB1cGRhdGVNYXNrKFJl bW90ZUxheWVyVHJlZU5vZGUmLCBjb25zdCBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjo6TGF5 ZXJQcm9wZXJ0aWVzJiwgY29uc3QgUmVsYXRlZExheWVyTWFwJik7CiAjaWYgUExBVEZPUk0oSU9T X0ZBTUlMWSkKICAgICBzdGF0aWMgdm9pZCBhcHBseVByb3BlcnRpZXNUb1VJVmlldyhVSVZpZXcg KiwgY29uc3QgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyUHJvcGVydGllcyYsIGNv bnN0IFJlbGF0ZWRMYXllck1hcCYpOwpJbmRleDogU291cmNlL1dlYktpdC9TaGFyZWQvUmVtb3Rl TGF5ZXJUcmVlL1JlbW90ZUxheWVyVHJlZVByb3BlcnR5QXBwbGllci5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1NoYXJlZC9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJUcmVlUHJv cGVydHlBcHBsaWVyLm1tCShyZXZpc2lvbiAyNzI1NTcpCisrKyBTb3VyY2UvV2ViS2l0L1NoYXJl ZC9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJUcmVlUHJvcGVydHlBcHBsaWVyLm1tCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNzksNyArMjc5LDYgQEAgdm9pZCBSZW1vdGVMYXllclRyZWVQcm9wZXJ0 eUFwcGxpZXI6OmFwcAogICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogCiAgICAgYXBw bHlQcm9wZXJ0aWVzVG9MYXllcihub2RlLmxheWVyKCksIGxheWVyVHJlZUhvc3QsIHByb3BlcnRp ZXMsIGxheWVyQ29udGVudHNUeXBlKTsKLSAgICB1cGRhdGVDaGlsZHJlbihub2RlLCBwcm9wZXJ0 aWVzLCByZWxhdGVkTGF5ZXJzKTsKICAgICB1cGRhdGVNYXNrKG5vZGUsIHByb3BlcnRpZXMsIHJl bGF0ZWRMYXllcnMpOwogCiAgICAgaWYgKHByb3BlcnRpZXMuY2hhbmdlZFByb3BlcnRpZXMgJiBS ZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjo6RXZlbnRSZWdpb25DaGFuZ2VkKQpAQCAtMjkyLDgg KzI5MSwxMCBAQCB2b2lkIFJlbW90ZUxheWVyVHJlZVByb3BlcnR5QXBwbGllcjo6YXBwCiAgICAg RU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogfQogCi12b2lkIFJlbW90ZUxheWVyVHJlZVByb3Bl cnR5QXBwbGllcjo6dXBkYXRlQ2hpbGRyZW4oUmVtb3RlTGF5ZXJUcmVlTm9kZSYgbm9kZSwgY29u c3QgUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246OkxheWVyUHJvcGVydGllcyYgcHJvcGVydGll cywgY29uc3QgUmVsYXRlZExheWVyTWFwJiByZWxhdGVkTGF5ZXJzKQordm9pZCBSZW1vdGVMYXll clRyZWVQcm9wZXJ0eUFwcGxpZXI6OmFwcGx5SGllcmFyY2h5VXBkYXRlcyhSZW1vdGVMYXllclRy ZWVOb2RlJiBub2RlLCBjb25zdCBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjo6TGF5ZXJQcm9w ZXJ0aWVzJiBwcm9wZXJ0aWVzLCBjb25zdCBSZWxhdGVkTGF5ZXJNYXAmIHJlbGF0ZWRMYXllcnMp CiB7CisgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TCisKICAgICBpZiAoIXByb3BlcnRp ZXMuY2hhbmdlZFByb3BlcnRpZXMuY29udGFpbnMoUmVtb3RlTGF5ZXJUcmVlVHJhbnNhY3Rpb246 OkNoaWxkcmVuQ2hhbmdlZCkpCiAgICAgICAgIHJldHVybjsKIApAQCAtMzQxLDYgKzM0Miw4IEBA IHZvaWQgUmVtb3RlTGF5ZXJUcmVlUHJvcGVydHlBcHBsaWVyOjp1cGQKICNlbmRpZgogICAgICAg ICByZXR1cm4gY2hpbGROb2RlLT5sYXllcigpOwogICAgIH0pLmdldCgpOworCisgICAgRU5EX0JM T0NLX09CSkNfRVhDRVBUSU9OUwogfQogCiB2b2lkIFJlbW90ZUxheWVyVHJlZVByb3BlcnR5QXBw bGllcjo6dXBkYXRlTWFzayhSZW1vdGVMYXllclRyZWVOb2RlJiBub2RlLCBjb25zdCBSZW1vdGVM YXllclRyZWVUcmFuc2FjdGlvbjo6TGF5ZXJQcm9wZXJ0aWVzJiBwcm9wZXJ0aWVzLCBjb25zdCBS ZWxhdGVkTGF5ZXJNYXAmIHJlbGF0ZWRMYXllcnMpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJUcmVlSG9zdC5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9SZW1vdGVMYXllclRyZWUvUmVtb3RlTGF5ZXJUcmVl SG9zdC5tbQkocmV2aXNpb24gMjcyNTU3KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVt b3RlTGF5ZXJUcmVlL1JlbW90ZUxheWVyVHJlZUhvc3QubW0JKHdvcmtpbmcgY29weSkKQEAgLTk1 LDYgKzk1LDIxIEBAIGJvb2wgUmVtb3RlTGF5ZXJUcmVlSG9zdDo6dXBkYXRlTGF5ZXJUcmUKICAg ICBhdXRvIGxheWVyQ29udGVudHNUeXBlID0gbV9kcmF3aW5nQXJlYS0+aGFzRGVidWdJbmRpY2F0 b3IoKSA/IFJlbW90ZUxheWVyQmFja2luZ1N0b3JlOjpMYXllckNvbnRlbnRzVHlwZTo6SU9TdXJm YWNlIDogUmVtb3RlTGF5ZXJCYWNraW5nU3RvcmU6OkxheWVyQ29udGVudHNUeXBlOjpDQU1hY2hQ b3J0OwogI2VuZGlmCiAgICAgCisgICAgZm9yIChhdXRvJiBbbGF5ZXJJRCwgcHJvcGVydGllc1Bv aW50ZXJdIDogdHJhbnNhY3Rpb24uY2hhbmdlZExheWVyUHJvcGVydGllcygpKSB7CisgICAgICAg IGNvbnN0IFJlbW90ZUxheWVyVHJlZVRyYW5zYWN0aW9uOjpMYXllclByb3BlcnRpZXMmIHByb3Bl cnRpZXMgPSAqcHJvcGVydGllc1BvaW50ZXI7CisKKyAgICAgICAgYXV0byogbm9kZSA9IG5vZGVG b3JJRChsYXllcklEKTsKKyAgICAgICAgQVNTRVJUKG5vZGUpOworCisgICAgICAgIGlmICghbm9k ZSkgeworICAgICAgICAgICAgLy8gV2UgaGF2ZSBldmlkZW5jZSB0aGF0IHRoaXMgY2FuIHN0aWxs IGhhcHBlbiwgYnV0IGRvbid0IGtub3cgaG93IChzZWUgcjI0MTg5OSBmb3Igb25lIGFscmVhZHkt Zml4ZWQgY2F1c2UpLgorICAgICAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgiJXAgUmVt b3RlTGF5ZXJUcmVlSG9zdDo6dXBkYXRlTGF5ZXJUcmVlIC0gZmFpbGVkIHRvIGZpbmQgbGF5ZXIg d2l0aCBJRCAlbGx1IiwgdGhpcywgbGF5ZXJJRCk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAg ICAgICAgfQorCisgICAgICAgIFJlbW90ZUxheWVyVHJlZVByb3BlcnR5QXBwbGllcjo6YXBwbHlI aWVyYXJjaHlVcGRhdGVzKCpub2RlLCBwcm9wZXJ0aWVzLCBtX25vZGVzKTsKKyAgICB9CisKICAg ICBmb3IgKGF1dG8mIGNoYW5nZWRMYXllciA6IHRyYW5zYWN0aW9uLmNoYW5nZWRMYXllclByb3Bl cnRpZXMoKSkgewogICAgICAgICBhdXRvIGxheWVySUQgPSBjaGFuZ2VkTGF5ZXIua2V5OwogICAg ICAgICBjb25zdCBSZW1vdGVMYXllclRyZWVUcmFuc2FjdGlvbjo6TGF5ZXJQcm9wZXJ0aWVzJiBw cm9wZXJ0aWVzID0gKmNoYW5nZWRMYXllci52YWx1ZTsK