221573 2021-02-08 14:12:34 -0800 [LFC][Integration] Style change on an inline box should trigger invalidation 2021-02-10 14:32:54 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1726795 0 zalan 2021-02-08 14:12:34 -0800 full invalidation at this point. 1726797 1 419626 zalan 2021-02-08 14:17:03 -0800 Created attachment 419626 Patch 1726952 2 419626 koivisto 2021-02-08 22:12:21 -0800 Comment on attachment 419626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419626&action=review > Source/WebCore/rendering/RenderInline.cpp:200 > + if (needsLayout()) { Probably selfNeedsLayout() We may also need descendant canUse test similar to canUseForAfterStyleChange. > Source/WebCore/rendering/RenderInline.cpp:202 > + downcast<RenderBlockFlow>(*containingBlock()).invalidateLineLayoutPath(); There is LineLayout::blockContainer I have been using for this sort of things. 1727141 3 419745 zalan 2021-02-09 11:21:45 -0800 Created attachment 419745 Patch 1727179 4 ews-feeder 2021-02-09 12:24:43 -0800 Committed r272601: <https://commits.webkit.org/r272601> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419745. 1727788 5 webkit-bug-importer 2021-02-10 14:32:54 -0800 <rdar://problem/74206609> 419626 2021-02-08 14:17:03 -0800 2021-02-09 11:21:43 -0800 Patch bug-221573-20210208141702.patch text/plain 1856 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNDk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2JlMzFhYjc0YjM0YzIz OTFkZGQyNTgzOGIxMzAyZDYyODM5ZDMwYy4uYjFhNjk4MWVjMjc0YjNhMDAwM2M0M2YzOTJjOTcw NDBmM2RiZTdhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25d IFN0eWxlIGNoYW5nZSBvbiBhbiBpbmxpbmUgYm94IHNob3VsZCB0cmlnZ2VyIGludmFsaWRhdGlv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW52YWxp ZGF0ZSB0aGUgbGluZSBsYXlvdXQgcGF0aCB3aGVuIHRoZSBpbmxpbmUgYm94IChSZW5kZXJJbmxp bmUpIG5lZWRzIGxheW91dC4KKyAgICAgICAgZS5nLiB0aGUgZm9udC1mYW1pbHkgcHJvcGVydHkg Y2hhbmdlIGluIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mb250cy9n ZW5lcmljLWZhbWlseS1rZXl3b3Jkcy0wMDEuaHRtbAorICAgICAgICAoVGhpcyBpcyBzYWRseSBh IGZ1bGwgaW52YWxpZGF0aW9uIGF0IHRoaXMgcG9pbnQuKQorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlcklubGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6OnN0eWxl RGlkQ2hhbmdlKToKKwogMjAyMS0wMi0wOCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5j b20+CiAKICAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25dIEhpdCB0ZXN0IGlubGluZSBib3hlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAppbmRleCBlNGE5ZDcyODcx NWUwZTdlZTM3YzIyNzQ1NGZhMDQ2ZDc5NjZlOGEwLi5jN2RlYjE4MTYzOWYxZjQ4Y2FlYjAyZjdi N2RiN2FmZTNmZTY3OWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVySW5saW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5l LmNwcApAQCAtMTk3LDcgKzE5NywxMCBAQCB2b2lkIFJlbmRlcklubGluZTo6c3R5bGVEaWRDaGFu Z2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdAogCiAjaWYg RU5BQkxFKExBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQpCiAgICAgaWYgKGRpZmYgPj0gU3R5bGVE aWZmZXJlbmNlOjpSZXBhaW50KSB7Ci0gICAgICAgIGlmIChhdXRvKiBsaW5lTGF5b3V0ID0gTGF5 b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6OmNvbnRhaW5pbmcoKnRoaXMpKQorICAgICAgICBp ZiAobmVlZHNMYXlvdXQoKSkgeworICAgICAgICAgICAgLy8gRklYTUU6IEFkZCBzdXBwb3J0IGZv ciBwYXJ0aWFsIGludmFsaWRhdGlvbi4KKyAgICAgICAgICAgIGRvd25jYXN0PFJlbmRlckJsb2Nr Rmxvdz4oKmNvbnRhaW5pbmdCbG9jaygpKS5pbnZhbGlkYXRlTGluZUxheW91dFBhdGgoKTsKKyAg ICAgICAgfSBlbHNlIGlmIChhdXRvKiBsaW5lTGF5b3V0ID0gTGF5b3V0SW50ZWdyYXRpb246Okxp bmVMYXlvdXQ6OmNvbnRhaW5pbmcoKnRoaXMpKQogICAgICAgICAgICAgbGluZUxheW91dC0+dXBk YXRlU3R5bGUoKnRoaXMpOwogICAgIH0KICNlbmRpZgo= 419745 2021-02-09 11:21:45 -0800 2021-02-09 13:19:26 -0800 Patch bug-221573-20210209112145.patch text/plain 2059 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmFjN2M4NTUyYmQzZmQy YjkwMmYwMjZkNjJjZTNhMmIxZDFkZjA2MC4uNWMxZjY1NGZmMjJhZDlmZDY1MDE2NTlhODg5OTBh NTc1ZGIwOGEwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSW50ZWdyYXRpb25d IFN0eWxlIGNoYW5nZSBvbiBhbiBpbmxpbmUgYm94IHNob3VsZCB0cmlnZ2VyIGludmFsaWRhdGlv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCisKKyAgICAgICAgSW52YWxp ZGF0ZSB0aGUgbGluZSBsYXlvdXQgcGF0aCB3aGVuIHRoZSBpbmxpbmUgYm94IChSZW5kZXJJbmxp bmUpIG5lZWRzIGxheW91dC4KKyAgICAgICAgZS5nLiB0aGUgZm9udC1mYW1pbHkgcHJvcGVydHkg Y2hhbmdlIGluIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mb250cy9n ZW5lcmljLWZhbWlseS1rZXl3b3Jkcy0wMDEuaHRtbAorICAgICAgICAoVGhpcyBpcyBzYWRseSBh IGZ1bGwgaW52YWxpZGF0aW9uIGF0IHRoaXMgcG9pbnQuKQorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlcklubGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6OnN0eWxl RGlkQ2hhbmdlKToKKwogMjAyMS0wMi0wOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdW0lGQ10gY2FuVXNlRm9yVGV4dCBzaG91bGQgYWxzbyBjaGVjayBp ZiB0aGUgc3BhY2UgZ2x5cGggY29tZXMgZnJvbSB0aGUgcHJpbWFyeSBmb250CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJJbmxpbmUuY3BwCmluZGV4IGU0YTlkNzI4NzE1ZTBlN2VlMzdj MjI3NDU0ZmEwNDZkNzk2NmU4YTAuLmRjYWNiMWFmZTcwZmZhMjJmNGJmMTVlMzM1ODVjYmQ3NzI2 OGYxMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmxpbmUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmxpbmUuY3BwCkBAIC0x OTcsOCArMTk3LDE0IEBAIHZvaWQgUmVuZGVySW5saW5lOjpzdHlsZURpZENoYW5nZShTdHlsZURp ZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0CiAKICNpZiBFTkFCTEUoTEFZ T1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKICAgICBpZiAoZGlmZiA+PSBTdHlsZURpZmZlcmVuY2U6 OlJlcGFpbnQpIHsKLSAgICAgICAgaWYgKGF1dG8qIGxpbmVMYXlvdXQgPSBMYXlvdXRJbnRlZ3Jh dGlvbjo6TGluZUxheW91dDo6Y29udGFpbmluZygqdGhpcykpCi0gICAgICAgICAgICBsaW5lTGF5 b3V0LT51cGRhdGVTdHlsZSgqdGhpcyk7CisgICAgICAgIGlmIChhdXRvKiBsaW5lTGF5b3V0ID0g TGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6OmNvbnRhaW5pbmcoKnRoaXMpKSB7CisgICAg ICAgICAgICBpZiAoc2VsZk5lZWRzTGF5b3V0KCkpIHsKKyAgICAgICAgICAgICAgICAvLyBGSVhN RTogQWRkIHN1cHBvcnQgZm9yIHBhcnRpYWwgaW52YWxpZGF0aW9uLgorICAgICAgICAgICAgICAg IGlmIChhdXRvKiBjb250YWluZXIgPSBMYXlvdXRJbnRlZ3JhdGlvbjo6TGluZUxheW91dDo6Ymxv Y2tDb250YWluZXIoKnRoaXMpKQorICAgICAgICAgICAgICAgICAgICBjb250YWluZXItPmludmFs aWRhdGVMaW5lTGF5b3V0UGF0aCgpOworICAgICAgICAgICAgfSBlbHNlCisgICAgICAgICAgICAg ICAgbGluZUxheW91dC0+dXBkYXRlU3R5bGUoKnRoaXMpOworICAgICAgICB9CiAgICAgfQogI2Vu ZGlmCiB9Cg==