221557 2021-02-08 09:09:26 -0800 JSC stress test stress/copy-data-properties-fast-path.js.default fails on s390x and ppc64le 2021-02-14 11:06:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221454 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro mcatanzaro saam webkit-bug-importer ysuzuki oldest_to_newest 1726660 0 mcatanzaro 2021-02-08 09:09:26 -0800 This new test from bug #221454 is broken on s390x and ppc64le, but works on x86_64 and aarch64. This is a little odd since these architectures have little in common. All architectures have JIT disabled and cloop enabled. The test is: //@ runDefault("--slowPathAllocsBetweenGCs=4", "--watchdog=100", "--watchdog-exception-ok") function foo() { let { ...r } = { xx:0 }; foo(); } foo(); How is that recursion supposed to end? Anyway, on these architectures it doesn't, the error is: stress/copy-data-properties-fast-path.js.default: Exception: RangeError: Maximum call stack size exceeded. stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: foo@copy-data-properties-fast-path.js:5:6 stress/copy-data-properties-fast-path.js.default: ERROR: Unexpected exit code: 3 FAIL: stress/copy-data-properties-fast-path.js.default 1728082 1 419987 mcatanzaro 2021-02-11 07:36:29 -0800 Created attachment 419987 Patch 1728220 2 419987 saam 2021-02-11 12:08:56 -0800 Comment on attachment 419987 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419987&action=review > JSTests/ChangeLog:8 > + Skip the test on these architectures. I don't know what else to do with it. how are they failing? Maybe worth a bug to figure it out on your end? 1728343 3 mcatanzaro 2021-02-11 16:15:55 -0800 (In reply to Saam Barati from comment #2) > Comment on attachment 419987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419987&action=review > > > JSTests/ChangeLog:8 > > + Skip the test on these architectures. I don't know what else to do with it. > > how are they failing? The failure is in comment #0: the test just keeps recursing forever. > Maybe worth a bug to figure it out on your end? Well, I think this is that bug? :P I don't think we'll figure it out without guidance from JSC developers. The best I can do is usually a bisect, but in this case it's a new test so there's nothing to bisect. I'm happy to try checking code changes on the affected machines if that would be helpful, but I wouldn't know where to start. 1728929 4 ews-feeder 2021-02-13 10:19:06 -0800 Committed r272833: <https://commits.webkit.org/r272833> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419987. 1728930 5 webkit-bug-importer 2021-02-13 10:20:18 -0800 <rdar://problem/74311603> 1728942 6 mcatanzaro 2021-02-13 13:15:25 -0800 ... 1728944 7 ysuzuki 2021-02-13 13:24:38 -0800 Ah! I landed the fix in https://bugs.webkit.org/show_bug.cgi?id=221668#c8 when working on https://bugs.webkit.org/show_bug.cgi?id=221668 :) 1728955 8 mcatanzaro 2021-02-13 15:39:40 -0800 Ah... so I should unskip the test, then? 1728993 9 mcatanzaro 2021-02-14 10:18:18 -0800 Let's try that. 1728994 10 420241 mcatanzaro 2021-02-14 10:20:32 -0800 Created attachment 420241 Patch for landing 1728996 11 ews-feeder 2021-02-14 11:06:13 -0800 Committed r272840: <https://commits.webkit.org/r272840> All reviewed patches have been landed. Closing bug and clearing flags on attachment 420241. 419987 2021-02-11 07:36:29 -0800 2021-02-14 10:20:30 -0800 Patch bug-221557-20210211093628.patch text/plain 1236 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNjMxCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhjMWQ3NDljNjEyMjkxYjY4MzFhZWJkZGU4ZGFm NGQwNmE1N2M1YWEuLjFhZTZhYTZkMjNlMDhhNTUzMjY5YzhhMDRiY2IwYzY2YWM2NTg2YmEgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMjEtMDItMTEgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bn bm9tZS5vcmc+CisKKyAgICAgICAgSlNDIHN0cmVzcyB0ZXN0IHN0cmVzcy9jb3B5LWRhdGEtcHJv cGVydGllcy1mYXN0LXBhdGguanMuZGVmYXVsdCBmYWlscyBvbiBzMzkweCBhbmQgcHBjNjRsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTU3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2tpcCB0aGUg dGVzdCBvbiB0aGVzZSBhcmNoaXRlY3R1cmVzLiBJIGRvbid0IGtub3cgd2hhdCBlbHNlIHRvIGRv IHdpdGggaXQuCisKKyAgICAgICAgKiBzdHJlc3MvY29weS1kYXRhLXByb3BlcnRpZXMtZmFzdC1w YXRoLmpzOgorCiAyMDIxLTAyLTA5ICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4K IAogICAgICAgICBGaXggd2FybmluZyBpbnRyb2R1Y2VkIGJ5IHIyNzI1ODAKZGlmZiAtLWdpdCBh L0pTVGVzdHMvc3RyZXNzL2NvcHktZGF0YS1wcm9wZXJ0aWVzLWZhc3QtcGF0aC5qcyBiL0pTVGVz dHMvc3RyZXNzL2NvcHktZGF0YS1wcm9wZXJ0aWVzLWZhc3QtcGF0aC5qcwppbmRleCAxZGFhMGEz YzBjMzJhYmEyZGI3ZjI4NzM4ZTAxZmFkY2Y4YjU1OTBmLi5kYTE0MjdjYjQ4MWZhYzI2OWNhMzZl NDJlYjZiOTZlZTJjMjQwMDY0IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9jb3B5LWRhdGEt cHJvcGVydGllcy1mYXN0LXBhdGguanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvY29weS1kYXRhLXBy b3BlcnRpZXMtZmFzdC1wYXRoLmpzCkBAIC0xLDMgKzEsNCBAQAorLy9AIHNraXAgaWYgWyJwb3dl cnBjNjQiLCAiczM5MCJdLmluY2x1ZGU/KCRhcmNoaXRlY3R1cmUpCiAvL0AgcnVuRGVmYXVsdCgi LS1zbG93UGF0aEFsbG9jc0JldHdlZW5HQ3M9NCIsICItLXdhdGNoZG9nPTEwMCIsICItLXdhdGNo ZG9nLWV4Y2VwdGlvbi1vayIpCiAKIGZ1bmN0aW9uIGZvbygpIHsK 420241 2021-02-14 10:20:32 -0800 2021-02-14 11:06:14 -0800 Patch for landing bug-221557-20210214122031.patch text/plain 1285 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyODM5CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVjMjk5ODg2NmJjMzk2ODk2NWE4OWQ3M2I3NzBh ODc0YTAxZjY0Y2QuLjc4MWIyM2NiMWE3MzRlOTBmNjJmZThiZjU3NmYzZWZiODcwOGVhMjYgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMjEtMDItMTQgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bn bm9tZS5vcmc+CisKKyAgICAgICAgSlNDIHN0cmVzcyB0ZXN0IHN0cmVzcy9jb3B5LWRhdGEtcHJv cGVydGllcy1mYXN0LXBhdGguanMuZGVmYXVsdCBmYWlscyBvbiBzMzkweCBhbmQgcHBjNjRsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTU3Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDMxMTYwMz4KKworICAgICAgICBVbnJldmlld2VkLCB1 bnNraXAgdGhpcyB0ZXN0IHNpbmNlIGl0IHNlZW1zIFl1c3VrZSBoYXMgYWxyZWFkeSBmaXhlZCBp dC4KKworICAgICAgICAqIHN0cmVzcy9jb3B5LWRhdGEtcHJvcGVydGllcy1mYXN0LXBhdGguanM6 CisKIDIwMjEtMDItMTMgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgog CiAgICAgICAgIFByb3h5J3MgW1tHZXRPd25Qcm9wZXJ0eV1dIHNob3VsZCBjb21wbGV0ZSB0cmFw IHJlc3VsdCBkZXNjcmlwdG9yIGJlZm9yZSB2YWxpZGF0aW9uCmRpZmYgLS1naXQgYS9KU1Rlc3Rz L3N0cmVzcy9jb3B5LWRhdGEtcHJvcGVydGllcy1mYXN0LXBhdGguanMgYi9KU1Rlc3RzL3N0cmVz cy9jb3B5LWRhdGEtcHJvcGVydGllcy1mYXN0LXBhdGguanMKaW5kZXggMjkxMGIwODU4ZWI4ZGFh OTUwMTM4NzFlODg4OWQ0NzUzYTc4MTRjMC4uNTFkZGU3YTMzMjU4YTNkN2MzNGNlOTI4YTJiZjM4 OGY4MDdiMDYwOCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvY29weS1kYXRhLXByb3BlcnRp ZXMtZmFzdC1wYXRoLmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL2NvcHktZGF0YS1wcm9wZXJ0aWVz LWZhc3QtcGF0aC5qcwpAQCAtMSw0ICsxLDMgQEAKLS8vQCBza2lwIGlmIFsicG93ZXJwYzY0Iiwg InMzOTAiXS5pbmNsdWRlPygkYXJjaGl0ZWN0dXJlKQogLy9AIHJ1bkRlZmF1bHQoIi0tc2xvd1Bh dGhBbGxvY3NCZXR3ZWVuR0NzPTQiLCAiLS13YXRjaGRvZz0xMDAiLCAiLS13YXRjaGRvZy1leGNl cHRpb24tb2siKQogCiBmdW5jdGlvbiBmb28oKSB7Cg==